Re: [PATCH v1 10/12] fastboot: check device type for SPI NAND too

[Mattijs Korpershoek]

Hi Alexey,

Thank you for the patch.

On Thu, Dec 28, 2023 at 18:39, Alexey Romanov  
wrote:

> SPI NAND devices also supports 'fastboot erase / flash' commands.
>
> Signed-off-by: Alexey Romanov 

Reviewed-by: Mattijs Korpershoek 

> ---
>  drivers/fastboot/fb_nand.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fastboot/fb_nand.c b/drivers/fastboot/fb_nand.c
> index 6d3a900c77..39d888301f 100644
> --- a/drivers/fastboot/fb_nand.c
> +++ b/drivers/fastboot/fb_nand.c
> @@ -53,7 +53,7 @@ static int fb_nand_lookup(const char *partname,
>   return ret;
>   }
>  
> - if (dev->id->type != MTD_DEV_TYPE_NAND) {
> + if (dev->id->type != MTD_DEV_TYPE_NAND && dev->id->type != 
> MTD_DEV_TYPE_SPINAND) {
>   pr_err("partition '%s' is not stored on a NAND device",
> partname);
>   fastboot_fail("not a NAND device", response);
> -- 
> 2.30.1

Re: [PATCH v1 10/12] fastboot: check device type for SPI NAND too

[Sean Anderson]

On 12/28/23 10:39, Alexey Romanov wrote:
> SPI NAND devices also supports 'fastboot erase / flash' commands.
> 
> Signed-off-by: Alexey Romanov 
> ---
>  drivers/fastboot/fb_nand.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/fastboot/fb_nand.c b/drivers/fastboot/fb_nand.c
> index 6d3a900c77..39d888301f 100644
> --- a/drivers/fastboot/fb_nand.c
> +++ b/drivers/fastboot/fb_nand.c
> @@ -53,7 +53,7 @@ static int fb_nand_lookup(const char *partname,
>   return ret;
>   }
>  
> - if (dev->id->type != MTD_DEV_TYPE_NAND) {
> + if (dev->id->type != MTD_DEV_TYPE_NAND && dev->id->type != 
> MTD_DEV_TYPE_SPINAND) {
>   pr_err("partition '%s' is not stored on a NAND device",
> partname);
>   fastboot_fail("not a NAND device", response);

Reviewed-by: Sean Anderson