Re: [PATCH v2] cmd: Add command to dump drivers and compatible strings

[Simon Glass]

Hi Sean,

On Mon, 3 Feb 2020 at 13:51, Sean Anderson  wrote:
>
> This adds a subcommand to dm to dump out what drivers are installed, and their
> compatible strings. I have found this useful in ensuring that I have the 
> correct
> drivers compiled, and that I have put in the correct compatible strings.
>
> Signed-off-by: Sean Anderson 
> ---
>   Changes for v2:
>   - Check if entry->of_match is NULL before accessing it
>
>  cmd/dm.c| 12 +++-
>  drivers/core/dump.c | 20 
>  include/dm/util.h   |  3 +++
>  3 files changed, 34 insertions(+), 1 deletion(-)

Looks good. Please can you add a test?

If it helps u-boot-dm/.testing has 'test: Add a way to check each line
of console output' so you can write it in C.

Regards,
Simon

Re: [PATCH v2] cmd: Add command to dump drivers and compatible strings

[Bin Meng]

On Tue, Feb 4, 2020 at 4:51 AM Sean Anderson  wrote:
>
> This adds a subcommand to dm to dump out what drivers are installed, and their
> compatible strings. I have found this useful in ensuring that I have the 
> correct
> drivers compiled, and that I have put in the correct compatible strings.
>
> Signed-off-by: Sean Anderson 
> ---
>   Changes for v2:
>   - Check if entry->of_match is NULL before accessing it
>
>  cmd/dm.c| 12 +++-
>  drivers/core/dump.c | 20 
>  include/dm/util.h   |  3 +++
>  3 files changed, 34 insertions(+), 1 deletion(-)
>

Reviewed-by: Bin Meng 
Tested-by: Bin Meng