Re: [PATCH v3 16/32] net: Depend on CONFIG_CMDLINE

2023-10-17 Thread Simon Glass
Hi Tom,

On Tue, 17 Oct 2023 at 08:04, Tom Rini  wrote:
>
> On Mon, Oct 16, 2023 at 04:28:07PM -0600, Simon Glass wrote:
>
> > At present it isn't possible to use networking without the command line
> > enabled. Add this as a condition.
> >
> > Signed-off-by: Simon Glass 
> > Reviewed-by: Ramon Fried 
> > ---
> >
> > (no changes since v1)
> >
> >  cmd/Kconfig | 1 +
> >  net/Kconfig | 1 +
> >  2 files changed, 2 insertions(+)
> >
> > diff --git a/cmd/Kconfig b/cmd/Kconfig
> > index 148414f011df..c6ea5c860e33 100644
> > --- a/cmd/Kconfig
> > +++ b/cmd/Kconfig
> > @@ -1694,6 +1694,7 @@ if NET
> >
> >  menuconfig CMD_NET
> >   bool "Network commands"
> > + depends on CMDLINE
> >   default y
> >   imply NETDEVICES
> >
> > diff --git a/net/Kconfig b/net/Kconfig
> > index 4215889127c9..25d494e1db46 100644
> > --- a/net/Kconfig
> > +++ b/net/Kconfig
> > @@ -4,6 +4,7 @@
> >
> >  menuconfig NET
> >   bool "Networking support"
> > + depends on CMDLINE
> >   default y
> >
> >  if NET
>
> Please unwind this in the other direction.  What in network is depending
> on cmdline in a non-trivial way?

I can look at this as a follow-on, but I need a starting point. See my
other comment.

Regards,
Simon


Re: [PATCH v3 16/32] net: Depend on CONFIG_CMDLINE

2023-10-17 Thread Tom Rini
On Mon, Oct 16, 2023 at 04:28:07PM -0600, Simon Glass wrote:

> At present it isn't possible to use networking without the command line
> enabled. Add this as a condition.
> 
> Signed-off-by: Simon Glass 
> Reviewed-by: Ramon Fried 
> ---
> 
> (no changes since v1)
> 
>  cmd/Kconfig | 1 +
>  net/Kconfig | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 148414f011df..c6ea5c860e33 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1694,6 +1694,7 @@ if NET
>  
>  menuconfig CMD_NET
>   bool "Network commands"
> + depends on CMDLINE
>   default y
>   imply NETDEVICES
>  
> diff --git a/net/Kconfig b/net/Kconfig
> index 4215889127c9..25d494e1db46 100644
> --- a/net/Kconfig
> +++ b/net/Kconfig
> @@ -4,6 +4,7 @@
>  
>  menuconfig NET
>   bool "Networking support"
> + depends on CMDLINE
>   default y
>  
>  if NET

Please unwind this in the other direction.  What in network is depending
on cmdline in a non-trivial way?

-- 
Tom


signature.asc
Description: PGP signature