Re: [PATCH v4 06/11] remoteproc: uclass: Add remoteproc resource handling helpers
Hi Simon, Thank you for your feedback. Since the patchset has already been applied, I will address your comments in follow-up patches. Kindly, Amjad On 27/01/2022 16:43, Simon Glass wrote: Hi Amjad, On Thu, 27 Jan 2022 at 05:17, Amjad Ouled-Ameur wrote: From: Keerthy Add remoteproc resource handling helpers. These functions are primarily to parse the resource table and to handle different types of resources. Carveout, devmem, trace & vring resources are handled. Signed-off-by: Keerthy [Amjad: fix redefinition of "struct resource_table" and compile warnings ] Signed-off-by: Amjad Ouled-Ameur --- (no changes since v2) Changes in v2: - Add useful checks and remove redundant code. drivers/remoteproc/rproc-uclass.c | 534 ++ include/remoteproc.h | 384 - 2 files changed, 917 insertions(+), 1 deletion(-) Sorry my comments are a bit late - I sent them on v3. Regards, Simon
Re: [PATCH v4 06/11] remoteproc: uclass: Add remoteproc resource handling helpers
On Thu, Jan 27, 2022 at 01:16:55PM +0100, Amjad Ouled-Ameur wrote: > From: Keerthy > > Add remoteproc resource handling helpers. These functions > are primarily to parse the resource table and to handle > different types of resources. Carveout, devmem, trace & > vring resources are handled. > > Signed-off-by: Keerthy > [Amjad: fix redefinition of "struct resource_table" and compile warnings ] > Signed-off-by: Amjad Ouled-Ameur Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature
Re: [PATCH v4 06/11] remoteproc: uclass: Add remoteproc resource handling helpers
Hi Amjad, On Thu, 27 Jan 2022 at 05:17, Amjad Ouled-Ameur wrote: > > From: Keerthy > > Add remoteproc resource handling helpers. These functions > are primarily to parse the resource table and to handle > different types of resources. Carveout, devmem, trace & > vring resources are handled. > > Signed-off-by: Keerthy > [Amjad: fix redefinition of "struct resource_table" and compile warnings ] > Signed-off-by: Amjad Ouled-Ameur > > --- > > (no changes since v2) > > Changes in v2: > - Add useful checks and remove redundant code. > > drivers/remoteproc/rproc-uclass.c | 534 ++ > include/remoteproc.h | 384 - > 2 files changed, 917 insertions(+), 1 deletion(-) Sorry my comments are a bit late - I sent them on v3. Regards, Simon
