Re: [PATCH v6 1/8] lib: rsa: distinguish between tpl and spl for CONFIG_RSA_VERIFY
On Thu, Jun 18, 2020 at 04:23:21PM +0200, Heiko Stuebner wrote: > From: Heiko Stuebner > > While the SPL may want to do signature checking this won't be > the case for TPL in all cases, as TPL is mostly used when the > amount of initial memory is not enough for a full SPL. > > So on a system where SPL uses DM but TPL does not we currently > end up with a TPL compile error of: > > lib/rsa/rsa-verify.c:48:25: error: dereferencing pointer to incomplete > type ‘struct checksum_algo’ > > To prevent that change the $(SPL_) to $(SPL_TPL_) to distinguish > between both. If someone really needs FIT signature checking in > TPL as well, a new TPL_RSA_VERIFY config symbol needs to be added. > > Signed-off-by: Heiko Stuebner > Reviewed-by: Philipp Tomsich > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature
Re: [PATCH v6 1/8] lib: rsa: distinguish between tpl and spl for CONFIG_RSA_VERIFY
On 6/30/20 2:49 PM, Heiko Stübner wrote: > Am Donnerstag, 18. Juni 2020, 16:23:21 CEST schrieb Heiko Stuebner: >> From: Heiko Stuebner >> >> While the SPL may want to do signature checking this won't be >> the case for TPL in all cases, as TPL is mostly used when the >> amount of initial memory is not enough for a full SPL. >> >> So on a system where SPL uses DM but TPL does not we currently >> end up with a TPL compile error of: >> >> lib/rsa/rsa-verify.c:48:25: error: dereferencing pointer to incomplete >> type ‘struct checksum_algo’ >> >> To prevent that change the $(SPL_) to $(SPL_TPL_) to distinguish >> between both. If someone really needs FIT signature checking in >> TPL as well, a new TPL_RSA_VERIFY config symbol needs to be added. >> >> Signed-off-by: Heiko Stuebner >> Reviewed-by: Philipp Tomsich > > with it looking like everybody is happy with the fixes series now, > whom do I need to pester into picking it up? :-D No pestering needed :) The series is assigned to Tom: https://patchwork.ozlabs.org/project/uboot/list/?series=184291 Best regards Heinrich > > > Thanks > Heiko > > >> --- >> changes in v5: >> - drop change that belongs in patch 2/8 >> changes in v4: >> - amound -> amount >> - found another entry to handle >> changes in v2: >> - fix typo "distinguis(h)" >> >> lib/rsa/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/rsa/Makefile b/lib/rsa/Makefile >> index 14ed3cb401..c61ebfd79e 100644 >> --- a/lib/rsa/Makefile >> +++ b/lib/rsa/Makefile >> @@ -5,6 +5,6 @@ >> # (C) Copyright 2000-2007 >> # Wolfgang Denk, DENX Software Engineering, w...@denx.de. >> >> -obj-$(CONFIG_$(SPL_)RSA_VERIFY) += rsa-verify.o rsa-checksum.o >> +obj-$(CONFIG_$(SPL_TPL_)RSA_VERIFY) += rsa-verify.o rsa-checksum.o >> obj-$(CONFIG_RSA_VERIFY_WITH_PKEY) += rsa-keyprop.o >> obj-$(CONFIG_RSA_SOFTWARE_EXP) += rsa-mod-exp.o >> > > > >
Re: [PATCH v6 1/8] lib: rsa: distinguish between tpl and spl for CONFIG_RSA_VERIFY
Am Donnerstag, 18. Juni 2020, 16:23:21 CEST schrieb Heiko Stuebner: > From: Heiko Stuebner > > While the SPL may want to do signature checking this won't be > the case for TPL in all cases, as TPL is mostly used when the > amount of initial memory is not enough for a full SPL. > > So on a system where SPL uses DM but TPL does not we currently > end up with a TPL compile error of: > > lib/rsa/rsa-verify.c:48:25: error: dereferencing pointer to incomplete > type ‘struct checksum_algo’ > > To prevent that change the $(SPL_) to $(SPL_TPL_) to distinguish > between both. If someone really needs FIT signature checking in > TPL as well, a new TPL_RSA_VERIFY config symbol needs to be added. > > Signed-off-by: Heiko Stuebner > Reviewed-by: Philipp Tomsich with it looking like everybody is happy with the fixes series now, whom do I need to pester into picking it up? :-D Thanks Heiko > --- > changes in v5: > - drop change that belongs in patch 2/8 > changes in v4: > - amound -> amount > - found another entry to handle > changes in v2: > - fix typo "distinguis(h)" > > lib/rsa/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/rsa/Makefile b/lib/rsa/Makefile > index 14ed3cb401..c61ebfd79e 100644 > --- a/lib/rsa/Makefile > +++ b/lib/rsa/Makefile > @@ -5,6 +5,6 @@ > # (C) Copyright 2000-2007 > # Wolfgang Denk, DENX Software Engineering, w...@denx.de. > > -obj-$(CONFIG_$(SPL_)RSA_VERIFY) += rsa-verify.o rsa-checksum.o > +obj-$(CONFIG_$(SPL_TPL_)RSA_VERIFY) += rsa-verify.o rsa-checksum.o > obj-$(CONFIG_RSA_VERIFY_WITH_PKEY) += rsa-keyprop.o > obj-$(CONFIG_RSA_SOFTWARE_EXP) += rsa-mod-exp.o >
Re: [PATCH v6 1/8] lib: rsa: distinguish between tpl and spl for CONFIG_RSA_VERIFY
On Thu, 18 Jun 2020 at 08:23, Heiko Stuebner wrote: > > From: Heiko Stuebner > > While the SPL may want to do signature checking this won't be > the case for TPL in all cases, as TPL is mostly used when the > amount of initial memory is not enough for a full SPL. > > So on a system where SPL uses DM but TPL does not we currently > end up with a TPL compile error of: > > lib/rsa/rsa-verify.c:48:25: error: dereferencing pointer to incomplete > type ‘struct checksum_algo’ > > To prevent that change the $(SPL_) to $(SPL_TPL_) to distinguish > between both. If someone really needs FIT signature checking in > TPL as well, a new TPL_RSA_VERIFY config symbol needs to be added. > > Signed-off-by: Heiko Stuebner > Reviewed-by: Philipp Tomsich > --- > changes in v5: > - drop change that belongs in patch 2/8 > changes in v4: > - amound -> amount > - found another entry to handle > changes in v2: > - fix typo "distinguis(h)" > > lib/rsa/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Simon Glass
