Re: [U-Boot] [PATCH] Makefile: use $(shell ...) for determining file_size
Hi Chris, On 24 July 2014 06:14, Chris Packham wrote: > Hi Simon, > > On Wed, Jul 23, 2014 at 10:27 PM, Simon Glass wrote: >> On 22 July 2014 18:08, Chris Packham wrote: >>> file_size was being calculated using back-ticks but map_size uses >>> $(shell ...). Update the file_size calculation to use $(shell ...). >>> >>> Signed-off-by: Chris Packham >> >> Acked-by: Simon Glass >> >> But you might want to look at this. >> >> http://patchwork.ozlabs.org/patch/371936/ >> > > Thanks. I've re-submitted a version with Jeroen's change included and > it seems a v2 of his patch is imminent too. Either way I'm not fussed. > > But this has highlighted another issue I'm experiencing related to > this code. Originally I thought it was because I was doing something a > bit weird with a custom u-boot.lds but actually the problem is my > u-boot is setup so that it finishes exactly at the end of a 32bit > address space so _image_binary_end is just off the end of it which > screws up the size calculation. > > $ grep _image_binary_end u-boot.map > 0x0001_image_binary_end = . > > $ grep _image_binary_end System.map > A _image_binary_end > > $ make binary_size_check > ... > System.map shows a binary size of -4294180864 > but u-boot.bin shows 786432 > make: *** [binary_size_check] Error 1 > > I think it should be possible to change binary_size_check to use > u-boot.map instead of System.map but would that be OK for all > architectures? That's unfortunate - it's just a little check. It does protect again a breakage but we need to keep it simple. Maybe in this case we can mask with 0x and get the right answer? Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Makefile: use $(shell ...) for determining file_size
Hi Simon, On Wed, Jul 23, 2014 at 10:27 PM, Simon Glass wrote: > On 22 July 2014 18:08, Chris Packham wrote: >> file_size was being calculated using back-ticks but map_size uses >> $(shell ...). Update the file_size calculation to use $(shell ...). >> >> Signed-off-by: Chris Packham > > Acked-by: Simon Glass > > But you might want to look at this. > > http://patchwork.ozlabs.org/patch/371936/ > Thanks. I've re-submitted a version with Jeroen's change included and it seems a v2 of his patch is imminent too. Either way I'm not fussed. But this has highlighted another issue I'm experiencing related to this code. Originally I thought it was because I was doing something a bit weird with a custom u-boot.lds but actually the problem is my u-boot is setup so that it finishes exactly at the end of a 32bit address space so _image_binary_end is just off the end of it which screws up the size calculation. $ grep _image_binary_end u-boot.map 0x0001_image_binary_end = . $ grep _image_binary_end System.map A _image_binary_end $ make binary_size_check ... System.map shows a binary size of -4294180864 but u-boot.bin shows 786432 make: *** [binary_size_check] Error 1 I think it should be possible to change binary_size_check to use u-boot.map instead of System.map but would that be OK for all architectures? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Makefile: use $(shell ...) for determining file_size
On Wed, Jul 23, 2014 at 09:24:00PM +0200, Jeroen Hofstee wrote: > Hi, > > On 23-07-14 20:03, Tom Rini wrote: > >On Wed, Jul 23, 2014 at 04:27:36AM -0600, Simon Glass wrote: > >>On 22 July 2014 18:08, Chris Packham wrote: > >>>file_size was being calculated using back-ticks but map_size uses > >>>$(shell ...). Update the file_size calculation to use $(shell ...). > >>> > >>>Signed-off-by: Chris Packham > >>Acked-by: Simon Glass > >> > >>But you might want to look at this. > >> > >>http://patchwork.ozlabs.org/patch/371936/ > >Yeah, Jeroen, can we get a v2 of your patch that uses $(shell ... )? > >Thanks! > > > > > no problem. For the record I have not seen any issues with > mentioned gmake version. But using $(shell .. ) seem like a sane > thing to do. v2 is on its way, running MAKEALL for arm (can we keep it?). MAKEALL isn't going away for v2014.10 but please reply to Simon's RFC about it. I do have to admit that switching all of my stuff to buildman is still on my TODO list. -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Makefile: use $(shell ...) for determining file_size
Hi, On 23-07-14 20:03, Tom Rini wrote: On Wed, Jul 23, 2014 at 04:27:36AM -0600, Simon Glass wrote: On 22 July 2014 18:08, Chris Packham wrote: file_size was being calculated using back-ticks but map_size uses $(shell ...). Update the file_size calculation to use $(shell ...). Signed-off-by: Chris Packham Acked-by: Simon Glass But you might want to look at this. http://patchwork.ozlabs.org/patch/371936/ Yeah, Jeroen, can we get a v2 of your patch that uses $(shell ... )? Thanks! no problem. For the record I have not seen any issues with mentioned gmake version. But using $(shell .. ) seem like a sane thing to do. v2 is on its way, running MAKEALL for arm (can we keep it?). Chris: blackfin targets seem to rely on the same construct btw... Regards, Jeroen ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Makefile: use $(shell ...) for determining file_size
On Wed, Jul 23, 2014 at 04:27:36AM -0600, Simon Glass wrote: > On 22 July 2014 18:08, Chris Packham wrote: > > file_size was being calculated using back-ticks but map_size uses > > $(shell ...). Update the file_size calculation to use $(shell ...). > > > > Signed-off-by: Chris Packham > > Acked-by: Simon Glass > > But you might want to look at this. > > http://patchwork.ozlabs.org/patch/371936/ Yeah, Jeroen, can we get a v2 of your patch that uses $(shell ... )? Thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Makefile: use $(shell ...) for determining file_size
On 22 July 2014 18:08, Chris Packham wrote: > file_size was being calculated using back-ticks but map_size uses > $(shell ...). Update the file_size calculation to use $(shell ...). > > Signed-off-by: Chris Packham Acked-by: Simon Glass But you might want to look at this. http://patchwork.ozlabs.org/patch/371936/ Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
