Re: [U-Boot] [PATCH] add board support for virtex4fx12 minimodul
Hello Ricardo, thanks for your comments. i have some more questions : 1) The board is manufactured by avnet, you must create it under the folder boards/avnet/fx12mm your are right, i will move it 2) Try to unificate the fx12mm board under a more global board, like the ml507 with is now in mainstream you mean, that i create only a new config file and use the ml507 board code ? is this better than create new board specific files under board/avnet/fx12mm ? 4) There are some object that are not used (or I don't see where are they used) in your makefile. (../common/*) ups, i clean it up. its correct, the objects are not used regards georg On Mon, Sep 8, 2008 at 14:07, schardt [EMAIL PROTECTED] wrote: From: schardt [EMAIL PROTECTED](none) --- Makefile |3 + board/xilinx/fx12mm/Makefile | 63 board/xilinx/fx12mm/config.mk | 28 +++ board/xilinx/fx12mm/fx12mm.c | 67 + board/xilinx/fx12mm/init.S| 32 board/xilinx/fx12mm/u-boot.lds| 149 + board/xilinx/fx12mm/xparameters.h | 40 ++ include/configs/FX12MM.h | 127 +++ 8 files changed, 509 insertions(+), 0 deletions(-) create mode 100644 board/xilinx/fx12mm/Makefile create mode 100644 board/xilinx/fx12mm/config.mk create mode 100644 board/xilinx/fx12mm/fx12mm.c create mode 100644 board/xilinx/fx12mm/init.S create mode 100644 board/xilinx/fx12mm/u-boot.lds create mode 100644 board/xilinx/fx12mm/xparameters.h create mode 100644 include/configs/FX12MM.h diff --git a/Makefile b/Makefile index 8d82ef5..1fc476d 100644 --- a/Makefile +++ b/Makefile @@ -1282,6 +1282,9 @@ ERIC_config: unconfig EXBITGEN_config: unconfig @$(MKCONFIG) $(@:_config=) ppc ppc4xx exbitgen +FX12MM_config: unconfig + @$(MKCONFIG) $(@:_config=) ppc ppc4xx fx12mm xilinx + G2000_config: unconfig @$(MKCONFIG) $(@:_config=) ppc ppc4xx g2000 diff --git a/board/xilinx/fx12mm/Makefile b/board/xilinx/fx12mm/Makefile new file mode 100644 index 000..aed47ef --- /dev/null +++ b/board/xilinx/fx12mm/Makefile @@ -0,0 +1,63 @@ +# +# (C) Copyright 2000-2006 +# Wolfgang Denk, DENX Software Engineering, [EMAIL PROTECTED] +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +include $(TOPDIR)/config.mk +ifneq ($(OBJTREE),$(SRCTREE)) +$(shell mkdir -p $(obj)../common) +$(shell mkdir -p $(obj)../xilinx_iic) +endif + +INCS := -I../common -I../xilinx_iic +CFLAGS += $(INCS) +HOST_CFLAGS+= $(INCS) + +LIB= $(obj)lib$(BOARD).a + +COBJS = $(BOARD).o \ + ../common/xbasic_types.o ../common/xdma_channel.o \ + ../common/xdma_channel_sg.o \ + ../common/xversion.o \ + +SOBJS = init.o + +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) +SOBJS := $(addprefix $(obj),$(SOBJS)) + +$(LIB):$(OBJS) $(SOBJS) + $(AR) $(ARFLAGS) $@ $^ + +clean: + rm -f $(SOBJS) $(OBJS) + +distclean: clean + rm -f $(LIB) core *.bak .depend + +# + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +# diff --git a/board/xilinx/fx12mm/config.mk b/board/xilinx/fx12mm/config.mk new file mode 100644 index 000..69490fb --- /dev/null +++ b/board/xilinx/fx12mm/config.mk @@ -0,0 +1,28 @@ +# +# (C) Copyright 2000 +# Wolfgang Denk, DENX Software Engineering, [EMAIL PROTECTED] +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or
Re: [U-Boot] [PATCH] add board support for virtex4fx12 minimodul
sorry, just pressed ctrl-r without thinking about georg [600+ lines of quote deleted] was there any need to re-quote the 600+ lines of your own posting? Best regards, Wolfgang Denk ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] add board support for virtex4fx12 minimodul
Hi Ricardo, if such an architecture is wanted i can try to create it ? but i'm stil a beginner in u-boot and not very firm in git, so i think i ask many things here on the list :) Georg Ricardo wrote: Hello Georg Its a pleasure to help. 2) Try to unificate the fx12mm board under a more global board, like the ml507 with is now in mainstream you mean, that i create only a new config file and use the ml507 board code ? is this better than create new board specific files under board/avnet/fx12mm ? I mean something more... If you take a look to your board, it is basically a modern version of the ml300 (what is great). Unfortunately, the ml300 board cannot use all your improvements. We faced the same problems building the v5fx30teval board and we decide to generate a generic board called ppc440-generic which will be the skeleton of all the fpgas boards with the ppc440 processor. What I am asking you is to create the same architechture for the ppc400 processor. Best Regards ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] add board support for virtex4fx12 minimodul
Hello again Some comments: 1) The board is manufactured by avnet, you must create it under the folder boards/avnet/fx12mm 2) Try to unificate the fx12mm board under a more global board, like the ml507 with is now in mainstream 3) Add your boad to the MAKEALL script and yourself to the MAINTAINERS 4) There are some object that are not used (or I don't see where are they used) in your makefile. (../common/*) 5) You can obtain CONFIG_SYS_CLK_FREQ from the xparameters (it is adjustable by the suer) Best regards On Mon, Sep 8, 2008 at 14:07, schardt [EMAIL PROTECTED] wrote: From: schardt [EMAIL PROTECTED](none) --- Makefile |3 + board/xilinx/fx12mm/Makefile | 63 board/xilinx/fx12mm/config.mk | 28 +++ board/xilinx/fx12mm/fx12mm.c | 67 + board/xilinx/fx12mm/init.S| 32 board/xilinx/fx12mm/u-boot.lds| 149 + board/xilinx/fx12mm/xparameters.h | 40 ++ include/configs/FX12MM.h | 127 +++ 8 files changed, 509 insertions(+), 0 deletions(-) create mode 100644 board/xilinx/fx12mm/Makefile create mode 100644 board/xilinx/fx12mm/config.mk create mode 100644 board/xilinx/fx12mm/fx12mm.c create mode 100644 board/xilinx/fx12mm/init.S create mode 100644 board/xilinx/fx12mm/u-boot.lds create mode 100644 board/xilinx/fx12mm/xparameters.h create mode 100644 include/configs/FX12MM.h diff --git a/Makefile b/Makefile index 8d82ef5..1fc476d 100644 --- a/Makefile +++ b/Makefile @@ -1282,6 +1282,9 @@ ERIC_config: unconfig EXBITGEN_config: unconfig @$(MKCONFIG) $(@:_config=) ppc ppc4xx exbitgen +FX12MM_config: unconfig + @$(MKCONFIG) $(@:_config=) ppc ppc4xx fx12mm xilinx + G2000_config: unconfig @$(MKCONFIG) $(@:_config=) ppc ppc4xx g2000 diff --git a/board/xilinx/fx12mm/Makefile b/board/xilinx/fx12mm/Makefile new file mode 100644 index 000..aed47ef --- /dev/null +++ b/board/xilinx/fx12mm/Makefile @@ -0,0 +1,63 @@ +# +# (C) Copyright 2000-2006 +# Wolfgang Denk, DENX Software Engineering, [EMAIL PROTECTED] +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +include $(TOPDIR)/config.mk +ifneq ($(OBJTREE),$(SRCTREE)) +$(shell mkdir -p $(obj)../common) +$(shell mkdir -p $(obj)../xilinx_iic) +endif + +INCS := -I../common -I../xilinx_iic +CFLAGS += $(INCS) +HOST_CFLAGS+= $(INCS) + +LIB= $(obj)lib$(BOARD).a + +COBJS = $(BOARD).o \ + ../common/xbasic_types.o ../common/xdma_channel.o \ + ../common/xdma_channel_sg.o \ + ../common/xversion.o \ + +SOBJS = init.o + +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) +SOBJS := $(addprefix $(obj),$(SOBJS)) + +$(LIB):$(OBJS) $(SOBJS) + $(AR) $(ARFLAGS) $@ $^ + +clean: + rm -f $(SOBJS) $(OBJS) + +distclean: clean + rm -f $(LIB) core *.bak .depend + +# + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +# diff --git a/board/xilinx/fx12mm/config.mk b/board/xilinx/fx12mm/config.mk new file mode 100644 index 000..69490fb --- /dev/null +++ b/board/xilinx/fx12mm/config.mk @@ -0,0 +1,28 @@ +# +# (C) Copyright 2000 +# Wolfgang Denk, DENX Software Engineering, [EMAIL PROTECTED] +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General
