Re: [U-Boot] [PATCH] arm: mx6: Fix missing Kconfig option for Novena
Hi Marek, (ccing Tom) I posted a patch a week ago to fix this and some other boards http://patchwork.ozlabs.org/patch/407286/ but it looks like Tom has not checked this bug fix patch. My patch is intended to go directly to Tom's repo, whereas I guess yours is going to u-boot-imx repo. I don't think it is a good idea to fix one problem by two patches in two places. Unfortunately, both are imperfect. The board/kosagi/novena/Kconfig fix is missing from yours and select SUPPORT_SPL is missing from mine. So, how shall we sort out this? Would you send v2 dropping redudant lines from board/kosagi/novena/Kconfig and shall I send v3 omitting Kosagi stuff? Best Regards Masahiro Yamada On Thu, 13 Nov 2014 11:06:21 +0100 Marek Vasut ma...@denx.de wrote: Add two missing Kconfig options for Novena and drop the SPL from the Novena config. Signed-off-by: Marek Vasut ma...@denx.de Cc: Stefano Babic sba...@denx.de Cc: Sean Cross x...@kosagi.com Cc: Marek Vasut ma...@denx.de Cc: Fabio Estevam fabio.este...@freescale.com --- arch/arm/Kconfig | 2 ++ configs/novena_defconfig | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 22eb2d5..5cd621a 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -629,6 +629,8 @@ config TARGET_HUMMINGBOARD config TARGET_KOSAGI_NOVENA bool Support Kosagi Novena + select CPU_V7 + select SUPPORT_SPL config TARGET_TQMA6 bool TQ Systems TQMa6 board diff --git a/configs/novena_defconfig b/configs/novena_defconfig index a560afb..cadf461 100644 --- a/configs/novena_defconfig +++ b/configs/novena_defconfig @@ -1,4 +1,4 @@ CONFIG_SPL=y -CONFIG_SYS_EXTRA_OPTIONS=IMX_CONFIG=board/kosagi/novena/setup.cfg,MX6Q,SPL +CONFIG_SYS_EXTRA_OPTIONS=IMX_CONFIG=board/kosagi/novena/setup.cfg,MX6Q +S:CONFIG_ARM=y +S:CONFIG_TARGET_KOSAGI_NOVENA=y -- 2.0.0 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arm: mx6: Fix missing Kconfig option for Novena
On Thursday, November 13, 2014 at 12:48:45 PM, Masahiro Yamada wrote: Hi Marek, (ccing Tom) Hi! I posted a patch a week ago to fix this and some other boards http://patchwork.ozlabs.org/patch/407286/ but it looks like Tom has not checked this bug fix patch. My patch is intended to go directly to Tom's repo, whereas I guess yours is going to u-boot-imx repo. I don't think it is a good idea to fix one problem by two patches in two places. Unfortunately, both are imperfect. The board/kosagi/novena/Kconfig fix is missing from yours and select SUPPORT_SPL is missing from mine. So, how shall we sort out this? Would you send v2 dropping redudant lines from board/kosagi/novena/Kconfig and shall I send v3 omitting Kosagi stuff? Given you're the Kconfig guru, I would gladly leave it up to you if that is not too much inconvenience, and test your result. Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arm: mx6: Fix missing Kconfig option for Novena
Hi Masahiro, On 13/11/2014 14:10, Marek Vasut wrote: Given you're the Kconfig guru, I would gladly leave it up to you if that is not too much inconvenience, and test your result. That's fine with me. It means only that novena will remain broken for a while on u-boot-imx until your patch will go into Tom's tree. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arm: mx6: Fix missing Kconfig option for Novena
On Thu, Nov 13, 2014 at 11:06:21AM +0100, Marek Vasut wrote: Add two missing Kconfig options for Novena and drop the SPL from the Novena config. Signed-off-by: Marek Vasut ma...@denx.de Cc: Stefano Babic sba...@denx.de Cc: Sean Cross x...@kosagi.com Cc: Marek Vasut ma...@denx.de Cc: Fabio Estevam fabio.este...@freescale.com --- arch/arm/Kconfig | 2 ++ configs/novena_defconfig | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 22eb2d5..5cd621a 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -629,6 +629,8 @@ config TARGET_HUMMINGBOARD config TARGET_KOSAGI_NOVENA bool Support Kosagi Novena + select CPU_V7 + select SUPPORT_SPL After editing things to apply on top of Masahiro's series, applied to u-boot/master, thanks! -- Tom signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arm: mx6: Fix missing Kconfig option for Novena
On Thursday, November 13, 2014 at 04:34:40 PM, Tom Rini wrote: On Thu, Nov 13, 2014 at 11:06:21AM +0100, Marek Vasut wrote: Add two missing Kconfig options for Novena and drop the SPL from the Novena config. Signed-off-by: Marek Vasut ma...@denx.de Cc: Stefano Babic sba...@denx.de Cc: Sean Cross x...@kosagi.com Cc: Marek Vasut ma...@denx.de Cc: Fabio Estevam fabio.este...@freescale.com --- arch/arm/Kconfig | 2 ++ configs/novena_defconfig | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 22eb2d5..5cd621a 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -629,6 +629,8 @@ config TARGET_HUMMINGBOARD config TARGET_KOSAGI_NOVENA bool Support Kosagi Novena + select CPU_V7 + select SUPPORT_SPL After editing things to apply on top of Masahiro's series, applied to u-boot/master, thanks! I hope I was a good ball and chain on your leg. My service is always available to you (lol) ;-) Thanks! Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
