Re: [U-Boot] [PATCH] drivers: dma: ti: k3-udma: Extract packet data only when Meta data is not NULL

[Tom Rini]

On Wed, Apr 24, 2019 at 04:33:54PM +0530, Keerthy wrote:

> Currently packet data is wrongly extracted when metadata is NULL.
> Fix it and negate the if check.
> 
> Signed-off-by: Keerthy 
> Reviewed-by: Grygorii Strashko 
> Reviewed-by: Peter Ujfalusi 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] drivers: dma: ti: k3-udma: Extract packet data only when Meta data is not NULL

[Peter Ujfalusi]

On 24/04/2019 14.03, Keerthy wrote:
> Currently packet data is wrongly extracted when metadata is NULL.
> Fix it and negate the if check.

Good catch.

Reviewed-by: Peter Ujfalusi 

> 
> Signed-off-by: Keerthy 
> Reviewed-by: Grygorii Strashko 
> ---
>  drivers/dma/ti/k3-udma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
> index f78a01aa8f..e9ca09d8d3 100644
> --- a/drivers/dma/ti/k3-udma.c
> +++ b/drivers/dma/ti/k3-udma.c
> @@ -1492,7 +1492,7 @@ static int udma_send(struct dma *dma, void *src, size_t 
> len, void *metadata)
>   u32 tc_ring_id;
>   int ret;
>  
> - if (!metadata)
> + if (metadata)
>   packet_data = *((struct ti_udma_drv_packet_data *)metadata);
>  
>   if (dma->id >= (ud->rchan_cnt + ud->tchan_cnt)) {
> 

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot