Re: [U-Boot] [PATCH] spi: armada100_spi: Remove unnecessary NULL test for dout and din

2013-06-12 Thread Marek Vasut 
Dear Simon Glass,

 On Tue, Jun 11, 2013 at 6:57 AM, Axel Lin axel@ingics.com wrote:
  Signed-off-by: Axel Lin axel@ingics.com
 
 Reviewed-by: Simon Glass s...@chromium.org

Reviewed-by: Marek Vasut ma...@denx.de

Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] spi: armada100_spi: Remove unnecessary NULL test for dout and din

2013-06-12 Thread Ajay Bhargav 

- Marek Vasut ma...@denx.de wrote:

 Dear Simon Glass,
 
  On Tue, Jun 11, 2013 at 6:57 AM, Axel Lin axel@ingics.com
 wrote:
   Signed-off-by: Axel Lin axel@ingics.com
  
  Reviewed-by: Simon Glass s...@chromium.org
 
 Reviewed-by: Marek Vasut ma...@denx.de
 
Acked-by: Ajay Bhargav ajay.bhar...@einfochips.com

Regards,
Ajay Bhargav

-
Notice: 
This message has been scanned by Trend Micro Mail Security scanner and is 
believed to be clean
-
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] spi: armada100_spi: Remove unnecessary NULL test for dout and din

2013-06-12 Thread Jagan Teki 

On 12-06-2013 15:49, Ajay Bhargav wrote:


- Marek Vasut ma...@denx.de wrote:


Dear Simon Glass,


On Tue, Jun 11, 2013 at 6:57 AM, Axel Lin axel@ingics.com

wrote:

Signed-off-by: Axel Lin axel@ingics.com


Reviewed-by: Simon Glass s...@chromium.org


Reviewed-by: Marek Vasut ma...@denx.de


Acked-by: Ajay Bhargav ajay.bhar...@einfochips.com

Regards,
Ajay Bhargav

-
Notice:
This message has been scanned by Trend Micro Mail Security scanner and is 
believed to be clean
-


Reviewed-by: Jagannadha Sutradharudu Teki jagannadh.t...@gmail.com

--
Thanks,
Jagan.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] spi: armada100_spi: Remove unnecessary NULL test for dout and din

2013-06-11 Thread Simon Glass 
On Tue, Jun 11, 2013 at 6:57 AM, Axel Lin axel@ingics.com wrote:

 Signed-off-by: Axel Lin axel@ingics.com


Reviewed-by: Simon Glass s...@chromium.org


 ---
  drivers/spi/armada100_spi.c | 11 ++-
  1 file changed, 2 insertions(+), 9 deletions(-)

 diff --git a/drivers/spi/armada100_spi.c b/drivers/spi/armada100_spi.c
 index afdbe05..b237c7c 100644
 --- a/drivers/spi/armada100_spi.c
 +++ b/drivers/spi/armada100_spi.c
 @@ -182,15 +182,8 @@ int spi_xfer(struct spi_slave *slave, unsigned int
 bitlen, const void *dout,
 goto done;
 }

 -   if (dout)
 -   pss-tx = dout;
 -   else
 -   pss-tx = NULL;
 -
 -   if (din)
 -   pss-rx = din;
 -   else
 -   pss-rx = NULL;
 +   pss-tx = dout;
 +   pss-rx = din;

 if (flags  SPI_XFER_BEGIN) {
 spi_cs_activate(slave);
 --
 1.8.1.2




___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot