Re: [U-Boot] [PATCH] tools/mkenvimage.c: Fix a merge issue
Dear Horst Kronstorfer, In message 1324723318-32752-1-git-send-email-hkron...@frequentis.com you wrote: With bfcc40bb09b05c90cc3b1496abb270eb8aa72134 'optopt' was reverted. Signed-off-by: Horst Kronstorfer hkron...@frequentis.com --- tools/mkenvimage.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The net result is a system that is not only binary compatible with 4.3 BSD, but is even bug for bug compatible in almost all features. - Avadit Tevanian, Jr., Architecture-Independent Virtual Memory Management for Parallel and Distributed Environments: The Mach Approach ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] tools/mkenvimage.c: Fix a merge issue
Dear Horst Kronstorfer, In message 1324723318-32752-1-git-send-email-hkron...@frequentis.com you wrote: With bfcc40bb09b05c90cc3b1496abb270eb8aa72134 'optopt' was reverted. Signed-off-by: Horst Kronstorfer hkron...@frequentis.com --- tools/mkenvimage.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c index c5ed373..8ee2bd0 100644 --- a/tools/mkenvimage.c +++ b/tools/mkenvimage.c @@ -122,11 +122,11 @@ int main(int argc, char **argv) return EXIT_SUCCESS; case ':': fprintf(stderr, Missing argument for option -%c\n, - option); + optopt); usage(argv[0]); return EXIT_FAILURE; default: - fprintf(stderr, Wrong option -%c\n, option); + fprintf(stderr, Wrong option -%c\n, optopt); usage(prg); return EXIT_FAILURE; This change is definitely wrong, as optopt is nowhere declared nor used in tools/mkenvimage.c Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The game of life is a game of boomerangs. Our thoughts, deeds and words return to us sooner or later with astounding accuracy. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] tools/mkenvimage.c: Fix a merge issue
On 12/24/2011 03:57 PM, Wolfgang Denk wrote: Dear Horst Kronstorfer, In message1324723318-32752-1-git-send-email-hkron...@frequentis.com you wrote: With bfcc40bb09b05c90cc3b1496abb270eb8aa72134 'optopt' was reverted. Signed-off-by: Horst Kronstorferhkron...@frequentis.com --- tools/mkenvimage.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c index c5ed373..8ee2bd0 100644 --- a/tools/mkenvimage.c +++ b/tools/mkenvimage.c @@ -122,11 +122,11 @@ int main(int argc, char **argv) return EXIT_SUCCESS; case ':': fprintf(stderr, Missing argument for option -%c\n, - option); + optopt); usage(argv[0]); return EXIT_FAILURE; default: - fprintf(stderr, Wrong option -%c\n, option); + fprintf(stderr, Wrong option -%c\n, optopt); usage(prg); return EXIT_FAILURE; This change is definitely wrong, as optopt is nowhere declared nor used in tools/mkenvimage.c 'optopt' is declared in unistd.h ... see 'man 3 getopt.' br -h Best regards, Wolfgang Denk ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
