Re: [U-Boot] [PATCH] ubi: Remove flash selection parameter (nor|nand|onenand) from ubi part

2009-04-27 Thread Wolfgang Denk 
Dear Stefan Roese,

In message 1240581619-746-1-git-send-email...@denx.de you wrote:
 This patch removes the now unnecessary flash type parameter from the
 ubi part command. Currently the user has to define the type of flash
 he will be using UBI on. Example:
 
 = ubi part nor partition1
 
 With this patch this type parameter is not needed anymore. The user can
 now select the partition directly without the flash type paramter.
 Example:
 
 = ubi part partition1
 
 This breaks backward compatibility right now because of the change in the
 command syntax. But UBI support is still quite fresh and the advantage of
 this new command is syntax big enough for this change. Additionally the
 code is much cleaner now.
 
 Signed-off-by: Stefan Roese s...@denx.de
 CC: Kyungmin Park kyungmin.p...@samsung.com
 ---
  common/cmd_ubi.c |   73 +++--
  1 files changed, 26 insertions(+), 47 deletions(-)

Appied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
The use of COBOL cripples the mind; its teaching  should,  therefore,
be regarded as a criminal offence.
  -- Edsger W. Dijkstra, SIGPLAN Notices, Volume 17, Number 5
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] ubi: Remove flash selection parameter (nor|nand|onenand) from ubi part

2009-04-24 Thread Scott Wood 
On Fri, Apr 24, 2009 at 04:00:19PM +0200, Stefan Roese wrote:
 This patch removes the now unnecessary flash type parameter from the
 ubi part command. Currently the user has to define the type of flash
 he will be using UBI on. Example:
 
 = ubi part nor partition1
 
 With this patch this type parameter is not needed anymore. The user can
 now select the partition directly without the flash type paramter.
 Example:
 
 = ubi part partition1
 
 This breaks backward compatibility right now because of the change in the
 command syntax. But UBI support is still quite fresh and the advantage of
 this new command is syntax big enough for this change. Additionally the
 code is much cleaner now.

Yes, some polymorphism at last. :-)

Now to do the same with cmd_nand/cmd_onenand...  and NOR flash for that
matter.

 + sprintf(mtd_dev, %s%d, MTD_DEV_TYPE(dev-id-type), 
 dev-id-num);
 + printf(%s: mtd_dev=%s!!!\n, __func__, mtd_dev); // test-only
 + ubi_dev.mtd_info = get_mtd_device_nm(mtd_dev);
 + printf(%s: mtd_info=%p!!!\n, __func__, ubi_dev.mtd_info); // 
 test-only

Should these be debug()?

 +if (IS_ERR(ubi_dev.mtd_info)) {

s/spaces/tabs/

-Scott
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] ubi: Remove flash selection parameter (nor|nand|onenand) from ubi part

2009-04-24 Thread Stefan Roese 
On Friday 24 April 2009, Scott Wood wrote:
 On Fri, Apr 24, 2009 at 04:00:19PM +0200, Stefan Roese wrote:
  This patch removes the now unnecessary flash type parameter from the
  ubi part command. Currently the user has to define the type of flash
  he will be using UBI on. Example:
 
  = ubi part nor partition1
 
  With this patch this type parameter is not needed anymore. The user can
  now select the partition directly without the flash type paramter.
  Example:
 
  = ubi part partition1
 
  This breaks backward compatibility right now because of the change in the
  command syntax. But UBI support is still quite fresh and the advantage of
  this new command is syntax big enough for this change. Additionally the
  code is much cleaner now.

 Yes, some polymorphism at last. :-)

 Now to do the same with cmd_nand/cmd_onenand...  and NOR flash for that
 matter.

That's a bigger task...

  +   sprintf(mtd_dev, %s%d, MTD_DEV_TYPE(dev-id-type), 
  dev-id-num);
  +   printf(%s: mtd_dev=%s!!!\n, __func__, mtd_dev); // test-only
  +   ubi_dev.mtd_info = get_mtd_device_nm(mtd_dev);
  +   printf(%s: mtd_info=%p!!!\n, __func__, ubi_dev.mtd_info); //
  test-only

 Should these be debug()?

Ups. Thanks for catching.

  +if (IS_ERR(ubi_dev.mtd_info)) {

 s/spaces/tabs/

OK. Will fix and resubmit.

Thanks.

Best regards,
Stefan

=
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: off...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot