Re: [U-Boot] [PATCH 011/126] dm: core: Correct the return value for uclass_find_first_device()

2019-10-06 Thread Bin Meng
On Fri, Oct 4, 2019 at 5:44 PM Bin Meng  wrote:
>
> On Wed, Sep 25, 2019 at 10:58 PM Simon Glass  wrote:
> >
> > This function returns -ENODEV when there is no device. This is
> > inconsistent with other functions, such as uclass_find_next_device(),
> > which returns 0.
> >
> > Update it and tidy up the incorrect '-1' values in the comments.
> >
> > Signed-off-by: Simon Glass 
> > ---
> >
> >  drivers/core/uclass.c| 2 +-
> >  include/dm/uclass-internal.h | 4 ++--
> >  test/dm/core.c   | 3 +--
> >  3 files changed, 4 insertions(+), 5 deletions(-)
> >
>
> Reviewed-by: Bin Meng 
> Tested-by: Bin Meng 

applied to u-boot-x86/next, thanks!
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [PATCH 011/126] dm: core: Correct the return value for uclass_find_first_device()

2019-10-04 Thread Bin Meng
On Wed, Sep 25, 2019 at 10:58 PM Simon Glass  wrote:
>
> This function returns -ENODEV when there is no device. This is
> inconsistent with other functions, such as uclass_find_next_device(),
> which returns 0.
>
> Update it and tidy up the incorrect '-1' values in the comments.
>
> Signed-off-by: Simon Glass 
> ---
>
>  drivers/core/uclass.c| 2 +-
>  include/dm/uclass-internal.h | 4 ++--
>  test/dm/core.c   | 3 +--
>  3 files changed, 4 insertions(+), 5 deletions(-)
>

Reviewed-by: Bin Meng 
Tested-by: Bin Meng 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot