Re: [U-Boot] [PATCH 02/28] net: cosmetic: checkpatch compliance
i hope you ran a script on this and didn't do it by hand :). can you post the commands that you ran ? -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 02/28] net: cosmetic: checkpatch compliance
On 20/01/2012 01:53, Joe Hershberger wrote: Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com Cc: Wolfgang Denk w...@denx.de --- Hi Joe, as far as I understand this patch has nothing to do with the main feature (link-local addressing). Maybe is it worth to remove it from this patchset and send it in a separate patch ? I see the patch address only code styling, but it is quite long for a review. IMHO it is better to have a separate patchset for this. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 02/28] net: cosmetic: checkpatch compliance
Hi Joe, On Fri, Jan 20, 2012 at 12:21 PM, Joe Hershberger joe.hershber...@gmail.com wrote: Hi Simon, On Fri, Jan 20, 2012 at 10:30 AM, Simon Glass s...@chromium.org wrote: Hi Joe, On Thu, Jan 19, 2012 at 4:53 PM, Joe Hershberger joe.hershber...@ni.com wrote: Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com Cc: Wolfgang Denk w...@denx.de --- common/main.c | 1 - drivers/net/netconsole.c | 122 + include/common.h | 4 + include/net.h | 123 + net/bootp.c | 338 +++--- net/bootp.h | 56 net/eth.c | 66 +- net/net.c | 19 +-- net/nfs.c | 300 - net/nfs.h | 2 +- net/rarp.c | 28 ++-- net/rarp.h | 4 +- net/sntp.c | 31 +++-- net/sntp.h | 2 +- net/tftp.c | 30 ++--- net/tftp.h | 2 +- 16 files changed, 572 insertions(+), 556 deletions(-) Others may fine with it, but it might be worth splitting this very long patch, perhaps split out some of the larger files or the show_activity() change. I had this separated by file, but figured since the series was pretty long, it is all cosmetic (making separate patches not especially helpful), and it was under the 100kB mail limit that it would be better as a single patch. If it will be a barrier to review, I can split it up again. I'm not sure if it is a barrier to review or not, but I did nod off about 15% through :-) Regards, Simon Best regards, -Joe ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 02/28] net: cosmetic: checkpatch compliance
Hi Joe, On Thu, Jan 19, 2012 at 4:53 PM, Joe Hershberger joe.hershber...@ni.com wrote: Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com Cc: Wolfgang Denk w...@denx.de --- common/main.c | 1 - drivers/net/netconsole.c | 122 + include/common.h | 4 + include/net.h | 123 + net/bootp.c | 338 +++--- net/bootp.h | 56 net/eth.c | 66 +- net/net.c | 19 +-- net/nfs.c | 300 - net/nfs.h | 2 +- net/rarp.c | 28 ++-- net/rarp.h | 4 +- net/sntp.c | 31 +++-- net/sntp.h | 2 +- net/tftp.c | 30 ++--- net/tftp.h | 2 +- 16 files changed, 572 insertions(+), 556 deletions(-) Others may fine with it, but it might be worth splitting this very long patch, perhaps split out some of the larger files or the show_activity() change. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 02/28] net: cosmetic: checkpatch compliance
Hi Simon, On Fri, Jan 20, 2012 at 10:30 AM, Simon Glass s...@chromium.org wrote: Hi Joe, On Thu, Jan 19, 2012 at 4:53 PM, Joe Hershberger joe.hershber...@ni.com wrote: Signed-off-by: Joe Hershberger joe.hershber...@ni.com Cc: Joe Hershberger joe.hershber...@gmail.com Cc: Wolfgang Denk w...@denx.de --- common/main.c | 1 - drivers/net/netconsole.c | 122 + include/common.h | 4 + include/net.h | 123 + net/bootp.c | 338 +++--- net/bootp.h | 56 net/eth.c | 66 +- net/net.c | 19 +-- net/nfs.c | 300 - net/nfs.h | 2 +- net/rarp.c | 28 ++-- net/rarp.h | 4 +- net/sntp.c | 31 +++-- net/sntp.h | 2 +- net/tftp.c | 30 ++--- net/tftp.h | 2 +- 16 files changed, 572 insertions(+), 556 deletions(-) Others may fine with it, but it might be worth splitting this very long patch, perhaps split out some of the larger files or the show_activity() change. I had this separated by file, but figured since the series was pretty long, it is all cosmetic (making separate patches not especially helpful), and it was under the 100kB mail limit that it would be better as a single patch. If it will be a barrier to review, I can split it up again. Best regards, -Joe ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
