Re: [U-Boot] [PATCH 08/11] powerpc/e6500: Move QCSP registers for QMan v3

2012-08-22 Thread Andy Fleming
On Fri, Aug 17, 2012 at 1:27 PM, York Sun york...@freescale.com wrote:
 The QCSP registers are at offset 0x1000 for SoCs with QMan v3.

 Signed-off-by: York Sun york...@freescale.com
 ---
  arch/powerpc/include/asm/immap_85xx.h |   19 ++-
  1 files changed, 18 insertions(+), 1 deletions(-)

 diff --git a/arch/powerpc/include/asm/immap_85xx.h 
 b/arch/powerpc/include/asm/immap_85xx.h
 index 15d2db4..20e6915 100644
 --- a/arch/powerpc/include/asm/immap_85xx.h
 +++ b/arch/powerpc/include/asm/immap_85xx.h
 @@ -2573,13 +2573,18 @@ typedef struct ccsr_sec {
  #endif

  typedef struct ccsr_qman {
 +#ifdef CONFIG_SYS_FSL_QMAN_V3
 +   /* T4240, PSC9164 */


B4860 is the name, not PSC9164

 +   u8  res0[0x200];
 +#else
 +   /* P4080, SC4080, P3041, P5020, P1023, SC1023 */


This comment is somewhat specific. There are others that aren't listed
here. And I'm not sure the SC1023 exists (anymore). Probably we should
just mention the version of the QMan that this code is for.


 struct {
 u32 qcsp_lio_cfg;   /* 0x0 - SW Portal n LIO cfg */
 u32 qcsp_io_cfg;/* 0x4 - SW Portal n IO cfg */
 u32 res;
 u32 qcsp_dd_cfg;/* 0xc - SW Portal n Dynamic Debug 
 cfg */
 } qcsp[32];
 -
 +#endif
 /* Not actually reserved, but irrelevant to u-boot */
 u8  res[0xbf8 - 0x200];
 u32 ip_rev_1;
 @@ -2604,6 +2609,18 @@ typedef struct ccsr_qman {
 u32 ci_rlm_cfg; /* Initiator Read Latency Monitor Cfg */
 u32 ci_rlm_avg; /* Initiator Read Latency Monitor Avg */
 u8  res7[0x2e8];
 +#ifdef CONFIG_SYS_FSL_QMAN_V3
 +   /*
 +* T4240 50 software portals
 +* PSC9164 25 software portals
 +*/


B4860


 +   struct {
 +   u32 qcsp_lio_cfg;   /* 0x0 - SW Portal n LIO cfg */
 +   u32 qcsp_io_cfg;/* 0x4 - SW Portal n IO cfg */
 +   u32 res;
 +   u32 qcsp_dd_cfg;/* 0xc - SW Portal n Dynamic Debug 
 cfg */
 +   } qcsp[50];
 +#endif
  } ccsr_qman_t;

  typedef struct ccsr_bman {
 --
 1.7.0.4


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [PATCH 08/11] powerpc/e6500: Move QCSP registers for QMan v3

2012-08-22 Thread York Sun
On Wed, 2012-08-22 at 11:18 -0500, Andy Fleming wrote:
 On Fri, Aug 17, 2012 at 1:27 PM, York Sun york...@freescale.com wrote:
  The QCSP registers are at offset 0x1000 for SoCs with QMan v3.
 
  Signed-off-by: York Sun york...@freescale.com
  ---
   arch/powerpc/include/asm/immap_85xx.h |   19 ++-
   1 files changed, 18 insertions(+), 1 deletions(-)
 
  diff --git a/arch/powerpc/include/asm/immap_85xx.h 
  b/arch/powerpc/include/asm/immap_85xx.h
  index 15d2db4..20e6915 100644
  --- a/arch/powerpc/include/asm/immap_85xx.h
  +++ b/arch/powerpc/include/asm/immap_85xx.h
  @@ -2573,13 +2573,18 @@ typedef struct ccsr_sec {
   #endif
 
   typedef struct ccsr_qman {
  +#ifdef CONFIG_SYS_FSL_QMAN_V3
  +   /* T4240, PSC9164 */
 
 
 B4860 is the name, not PSC9164

Thanks for pointing out. This patch was written when the name was
PSC9164. I will fix it in next version, along with other feedback.

York



___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot