Re: [U-Boot] [PATCH 1/7] arm: mvebu: helios4: Update Load address

2018-11-28 Thread Aditya Prayoga
Hi Dennis,

On Wed, Nov 28, 2018 at 8:40 PM Dennis Gilmore  wrote:
>
> I would strongly prefer to keep the addresses consistent across
> platforms in u-boot. Is there bugs you are seeing as a result of this?
>
At that time, I was not able to load linux with these commands
  setenv bootargs "${console} root=/dev/mmcblk0p1 rootwait rw
scandelay ignore_loglevel"
  load mmc 0:1 ${kernel_addr_r} /boot/zImage
  load mmc 0:1 ${ramdisk_addr_r} /boot/uInitrd
  load mmc 0:1 ${fdt_addr_r} /boot/dtb/${fdtfile}
  bootz ${kernel_addr_r}  ${ramdisk_addr_r} ${fdt_addr_r}

but after getting your feedback, I re-tested it without this patch and
it's running fine.
So no reason to apply this patch anymore. I will remove it on next version.
Thanks

Aditya

> Dennis
>
> On Wed, 2018-11-28 at 16:59 +0800, Aditya Prayoga wrote:
> > Use the values from U-Boot 2013.01 Marvell version: 2015_T1.0p16
> >
> > Signed-off-by: Aditya Prayoga 
> > ---
> >  include/configs/helios4.h | 10 +-
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/include/configs/helios4.h b/include/configs/helios4.h
> > index ce912ea..c289490 100644
> > --- a/include/configs/helios4.h
> > +++ b/include/configs/helios4.h
> > @@ -145,11 +145,11 @@
> >   func(PXE, pxe, na) \
> >   func(DHCP, dhcp, na)
> >
> > -#define KERNEL_ADDR_R__stringify(0x80)
> > -#define FDT_ADDR_R   __stringify(0x10)
> > -#define RAMDISK_ADDR_R   __stringify(0x180)
> > -#define SCRIPT_ADDR_R__stringify(0x20)
> > -#define PXEFILE_ADDR_R   __stringify(0x30)
> > +#define KERNEL_ADDR_R__stringify(0x208)
> > +#define FDT_ADDR_R   __stringify(0x204)
> > +#define RAMDISK_ADDR_R   __stringify(0x288)
> > +#define SCRIPT_ADDR_R__stringify(0x300)
> > +#define PXEFILE_ADDR_R   __stringify(0x310)
> >
> >  #define LOAD_ADDRESS_ENV_SETTINGS \
> >   "kernel_addr_r=" KERNEL_ADDR_R "\0" \
>
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [PATCH 1/7] arm: mvebu: helios4: Update Load address

2018-11-28 Thread Dennis Gilmore
I would strongly prefer to keep the addresses consistent across
platforms in u-boot. Is there bugs you are seeing as a result of this?

Dennis

On Wed, 2018-11-28 at 16:59 +0800, Aditya Prayoga wrote:
> Use the values from U-Boot 2013.01 Marvell version: 2015_T1.0p16
> 
> Signed-off-by: Aditya Prayoga 
> ---
>  include/configs/helios4.h | 10 +-
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/include/configs/helios4.h b/include/configs/helios4.h
> index ce912ea..c289490 100644
> --- a/include/configs/helios4.h
> +++ b/include/configs/helios4.h
> @@ -145,11 +145,11 @@
>   func(PXE, pxe, na) \
>   func(DHCP, dhcp, na)
>  
> -#define KERNEL_ADDR_R__stringify(0x80)
> -#define FDT_ADDR_R   __stringify(0x10)
> -#define RAMDISK_ADDR_R   __stringify(0x180)
> -#define SCRIPT_ADDR_R__stringify(0x20)
> -#define PXEFILE_ADDR_R   __stringify(0x30)
> +#define KERNEL_ADDR_R__stringify(0x208)
> +#define FDT_ADDR_R   __stringify(0x204)
> +#define RAMDISK_ADDR_R   __stringify(0x288)
> +#define SCRIPT_ADDR_R__stringify(0x300)
> +#define PXEFILE_ADDR_R   __stringify(0x310)
>  
>  #define LOAD_ADDRESS_ENV_SETTINGS \
>   "kernel_addr_r=" KERNEL_ADDR_R "\0" \

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot