Re: [U-Boot] [PATCH 2/2] HACK: arndale: deinit scsi before launching Linux

2014-10-09 Thread Ian Campbell 
On Wed, 2014-10-08 at 10:18 +0200, Wolfgang Denk wrote:
 Dear Ian Campbell,
 
 In message 1412690200-6630-2-git-send-email-...@hellion.org.uk you wrote:
  From: Ian Campbell ian.campb...@citrix.com
  
  NOT TO BE APPLIED AS IS
  
  Without this Linux fails to correctly init the phy (or something) and cannot
  detect the disk.
  
  Even with this we can fail to detect the disk outselves on some fraction of
  boots, so something else is clearly up too.
 
 Why does the Subject: say scsi when you actually mean SATA?

The patch is adding scsi_deinit to mirror the existing scsi_init
function, and the u-boot CLI command (and dev name to load etc) is
scsi. On this platform (as with several others) it happens that scsi
is backed by a sata device, that's all.

 Note that this is a bug fix.

But as noted above and in the series cover letter (more details there)
it is not a complete one. I'm hoping the maintainers might know of a
correct fix, which probably means correct peripheral shutdown
processs.

Ian.

   U-Boot should _always_ shut down all
 peripherals it used before booting an OS, see [1]
 
 [1] http://www.denx.de/wiki/U-Boot/DesignPrinciples
 
 Best regards,
 
 Wolfgang Denk
 


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/2] HACK: arndale: deinit scsi before launching Linux

2014-10-08 Thread Wolfgang Denk 
Dear Ian Campbell,

In message 1412690200-6630-2-git-send-email-...@hellion.org.uk you wrote:
 From: Ian Campbell ian.campb...@citrix.com
 
 NOT TO BE APPLIED AS IS
 
 Without this Linux fails to correctly init the phy (or something) and cannot
 detect the disk.
 
 Even with this we can fail to detect the disk outselves on some fraction of
 boots, so something else is clearly up too.

Why does the Subject: say scsi when you actually mean SATA?

Note that this is a bug fix.  U-Boot should _always_ shut down all
peripherals it used before booting an OS, see [1]

[1] http://www.denx.de/wiki/U-Boot/DesignPrinciples

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
If you want strict real-time behavior, run in the real  time  schedu-
ling class.  But there are no seatbelts or airbags;  main(){for(;;);}
can hard hang your system.  -- Bart Smaalders
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot