Re: [U-Boot] [PATCH 2/3] common: env_flags: include common.h even for HOST_CC

[Tom Rini]

On Tue, Feb 16, 2016 at 11:19:43AM +, Peter Robinson wrote:
> >> When compiling with gcc 6 we get the following error due to ARRAY_SIZE 
> >> being
> >> defined elsewhere.
> >>
> >> common/env_flags.c:155: undefined reference to `ARRAY_SIZE'
> >>
> >> Signed-off-by: Peter Robinson 
> >
> > I'm going to take http://patchwork.ozlabs.org/patch/582527/ to fix this
> > instead as I don't want to say that common.h must work in the case of
> > USE_HOSTCC==true (I'm surprised it did, in fact).  Thanks!
> 
> What ever was pulled into RC2 works for me but I still needed my gcc6 patch.

Somewhere along the lines, Linux stopped having compiler-gccN.h and just
has compiler-gcc.h and compiler-clang.h.  Would you feel up to making a
pass at migrating those changes or should I?  Thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/3] common: env_flags: include common.h even for HOST_CC

[Peter Robinson]

>> When compiling with gcc 6 we get the following error due to ARRAY_SIZE being
>> defined elsewhere.
>>
>> common/env_flags.c:155: undefined reference to `ARRAY_SIZE'
>>
>> Signed-off-by: Peter Robinson 
>
> I'm going to take http://patchwork.ozlabs.org/patch/582527/ to fix this
> instead as I don't want to say that common.h must work in the case of
> USE_HOSTCC==true (I'm surprised it did, in fact).  Thanks!

What ever was pulled into RC2 works for me but I still needed my gcc6 patch.

Peter
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/3] common: env_flags: include common.h even for HOST_CC

[Tom Rini]

On Wed, Feb 03, 2016 at 12:42:51PM +, Peter Robinson wrote:

> When compiling with gcc 6 we get the following error due to ARRAY_SIZE being
> defined elsewhere.
> 
> common/env_flags.c:155: undefined reference to `ARRAY_SIZE'
> 
> Signed-off-by: Peter Robinson 

I'm going to take http://patchwork.ozlabs.org/patch/582527/ to fix this
instead as I don't want to say that common.h must work in the case of
USE_HOSTCC==true (I'm surprised it did, in fact).  Thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/3] common: env_flags: include common.h even for HOST_CC

[Albert ARIBAUD]

Hello Peter,

On Wed,  3 Feb 2016 12:42:51 +, Peter Robinson
 wrote:
> When compiling with gcc 6 we get the following error due to ARRAY_SIZE being
> defined elsewhere.
> 
> common/env_flags.c:155: undefined reference to `ARRAY_SIZE'
> 
> Signed-off-by: Peter Robinson 
> ---
>  common/env_flags.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/env_flags.c b/common/env_flags.c
> index 9c3aed1..696adef 100644
> --- a/common/env_flags.c
> +++ b/common/env_flags.c
> @@ -7,6 +7,7 @@
>  
>  #include 
>  #include 
> +#include 
>  
>  #ifdef USE_HOSTCC /* Eliminate "ANSI does not permit..." warnings */
>  #include 
> @@ -16,7 +17,6 @@
>  #include 
>  #define getenv fw_getenv
>  #else
> -#include 
>  #include 
>  #endif

How come this happens only with gcc-6? Previous compilers surely did not
'guess' the proper value of ARRAY_SIZE, right?

> -- 
> 2.5.0
> 
> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

Amicalement,
-- 
Albert.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/3] common: env_flags: include common.h even for HOST_CC

[Peter Robinson]

Hi Albert,

On Wed, Feb 3, 2016 at 1:41 PM, Albert ARIBAUD
 wrote:
> Hello Peter,
>
> On Wed,  3 Feb 2016 12:42:51 +, Peter Robinson
>  wrote:
>> When compiling with gcc 6 we get the following error due to ARRAY_SIZE being
>> defined elsewhere.
>>
>> common/env_flags.c:155: undefined reference to `ARRAY_SIZE'
>>
>> Signed-off-by: Peter Robinson 
>> ---
>>  common/env_flags.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/common/env_flags.c b/common/env_flags.c
>> index 9c3aed1..696adef 100644
>> --- a/common/env_flags.c
>> +++ b/common/env_flags.c
>> @@ -7,6 +7,7 @@
>>
>>  #include 
>>  #include 
>> +#include 
>>
>>  #ifdef USE_HOSTCC /* Eliminate "ANSI does not permit..." warnings */
>>  #include 
>> @@ -16,7 +17,6 @@
>>  #include 
>>  #define getenv fw_getenv
>>  #else
>> -#include 
>>  #include 
>>  #endif
>
> How come this happens only with gcc-6? Previous compilers surely did not
> 'guess' the proper value of ARRAY_SIZE, right?

So testing this RC on on Fedora 23 with gcc 5.3.1 I see the same
failure, I didn't see it with 2016.01 when using 5.3.1 so I'm not sure
what's changed there

Peter
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/3] common: env_flags: include common.h even for HOST_CC

[Albert ARIBAUD]

Hello Peter,

On Wed, 3 Feb 2016 16:11:38 +, Peter Robinson
 wrote:
> Hi Albert,
> 
> On Wed, Feb 3, 2016 at 1:41 PM, Albert ARIBAUD
>  wrote:
> > Hello Peter,
> >
> > On Wed,  3 Feb 2016 12:42:51 +, Peter Robinson
> >  wrote:
> >> When compiling with gcc 6 we get the following error due to ARRAY_SIZE 
> >> being
> >> defined elsewhere.
> >>
> >> common/env_flags.c:155: undefined reference to `ARRAY_SIZE'
> >>
> >> Signed-off-by: Peter Robinson 
> >> ---
> >>  common/env_flags.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/common/env_flags.c b/common/env_flags.c
> >> index 9c3aed1..696adef 100644
> >> --- a/common/env_flags.c
> >> +++ b/common/env_flags.c
> >> @@ -7,6 +7,7 @@
> >>
> >>  #include 
> >>  #include 
> >> +#include 
> >>
> >>  #ifdef USE_HOSTCC /* Eliminate "ANSI does not permit..." warnings */
> >>  #include 
> >> @@ -16,7 +17,6 @@
> >>  #include 
> >>  #define getenv fw_getenv
> >>  #else
> >> -#include 
> >>  #include 
> >>  #endif
> >
> > How come this happens only with gcc-6? Previous compilers surely did not
> > 'guess' the proper value of ARRAY_SIZE, right?
> 
> So testing this RC on on Fedora 23 with gcc 5.3.1 I see the same
> failure, I didn't see it with 2016.01 when using 5.3.1 so I'm not sure
> what's changed there

OK, so maybe unrelated to gcc 6. Could you git bisect?

> Peter

Amicalement,
-- 
Albert.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 2/3] common: env_flags: include common.h even for HOST_CC

[Tom Rini]

On Wed, Feb 03, 2016 at 06:53:11PM +0100, Albert ARIBAUD wrote:
> Hello Peter,
> 
> On Wed, 3 Feb 2016 16:11:38 +, Peter Robinson
>  wrote:
> > Hi Albert,
> > 
> > On Wed, Feb 3, 2016 at 1:41 PM, Albert ARIBAUD
> >  wrote:
> > > Hello Peter,
> > >
> > > On Wed,  3 Feb 2016 12:42:51 +, Peter Robinson
> > >  wrote:
> > >> When compiling with gcc 6 we get the following error due to ARRAY_SIZE 
> > >> being
> > >> defined elsewhere.
> > >>
> > >> common/env_flags.c:155: undefined reference to `ARRAY_SIZE'
> > >>
> > >> Signed-off-by: Peter Robinson 
> > >> ---
> > >>  common/env_flags.c | 2 +-
> > >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > >>
> > >> diff --git a/common/env_flags.c b/common/env_flags.c
> > >> index 9c3aed1..696adef 100644
> > >> --- a/common/env_flags.c
> > >> +++ b/common/env_flags.c
> > >> @@ -7,6 +7,7 @@
> > >>
> > >>  #include 
> > >>  #include 
> > >> +#include 
> > >>
> > >>  #ifdef USE_HOSTCC /* Eliminate "ANSI does not permit..." warnings */
> > >>  #include 
> > >> @@ -16,7 +17,6 @@
> > >>  #include 
> > >>  #define getenv fw_getenv
> > >>  #else
> > >> -#include 
> > >>  #include 
> > >>  #endif
> > >
> > > How come this happens only with gcc-6? Previous compilers surely did not
> > > 'guess' the proper value of ARRAY_SIZE, right?
> > 
> > So testing this RC on on Fedora 23 with gcc 5.3.1 I see the same
> > failure, I didn't see it with 2016.01 when using 5.3.1 so I'm not sure
> > what's changed there
> 
> OK, so maybe unrelated to gcc 6. Could you git bisect?

Please, gcc 5.3.x is one of my regular tests now.  But I don't do a
tools only build (tossing that on my TODO list..).

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot