Re: [U-Boot] [PATCH 2/4] rk3288-board: remove pinctrl call for debug uart

2019-03-31 Thread Urja Rannikko
Hi,

On Sat, Mar 30, 2019 at 9:18 PM Simon Glass  wrote:
>
> Hi Urja,
>
> On Fri, 22 Mar 2019 at 13:15, Urja Rannikko  wrote:
> >
> > This failed and caused a boot failure on c201, and afaik
> > the pins should be setup by the new pinctrl driver.
>
> It should be set up in SPL, if enabled.
>
> I wonder when this code is actually used?
The original code mentioned chainloading so i thought eg. from
coreboot, but i mean i thought you should know better than me,
see commit fe974716326ce2eee4bcac710ce7ec007919845e.
It seemed to also have something to do with the clock driver (which is
a thing that has changed in the last 2 years too...).


> >
> > Signed-off-by: Urja Rannikko 
> > ---
> >  arch/arm/mach-rockchip/rk3288-board.c | 12 
> >  1 file changed, 12 deletions(-)
>
> Reviewed-by: Simon Glass 



-- 
Urja Rannikko
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [PATCH 2/4] rk3288-board: remove pinctrl call for debug uart

2019-03-30 Thread Simon Glass
Hi Urja,

On Fri, 22 Mar 2019 at 13:15, Urja Rannikko  wrote:
>
> This failed and caused a boot failure on c201, and afaik
> the pins should be setup by the new pinctrl driver.

It should be set up in SPL, if enabled.

I wonder when this code is actually used?
>
> Signed-off-by: Urja Rannikko 
> ---
>  arch/arm/mach-rockchip/rk3288-board.c | 12 
>  1 file changed, 12 deletions(-)

Reviewed-by: Simon Glass 
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot