Re: [U-Boot] [PATCH 3/7] da850evm: sf: Read default speed and mode values from DT

2018-12-13 Thread Patrick DELAUNAY
Thanks Jagan for the reviews.

> From: Jagan Teki 
> Sent: mercredi 12 décembre 2018 21:03
> > --- a/board/davinci/da8xxevm/da850evm.c
> > +++ b/board/davinci/da8xxevm/da850evm.c
> 
> This board support DM_SPI_FLASH even in for SPL, so there is no need of non-
> dm if here.

I will do the update in v3

Patrick.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [PATCH 3/7] da850evm: sf: Read default speed and mode values from DT

2018-12-12 Thread Jagan Teki
+ Adam

On Mon, Dec 10, 2018 at 4:23 PM Patrick Delaunay
 wrote:
>
> In case of DT boot, don't read default speed and mode for SPI from
> CONFIG_*, instead read from DT node.
>
> Signed-off-by: Patrick Delaunay 
> ---
>
>  board/davinci/da8xxevm/da850evm.c | 7 +++
>  1 file changed, 7 insertions(+)
>
> diff --git a/board/davinci/da8xxevm/da850evm.c 
> b/board/davinci/da8xxevm/da850evm.c
> index b0b29b3..4ef454e 100644
> --- a/board/davinci/da8xxevm/da850evm.c
> +++ b/board/davinci/da8xxevm/da850evm.c
> @@ -44,8 +44,15 @@ DECLARE_GLOBAL_DATA_PTR;
>
>  #define CFG_MAC_ADDR_SPI_BUS   0
>  #define CFG_MAC_ADDR_SPI_CS0
> +
> +#ifdef CONFIG_DM_SPI_FLASH
> +/* In DM mode, speed and mode value will be taken from DT */
> +#define CFG_MAC_ADDR_SPI_MAX_HZ0
> +#define CFG_MAC_ADDR_SPI_MODE  0
> +#else
>  #define CFG_MAC_ADDR_SPI_MAX_HZCONFIG_SF_DEFAULT_SPEED
>  #define CFG_MAC_ADDR_SPI_MODE  SPI_MODE_3
> +#endif

This board support DM_SPI_FLASH even in for SPL, so there is no need
of non-dm if here.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [PATCH 3/7] da850evm: sf: Read default speed and mode values from DT

2018-12-10 Thread Petr Vorel
Hi Patrick,

> In case of DT boot, don't read default speed and mode for SPI from
> CONFIG_*, instead read from DT node.

> Signed-off-by: Patrick Delaunay 
Reviewed-by: Petr Vorel 


Kind regards,
Petr
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot