Re: [U-Boot] [PATCH 8/8] spi: Kconfig: Mark LPC32XX_SSP has BROKEN

2019-05-09 Thread Sylvain Lemieux
Acked-by: Sylvain Lemieux 

On Tue, Apr 30, 2019 at 4:48 PM Vladimir Zapolskiy  wrote:
>
> Hi Jagan,
>
> On 04/28/2019 11:48 PM, Jagan Teki wrote:
> > Mark LPC32XX_SSP has BROKEN, this so the resulting build shows
> > warning for broken configuration enabled and associated code
> > will remove in v2019.07 release.
> >
> > Cc: Vladimir Zapolskiy 
> > Cc: Albert ARIBAUD 
> > Signed-off-by: Jagan Teki 
> > ---
> >  drivers/spi/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> > index 55f0d6cf2b..5fbe17bb20 100644
> > --- a/drivers/spi/Kconfig
> > +++ b/drivers/spi/Kconfig
> > @@ -369,6 +369,7 @@ config KIRKWOOD_SPI
> >
> >  config LPC32XX_SSP
> >   bool "LPC32XX SPI Driver"
> > + select BROKEN
> >   help
> > Enable support for SPI on LPC32xx
> >
> >
>
> Acked-by: Vladimir Zapolskiy 
>
> Thank you for the change, as we've discussed earlier I won't have
> objections against the driver removal when time is up.
>
> Thus you can locally prepare a removal change in advance, the one
> which you've sent earlier needs a minor update, please also remove
> lpc32xx_ssp_init() function and its usage in the board files.
>
> --
> Best wishes,
> Vladimir
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot


Re: [U-Boot] [PATCH 8/8] spi: Kconfig: Mark LPC32XX_SSP has BROKEN

2019-04-30 Thread Vladimir Zapolskiy
Hi Jagan,

On 04/28/2019 11:48 PM, Jagan Teki wrote:
> Mark LPC32XX_SSP has BROKEN, this so the resulting build shows
> warning for broken configuration enabled and associated code
> will remove in v2019.07 release.
> 
> Cc: Vladimir Zapolskiy 
> Cc: Albert ARIBAUD 
> Signed-off-by: Jagan Teki 
> ---
>  drivers/spi/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index 55f0d6cf2b..5fbe17bb20 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -369,6 +369,7 @@ config KIRKWOOD_SPI
>  
>  config LPC32XX_SSP
>   bool "LPC32XX SPI Driver"
> + select BROKEN
>   help
> Enable support for SPI on LPC32xx
>  
> 

Acked-by: Vladimir Zapolskiy 

Thank you for the change, as we've discussed earlier I won't have
objections against the driver removal when time is up.

Thus you can locally prepare a removal change in advance, the one
which you've sent earlier needs a minor update, please also remove
lpc32xx_ssp_init() function and its usage in the board files.

--
Best wishes,
Vladimir
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot