Re: [U-Boot] [PATCH v2] Correct ffs/fls regression for PowerPC etc
On Sep 17, 2009, at 8:15 AM, Simon Kagstrom wrote: Correct ffs/fls regression for PowerPC etc Commits 02f99901ed1c9d828e3ea117f94ce2264bf8389e 52d61227b66d4099b39c8309ab37cb67ee09a405 introduced a regression where platform-specific ffs/fls implementations were defined away. This patch corrects that by using PLATFORM_xxx instead of the name itself. Signed-off-by: Simon Kagstrom simon.kagst...@netinsight.net --- I've runtime tested on ARM (OpenRD base) and build-tested on MPC8536DS, where __ilog2_u64 now at least is non-empty. It would be nice if (at least!) some PowerPC people could test the patch. ChangeLog: v2 - Make _all_ macros upper case (Stefan, Wolfgang) Acked-by: Kumar Gala ga...@kernel.crashing.org This fixes the issue I was seeing. - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] Correct ffs/fls regression for PowerPC etc
On Thursday 17 September 2009 15:15:52 Simon Kagstrom wrote: Correct ffs/fls regression for PowerPC etc Commits 02f99901ed1c9d828e3ea117f94ce2264bf8389e 52d61227b66d4099b39c8309ab37cb67ee09a405 introduced a regression where platform-specific ffs/fls implementations were defined away. This patch corrects that by using PLATFORM_xxx instead of the name itself. Signed-off-by: Simon Kagstrom simon.kagst...@netinsight.net You have the subject Correct ffs/fls regression for PowerPC etc twice in the commit message, once in the email subject and once at the beginning of the mail body. Other than this: Acked-by: Stefan Roese s...@denx.de Thanks. Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] Correct ffs/fls regression for PowerPC etc
On Thursday 17 September 2009 16:22:12 Simon Kagstrom wrote: You have the subject Correct ffs/fls regression for PowerPC etc twice in the commit message, once in the email subject and once at the beginning of the mail body. Well, I'll admit that I haven't setup git to send emails yet, so I simply paste them into my regular mail program. I'll submit with the first line only in the subject from now on. Or setup git-send-email one day :-) Yes, git send-email really saves time and trouble from my experience. :) Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] Correct ffs/fls regression for PowerPC etc
Dear Simon Kagstrom, In message 20090917151552.013d4...@marrow.netinsight.se you wrote: Correct ffs/fls regression for PowerPC etc Commits 02f99901ed1c9d828e3ea117f94ce2264bf8389e 52d61227b66d4099b39c8309ab37cb67ee09a405 introduced a regression where platform-specific ffs/fls implementations were defined away. This patch corrects that by using PLATFORM_xxx instead of the name itself. Signed-off-by: Simon Kagstrom simon.kagst...@netinsight.net --- I've runtime tested on ARM (OpenRD base) and build-tested on MPC8536DS, where __ilog2_u64 now at least is non-empty. It would be nice if (at least!) some PowerPC people could test the patch. ChangeLog: v2 - Make _all_ macros upper case (Stefan, Wolfgang) include/asm-arm/bitops.h|8 include/asm-blackfin/bitops.h | 10 +- include/asm-i386/bitops.h |2 +- include/asm-m68k/bitops.h |2 +- include/asm-microblaze/bitops.h |3 ++- include/asm-mips/bitops.h | 13 + include/asm-nios/bitops.h |2 +- include/asm-nios2/bitops.h |2 +- include/asm-ppc/bitops.h|4 ++-- include/asm-sh/bitops.h |2 +- include/linux/bitops.h |8 11 files changed, 15 insertions(+), 41 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de It may be bad manners to talk with your mouth full, but it isn't too good either if you speak when your head is empty. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
