Re: [U-Boot] [PATCH v2 1/5] ARM: MediaTek: Add support for MediaTek MT8518 SoC
On Wed, 2019-10-30 at 23:09 -0400, Tom Rini wrote:
> On Mon, Oct 21, 2019 at 02:59:04PM +0800, mingming lee wrote:
>
> > Add support for MediaTek MT8518 SoC. This include the file
> > that will initialize the SoC after boot and its device tree.
> >
> > Signed-off-by: mingming lee
> > ---
> > Changes for v2:
> >-drop unused 'device' in dtsi to keep it simple
>
> Please fix problems such as:
> +drivers/clk/mediatek/clk-mt8518.c:1294:35: error: 'top7_cg_regs'
> defined but not used [-Werror=unused-const-variable=]
> + static const struct mtk_gate_regs top7_cg_regs = {
> + ^~~~
> +drivers/clk/mediatek/clk-mt8518.c:1288:35: error: 'top6_cg_regs'
> defined but not used [-Werror=unused-const-variable=]
> + static const struct mtk_gate_regs top6_cg_regs = {
> +cc1: all warnings being treated as errors
> +make[4]: *** [drivers/clk/mediatek/clk-mt8518.o] Error 1
> +make[3]: *** [drivers/clk/mediatek] Error 2
> +make[2]: *** [drivers/clk] Error 2
> +make[1]: *** [drivers] Error 2
>
> and ensure everything builds without warning, thanks!
>
Thank you for your review.
Sorry for forgetting build with -Werror flag, and I would check it
again.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/5] ARM: MediaTek: Add support for MediaTek MT8518 SoC
On Mon, Oct 21, 2019 at 02:59:04PM +0800, mingming lee wrote:
> Add support for MediaTek MT8518 SoC. This include the file
> that will initialize the SoC after boot and its device tree.
>
> Signed-off-by: mingming lee
> ---
> Changes for v2:
>-drop unused 'device' in dtsi to keep it simple
Please fix problems such as:
+drivers/clk/mediatek/clk-mt8518.c:1294:35: error: 'top7_cg_regs'
defined but not used [-Werror=unused-const-variable=]
+ static const struct mtk_gate_regs top7_cg_regs = {
+ ^~~~
+drivers/clk/mediatek/clk-mt8518.c:1288:35: error: 'top6_cg_regs'
defined but not used [-Werror=unused-const-variable=]
+ static const struct mtk_gate_regs top6_cg_regs = {
+cc1: all warnings being treated as errors
+make[4]: *** [drivers/clk/mediatek/clk-mt8518.o] Error 1
+make[3]: *** [drivers/clk/mediatek] Error 2
+make[2]: *** [drivers/clk] Error 2
+make[1]: *** [drivers] Error 2
and ensure everything builds without warning, thanks!
--
Tom
signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
