Re: [U-Boot] [PATCH v2 1/6] arm: ensure u-boot only uses relative relocations

[Benoît Thébaudeau]

Hi Albert,

On Tuesday, May 28, 2013 9:01:46 AM, Albert ARIBAUD wrote:
 Add a Makefile target ('checkarmreloc') which
 fails of the ELF binary contains relocation records
^
if

Sorry to have missed that in my review of v1.

 of types other than R_ARM_RELATIVE.

The rest of the patch is OK.

Best regards,
Benoît
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 1/6] arm: ensure u-boot only uses relative relocations

[Albert ARIBAUD]

Hi Benoît,

On Tue, 28 May 2013 19:04:23 +0200 (CEST), Benoît Thébaudeau
benoit.thebaud...@advansee.com wrote:

 Hi Albert,
 
 On Tuesday, May 28, 2013 9:01:46 AM, Albert ARIBAUD wrote:
  Add a Makefile target ('checkarmreloc') which
  fails of the ELF binary contains relocation records
 ^
 if

(and)

  Also, __image_copy_end needs its own section; putting
  it in relocation sections changes their flags and makes
  relocation breaks.
  ^
  break

 Sorry to have missed that in my review of v1.

Never mind: I'd missed them too. :)

I'll wait a bit for other comments if any, then send out a fixed V3.

 Best regards,
 Benoît

Amicalement,
-- 
Albert.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot