Re: [U-Boot] [PATCH v6 4/7] net: phy: ti: Allow the driver to be more configurable

[Dan Murphy]

Michal

On 04/28/2016 01:26 AM, Michal Simek wrote:
> Hi Joe,
>
> On 28.4.2016 06:52, Joe Hershberger wrote:
>> On Wed, Apr 27, 2016 at 10:46 AM, Dan Murphy  wrote:
>>> Joe
>>>
>>> On 04/26/2016 04:44 PM, Joe Hershberger wrote:
 On Mon, Apr 25, 2016 at 4:35 PM, Joe Hershberger
  wrote:
> On Fri, Apr 15, 2016 at 7:27 AM, Dan Murphy  wrote:
>> Not all devices use the same internal delay or fifo depth.
>> Add the ability to set the internal delay for rx or tx and the
>> fifo depth via the devicetree.  If the value is not set in the
>> devicetree then set the delay to the default.
>>
>> If devicetree is not used then use the default defines within the
>> driver.
>>
>> Signed-off-by: Dan Murphy 
> Acked-by: Joe Hershberger 
 This patch is not checkpatch.pl clean. Please resubmit.


 610950.mbox:140: WARNING: line over 80 characters
 610950.mbox:153: WARNING: line over 80 characters
 610950.mbox:154: WARNING: line over 80 characters
 610950.mbox:165: WARNING: line over 80 characters
 total: 0 errors, 4 warnings, 0 checks, 136 lines checked

Joe fixing these will break readability of the code.
I will document this in the next patch submission


>>> How do you want me to rebase these patches on the SGMII work from Michal on 
>>> the ti.c
>>> or off of master?  The patch I submitted was based off of the SGMII 
>>> patchset.
>> I'm pulling in some of Michal's patches this release. Please reference
>> which patches this depends on (patchwork links).
> NOTE: A lot of my patches (maybe all of them) were already merged to
> mainline via Xilinx tree.

OK latest pull has the SGMII patches on the ti.c.

> Cheers,
> Michal


-- 
--
Dan Murphy

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v6 4/7] net: phy: ti: Allow the driver to be more configurable

[Michal Simek]

Hi Joe,

On 28.4.2016 06:52, Joe Hershberger wrote:
> On Wed, Apr 27, 2016 at 10:46 AM, Dan Murphy  wrote:
>> Joe
>>
>> On 04/26/2016 04:44 PM, Joe Hershberger wrote:
>>> On Mon, Apr 25, 2016 at 4:35 PM, Joe Hershberger
>>>  wrote:
 On Fri, Apr 15, 2016 at 7:27 AM, Dan Murphy  wrote:
> Not all devices use the same internal delay or fifo depth.
> Add the ability to set the internal delay for rx or tx and the
> fifo depth via the devicetree.  If the value is not set in the
> devicetree then set the delay to the default.
>
> If devicetree is not used then use the default defines within the
> driver.
>
> Signed-off-by: Dan Murphy 
 Acked-by: Joe Hershberger 
>>> This patch is not checkpatch.pl clean. Please resubmit.
>>>
>>>
>>> 610950.mbox:140: WARNING: line over 80 characters
>>> 610950.mbox:153: WARNING: line over 80 characters
>>> 610950.mbox:154: WARNING: line over 80 characters
>>> 610950.mbox:165: WARNING: line over 80 characters
>>> total: 0 errors, 4 warnings, 0 checks, 136 lines checked
>>
>> How do you want me to rebase these patches on the SGMII work from Michal on 
>> the ti.c
>> or off of master?  The patch I submitted was based off of the SGMII patchset.
> 
> I'm pulling in some of Michal's patches this release. Please reference
> which patches this depends on (patchwork links).

NOTE: A lot of my patches (maybe all of them) were already merged to
mainline via Xilinx tree.

Cheers,
Michal
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v6 4/7] net: phy: ti: Allow the driver to be more configurable

[Joe Hershberger]

On Wed, Apr 27, 2016 at 10:46 AM, Dan Murphy  wrote:
> Joe
>
> On 04/26/2016 04:44 PM, Joe Hershberger wrote:
>> On Mon, Apr 25, 2016 at 4:35 PM, Joe Hershberger
>>  wrote:
>>> On Fri, Apr 15, 2016 at 7:27 AM, Dan Murphy  wrote:
 Not all devices use the same internal delay or fifo depth.
 Add the ability to set the internal delay for rx or tx and the
 fifo depth via the devicetree.  If the value is not set in the
 devicetree then set the delay to the default.

 If devicetree is not used then use the default defines within the
 driver.

 Signed-off-by: Dan Murphy 
>>> Acked-by: Joe Hershberger 
>> This patch is not checkpatch.pl clean. Please resubmit.
>>
>>
>> 610950.mbox:140: WARNING: line over 80 characters
>> 610950.mbox:153: WARNING: line over 80 characters
>> 610950.mbox:154: WARNING: line over 80 characters
>> 610950.mbox:165: WARNING: line over 80 characters
>> total: 0 errors, 4 warnings, 0 checks, 136 lines checked
>
> How do you want me to rebase these patches on the SGMII work from Michal on 
> the ti.c
> or off of master?  The patch I submitted was based off of the SGMII patchset.

I'm pulling in some of Michal's patches this release. Please reference
which patches this depends on (patchwork links).

> Need to know how you want to handle this as I see the SGMII code is not in 
> the base line
> yet.

If the patches you depend on are acceptable (no changes requested)
then definitely base your changes on them, but point them out to me.

Thanks,
-Joe
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v6 4/7] net: phy: ti: Allow the driver to be more configurable

[Dan Murphy]

Joe

On 04/26/2016 04:44 PM, Joe Hershberger wrote:
> On Mon, Apr 25, 2016 at 4:35 PM, Joe Hershberger
>  wrote:
>> On Fri, Apr 15, 2016 at 7:27 AM, Dan Murphy  wrote:
>>> Not all devices use the same internal delay or fifo depth.
>>> Add the ability to set the internal delay for rx or tx and the
>>> fifo depth via the devicetree.  If the value is not set in the
>>> devicetree then set the delay to the default.
>>>
>>> If devicetree is not used then use the default defines within the
>>> driver.
>>>
>>> Signed-off-by: Dan Murphy 
>> Acked-by: Joe Hershberger 
> This patch is not checkpatch.pl clean. Please resubmit.
>
>
> 610950.mbox:140: WARNING: line over 80 characters
> 610950.mbox:153: WARNING: line over 80 characters
> 610950.mbox:154: WARNING: line over 80 characters
> 610950.mbox:165: WARNING: line over 80 characters
> total: 0 errors, 4 warnings, 0 checks, 136 lines checked

How do you want me to rebase these patches on the SGMII work from Michal on the 
ti.c
or off of master?  The patch I submitted was based off of the SGMII patchset.

Need to know how you want to handle this as I see the SGMII code is not in the 
base line
yet.

Dan

-- 
--
Dan Murphy

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v6 4/7] net: phy: ti: Allow the driver to be more configurable

[Joe Hershberger]

On Mon, Apr 25, 2016 at 4:35 PM, Joe Hershberger
 wrote:
> On Fri, Apr 15, 2016 at 7:27 AM, Dan Murphy  wrote:
>> Not all devices use the same internal delay or fifo depth.
>> Add the ability to set the internal delay for rx or tx and the
>> fifo depth via the devicetree.  If the value is not set in the
>> devicetree then set the delay to the default.
>>
>> If devicetree is not used then use the default defines within the
>> driver.
>>
>> Signed-off-by: Dan Murphy 
>
> Acked-by: Joe Hershberger 

This patch is not checkpatch.pl clean. Please resubmit.


610950.mbox:140: WARNING: line over 80 characters
610950.mbox:153: WARNING: line over 80 characters
610950.mbox:154: WARNING: line over 80 characters
610950.mbox:165: WARNING: line over 80 characters
total: 0 errors, 4 warnings, 0 checks, 136 lines checked
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v6 4/7] net: phy: ti: Allow the driver to be more configurable

[Joe Hershberger]

On Fri, Apr 15, 2016 at 7:27 AM, Dan Murphy  wrote:
> Not all devices use the same internal delay or fifo depth.
> Add the ability to set the internal delay for rx or tx and the
> fifo depth via the devicetree.  If the value is not set in the
> devicetree then set the delay to the default.
>
> If devicetree is not used then use the default defines within the
> driver.
>
> Signed-off-by: Dan Murphy 

Acked-by: Joe Hershberger 
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v6 4/7] net: phy: ti: Allow the driver to be more configurable

[Mugunthan V N]

On Friday 15 April 2016 05:57 PM, Dan Murphy wrote:
> Not all devices use the same internal delay or fifo depth.
> Add the ability to set the internal delay for rx or tx and the
> fifo depth via the devicetree.  If the value is not set in the
> devicetree then set the delay to the default.
> 
> If devicetree is not used then use the default defines within the
> driver.
> 
> Signed-off-by: Dan Murphy 

Tested this on dra72 rev C evm

Tested-by: Mugunthan V N 

Regards
Mugutnhan V N
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot