Re: [U-Boot] [RESEND][PATCH] power: regulator: denied disable on always-on regulator
On Tue, 4 Dec 2018 at 01:02, Patrice CHOTARD wrote: > > Hi Simon > > On 12/3/18 7:20 PM, Simon Glass wrote: > > Hi, > > > > On Mon, 3 Dec 2018 at 04:07, Felix Brack wrote: > >> > >> On 15.11.2018 13:45, Patrice Chotard wrote: > >>> From: Patrick Delaunay > >>> > >>> Don't disable regulator which are tagged as "regulator-always-on" in DT. > >>> > >>> Signed-off-by: Patrick Delaunay > >>> Reviewed-by: Simon Glass > >>> Reviewed-by: Jack Mitchell > >>> Tested-by: Jack Mitchell > >>> Signed-off-by: Patrice Chotard > >>> --- > >>> > >>> drivers/power/regulator/regulator-uclass.c | 5 + > >>> 1 file changed, 5 insertions(+) > >>> > > > > I'm happy to pick it up if that helps. > > Thank you ;-) Applied to u-boot-dm, thanks! ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [RESEND][PATCH] power: regulator: denied disable on always-on regulator
Hi Simon On 12/3/18 7:20 PM, Simon Glass wrote: > Hi, > > On Mon, 3 Dec 2018 at 04:07, Felix Brack wrote: >> >> On 15.11.2018 13:45, Patrice Chotard wrote: >>> From: Patrick Delaunay >>> >>> Don't disable regulator which are tagged as "regulator-always-on" in DT. >>> >>> Signed-off-by: Patrick Delaunay >>> Reviewed-by: Simon Glass >>> Reviewed-by: Jack Mitchell >>> Tested-by: Jack Mitchell >>> Signed-off-by: Patrice Chotard >>> --- >>> >>> drivers/power/regulator/regulator-uclass.c | 5 + >>> 1 file changed, 5 insertions(+) >>> > > I'm happy to pick it up if that helps. Thank you ;-) > > Regards, > Simon > ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [RESEND][PATCH] power: regulator: denied disable on always-on regulator
Hello Simon, On 03.12.18 19:20, Simon Glass wrote: Hi, On Mon, 3 Dec 2018 at 04:07, Felix Brack wrote: On 15.11.2018 13:45, Patrice Chotard wrote: From: Patrick Delaunay Don't disable regulator which are tagged as "regulator-always-on" in DT. Signed-off-by: Patrick Delaunay Reviewed-by: Simon Glass Reviewed-by: Jack Mitchell Tested-by: Jack Mitchell Signed-off-by: Patrice Chotard --- drivers/power/regulator/regulator-uclass.c | 5 + 1 file changed, 5 insertions(+) I'm happy to pick it up if that helps. Excellent! Thank you very much for taking care. Regards, Felix ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [RESEND][PATCH] power: regulator: denied disable on always-on regulator
On Mon, Dec 03, 2018 at 11:20:13AM -0700, Simon Glass wrote: > Hi, > > On Mon, 3 Dec 2018 at 04:07, Felix Brack wrote: > > > > On 15.11.2018 13:45, Patrice Chotard wrote: > > > From: Patrick Delaunay > > > > > > Don't disable regulator which are tagged as "regulator-always-on" in DT. > > > > > > Signed-off-by: Patrick Delaunay > > > Reviewed-by: Simon Glass > > > Reviewed-by: Jack Mitchell > > > Tested-by: Jack Mitchell > > > Signed-off-by: Patrice Chotard > > > --- > > > > > > drivers/power/regulator/regulator-uclass.c | 5 + > > > 1 file changed, 5 insertions(+) > > > > > I'm happy to pick it up if that helps. Please, thanks! -- Tom signature.asc Description: PGP signature ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [RESEND][PATCH] power: regulator: denied disable on always-on regulator
Hi, On Mon, 3 Dec 2018 at 04:07, Felix Brack wrote: > > On 15.11.2018 13:45, Patrice Chotard wrote: > > From: Patrick Delaunay > > > > Don't disable regulator which are tagged as "regulator-always-on" in DT. > > > > Signed-off-by: Patrick Delaunay > > Reviewed-by: Simon Glass > > Reviewed-by: Jack Mitchell > > Tested-by: Jack Mitchell > > Signed-off-by: Patrice Chotard > > --- > > > > drivers/power/regulator/regulator-uclass.c | 5 + > > 1 file changed, 5 insertions(+) > > I'm happy to pick it up if that helps. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [RESEND][PATCH] power: regulator: denied disable on always-on regulator
On 15.11.2018 13:45, Patrice Chotard wrote:
> From: Patrick Delaunay
>
> Don't disable regulator which are tagged as "regulator-always-on" in DT.
>
> Signed-off-by: Patrick Delaunay
> Reviewed-by: Simon Glass
> Reviewed-by: Jack Mitchell
> Tested-by: Jack Mitchell
> Signed-off-by: Patrice Chotard
> ---
>
> drivers/power/regulator/regulator-uclass.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/power/regulator/regulator-uclass.c
> b/drivers/power/regulator/regulator-uclass.c
> index 4da8e43259fc..4511625ff251 100644
> --- a/drivers/power/regulator/regulator-uclass.c
> +++ b/drivers/power/regulator/regulator-uclass.c
> @@ -106,10 +106,15 @@ int regulator_get_enable(struct udevice *dev)
> int regulator_set_enable(struct udevice *dev, bool enable)
> {
> const struct dm_regulator_ops *ops = dev_get_driver_ops(dev);
> + struct dm_regulator_uclass_platdata *uc_pdata;
>
> if (!ops || !ops->set_enable)
> return -ENOSYS;
>
> + uc_pdata = dev_get_uclass_platdata(dev);
> + if (!enable && uc_pdata->always_on)
> + return -EACCES;
> +
> return ops->set_enable(dev, enable);
> }
>
>
This patch has been around since May 2018 (albeit superseded). A request
from Patrice Chotard to Jaehoon Chung about the patch status change
never got answered. Looking Patchwork I don't see any post from Jaehoon
after May 8. 2018.
Please don't get me wrong: I just want to make sure this patch doesn't
get forgotten, knowing very well, that it was posted (resent) just 2
weeks ago. Expecting quite a few board maintainers to enable DM_MMC in
the coming weeks and months this patch might get important to more
people as it prevents powering off the MMC supply voltage during power
cycling.
If the patch is on someones radar that's fine with me.
regards, Felix
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [RESEND][PATCH] power: regulator: denied disable on always-on regulator
On 15.11.2018 13:45, Patrice Chotard wrote: > From: Patrick Delaunay > > Don't disable regulator which are tagged as "regulator-always-on" in DT. > > Signed-off-by: Patrick Delaunay > Reviewed-by: Simon Glass > Reviewed-by: Jack Mitchell > Tested-by: Jack Mitchell > Signed-off-by: Patrice Chotard > --- > Reviewed-by: Felix Brack Tested-by: Felix Brack ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
Re: [U-Boot] [RESEND][PATCH] power: regulator: denied disable on always-on regulator
On Thu, Nov 15, 2018 at 1:46 PM Patrice Chotard wrote: > > From: Patrick Delaunay > > Don't disable regulator which are tagged as "regulator-always-on" in DT. > > Signed-off-by: Patrick Delaunay > Reviewed-by: Simon Glass > Reviewed-by: Jack Mitchell > Tested-by: Jack Mitchell > Signed-off-by: Patrice Chotard Reviewed-by: Richard Röjfors Tested-by: Richard Röjfors ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
