Re: [U-Boot] [RFC PATCH 1/7] Allow checking in multiple partitions for scan_dev_for_boot.

2014-10-07 Thread Vagrant Cascadian
Thanks for the review!

On 2014-10-06, Stephen Warren swar...@nvidia.com wrote:
 On 10/03/2014 03:08 PM, Vagrant Cascadian wrote:

 Some standalone description of this change, and justification for it,
 should really be present in the commit message. Patch 0/7 doesn't get
 applied anywhere.

Of course; that was a consequence of learning how patman/git-send-email
work... trial by fire... I'll use more verbose commit messages in the
future.


 diff --git a/include/config_distro_bootcmd.h 
 b/include/config_distro_bootcmd.h

 -bootpart=1\0 \
 +boot_partitions=1\0 \

 Instead of searching a hard-coded list of partitions, I think it'd be
 better to have the script automatically determine which partition to
 boot from based on the partition tables' bootable flag or partition
 type. I had always intended these scripts to do that, but never got
 around to doing it. I think the $dev:$part syntax already chooses the
 first partition marked bootable if you don't specify a partition. Would
 that work?

I suspect that might work. I merely went with the simplest approach to
extend what was already there, by supporting an arbitrary number of
partitions to search, and leaving the defaults as is.

The BeagleBone Black board ships with various boot files on the first
FAT partition, but newer images available for it moved boot files
(kernel/initrd/dtb/uEnv.txt) onto the second (ext4?) partition, as the
FAT partition is exported as a multifunction device over USB... So
ideally u-boot could support multiple partitions to search, to support
multiple generations of images without having to manually configure
u-boot.


live well,
  vagrant


pgpYMPgOlw9Yn.pgp
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [RFC PATCH 1/7] Allow checking in multiple partitions for scan_dev_for_boot.

2014-10-06 Thread Stephen Warren
On 10/03/2014 03:08 PM, Vagrant Cascadian wrote:

Some standalone description of this change, and justification for it,
should really be present in the commit message. Patch 0/7 doesn't get
applied anywhere.

 diff --git a/include/config_distro_bootcmd.h b/include/config_distro_bootcmd.h

 - bootpart=1\0 \
 + boot_partitions=1\0 \

Instead of searching a hard-coded list of partitions, I think it'd be
better to have the script automatically determine which partition to
boot from based on the partition tables' bootable flag or partition
type. I had always intended these scripts to do that, but never got
around to doing it. I think the $dev:$part syntax already chooses the
first partition marked bootable if you don't specify a partition. Would
that work?
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot