Re: [U-Boot] [RFC PATCH v2 04/15] bootstage: Convert progress numbers 1-9 into enums

2012-01-08 Thread Simon Glass 
Hi Mike,

On Sun, Jan 8, 2012 at 12:27 AM, Mike Frysinger  wrote:
> On Saturday 10 December 2011 16:07:56 Simon Glass wrote:
>> --- a/include/bootstage.h
>> +++ b/include/bootstage.h
>>
>>  enum bootstage_id {
>> +     BOOTSTAGE_ID_START,
>> +     BOOTSTAGE_ID_CHECK_MAGIC,       /* Checking image magic */
>> +     BOOTSTAGE_ID_CHECK_HEADER,      /* Checking image header */
>> +     BOOTSTAGE_ID_CHECK_CHECKSUM,    /* Checking image checksum */
>> +     BOOTSTAGE_ID_CHECK_ARCH,        /* Checking architecture */
>
> i know it's unlikely to ever change, but this would be good to be explicit:
>        BOOTSTAGE_ID_START = 0,
> -mike

done

Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [RFC PATCH v2 04/15] bootstage: Convert progress numbers 1-9 into enums

2012-01-08 Thread Mike Frysinger 
On Saturday 10 December 2011 16:07:56 Simon Glass wrote:
> --- a/include/bootstage.h
> +++ b/include/bootstage.h
>
>  enum bootstage_id {
> + BOOTSTAGE_ID_START,
> + BOOTSTAGE_ID_CHECK_MAGIC,   /* Checking image magic */
> + BOOTSTAGE_ID_CHECK_HEADER,  /* Checking image header */
> + BOOTSTAGE_ID_CHECK_CHECKSUM,/* Checking image checksum */
> + BOOTSTAGE_ID_CHECK_ARCH,/* Checking architecture */

i know it's unlikely to ever change, but this would be good to be explicit:
BOOTSTAGE_ID_START = 0,
-mike


signature.asc
Description: This is a digitally signed message part.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot