Re: [U-Boot] [u-boot V5] spi: arm-pl022: Add support for ARM PL022 spi controller

2013-06-12 Thread Jagan Teki
Hi,

Your patch looks good to me, but the same time
I have sent some comments on v4 patch
http://patchwork.ozlabs.org/patch/249603/

I think you might respond to above thread before sending v5, may be
your missing my
earlier comments?

fyi: One one more thing the patch subject prefix should be PATCH like
--subject-prefix=PATCH v5

Please respond to above thread for sending next level patch.

--
Thanks,
Jagan.

On Wed, Jun 12, 2013 at 1:38 PM, Armando Visconti
armando.visco...@st.com wrote:
 This patch adds the support for the ARM PL022 SPI controller for the standard
 variant (0x00041022), which has a 16bit wide and 8 locations deep TX/RX FIFO.

 Signed-off-by: Armando Visconti armando.visco...@st.com
 Signed-off-by: Vipin Kumar vipin.ku...@st.com
 Acked-by: Stefan Roese s...@denx.de
 ---
 V4-V5:
 Changed the commit message to a more standard format.

 Armando


  drivers/spi/Makefile|   1 +
  drivers/spi/pl022_spi.c | 310 
 
  2 files changed, 311 insertions(+)
  create mode 100644 drivers/spi/pl022_spi.c

 diff --git a/drivers/spi/Makefile b/drivers/spi/Makefile
 index d08609e..b6443b1 100644
 --- a/drivers/spi/Makefile
 +++ b/drivers/spi/Makefile
 @@ -47,6 +47,7 @@ COBJS-$(CONFIG_MXC_SPI) += mxc_spi.o
  COBJS-$(CONFIG_MXS_SPI) += mxs_spi.o
  COBJS-$(CONFIG_OC_TINY_SPI) += oc_tiny_spi.o
  COBJS-$(CONFIG_OMAP3_SPI) += omap3_spi.o
 +COBJS-$(CONFIG_PL022_SPI) += pl022_spi.o
  COBJS-$(CONFIG_SOFT_SPI) += soft_spi.o
  COBJS-$(CONFIG_SH_SPI) += sh_spi.o
  COBJS-$(CONFIG_FSL_ESPI) += fsl_espi.o
 diff --git a/drivers/spi/pl022_spi.c b/drivers/spi/pl022_spi.c
 new file mode 100644
 index 000..8a8b9ab
 --- /dev/null
 +++ b/drivers/spi/pl022_spi.c
 @@ -0,0 +1,310 @@
 +/*
 + * (C) Copyright 2012
 + * Armando Visconti, ST Microelectronics, armando.visco...@st.com.
 + *
 + * Driver for ARM PL022 SPI Controller. Based on atmel_spi.c
 + * by Atmel Corporation.
 + *
 + * This program is free software; you can redistribute it and/or
 + * modify it under the terms of the GNU General Public License as
 + * published by the Free Software Foundation; either version 2 of
 + * the License, or (at your option) any later version.
 + *
 + * This program is distributed in the hope that it will be useful,
 + * but WITHOUT ANY WARRANTY; without even the implied warranty of
 + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 + * GNU General Public License for more details.
 + *
 + * You should have received a copy of the GNU General Public License
 + * along with this program; if not, write to the Free Software
 + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
 + * MA 02111-1307 USA
 + */
 +
 +#include common.h
 +#include malloc.h
 +#include spi.h
 +#include asm/io.h
 +#include asm/arch/hardware.h
 +
 +/* SSP registers mapping */
 +struct pl022 {
 +   u32 ssp_cr0;/* 0x000 */
 +   u32 ssp_cr1;/* 0x004 */
 +   u32 ssp_dr; /* 0x008 */
 +   u32 ssp_sr; /* 0x00c */
 +   u32 ssp_cpsr;   /* 0x010 */
 +   u32 ssp_imsc;   /* 0x014 */
 +   u32 ssp_ris;/* 0x018 */
 +   u32 ssp_mis;/* 0x01c */
 +   u32 ssp_icr;/* 0x020 */
 +   u32 ssp_dmacr;  /* 0x024 */
 +   u8  reserved_1[0x080 - 0x028];
 +   u32 ssp_itcr;   /* 0x080 */
 +   u32 ssp_itip;   /* 0x084 */
 +   u32 ssp_itop;   /* 0x088 */
 +   u32 ssp_tdr;/* 0x08c */
 +   u8  reserved_2[0xFE0 - 0x090];
 +   u32 ssp_pid0;   /* 0xfe0 */
 +   u32 ssp_pid1;   /* 0xfe4 */
 +   u32 ssp_pid2;   /* 0xfe8 */
 +   u32 ssp_pid3;   /* 0xfec */
 +   u32 ssp_cid0;   /* 0xff0 */
 +   u32 ssp_cid1;   /* 0xff4 */
 +   u32 ssp_cid2;   /* 0xff8 */
 +   u32 ssp_cid3;   /* 0xffc */
 +};
 +
 +/* SSP Control Register 0  - SSP_CR0 */
 +#define SSP_CR0_SPO(0x1  6)
 +#define SSP_CR0_SPH(0x1  7)
 +#define SSP_CR0_8BIT_MODE  (0x07)
 +#define SSP_SCR_MAX(0xFF)
 +#define SSP_SCR_SHFT   8
 +
 +/* SSP Control Register 0  - SSP_CR1 */
 +#define SSP_CR1_MASK_SSE   (0x1  1)
 +
 +#define SSP_CPSR_MAX   (0xFE)
 +
 +/* SSP Status Register - SSP_SR */
 +#define SSP_SR_MASK_TFE(0x1  0) /* Transmit FIFO empty */
 +#define SSP_SR_MASK_TNF(0x1  1) /* Transmit FIFO not full 
 */
 +#define SSP_SR_MASK_RNE(0x1  2) /* Receive FIFO not empty 
 */
 +#define SSP_SR_MASK_RFF(0x1  3) /* Receive FIFO full */
 +#define SSP_SR_MASK_BSY(0x1  4) /* Busy Flag */
 +
 +struct pl022_spi_slave {
 +   struct spi_slave slave;
 +   void *regs;
 +   unsigned int freq;
 +};
 +
 +static inline struct pl022_spi_slave *to_pl022_spi(struct spi_slave *slave)
 +{
 +   return container_of(slave, struct pl022_spi_slave, slave);
 +}
 

Re: [U-Boot] [u-boot V5] spi: arm-pl022: Add support for ARM PL022 spi controller

2013-06-12 Thread Armando Visconti

On 06/12/2013 10:56 AM, Jagan Teki wrote:

Hi,

Your patch looks good to me, but the same time
I have sent some comments on v4 patch
http://patchwork.ozlabs.org/patch/249603/

I think you might respond to above thread before sending v5, may be
your missing my
earlier comments?


Yes, I missed them.
Sorry... I'm doing too many things at the same time... :(

I will analyse them right now.



fyi: One one more thing the patch subject prefix should be PATCH like
--subject-prefix=PATCH v5



ok, I will.
Next will be v6 at thi point..



Please respond to above thread for sending next level patch.



sure

Arm

___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot


Re: [U-Boot] [u-boot V5] spi: arm-pl022: Add support for ARM PL022 spi controller

2013-06-12 Thread Jagan Teki
On Wed, Jun 12, 2013 at 3:56 PM, Armando Visconti
armando.visco...@st.com wrote:
 On 06/12/2013 10:56 AM, Jagan Teki wrote:

 Hi,

 Your patch looks good to me, but the same time
 I have sent some comments on v4 patch
 http://patchwork.ozlabs.org/patch/249603/

 I think you might respond to above thread before sending v5, may be
 your missing my
 earlier comments?


 Yes, I missed them.
 Sorry... I'm doing too many things at the same time... :(

 I will analyse them right now.



 fyi: One one more thing the patch subject prefix should be PATCH like
 --subject-prefix=PATCH v5


 ok, I will.
 Next will be v6 at thi point..



 Please respond to above thread for sending next level patch.

no issues, thanks.
Also please use the commit header as spi: pl022_spi: 

--
Thanks,
Jagan.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot