Re: [U-Boot] Pull request: u-boot-spi/master

[Jagan Teki]

On Thu, Oct 31, 2019 at 1:31 PM Schrempf Frieder
 wrote:
>
> On 31.10.19 08:57, Jagan Teki wrote:
> > Hi Schrempf,
> >
> > On Thu, Oct 31, 2019 at 1:24 PM Schrempf Frieder
> >  wrote:
> >>
> >> Hi Jagan,
> >>
> >> On 28.10.19 01:46, Tom Rini wrote:
> >>> On Sun, Oct 27, 2019 at 05:20:22PM +0530, Jagan Teki wrote:
>  Hi Tom,
> 
>  On Fri, Oct 25, 2019 at 11:19 PM Tom Rini  wrote:
> >
> > On Fri, Oct 25, 2019 at 02:08:12PM +0530, Jagan Teki wrote:
> >
> >> Hi Tom,
> >>
> >> Please pull this PR.
> >>
> >> Summary:
> >> - SPL_SPI_FLASH_MTD (Frieder)
> >> - SPI NOR IDs' fixes, additions (Vignesh)
> >> - cs_info change (Bin)
> >> - Enable sunxi spi (Jagan)
> >>
> >> Travis-CI:
> >> https://travis-ci.org/openedev/u-boot-amarula/builds/602483415
> >>
> >> Thanks,
> >> Jagan.
> >>
> >> The following changes since commit 
> >> 17fd9915a4c639381804ed28274fa136ae3b0bee:
> >>
> >> Merge branch '2019-10-24-UFS-support' (2019-10-24 09:51:48 -0400)
> >>
> >> are available in the Git repository at:
> >>
> >> https://gitlab.denx.de/u-boot/custodians/u-boot-spi master
> >>
> >> for you to fetch changes up to 
> >> 395ec7418695e5ce23f8b48c01a1dbffd2e52d3f:
> >>
> >> spi-nor-ids: Add support for Adesto AT25SL321 (2019-10-25 00:48:32 
> >> +0530)
> >>
> >
> > So, looking over the build output, I see the expected size increase in
> > sunxi due to new support. But I also see a lot of size increases in
> > rockchip and layerscape platforms (and possibly more, I stopped after
> > spotting two different SoCs), for example:
> >   evb-px5: all +12139 data +176 rodata +2275 
> > spl/u-boot-spl:all +3529 spl/u-boot-spl:data +120 spl/u-boot-spl:rodata 
> > +309 spl/u-boot-spl:text +3100 text +9688
> >  u-boot: add: 49/0, grow: 0/0 bytes: 9512/0 (9512)
> >function   old 
> > new   delta
> >spi_nor_scan -
> > 2032   +2032
> >do_spi_flash -
> > 2008   +2008
> >spi_get_bus_and_cs   - 
> > 436+436
> >spi_mem_exec_op  - 
> > 420+420
> >static.spi_nor_wait_till_ready_with_timeout   -  
> >300+300
> >spi_nor_write- 
> > 300+300
> >mtd_arg_off_size - 
> > 276+276
> >spi_nor_erase- 
> > 232+232
> >device_unbind- 
> > 232+232
> >spi_nor_read_data- 
> > 220+220
> >spi_nor_write_data   - 
> > 212+212
> >dm_spi_claim_bus - 
> > 196+196
> >spi_mem_adjust_op_size   - 
> > 160+160
> >spi_mem_default_supports_op  - 
> > 156+156
> >spi_nor_read - 
> > 152+152
> >spi_flash_probe_bus_cs   - 
> > 152+152
> >spi_set_speed_mode   - 
> > 148+148
> >spi_flash_std_erase  - 
> > 136+136
> >spi_flash_std_probe  - 
> > 132+132
> >mtd_arg_off  - 
> > 124+124
> >device_chld_unbind   - 
> > 120+120
> >_u_boot_list_2_driver_2_spi_flash_std- 
> > 120+120
> >spi_nor_write_reg- 
> > 104+104
> >spi_find_bus_and_cs  - 
> > 104+104
> >spi_nor_read_reg - 
> > 100+100
> >spi_find_chip_select -  
> > 96 +96
> >static.spi_check_buswidth_req-  
> > 88 +88
> >str2off  -  
> > 80 +80
> >bytes_per_second -  
> > 76 +76
> >

Re: [U-Boot] Pull request: u-boot-spi/master

[Schrempf Frieder]

On 31.10.19 08:57, Jagan Teki wrote:
> Hi Schrempf,
> 
> On Thu, Oct 31, 2019 at 1:24 PM Schrempf Frieder
>  wrote:
>>
>> Hi Jagan,
>>
>> On 28.10.19 01:46, Tom Rini wrote:
>>> On Sun, Oct 27, 2019 at 05:20:22PM +0530, Jagan Teki wrote:
 Hi Tom,

 On Fri, Oct 25, 2019 at 11:19 PM Tom Rini  wrote:
>
> On Fri, Oct 25, 2019 at 02:08:12PM +0530, Jagan Teki wrote:
>
>> Hi Tom,
>>
>> Please pull this PR.
>>
>> Summary:
>> - SPL_SPI_FLASH_MTD (Frieder)
>> - SPI NOR IDs' fixes, additions (Vignesh)
>> - cs_info change (Bin)
>> - Enable sunxi spi (Jagan)
>>
>> Travis-CI:
>> https://travis-ci.org/openedev/u-boot-amarula/builds/602483415
>>
>> Thanks,
>> Jagan.
>>
>> The following changes since commit 
>> 17fd9915a4c639381804ed28274fa136ae3b0bee:
>>
>> Merge branch '2019-10-24-UFS-support' (2019-10-24 09:51:48 -0400)
>>
>> are available in the Git repository at:
>>
>> https://gitlab.denx.de/u-boot/custodians/u-boot-spi master
>>
>> for you to fetch changes up to 395ec7418695e5ce23f8b48c01a1dbffd2e52d3f:
>>
>> spi-nor-ids: Add support for Adesto AT25SL321 (2019-10-25 00:48:32 
>> +0530)
>>
>
> So, looking over the build output, I see the expected size increase in
> sunxi due to new support. But I also see a lot of size increases in
> rockchip and layerscape platforms (and possibly more, I stopped after
> spotting two different SoCs), for example:
>   evb-px5: all +12139 data +176 rodata +2275 
> spl/u-boot-spl:all +3529 spl/u-boot-spl:data +120 spl/u-boot-spl:rodata 
> +309 spl/u-boot-spl:text +3100 text +9688
>  u-boot: add: 49/0, grow: 0/0 bytes: 9512/0 (9512)
>function   old new 
>   delta
>spi_nor_scan -2032 
>   +2032
>do_spi_flash -2008 
>   +2008
>spi_get_bus_and_cs   - 436 
>+436
>spi_mem_exec_op  - 420 
>+420
>static.spi_nor_wait_till_ready_with_timeout   -
>  300+300
>spi_nor_write- 300 
>+300
>mtd_arg_off_size - 276 
>+276
>spi_nor_erase- 232 
>+232
>device_unbind- 232 
>+232
>spi_nor_read_data- 220 
>+220
>spi_nor_write_data   - 212 
>+212
>dm_spi_claim_bus - 196 
>+196
>spi_mem_adjust_op_size   - 160 
>+160
>spi_mem_default_supports_op  - 156 
>+156
>spi_nor_read - 152 
>+152
>spi_flash_probe_bus_cs   - 152 
>+152
>spi_set_speed_mode   - 148 
>+148
>spi_flash_std_erase  - 136 
>+136
>spi_flash_std_probe  - 132 
>+132
>mtd_arg_off  - 124 
>+124
>device_chld_unbind   - 120 
>+120
>_u_boot_list_2_driver_2_spi_flash_std- 120 
>+120
>spi_nor_write_reg- 104 
>+104
>spi_find_bus_and_cs  - 104 
>+104
>spi_nor_read_reg - 100 
>+100
>spi_find_chip_select -  96 
> +96
>static.spi_check_buswidth_req-  88 
> +88
>str2off  -  80 
> +80
>bytes_per_second -  76 
> +76
>spi_flash_std_write  -  72 
> +72
>spi_flash_std_read   -  72 
> +72
>spi_mem_supports_op  -  56 
> +56
>_u_boot_list_2_cmd_2_sf   

Re: [U-Boot] Pull request: u-boot-spi/master

[Jagan Teki]

Hi Schrempf,

On Thu, Oct 31, 2019 at 1:24 PM Schrempf Frieder
 wrote:
>
> Hi Jagan,
>
> On 28.10.19 01:46, Tom Rini wrote:
> > On Sun, Oct 27, 2019 at 05:20:22PM +0530, Jagan Teki wrote:
> >> Hi Tom,
> >>
> >> On Fri, Oct 25, 2019 at 11:19 PM Tom Rini  wrote:
> >>>
> >>> On Fri, Oct 25, 2019 at 02:08:12PM +0530, Jagan Teki wrote:
> >>>
>  Hi Tom,
> 
>  Please pull this PR.
> 
>  Summary:
>  - SPL_SPI_FLASH_MTD (Frieder)
>  - SPI NOR IDs' fixes, additions (Vignesh)
>  - cs_info change (Bin)
>  - Enable sunxi spi (Jagan)
> 
>  Travis-CI:
>  https://travis-ci.org/openedev/u-boot-amarula/builds/602483415
> 
>  Thanks,
>  Jagan.
> 
>  The following changes since commit 
>  17fd9915a4c639381804ed28274fa136ae3b0bee:
> 
> Merge branch '2019-10-24-UFS-support' (2019-10-24 09:51:48 -0400)
> 
>  are available in the Git repository at:
> 
> https://gitlab.denx.de/u-boot/custodians/u-boot-spi master
> 
>  for you to fetch changes up to 395ec7418695e5ce23f8b48c01a1dbffd2e52d3f:
> 
> spi-nor-ids: Add support for Adesto AT25SL321 (2019-10-25 00:48:32 
>  +0530)
> 
> >>>
> >>> So, looking over the build output, I see the expected size increase in
> >>> sunxi due to new support. But I also see a lot of size increases in
> >>> rockchip and layerscape platforms (and possibly more, I stopped after
> >>> spotting two different SoCs), for example:
> >>>  evb-px5: all +12139 data +176 rodata +2275 
> >>> spl/u-boot-spl:all +3529 spl/u-boot-spl:data +120 spl/u-boot-spl:rodata 
> >>> +309 spl/u-boot-spl:text +3100 text +9688
> >>> u-boot: add: 49/0, grow: 0/0 bytes: 9512/0 (9512)
> >>>   function   old new  
> >>>  delta
> >>>   spi_nor_scan -2032  
> >>>  +2032
> >>>   do_spi_flash -2008  
> >>>  +2008
> >>>   spi_get_bus_and_cs   - 436  
> >>>   +436
> >>>   spi_mem_exec_op  - 420  
> >>>   +420
> >>>   static.spi_nor_wait_till_ready_with_timeout   - 
> >>> 300+300
> >>>   spi_nor_write- 300  
> >>>   +300
> >>>   mtd_arg_off_size - 276  
> >>>   +276
> >>>   spi_nor_erase- 232  
> >>>   +232
> >>>   device_unbind- 232  
> >>>   +232
> >>>   spi_nor_read_data- 220  
> >>>   +220
> >>>   spi_nor_write_data   - 212  
> >>>   +212
> >>>   dm_spi_claim_bus - 196  
> >>>   +196
> >>>   spi_mem_adjust_op_size   - 160  
> >>>   +160
> >>>   spi_mem_default_supports_op  - 156  
> >>>   +156
> >>>   spi_nor_read - 152  
> >>>   +152
> >>>   spi_flash_probe_bus_cs   - 152  
> >>>   +152
> >>>   spi_set_speed_mode   - 148  
> >>>   +148
> >>>   spi_flash_std_erase  - 136  
> >>>   +136
> >>>   spi_flash_std_probe  - 132  
> >>>   +132
> >>>   mtd_arg_off  - 124  
> >>>   +124
> >>>   device_chld_unbind   - 120  
> >>>   +120
> >>>   _u_boot_list_2_driver_2_spi_flash_std- 120  
> >>>   +120
> >>>   spi_nor_write_reg- 104  
> >>>   +104
> >>>   spi_find_bus_and_cs  - 104  
> >>>   +104
> >>>   spi_nor_read_reg - 100  
> >>>   +100
> >>>   spi_find_chip_select -  96  
> >>>+96
> >>>   static.spi_check_buswidth_req-  88  
> >>>+88
> >>>   str2off  -  80  
> >>>+80
> >>>   bytes_per_second -  76  
> >>>+76
> >>>   spi_flash_std_write  -  72  
> >>>+72
> >>>   spi_flash_std_read   -  72  
> >>>+72
> >>>   spi_mem_supports_op  -  56  
> >>>+56
> >>>   _u_boot_list_2_cmd_2_sf  -  56  
> >>>+56
> >>>   dm_spi_xfer 

Re: [U-Boot] Pull request: u-boot-spi/master

[Schrempf Frieder]

Hi Jagan,

On 28.10.19 01:46, Tom Rini wrote:
> On Sun, Oct 27, 2019 at 05:20:22PM +0530, Jagan Teki wrote:
>> Hi Tom,
>>
>> On Fri, Oct 25, 2019 at 11:19 PM Tom Rini  wrote:
>>>
>>> On Fri, Oct 25, 2019 at 02:08:12PM +0530, Jagan Teki wrote:
>>>
 Hi Tom,

 Please pull this PR.

 Summary:
 - SPL_SPI_FLASH_MTD (Frieder)
 - SPI NOR IDs' fixes, additions (Vignesh)
 - cs_info change (Bin)
 - Enable sunxi spi (Jagan)

 Travis-CI:
 https://travis-ci.org/openedev/u-boot-amarula/builds/602483415

 Thanks,
 Jagan.

 The following changes since commit 
 17fd9915a4c639381804ed28274fa136ae3b0bee:

Merge branch '2019-10-24-UFS-support' (2019-10-24 09:51:48 -0400)

 are available in the Git repository at:

https://gitlab.denx.de/u-boot/custodians/u-boot-spi master

 for you to fetch changes up to 395ec7418695e5ce23f8b48c01a1dbffd2e52d3f:

spi-nor-ids: Add support for Adesto AT25SL321 (2019-10-25 00:48:32 
 +0530)

>>>
>>> So, looking over the build output, I see the expected size increase in
>>> sunxi due to new support. But I also see a lot of size increases in
>>> rockchip and layerscape platforms (and possibly more, I stopped after
>>> spotting two different SoCs), for example:
>>>  evb-px5: all +12139 data +176 rodata +2275 
>>> spl/u-boot-spl:all +3529 spl/u-boot-spl:data +120 spl/u-boot-spl:rodata 
>>> +309 spl/u-boot-spl:text +3100 text +9688
>>> u-boot: add: 49/0, grow: 0/0 bytes: 9512/0 (9512)
>>>   function   old new   
>>> delta
>>>   spi_nor_scan -2032   
>>> +2032
>>>   do_spi_flash -2008   
>>> +2008
>>>   spi_get_bus_and_cs   - 436
>>> +436
>>>   spi_mem_exec_op  - 420
>>> +420
>>>   static.spi_nor_wait_till_ready_with_timeout   - 
>>> 300+300
>>>   spi_nor_write- 300
>>> +300
>>>   mtd_arg_off_size - 276
>>> +276
>>>   spi_nor_erase- 232
>>> +232
>>>   device_unbind- 232
>>> +232
>>>   spi_nor_read_data- 220
>>> +220
>>>   spi_nor_write_data   - 212
>>> +212
>>>   dm_spi_claim_bus - 196
>>> +196
>>>   spi_mem_adjust_op_size   - 160
>>> +160
>>>   spi_mem_default_supports_op  - 156
>>> +156
>>>   spi_nor_read - 152
>>> +152
>>>   spi_flash_probe_bus_cs   - 152
>>> +152
>>>   spi_set_speed_mode   - 148
>>> +148
>>>   spi_flash_std_erase  - 136
>>> +136
>>>   spi_flash_std_probe  - 132
>>> +132
>>>   mtd_arg_off  - 124
>>> +124
>>>   device_chld_unbind   - 120
>>> +120
>>>   _u_boot_list_2_driver_2_spi_flash_std- 120
>>> +120
>>>   spi_nor_write_reg- 104
>>> +104
>>>   spi_find_bus_and_cs  - 104
>>> +104
>>>   spi_nor_read_reg - 100
>>> +100
>>>   spi_find_chip_select -  96
>>>  +96
>>>   static.spi_check_buswidth_req-  88
>>>  +88
>>>   str2off  -  80
>>>  +80
>>>   bytes_per_second -  76
>>>  +76
>>>   spi_flash_std_write  -  72
>>>  +72
>>>   spi_flash_std_read   -  72
>>>  +72
>>>   spi_mem_supports_op  -  56
>>>  +56
>>>   _u_boot_list_2_cmd_2_sf  -  56
>>>  +56
>>>   dm_spi_xfer  -  48
>>>  +48
>>>   read_sr  -  44
>>>  +44
>>>   device_find_next_child   -  40
>>>  +40
>>>   spi_flash_cmd_get_sw_write_prot  -  36

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Sun, Oct 27, 2019 at 05:20:22PM +0530, Jagan Teki wrote:
> Hi Tom,
> 
> On Fri, Oct 25, 2019 at 11:19 PM Tom Rini  wrote:
> >
> > On Fri, Oct 25, 2019 at 02:08:12PM +0530, Jagan Teki wrote:
> >
> > > Hi Tom,
> > >
> > > Please pull this PR.
> > >
> > > Summary:
> > > - SPL_SPI_FLASH_MTD (Frieder)
> > > - SPI NOR IDs' fixes, additions (Vignesh)
> > > - cs_info change (Bin)
> > > - Enable sunxi spi (Jagan)
> > >
> > > Travis-CI:
> > > https://travis-ci.org/openedev/u-boot-amarula/builds/602483415
> > >
> > > Thanks,
> > > Jagan.
> > >
> > > The following changes since commit 
> > > 17fd9915a4c639381804ed28274fa136ae3b0bee:
> > >
> > >   Merge branch '2019-10-24-UFS-support' (2019-10-24 09:51:48 -0400)
> > >
> > > are available in the Git repository at:
> > >
> > >   https://gitlab.denx.de/u-boot/custodians/u-boot-spi master
> > >
> > > for you to fetch changes up to 395ec7418695e5ce23f8b48c01a1dbffd2e52d3f:
> > >
> > >   spi-nor-ids: Add support for Adesto AT25SL321 (2019-10-25 00:48:32 
> > > +0530)
> > >
> >
> > So, looking over the build output, I see the expected size increase in
> > sunxi due to new support. But I also see a lot of size increases in
> > rockchip and layerscape platforms (and possibly more, I stopped after
> > spotting two different SoCs), for example:
> > evb-px5: all +12139 data +176 rodata +2275 
> > spl/u-boot-spl:all +3529 spl/u-boot-spl:data +120 spl/u-boot-spl:rodata 
> > +309 spl/u-boot-spl:text +3100 text +9688
> >u-boot: add: 49/0, grow: 0/0 bytes: 9512/0 (9512)
> >  function   old new   
> > delta
> >  spi_nor_scan -2032   
> > +2032
> >  do_spi_flash -2008   
> > +2008
> >  spi_get_bus_and_cs   - 436
> > +436
> >  spi_mem_exec_op  - 420
> > +420
> >  static.spi_nor_wait_till_ready_with_timeout   - 
> > 300+300
> >  spi_nor_write- 300
> > +300
> >  mtd_arg_off_size - 276
> > +276
> >  spi_nor_erase- 232
> > +232
> >  device_unbind- 232
> > +232
> >  spi_nor_read_data- 220
> > +220
> >  spi_nor_write_data   - 212
> > +212
> >  dm_spi_claim_bus - 196
> > +196
> >  spi_mem_adjust_op_size   - 160
> > +160
> >  spi_mem_default_supports_op  - 156
> > +156
> >  spi_nor_read - 152
> > +152
> >  spi_flash_probe_bus_cs   - 152
> > +152
> >  spi_set_speed_mode   - 148
> > +148
> >  spi_flash_std_erase  - 136
> > +136
> >  spi_flash_std_probe  - 132
> > +132
> >  mtd_arg_off  - 124
> > +124
> >  device_chld_unbind   - 120
> > +120
> >  _u_boot_list_2_driver_2_spi_flash_std- 120
> > +120
> >  spi_nor_write_reg- 104
> > +104
> >  spi_find_bus_and_cs  - 104
> > +104
> >  spi_nor_read_reg - 100
> > +100
> >  spi_find_chip_select -  96 
> > +96
> >  static.spi_check_buswidth_req-  88 
> > +88
> >  str2off  -  80 
> > +80
> >  bytes_per_second -  76 
> > +76
> >  spi_flash_std_write  -  72 
> > +72
> >  spi_flash_std_read   -  72 
> > +72
> >  spi_mem_supports_op  -  56 
> > +56
> >  _u_boot_list_2_cmd_2_sf  -  56 
> > +56
> >  dm_spi_xfer  -  48 
> > +48
> >  read_sr  -  44 
> > +44
> >  device_find_next_child   -  40 
> > +40
> >  spi_flash_cmd_get_sw_write_prot  -  36 
> > +36
> >  dm_spi_release_bus  

Re: [U-Boot] Pull request: u-boot-spi/master

[Jagan Teki]

Hi Tom,

On Fri, Oct 25, 2019 at 11:19 PM Tom Rini  wrote:
>
> On Fri, Oct 25, 2019 at 02:08:12PM +0530, Jagan Teki wrote:
>
> > Hi Tom,
> >
> > Please pull this PR.
> >
> > Summary:
> > - SPL_SPI_FLASH_MTD (Frieder)
> > - SPI NOR IDs' fixes, additions (Vignesh)
> > - cs_info change (Bin)
> > - Enable sunxi spi (Jagan)
> >
> > Travis-CI:
> > https://travis-ci.org/openedev/u-boot-amarula/builds/602483415
> >
> > Thanks,
> > Jagan.
> >
> > The following changes since commit 17fd9915a4c639381804ed28274fa136ae3b0bee:
> >
> >   Merge branch '2019-10-24-UFS-support' (2019-10-24 09:51:48 -0400)
> >
> > are available in the Git repository at:
> >
> >   https://gitlab.denx.de/u-boot/custodians/u-boot-spi master
> >
> > for you to fetch changes up to 395ec7418695e5ce23f8b48c01a1dbffd2e52d3f:
> >
> >   spi-nor-ids: Add support for Adesto AT25SL321 (2019-10-25 00:48:32 +0530)
> >
>
> So, looking over the build output, I see the expected size increase in
> sunxi due to new support. But I also see a lot of size increases in
> rockchip and layerscape platforms (and possibly more, I stopped after
> spotting two different SoCs), for example:
> evb-px5: all +12139 data +176 rodata +2275 
> spl/u-boot-spl:all +3529 spl/u-boot-spl:data +120 spl/u-boot-spl:rodata +309 
> spl/u-boot-spl:text +3100 text +9688
>u-boot: add: 49/0, grow: 0/0 bytes: 9512/0 (9512)
>  function   old new   
> delta
>  spi_nor_scan -2032   
> +2032
>  do_spi_flash -2008   
> +2008
>  spi_get_bus_and_cs   - 436
> +436
>  spi_mem_exec_op  - 420
> +420
>  static.spi_nor_wait_till_ready_with_timeout   - 300  
>   +300
>  spi_nor_write- 300
> +300
>  mtd_arg_off_size - 276
> +276
>  spi_nor_erase- 232
> +232
>  device_unbind- 232
> +232
>  spi_nor_read_data- 220
> +220
>  spi_nor_write_data   - 212
> +212
>  dm_spi_claim_bus - 196
> +196
>  spi_mem_adjust_op_size   - 160
> +160
>  spi_mem_default_supports_op  - 156
> +156
>  spi_nor_read - 152
> +152
>  spi_flash_probe_bus_cs   - 152
> +152
>  spi_set_speed_mode   - 148
> +148
>  spi_flash_std_erase  - 136
> +136
>  spi_flash_std_probe  - 132
> +132
>  mtd_arg_off  - 124
> +124
>  device_chld_unbind   - 120
> +120
>  _u_boot_list_2_driver_2_spi_flash_std- 120
> +120
>  spi_nor_write_reg- 104
> +104
>  spi_find_bus_and_cs  - 104
> +104
>  spi_nor_read_reg - 100
> +100
>  spi_find_chip_select -  96 
> +96
>  static.spi_check_buswidth_req-  88 
> +88
>  str2off  -  80 
> +80
>  bytes_per_second -  76 
> +76
>  spi_flash_std_write  -  72 
> +72
>  spi_flash_std_read   -  72 
> +72
>  spi_mem_supports_op  -  56 
> +56
>  _u_boot_list_2_cmd_2_sf  -  56 
> +56
>  dm_spi_xfer  -  48 
> +48
>  read_sr  -  44 
> +44
>  device_find_next_child   -  40 
> +40
>  spi_flash_cmd_get_sw_write_prot  -  36 
> +36
>  dm_spi_release_bus   -  28 
> +28
>  write_enable -  20 
> +20
>  write_disable-  20 
> +20
>  spi_flash_std_get_sw_write_prot  -  20 
> +20
>  

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Fri, Oct 25, 2019 at 02:08:12PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> Summary:
> - SPL_SPI_FLASH_MTD (Frieder)
> - SPI NOR IDs' fixes, additions (Vignesh)
> - cs_info change (Bin)
> - Enable sunxi spi (Jagan)
> 
> Travis-CI:
> https://travis-ci.org/openedev/u-boot-amarula/builds/602483415
> 
> Thanks,
> Jagan.
> 
> The following changes since commit 17fd9915a4c639381804ed28274fa136ae3b0bee:
> 
>   Merge branch '2019-10-24-UFS-support' (2019-10-24 09:51:48 -0400)
> 
> are available in the Git repository at:
> 
>   https://gitlab.denx.de/u-boot/custodians/u-boot-spi master
> 
> for you to fetch changes up to 395ec7418695e5ce23f8b48c01a1dbffd2e52d3f:
> 
>   spi-nor-ids: Add support for Adesto AT25SL321 (2019-10-25 00:48:32 +0530)
> 

So, looking over the build output, I see the expected size increase in
sunxi due to new support. But I also see a lot of size increases in
rockchip and layerscape platforms (and possibly more, I stopped after
spotting two different SoCs), for example:
evb-px5: all +12139 data +176 rodata +2275 
spl/u-boot-spl:all +3529 spl/u-boot-spl:data +120 spl/u-boot-spl:rodata +309 
spl/u-boot-spl:text +3100 text +9688
   u-boot: add: 49/0, grow: 0/0 bytes: 9512/0 (9512)
 function   old new   delta
 spi_nor_scan -2032   +2032
 do_spi_flash -2008   +2008
 spi_get_bus_and_cs   - 436+436
 spi_mem_exec_op  - 420+420
 static.spi_nor_wait_till_ready_with_timeout   - 300
+300
 spi_nor_write- 300+300
 mtd_arg_off_size - 276+276
 spi_nor_erase- 232+232
 device_unbind- 232+232
 spi_nor_read_data- 220+220
 spi_nor_write_data   - 212+212
 dm_spi_claim_bus - 196+196
 spi_mem_adjust_op_size   - 160+160
 spi_mem_default_supports_op  - 156+156
 spi_nor_read - 152+152
 spi_flash_probe_bus_cs   - 152+152
 spi_set_speed_mode   - 148+148
 spi_flash_std_erase  - 136+136
 spi_flash_std_probe  - 132+132
 mtd_arg_off  - 124+124
 device_chld_unbind   - 120+120
 _u_boot_list_2_driver_2_spi_flash_std- 120+120
 spi_nor_write_reg- 104+104
 spi_find_bus_and_cs  - 104+104
 spi_nor_read_reg - 100+100
 spi_find_chip_select -  96 +96
 static.spi_check_buswidth_req-  88 +88
 str2off  -  80 +80
 bytes_per_second -  76 +76
 spi_flash_std_write  -  72 +72
 spi_flash_std_read   -  72 +72
 spi_mem_supports_op  -  56 +56
 _u_boot_list_2_cmd_2_sf  -  56 +56
 dm_spi_xfer  -  48 +48
 read_sr  -  44 +44
 device_find_next_child   -  40 +40
 spi_flash_cmd_get_sw_write_prot  -  36 +36
 dm_spi_release_bus   -  28 +28
 write_enable -  20 +20
 write_disable-  20 +20
 spi_flash_std_get_sw_write_prot  -  20 +20
 spi_flash_write_dm   -  16 +16
 spi_flash_read_dm-  16 +16
 spi_flash_erase_dm   -  16 +16
 spi_xfer -   8  +8
 spi_release_bus

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Mon, Sep 16, 2019 at 08:15:49AM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this for v2019.10 release.
> 
> Summary:
> - fix mvebu_a3700_spi clock prescale (Marek Behún)
> - unmark MXS_SPI, DEPRECATED (Lukasz)
> - add spi_write_then_read (Jagan)
> - fix SST26* flash ICs (Eugeniy)
> - fix soft_spi data abort (Christophe)
> 
> The following changes since commit 23b93e33adde0a8313388eda7c78d1d0786e3c92:
> 
>   Merge branch '2019-09-13-ti-imports' (2019-09-14 19:53:24 -0400)
> 
> are available in the Git repository at:
> 
>   https://gitlab.denx.de/u-boot/custodians/u-boot-spi.git master
> 
> for you to fetch changes up to ce704ea11f29b0ee8c195f17370a4048b6be29a9:
> 
>   doc: driver-model: Update SPI migration status (2019-09-16 08:09:22 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Mon, Jun 17, 2019 at 01:15:45PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> Summary:
> - Drop zipitz2 board (Tom)
> - Add DEPRECATED option (Tom)
> - Mark legacy or non-dm drivers as DEPRECATED (Jagan)
> 
> thanks,
> Jagan.
> 
> The following changes since commit 68b90e57bc034e237923b02acb633dc4e91d44cb:
> 
>   configs: tinker-rk3288 disable CONFIG_SPL_I2C_SUPPORT (2019-06-11 08:13:05 
> -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 88369d33e322e0cdfbb1f0c33021ad424578619e:
> 
>   configs: Disable now unbuildable SPI options for boards (2019-06-13 
> 12:51:06 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Mario Six]

Hi Heiko,

On Fri, Jun 7, 2019 at 11:15 AM Heiko Schocher  wrote:
>
> Hello Mario,
>
> Am 07.06.2019 um 11:10 schrieb Mario Six:
> > Hi Heiko,
> >
> > On Fri, Jun 7, 2019 at 10:56 AM Heiko Schocher  wrote:
> >>
> >> Hello Mario,
> >>
> >> Am 07.06.2019 um 09:51 schrieb Mario Six:
> >>> (adding Heiko, since he's the maintainer of the board in question)
> >>>
> >>> On Fri, May 24, 2019 at 9:34 PM Jagan Teki  
> >>> wrote:
> >>
> >> Huch, missed this Email ...
> >>
> 
>  Hi Mario,
> 
>  On Tue, May 21, 2019 at 4:42 PM Tom Rini  wrote:
> >
> > On Mon, May 20, 2019 at 10:48:23PM +0530, Jagan Teki wrote:
> >
> >> Hi Tom,
> >>
> >> Please pull this PR.
> >>
> >> Summary:
> >> - mpc8xxx spi driver fixes (Mario)
> >> - mpc8xxx spi dm conversion (Mario, Jagan)
> >> - SPI DM Migration update (Jagan)
> >>
> >> The following changes since commit 
> >> 748198cb8d32d41bc35e6f492bac9948f339bece:
> >>
> >> Revert "Makefile: Prioritize external dtb if defined" (2019-05-19 
> >> 18:09:35 -0400)
> >>
> >> are available in the Git repository at:
> >>
> >> git://git.denx.de/u-boot-spi.git master
> >>
> >> for you to fetch changes up to 
> >> 93842e580cee40c9d3e70de625e4bd826a749e65:
> >>
> >> dm: MIGRATION: Update migration status for SPI (2019-05-20 
> >> 22:18:54 +0530)
> >>
> >
> > NAK:
> >  powerpc:  +   ids8313
> > +(ids8313) cmd/built-in.o: In function `do_spi_xfer':
> > +(ids8313) build/../cmd/spi.c:53: undefined reference to 
> > `spi_setup_slave'
> > +(ids8313) build/../cmd/spi.c:60: undefined reference to `spi_claim_bus'
> > +(ids8313) build/../cmd/spi.c:63: undefined reference to `spi_xfer'
> > +(ids8313) build/../cmd/spi.c:80: undefined reference to 
> > `spi_release_bus'
> > +(ids8313) build/../cmd/spi.c:82: undefined reference to 
> > `spi_free_slave'
> > +(ids8313) common/built-in.o: In function `jumptable_init':
> > +(ids8313) build/../include/_exports.h:56: undefined reference to 
> > `spi_setup_slave'
> > +(ids8313) build/../include/_exports.h:58: undefined reference to 
> > `spi_free_slave'
> > +(ids8313) build/../include/_exports.h:65: undefined reference to 
> > `spi_claim_bus'
> > +(ids8313) build/../include/_exports.h:66: undefined reference to 
> > `spi_release_bus'
> > +(ids8313) build/../include/_exports.h:67: undefined reference to 
> > `spi_xfer'
> > +(ids8313) make[1]: *** [Makefile:1552: u-boot] Error 1
> > +(ids8313) make: *** [Makefile:148: sub-make] Error 2
> >
> 
>  Any help?
> >>>
> >>> @Heiko: I'll post a minimal patch that starts DM conversion on ids8313; I 
> >>> used
> >>> the mpc8313erdb tree from the Linux sources for now. No guarantees for
> >>> functionality, but it does compile.
> >>
> >> Just saw this patch .. it is really a fast shot :-P
> >>
> >> I just wrote an EMail to the customer, if we should remove the board
> >> from mainline (or convert it).
> >>
> >>> @Jagan: Could you rebase this series on the current master to pull in my
> >>> MPC83xx DM updates, and then apply the previously mentioned ids8313 patch 
> >>> after
> >>> Heiko gave his OK?
> >>
> >> As it blocks spi patches ... Isn,t it better we remove SPI functionality
> >> from the ids8313 board instead of adding a DTS which does not really fit?
> >>
> > That would be the alternative, of course. If you do want to go forward with
> > removing the board, then I'm all for disabling the SPI support until we know
> > more, of course.
> >
> > Do you want to prepare a patch for the SPI removal, or should I do it?
>
> If you can do it, that would be great!
>
Sure, one patch coming up...

> Many thanks!
>
> bye,
> Heiko
>
Best regards,
Mario
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Heiko Schocher]

Hello Mario,

Am 07.06.2019 um 11:10 schrieb Mario Six:

Hi Heiko,

On Fri, Jun 7, 2019 at 10:56 AM Heiko Schocher  wrote:


Hello Mario,

Am 07.06.2019 um 09:51 schrieb Mario Six:

(adding Heiko, since he's the maintainer of the board in question)

On Fri, May 24, 2019 at 9:34 PM Jagan Teki  wrote:


Huch, missed this Email ...



Hi Mario,

On Tue, May 21, 2019 at 4:42 PM Tom Rini  wrote:


On Mon, May 20, 2019 at 10:48:23PM +0530, Jagan Teki wrote:


Hi Tom,

Please pull this PR.

Summary:
- mpc8xxx spi driver fixes (Mario)
- mpc8xxx spi dm conversion (Mario, Jagan)
- SPI DM Migration update (Jagan)

The following changes since commit 748198cb8d32d41bc35e6f492bac9948f339bece:

Revert "Makefile: Prioritize external dtb if defined" (2019-05-19 18:09:35 
-0400)

are available in the Git repository at:

git://git.denx.de/u-boot-spi.git master

for you to fetch changes up to 93842e580cee40c9d3e70de625e4bd826a749e65:

dm: MIGRATION: Update migration status for SPI (2019-05-20 22:18:54 +0530)



NAK:
 powerpc:  +   ids8313
+(ids8313) cmd/built-in.o: In function `do_spi_xfer':
+(ids8313) build/../cmd/spi.c:53: undefined reference to `spi_setup_slave'
+(ids8313) build/../cmd/spi.c:60: undefined reference to `spi_claim_bus'
+(ids8313) build/../cmd/spi.c:63: undefined reference to `spi_xfer'
+(ids8313) build/../cmd/spi.c:80: undefined reference to `spi_release_bus'
+(ids8313) build/../cmd/spi.c:82: undefined reference to `spi_free_slave'
+(ids8313) common/built-in.o: In function `jumptable_init':
+(ids8313) build/../include/_exports.h:56: undefined reference to 
`spi_setup_slave'
+(ids8313) build/../include/_exports.h:58: undefined reference to 
`spi_free_slave'
+(ids8313) build/../include/_exports.h:65: undefined reference to 
`spi_claim_bus'
+(ids8313) build/../include/_exports.h:66: undefined reference to 
`spi_release_bus'
+(ids8313) build/../include/_exports.h:67: undefined reference to `spi_xfer'
+(ids8313) make[1]: *** [Makefile:1552: u-boot] Error 1
+(ids8313) make: *** [Makefile:148: sub-make] Error 2



Any help?


@Heiko: I'll post a minimal patch that starts DM conversion on ids8313; I used
the mpc8313erdb tree from the Linux sources for now. No guarantees for
functionality, but it does compile.


Just saw this patch .. it is really a fast shot :-P

I just wrote an EMail to the customer, if we should remove the board
from mainline (or convert it).


@Jagan: Could you rebase this series on the current master to pull in my
MPC83xx DM updates, and then apply the previously mentioned ids8313 patch after
Heiko gave his OK?


As it blocks spi patches ... Isn,t it better we remove SPI functionality
from the ids8313 board instead of adding a DTS which does not really fit?


That would be the alternative, of course. If you do want to go forward with
removing the board, then I'm all for disabling the SPI support until we know
more, of course.

Do you want to prepare a patch for the SPI removal, or should I do it?


If you can do it, that would be great!

Many thanks!

bye,
Heiko
--
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: h...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Mario Six]

Hi Heiko,

On Fri, Jun 7, 2019 at 10:56 AM Heiko Schocher  wrote:
>
> Hello Mario,
>
> Am 07.06.2019 um 09:51 schrieb Mario Six:
> > (adding Heiko, since he's the maintainer of the board in question)
> >
> > On Fri, May 24, 2019 at 9:34 PM Jagan Teki  
> > wrote:
>
> Huch, missed this Email ...
>
> >>
> >> Hi Mario,
> >>
> >> On Tue, May 21, 2019 at 4:42 PM Tom Rini  wrote:
> >>>
> >>> On Mon, May 20, 2019 at 10:48:23PM +0530, Jagan Teki wrote:
> >>>
>  Hi Tom,
> 
>  Please pull this PR.
> 
>  Summary:
>  - mpc8xxx spi driver fixes (Mario)
>  - mpc8xxx spi dm conversion (Mario, Jagan)
>  - SPI DM Migration update (Jagan)
> 
>  The following changes since commit 
>  748198cb8d32d41bc35e6f492bac9948f339bece:
> 
> Revert "Makefile: Prioritize external dtb if defined" (2019-05-19 
>  18:09:35 -0400)
> 
>  are available in the Git repository at:
> 
> git://git.denx.de/u-boot-spi.git master
> 
>  for you to fetch changes up to 93842e580cee40c9d3e70de625e4bd826a749e65:
> 
> dm: MIGRATION: Update migration status for SPI (2019-05-20 22:18:54 
>  +0530)
> 
> >>>
> >>> NAK:
> >>> powerpc:  +   ids8313
> >>> +(ids8313) cmd/built-in.o: In function `do_spi_xfer':
> >>> +(ids8313) build/../cmd/spi.c:53: undefined reference to `spi_setup_slave'
> >>> +(ids8313) build/../cmd/spi.c:60: undefined reference to `spi_claim_bus'
> >>> +(ids8313) build/../cmd/spi.c:63: undefined reference to `spi_xfer'
> >>> +(ids8313) build/../cmd/spi.c:80: undefined reference to `spi_release_bus'
> >>> +(ids8313) build/../cmd/spi.c:82: undefined reference to `spi_free_slave'
> >>> +(ids8313) common/built-in.o: In function `jumptable_init':
> >>> +(ids8313) build/../include/_exports.h:56: undefined reference to 
> >>> `spi_setup_slave'
> >>> +(ids8313) build/../include/_exports.h:58: undefined reference to 
> >>> `spi_free_slave'
> >>> +(ids8313) build/../include/_exports.h:65: undefined reference to 
> >>> `spi_claim_bus'
> >>> +(ids8313) build/../include/_exports.h:66: undefined reference to 
> >>> `spi_release_bus'
> >>> +(ids8313) build/../include/_exports.h:67: undefined reference to 
> >>> `spi_xfer'
> >>> +(ids8313) make[1]: *** [Makefile:1552: u-boot] Error 1
> >>> +(ids8313) make: *** [Makefile:148: sub-make] Error 2
> >>>
> >>
> >> Any help?
> >
> > @Heiko: I'll post a minimal patch that starts DM conversion on ids8313; I 
> > used
> > the mpc8313erdb tree from the Linux sources for now. No guarantees for
> > functionality, but it does compile.
>
> Just saw this patch .. it is really a fast shot :-P
>
> I just wrote an EMail to the customer, if we should remove the board
> from mainline (or convert it).
>
> > @Jagan: Could you rebase this series on the current master to pull in my
> > MPC83xx DM updates, and then apply the previously mentioned ids8313 patch 
> > after
> > Heiko gave his OK?
>
> As it blocks spi patches ... Isn,t it better we remove SPI functionality
> from the ids8313 board instead of adding a DTS which does not really fit?
>
That would be the alternative, of course. If you do want to go forward with
removing the board, then I'm all for disabling the SPI support until we know
more, of course.

Do you want to prepare a patch for the SPI removal, or should I do it?

> bye,
> Heiko
>
Best regards,
Mario
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Heiko Schocher]

Hello Mario,

Am 07.06.2019 um 09:51 schrieb Mario Six:

(adding Heiko, since he's the maintainer of the board in question)

On Fri, May 24, 2019 at 9:34 PM Jagan Teki  wrote:


Huch, missed this Email ...



Hi Mario,

On Tue, May 21, 2019 at 4:42 PM Tom Rini  wrote:


On Mon, May 20, 2019 at 10:48:23PM +0530, Jagan Teki wrote:


Hi Tom,

Please pull this PR.

Summary:
- mpc8xxx spi driver fixes (Mario)
- mpc8xxx spi dm conversion (Mario, Jagan)
- SPI DM Migration update (Jagan)

The following changes since commit 748198cb8d32d41bc35e6f492bac9948f339bece:

   Revert "Makefile: Prioritize external dtb if defined" (2019-05-19 18:09:35 
-0400)

are available in the Git repository at:

   git://git.denx.de/u-boot-spi.git master

for you to fetch changes up to 93842e580cee40c9d3e70de625e4bd826a749e65:

   dm: MIGRATION: Update migration status for SPI (2019-05-20 22:18:54 +0530)



NAK:
powerpc:  +   ids8313
+(ids8313) cmd/built-in.o: In function `do_spi_xfer':
+(ids8313) build/../cmd/spi.c:53: undefined reference to `spi_setup_slave'
+(ids8313) build/../cmd/spi.c:60: undefined reference to `spi_claim_bus'
+(ids8313) build/../cmd/spi.c:63: undefined reference to `spi_xfer'
+(ids8313) build/../cmd/spi.c:80: undefined reference to `spi_release_bus'
+(ids8313) build/../cmd/spi.c:82: undefined reference to `spi_free_slave'
+(ids8313) common/built-in.o: In function `jumptable_init':
+(ids8313) build/../include/_exports.h:56: undefined reference to 
`spi_setup_slave'
+(ids8313) build/../include/_exports.h:58: undefined reference to 
`spi_free_slave'
+(ids8313) build/../include/_exports.h:65: undefined reference to 
`spi_claim_bus'
+(ids8313) build/../include/_exports.h:66: undefined reference to 
`spi_release_bus'
+(ids8313) build/../include/_exports.h:67: undefined reference to `spi_xfer'
+(ids8313) make[1]: *** [Makefile:1552: u-boot] Error 1
+(ids8313) make: *** [Makefile:148: sub-make] Error 2



Any help?


@Heiko: I'll post a minimal patch that starts DM conversion on ids8313; I used
the mpc8313erdb tree from the Linux sources for now. No guarantees for
functionality, but it does compile.


Just saw this patch .. it is really a fast shot :-P

I just wrote an EMail to the customer, if we should remove the board
from mainline (or convert it).


@Jagan: Could you rebase this series on the current master to pull in my
MPC83xx DM updates, and then apply the previously mentioned ids8313 patch after
Heiko gave his OK?


As it blocks spi patches ... Isn,t it better we remove SPI functionality
from the ids8313 board instead of adding a DTS which does not really fit?

bye,
Heiko
--
DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: h...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Mario Six]

(adding Heiko, since he's the maintainer of the board in question)

On Fri, May 24, 2019 at 9:34 PM Jagan Teki  wrote:
>
> Hi Mario,
>
> On Tue, May 21, 2019 at 4:42 PM Tom Rini  wrote:
> >
> > On Mon, May 20, 2019 at 10:48:23PM +0530, Jagan Teki wrote:
> >
> > > Hi Tom,
> > >
> > > Please pull this PR.
> > >
> > > Summary:
> > > - mpc8xxx spi driver fixes (Mario)
> > > - mpc8xxx spi dm conversion (Mario, Jagan)
> > > - SPI DM Migration update (Jagan)
> > >
> > > The following changes since commit 
> > > 748198cb8d32d41bc35e6f492bac9948f339bece:
> > >
> > >   Revert "Makefile: Prioritize external dtb if defined" (2019-05-19 
> > > 18:09:35 -0400)
> > >
> > > are available in the Git repository at:
> > >
> > >   git://git.denx.de/u-boot-spi.git master
> > >
> > > for you to fetch changes up to 93842e580cee40c9d3e70de625e4bd826a749e65:
> > >
> > >   dm: MIGRATION: Update migration status for SPI (2019-05-20 22:18:54 
> > > +0530)
> > >
> >
> > NAK:
> >powerpc:  +   ids8313
> > +(ids8313) cmd/built-in.o: In function `do_spi_xfer':
> > +(ids8313) build/../cmd/spi.c:53: undefined reference to `spi_setup_slave'
> > +(ids8313) build/../cmd/spi.c:60: undefined reference to `spi_claim_bus'
> > +(ids8313) build/../cmd/spi.c:63: undefined reference to `spi_xfer'
> > +(ids8313) build/../cmd/spi.c:80: undefined reference to `spi_release_bus'
> > +(ids8313) build/../cmd/spi.c:82: undefined reference to `spi_free_slave'
> > +(ids8313) common/built-in.o: In function `jumptable_init':
> > +(ids8313) build/../include/_exports.h:56: undefined reference to 
> > `spi_setup_slave'
> > +(ids8313) build/../include/_exports.h:58: undefined reference to 
> > `spi_free_slave'
> > +(ids8313) build/../include/_exports.h:65: undefined reference to 
> > `spi_claim_bus'
> > +(ids8313) build/../include/_exports.h:66: undefined reference to 
> > `spi_release_bus'
> > +(ids8313) build/../include/_exports.h:67: undefined reference to `spi_xfer'
> > +(ids8313) make[1]: *** [Makefile:1552: u-boot] Error 1
> > +(ids8313) make: *** [Makefile:148: sub-make] Error 2
> >
>
> Any help?

@Heiko: I'll post a minimal patch that starts DM conversion on ids8313; I used
the mpc8313erdb tree from the Linux sources for now. No guarantees for
functionality, but it does compile.

@Jagan: Could you rebase this series on the current master to pull in my
MPC83xx DM updates, and then apply the previously mentioned ids8313 patch after
Heiko gave his OK?

Thanks, and best regards,
Mario
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Jagan Teki]

Hi Mario,

On Tue, May 21, 2019 at 4:42 PM Tom Rini  wrote:
>
> On Mon, May 20, 2019 at 10:48:23PM +0530, Jagan Teki wrote:
>
> > Hi Tom,
> >
> > Please pull this PR.
> >
> > Summary:
> > - mpc8xxx spi driver fixes (Mario)
> > - mpc8xxx spi dm conversion (Mario, Jagan)
> > - SPI DM Migration update (Jagan)
> >
> > The following changes since commit 748198cb8d32d41bc35e6f492bac9948f339bece:
> >
> >   Revert "Makefile: Prioritize external dtb if defined" (2019-05-19 
> > 18:09:35 -0400)
> >
> > are available in the Git repository at:
> >
> >   git://git.denx.de/u-boot-spi.git master
> >
> > for you to fetch changes up to 93842e580cee40c9d3e70de625e4bd826a749e65:
> >
> >   dm: MIGRATION: Update migration status for SPI (2019-05-20 22:18:54 +0530)
> >
>
> NAK:
>powerpc:  +   ids8313
> +(ids8313) cmd/built-in.o: In function `do_spi_xfer':
> +(ids8313) build/../cmd/spi.c:53: undefined reference to `spi_setup_slave'
> +(ids8313) build/../cmd/spi.c:60: undefined reference to `spi_claim_bus'
> +(ids8313) build/../cmd/spi.c:63: undefined reference to `spi_xfer'
> +(ids8313) build/../cmd/spi.c:80: undefined reference to `spi_release_bus'
> +(ids8313) build/../cmd/spi.c:82: undefined reference to `spi_free_slave'
> +(ids8313) common/built-in.o: In function `jumptable_init':
> +(ids8313) build/../include/_exports.h:56: undefined reference to 
> `spi_setup_slave'
> +(ids8313) build/../include/_exports.h:58: undefined reference to 
> `spi_free_slave'
> +(ids8313) build/../include/_exports.h:65: undefined reference to 
> `spi_claim_bus'
> +(ids8313) build/../include/_exports.h:66: undefined reference to 
> `spi_release_bus'
> +(ids8313) build/../include/_exports.h:67: undefined reference to `spi_xfer'
> +(ids8313) make[1]: *** [Makefile:1552: u-boot] Error 1
> +(ids8313) make: *** [Makefile:148: sub-make] Error 2
>

Any help?
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Mon, May 20, 2019 at 10:48:23PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> Summary:
> - mpc8xxx spi driver fixes (Mario)
> - mpc8xxx spi dm conversion (Mario, Jagan)
> - SPI DM Migration update (Jagan)
> 
> The following changes since commit 748198cb8d32d41bc35e6f492bac9948f339bece:
> 
>   Revert "Makefile: Prioritize external dtb if defined" (2019-05-19 18:09:35 
> -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 93842e580cee40c9d3e70de625e4bd826a749e65:
> 
>   dm: MIGRATION: Update migration status for SPI (2019-05-20 22:18:54 +0530)
> 

NAK:
   powerpc:  +   ids8313
+(ids8313) cmd/built-in.o: In function `do_spi_xfer':
+(ids8313) build/../cmd/spi.c:53: undefined reference to `spi_setup_slave'
+(ids8313) build/../cmd/spi.c:60: undefined reference to `spi_claim_bus'
+(ids8313) build/../cmd/spi.c:63: undefined reference to `spi_xfer'
+(ids8313) build/../cmd/spi.c:80: undefined reference to `spi_release_bus'
+(ids8313) build/../cmd/spi.c:82: undefined reference to `spi_free_slave'
+(ids8313) common/built-in.o: In function `jumptable_init':
+(ids8313) build/../include/_exports.h:56: undefined reference to 
`spi_setup_slave'
+(ids8313) build/../include/_exports.h:58: undefined reference to 
`spi_free_slave'
+(ids8313) build/../include/_exports.h:65: undefined reference to 
`spi_claim_bus'
+(ids8313) build/../include/_exports.h:66: undefined reference to 
`spi_release_bus'
+(ids8313) build/../include/_exports.h:67: undefined reference to `spi_xfer'
+(ids8313) make[1]: *** [Makefile:1552: u-boot] Error 1
+(ids8313) make: *** [Makefile:148: sub-make] Error 2

Due to:
commit 96ff5503a543bee956c0f55f43c26a1f6a07f21a
Author: Jagan Teki 
Date:   Mon Apr 29 01:58:53 2019 +0530

spi: mpc8xxx: Convert to DM
 

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Sun, May 05, 2019 at 10:12:24PM +0530, Jagan Teki wrote:

> Hi Tom, 
> 
> Please pull this spi-mem fix.
> 
> thanks,
> Jagan.
> 
> The following changes since commit b4ee6daad7a2604ca9466b2ba48de86cc27d381f:
> 
>   Merge tag 'u-boot-imx-20190426' of git://git.denx.de/u-boot-imx (2019-05-01 
> 07:25:51 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 60e2bf46784ebbd30ff29b3d3c7c97e56b11e86a:
> 
>   mtd: spi-nor: fix page program issue when using spi-mem driver (2019-05-03 
> 15:26:12 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Wed, Apr 17, 2019 at 05:51:37PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> Summary:
> - drop non-DM code from ti_qspi
> - support spi-mem for ti_qspi
> 
> thanks,
> Jagan.
> 
> The following changes since commit 216800acf1fbf9f498455bf3c92d4513d9a4c681:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-spi (2019-04-14 00:03:06 
> -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 4c96c61216719155b3a1d51f6373e996335861de:
> 
>   spi: ti_qspi: Convert to spi-mem ops (2019-04-17 17:43:54 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Vignesh Raghavendra]

On 17/04/19 5:51 PM, Jagan Teki wrote:

Hi Tom,

Please pull this PR.



Thanks Jagan!

Tom,
These patches depend on [1] that drops cl-som-am57x board support.
http://patchwork.ozlabs.org/patch/1085281/

Regards
Vignesh


Summary:
- drop non-DM code from ti_qspi
- support spi-mem for ti_qspi

thanks,
Jagan.

The following changes since commit 216800acf1fbf9f498455bf3c92d4513d9a4c681:

   Merge branch 'master' of git://git.denx.de/u-boot-spi (2019-04-14 00:03:06 
-0400)

are available in the Git repository at:

   git://git.denx.de/u-boot-spi.git master

for you to fetch changes up to 4c96c61216719155b3a1d51f6373e996335861de:

   spi: ti_qspi: Convert to spi-mem ops (2019-04-17 17:43:54 +0530)


Vignesh Raghavendra (2):
   spi: ti_qspi: Drop non DM code
   spi: ti_qspi: Convert to spi-mem ops

  doc/driver-model/MIGRATION.txt |   1 -
  drivers/spi/Kconfig|  13 +-
  drivers/spi/Makefile   |   2 +-
  drivers/spi/ti_qspi.c  | 351 -
  include/configs/am43xx_evm.h   |   6 -
  include/configs/am57xx_evm.h   |   5 -
  include/configs/cm_t43.h   |   3 -
  include/configs/dra7xx_evm.h   |   5 -
  scripts/config_whitelist.txt   |   3 -
  9 files changed, 108 insertions(+), 281 deletions(-)


___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Fri, Apr 12, 2019 at 07:13:01PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks,
> Jagan.
> 
> The following changes since commit 02f173ca156cee8526dff87603d5e446b443cde3:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-usb (2019-04-11 14:29:37 
> -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 59aea29a31869ed0fd5ffc4b95050db966fcaf6d:
> 
>   MAINTAINERS: Change Jagan's email address (2019-04-12 18:47:16 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Wed, Mar 06, 2019 at 10:32:20PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> Summary:
> - dw spi include file fix
> - Allwinner A31 spi, been in ML in many releases.
> 
> thanks,
> Jagan.
> 
> The following changes since commit cfba74d0bef350d81241b059180bcc5a1e93bdfa:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-socfpga (2019-02-28 
> 18:57:32 -0500)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to a51cd54eff284ee42bfc1b74b8581daec78496f6:
> 
>   spi: Rename sun4i_spi.c into spi-sunxi.c (2019-03-04 18:08:56 +0530)
> 

Related, do you have any comments on
https://patchwork.ozlabs.org/patch/1014186/ ?

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Fri, Feb 08, 2019 at 01:17:21AM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this SPI-NOR sync.
> 
> thanks,
> Jagan.
> 
> The following changes since commit e5fd39c886485e3dec77f4438a6e364c2987cf5f:
> 
>   Merge tag 'for-master-20190201' of git://git.denx.de/u-boot-rockchip 
> (2019-02-02 10:11:20 -0500)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 4d40e009c06742df9582f8b54f37f6cea0680ba1:
> 
>   MAINTAINERS: Add an entry for SPI NOR (2019-02-07 15:36:00 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Thu, Jan 03, 2019 at 12:49:12AM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this spi PR as part of 2019.01
> 
> thanks,
> Jagan.
> 
> The following changes since commit 08337cd64832ed7f8147da75013510b92bbcd188:
> 
>   riscv: bootm: Support booting VxWorks (2018-12-31 08:08:51 -0500)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 689795242b1cb7de5a3d8c8bf1a9582a8924ff69:
> 
>   dm: MIGRATION: Update migration plan for DM_SPI_FLASH (2019-01-02 01:00:31 
> +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Jagan Teki]

On Thu, Jan 3, 2019 at 12:49 AM Jagan Teki  wrote:
>
> Hi Tom,
>
> Please pull this spi PR as part of 2019.01

This PR is for the release as well, please pick.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Mon, Dec 24, 2018 at 02:49:30AM +0530, Jagan Teki wrote:
> Hi Tom,
> 
> Please pull this as part of v2019.01 release.
> 
> thanks,
> Jagan.
> 
> The following changes since commit 562a63e86bc7b308a328a7bbdf0db237855c39a8:
> 
>   Merge git://git.denx.de/u-boot-marvell (2018-12-21 13:38:09 -0500)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 532741dfbfebe917bf6c7c05ed7bab55105ce2a4:
> 
>   dm: MIGRATION: Update migration plan for SPI/SPI_FLASH (2018-12-24 02:05:25 
> +0530)
> 
> 
> Jagan Teki (1):
>   dm: MIGRATION: Update migration plan for SPI/SPI_FLASH

WARNING: 'convertion' may be misspelled - perhaps 'conversion'?
#30: FILE: Makefile:960:
+   @echo >&2 "Please update the board before v2019.04 for no dm
convertion"
 
Please fix since you're doing v2 anyhow, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Jagan Teki]

Tom,

Forgot to include once patch, please ignore this will send v2.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Thu, Dec 06, 2018 at 12:53:32AM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.

I've done a short summary this time, can you please include one in the
future?  Thanks.

> 
> thanks,
> Jagan.
> 
> The following changes since commit a3e1653ddeb02f39481eba572275016171e9670c:
> 
>   Merge git://git.denx.de/u-boot-marvell (2018-11-20 12:39:16 -0500)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 08898e8b22d74a4511eadee9b06b11aab43e809c:
> 
>   mtd: sf: Make sf_mtd.c more robust (2018-12-06 00:45:36 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Fri, Oct 12, 2018 at 11:45:13AM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks,
> Jagan.
> 
> The following changes since commit 0a60a81ba3860946551cb79aa6486aa076e357f3:
> 
>   Kconfig: sandbox: enable cmd_avb and dependencies (2018-10-07 13:34:19 
> -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 5c391486b411025785e064f160d248bef31b3d28:
> 
>   sf: Add MICRON manufacturer id (2018-10-12 11:37:49 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Thu, Oct 04, 2018 at 06:46:57PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks,
> Jagan.
> 
> The following changes since commit 94228a9188803473206544c8f33649ea72bf1ee1:
> 
>   Merge git://git.denx.de/u-boot-riscv (2018-10-03 08:09:53 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 5eee9dee419f940ea75977df8b7ed8bb12bc029f:
> 
>   spi: Add SPI driver for MT76xx SoCs (2018-10-04 18:27:28 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Miquel Raynal]

Hi Jagan, Tom,

Tom Rini  wrote on Tue, 2 Oct 2018 20:54:31 -0400:

> On Tue, Oct 02, 2018 at 10:26:04PM +0530, Jagan Teki wrote:
> 
> > Hi Tom,
> > 
> > This is the PR for SPI-NAND changes along with few spi changes.
> > 
> > Yes, we missed one day for MW but Miquel did his best since 
> > from few releases. request you to accept the delay and pull this PR.
> > 
> > thanks,
> > Jagan.
> > 
> > The following changes since commit 9dc8d155d4e88563f572ee79aab758eb4272f3fd:
> > 
> >   Merge git://git.denx.de/u-boot-imx (2018-09-19 20:35:27 -0400)
> > 
> > are available in the Git repository at:
> > 
> >   git://git.denx.de/u-boot-spi.git master 
> > 
> > for you to fetch changes up to b3bec2525604d6b42bb9e7fd719c84b022447db3:
> > 
> >   spi: sh_qspi: Add DM support to SH QSPI driver (2018-10-02 22:14:59 +0530)
> >   
> 
> Note that I had to modify the configs/ls1012afrwy_qspi_* files slightly
> to keep them building.
> 
> Applied to u-boot/master, thanks!
> 

Thanks for the PR and for taking it, let me know if people raise
issues without cc'ing me.

Kind regards,
Miquèl
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Tue, Oct 02, 2018 at 10:26:04PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> This is the PR for SPI-NAND changes along with few spi changes.
> 
> Yes, we missed one day for MW but Miquel did his best since 
> from few releases. request you to accept the delay and pull this PR.
> 
> thanks,
> Jagan.
> 
> The following changes since commit 9dc8d155d4e88563f572ee79aab758eb4272f3fd:
> 
>   Merge git://git.denx.de/u-boot-imx (2018-09-19 20:35:27 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master 
> 
> for you to fetch changes up to b3bec2525604d6b42bb9e7fd719c84b022447db3:
> 
>   spi: sh_qspi: Add DM support to SH QSPI driver (2018-10-02 22:14:59 +0530)
> 

Note that I had to modify the configs/ls1012afrwy_qspi_* files slightly
to keep them building.

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Sat, Aug 04, 2018 at 09:43:24PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks,
> Jagan.
> 
> The following changes since commit a839c3641e4de98981695056eeeb2ec17ba1a4ab:
> 
>   ARM: tegra: align carveout size (2018-08-01 20:06:10 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 7f25d8179776226a8ecfbaad3d3a88e9acd89f28:
> 
>   arm: sunxi: Allwinner A10 SPI driver (2018-08-03 11:14:08 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Mon, Jul 16, 2018 at 06:31:19PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks,
> Jagan.
> 
> The following changes since commit 5e9a9645816edcc68c09729f257e0c863292bf26:
> 
>   mach-stm32: Rename CONFIG_SPL_RESET_SUPPORT to CONFIG_SPL_DM_RESET 
> (2018-07-13 14:47:29 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 51b2411946e5f247f26fde41a7227a002270d376:
> 
>   sf: add paired dev info for winbond w25q16jv (2018-07-16 14:17:13 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Mon, Jul 02, 2018 at 11:05:35PM +0530, Jagan Teki wrote:

> Hi,
> 
> Please pull this PR.
> 
> thanks,
> Jagan.
> 
> The following changes since commit 51dce7d2bfdecd974412634e4a0758ac55edcc00:
> 
>   mtd: spi: Correct parameters for s25fs512s flash (2018-06-25 15:50:33 +0530)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 069b746ad9e66ab75973020f992e059c06cf3a7c:
> 
>   sf: Enable FSR polling on N25Q256(A) (2018-06-28 19:58:40 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Tue, Jun 26, 2018 at 12:19:03AM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks,
> Jagan.
> 
> The following changes since commit 77b5ba5d2b94c5b028991c82782493f64bd4f392:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-uniphier (2018-06-22 
> 13:12:53 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 51dce7d2bfdecd974412634e4a0758ac55edcc00:
> 
>   mtd: spi: Correct parameters for s25fs512s flash (2018-06-25 15:50:33 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Jagan Teki]

On Wed, Jun 27, 2018 at 8:50 PM, Tom Rini  wrote:
> On Wed, Jun 27, 2018 at 12:17:56PM +0530, Jagan Teki wrote:
>> On Tue, Jun 26, 2018 at 3:05 AM, Tom Rini  wrote:
>> > On Tue, Jun 26, 2018 at 12:19:03AM +0530, Jagan Teki wrote:
>> >
>> >> Hi Tom,
>> >>
>> >> Please pull this PR.
>> >>
>> >> thanks,
>> >> Jagan.
>> >>
>> >> The following changes since commit 
>> >> 77b5ba5d2b94c5b028991c82782493f64bd4f392:
>> >>
>> >>   Merge branch 'master' of git://git.denx.de/u-boot-uniphier (2018-06-22 
>> >> 13:12:53 -0400)
>> >>
>> >> are available in the Git repository at:
>> >>
>> >>   git://git.denx.de/u-boot-spi.git master
>> >>
>> >> for you to fetch changes up to 51dce7d2bfdecd974412634e4a0758ac55edcc00:
>> >>
>> >>   mtd: spi: Correct parameters for s25fs512s flash (2018-06-25 15:50:33 
>> >> +0530)
>> >>
>> >> 
>> >> Ashish Kumar (1):
>> >>   mtd: spi: Correct parameters for s25fs512s flash
>> >>
>> >> Hannes Schmelzer (2):
>> >>   spi: omap3: pre-initialize bus-speed with max. slave-speed
>> >>   spi: omap3: fix set_speed and set_mode dm callbacks
>> >>
>> >> Michael Trimarchi (2):
>> >>   spi: mxc: Fix compilation problem of DM_SPI class driver
>> >>   spi: mxc_spi: Fix chipselect on DM_SPI driver uclass
>> >>
>> >> Vipul Kumar (1):
>> >>   spi: zynq_qspi: Fixed incorrect return value error
>> >
>> > I thought we had a change or two from Marek that were bug fixes that
>> > should be brought in?  Thanks!
>>
>> One fix from Marek "sf: Set current flash bank to 0 in clean_bar()"
>> already in master, other one is under discussion [1]. are you
>> referring any other fixes?
>>
>> [1] https://patchwork.ozlabs.org/patch/920094/
>
> That didn't seem under discussion to me, it seemed like it had been
> explained as a correct change given the datasheet.  Thanks!

Please see my last comment on that patch, I'm waiting for response for
the same. don't understand why we discuss here, if all fine that patch
anyway go into next PR.

Jagan.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Wed, Jun 27, 2018 at 12:17:56PM +0530, Jagan Teki wrote:
> On Tue, Jun 26, 2018 at 3:05 AM, Tom Rini  wrote:
> > On Tue, Jun 26, 2018 at 12:19:03AM +0530, Jagan Teki wrote:
> >
> >> Hi Tom,
> >>
> >> Please pull this PR.
> >>
> >> thanks,
> >> Jagan.
> >>
> >> The following changes since commit 
> >> 77b5ba5d2b94c5b028991c82782493f64bd4f392:
> >>
> >>   Merge branch 'master' of git://git.denx.de/u-boot-uniphier (2018-06-22 
> >> 13:12:53 -0400)
> >>
> >> are available in the Git repository at:
> >>
> >>   git://git.denx.de/u-boot-spi.git master
> >>
> >> for you to fetch changes up to 51dce7d2bfdecd974412634e4a0758ac55edcc00:
> >>
> >>   mtd: spi: Correct parameters for s25fs512s flash (2018-06-25 15:50:33 
> >> +0530)
> >>
> >> 
> >> Ashish Kumar (1):
> >>   mtd: spi: Correct parameters for s25fs512s flash
> >>
> >> Hannes Schmelzer (2):
> >>   spi: omap3: pre-initialize bus-speed with max. slave-speed
> >>   spi: omap3: fix set_speed and set_mode dm callbacks
> >>
> >> Michael Trimarchi (2):
> >>   spi: mxc: Fix compilation problem of DM_SPI class driver
> >>   spi: mxc_spi: Fix chipselect on DM_SPI driver uclass
> >>
> >> Vipul Kumar (1):
> >>   spi: zynq_qspi: Fixed incorrect return value error
> >
> > I thought we had a change or two from Marek that were bug fixes that
> > should be brought in?  Thanks!
> 
> One fix from Marek "sf: Set current flash bank to 0 in clean_bar()"
> already in master, other one is under discussion [1]. are you
> referring any other fixes?
> 
> [1] https://patchwork.ozlabs.org/patch/920094/

That didn't seem under discussion to me, it seemed like it had been
explained as a correct change given the datasheet.  Thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Jagan Teki]

On Tue, Jun 26, 2018 at 3:05 AM, Tom Rini  wrote:
> On Tue, Jun 26, 2018 at 12:19:03AM +0530, Jagan Teki wrote:
>
>> Hi Tom,
>>
>> Please pull this PR.
>>
>> thanks,
>> Jagan.
>>
>> The following changes since commit 77b5ba5d2b94c5b028991c82782493f64bd4f392:
>>
>>   Merge branch 'master' of git://git.denx.de/u-boot-uniphier (2018-06-22 
>> 13:12:53 -0400)
>>
>> are available in the Git repository at:
>>
>>   git://git.denx.de/u-boot-spi.git master
>>
>> for you to fetch changes up to 51dce7d2bfdecd974412634e4a0758ac55edcc00:
>>
>>   mtd: spi: Correct parameters for s25fs512s flash (2018-06-25 15:50:33 
>> +0530)
>>
>> 
>> Ashish Kumar (1):
>>   mtd: spi: Correct parameters for s25fs512s flash
>>
>> Hannes Schmelzer (2):
>>   spi: omap3: pre-initialize bus-speed with max. slave-speed
>>   spi: omap3: fix set_speed and set_mode dm callbacks
>>
>> Michael Trimarchi (2):
>>   spi: mxc: Fix compilation problem of DM_SPI class driver
>>   spi: mxc_spi: Fix chipselect on DM_SPI driver uclass
>>
>> Vipul Kumar (1):
>>   spi: zynq_qspi: Fixed incorrect return value error
>
> I thought we had a change or two from Marek that were bug fixes that
> should be brought in?  Thanks!

One fix from Marek "sf: Set current flash bank to 0 in clean_bar()"
already in master, other one is under discussion [1]. are you
referring any other fixes?

[1] https://patchwork.ozlabs.org/patch/920094/
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Tue, Jun 26, 2018 at 12:19:03AM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks,
> Jagan.
> 
> The following changes since commit 77b5ba5d2b94c5b028991c82782493f64bd4f392:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-uniphier (2018-06-22 
> 13:12:53 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 51dce7d2bfdecd974412634e4a0758ac55edcc00:
> 
>   mtd: spi: Correct parameters for s25fs512s flash (2018-06-25 15:50:33 +0530)
> 
> 
> Ashish Kumar (1):
>   mtd: spi: Correct parameters for s25fs512s flash
> 
> Hannes Schmelzer (2):
>   spi: omap3: pre-initialize bus-speed with max. slave-speed
>   spi: omap3: fix set_speed and set_mode dm callbacks
> 
> Michael Trimarchi (2):
>   spi: mxc: Fix compilation problem of DM_SPI class driver
>   spi: mxc_spi: Fix chipselect on DM_SPI driver uclass
> 
> Vipul Kumar (1):
>   spi: zynq_qspi: Fixed incorrect return value error

I thought we had a change or two from Marek that were bug fixes that
should be brought in?  Thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Tue, Jun 05, 2018 at 11:58:34PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks,
> Jagan.
> 
> The following changes since commit 809e0e398a91db7bf8b4d6259d9bfc6fbd6bce83:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-sunxi (2018-06-04 
> 08:55:00 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to b1f2b72e39465f2d4582bb4d8c426489ee94e2d9:
> 
>   sf: Add support for gd25q32b gigadevice flash (2018-06-04 23:40:04 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Wed, May 30, 2018 at 11:38:37PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks,
> Jagan.
> 
> The following changes since commit 31dd8efeb661c8db9175a09cf2bab090906a:
> 
>   usb: composite convert __set_bit to generic_set_bit (2018-05-15 21:44:05 
> -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to a2569f12f0efaad2b1e0754a19f373275562f91e:
> 
>   sf: Add Macronix MX25U25635F ID (2018-05-29 10:05:52 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Wed, Apr 25, 2018 at 10:59:27AM +0530, Jagan Teki wrote:

> Hi Tom, 
> 
> Please pull this PR.
> 
> thanks,
> Jagan.
> 
> The following changes since commit 40df6b3e1882c55dd34b9177a42e21a591d668ee:
> 
>   Merge git://git.denx.de/u-boot-socfpga (2018-04-17 17:45:28 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 9b14ac5cc2294ac3eaae92421abff27ed3e6caae:
> 
>   spi: dw: invert wait condition in dw_spi_xfer (2018-04-23 11:16:41 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Sat, Mar 24, 2018 at 01:55:17PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 2511930193a420eb8bb6cfa9c60912626f68ae67:
> 
>   Merge git://git.denx.de/u-boot-mips (2018-03-21 18:58:03 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 63018a3eddd5d9c64f7ee42615a63c6a67ab484d:
> 
>   omap3: spi: Correct ti, pindir-d0-out-d1-in parsing (2018-03-23 23:03:29 
> +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Jagan Teki]

On Thu, Mar 15, 2018 at 12:17 AM, Jagan Teki  wrote:
> On Thu, Mar 15, 2018 at 12:08 AM, Adam Ford  wrote:
>> On Wed, Mar 14, 2018 at 12:39 PM, Jagan Teki  
>> wrote:
>>> On Wed, Mar 14, 2018 at 10:57 PM, Tom Rini  wrote:
 On Wed, Mar 14, 2018 at 07:32:07PM +0530, Jagan Teki wrote:

> Hi Tom,
>
> Please pull this PR.
>
> thanks,
> Jagan.
>
> The following changes since commit 
> f95ab1fb6e37f0601f397091bb011edf7a98b890:
>
>   Prepare v2018.03 (2018-03-13 08:02:19 -0400)
>
> are available in the Git repository at:
>
>   git://git.denx.de/u-booti-spi.git master
>
> for you to fetch changes up to 3e4ef60403c626cf6c9a5f3d1f600bc9a39f3ce5:
>
>   omap3_logic: Enable DM_SPI (2018-03-13 19:50:10 +0530)
>

 NAK, omap3_logic no longer builds with this PR.
>>>
>>> Ahh, missed one local patch will resend the PR with updated patch. sorry.
>>
>> Can you CC me on the final patch so I can re-verify? I won't
>> necessarily see the post if it just goes to the mailing list.
>
> Here is the fix [1]
>
> [1] https://patchwork.ozlabs.org/patch/885976/

Any issues with this fix?
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Jagan Teki]

On Thu, Mar 15, 2018 at 12:08 AM, Adam Ford  wrote:
> On Wed, Mar 14, 2018 at 12:39 PM, Jagan Teki  
> wrote:
>> On Wed, Mar 14, 2018 at 10:57 PM, Tom Rini  wrote:
>>> On Wed, Mar 14, 2018 at 07:32:07PM +0530, Jagan Teki wrote:
>>>
 Hi Tom,

 Please pull this PR.

 thanks,
 Jagan.

 The following changes since commit 
 f95ab1fb6e37f0601f397091bb011edf7a98b890:

   Prepare v2018.03 (2018-03-13 08:02:19 -0400)

 are available in the Git repository at:

   git://git.denx.de/u-booti-spi.git master

 for you to fetch changes up to 3e4ef60403c626cf6c9a5f3d1f600bc9a39f3ce5:

   omap3_logic: Enable DM_SPI (2018-03-13 19:50:10 +0530)

>>>
>>> NAK, omap3_logic no longer builds with this PR.
>>
>> Ahh, missed one local patch will resend the PR with updated patch. sorry.
>
> Can you CC me on the final patch so I can re-verify? I won't
> necessarily see the post if it just goes to the mailing list.

Here is the fix [1]

[1] https://patchwork.ozlabs.org/patch/885976/
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Adam Ford]

On Wed, Mar 14, 2018 at 12:39 PM, Jagan Teki  wrote:
> On Wed, Mar 14, 2018 at 10:57 PM, Tom Rini  wrote:
>> On Wed, Mar 14, 2018 at 07:32:07PM +0530, Jagan Teki wrote:
>>
>>> Hi Tom,
>>>
>>> Please pull this PR.
>>>
>>> thanks,
>>> Jagan.
>>>
>>> The following changes since commit f95ab1fb6e37f0601f397091bb011edf7a98b890:
>>>
>>>   Prepare v2018.03 (2018-03-13 08:02:19 -0400)
>>>
>>> are available in the Git repository at:
>>>
>>>   git://git.denx.de/u-booti-spi.git master
>>>
>>> for you to fetch changes up to 3e4ef60403c626cf6c9a5f3d1f600bc9a39f3ce5:
>>>
>>>   omap3_logic: Enable DM_SPI (2018-03-13 19:50:10 +0530)
>>>
>>
>> NAK, omap3_logic no longer builds with this PR.
>
> Ahh, missed one local patch will resend the PR with updated patch. sorry.

Can you CC me on the final patch so I can re-verify? I won't
necessarily see the post if it just goes to the mailing list.

adam

> ___
> U-Boot mailing list
> U-Boot@lists.denx.de
> https://lists.denx.de/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Jagan Teki]

On Wed, Mar 14, 2018 at 10:57 PM, Tom Rini  wrote:
> On Wed, Mar 14, 2018 at 07:32:07PM +0530, Jagan Teki wrote:
>
>> Hi Tom,
>>
>> Please pull this PR.
>>
>> thanks,
>> Jagan.
>>
>> The following changes since commit f95ab1fb6e37f0601f397091bb011edf7a98b890:
>>
>>   Prepare v2018.03 (2018-03-13 08:02:19 -0400)
>>
>> are available in the Git repository at:
>>
>>   git://git.denx.de/u-booti-spi.git master
>>
>> for you to fetch changes up to 3e4ef60403c626cf6c9a5f3d1f600bc9a39f3ce5:
>>
>>   omap3_logic: Enable DM_SPI (2018-03-13 19:50:10 +0530)
>>
>
> NAK, omap3_logic no longer builds with this PR.

Ahh, missed one local patch will resend the PR with updated patch. sorry.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Wed, Mar 14, 2018 at 07:32:07PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks,
> Jagan.
> 
> The following changes since commit f95ab1fb6e37f0601f397091bb011edf7a98b890:
> 
>   Prepare v2018.03 (2018-03-13 08:02:19 -0400)
> 
> are available in the Git repository at:
> 
>   git://git.denx.de/u-booti-spi.git master
> 
> for you to fetch changes up to 3e4ef60403c626cf6c9a5f3d1f600bc9a39f3ce5:
> 
>   omap3_logic: Enable DM_SPI (2018-03-13 19:50:10 +0530)
> 

NAK, omap3_logic no longer builds with this PR.

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Álvaro Fernández Rojas]

Hi Jagan,

El 24/01/2018 a las 7:57, Jagan Teki escribió:

On Tue, Jan 23, 2018 at 3:58 PM, Daniel Schwierzeck
 wrote:


On 22.01.2018 21:55, Álvaro Fernández Rojas wrote:

Hi Daniel,


El 22/01/2018 a las 21:26, Daniel Schwierzeck escribió:

On 22.01.2018 18:14, Tom Rini wrote:

On Mon, Jan 22, 2018 at 05:49:39PM +0100, Daniel Schwierzeck wrote:

On 22.01.2018 13:58, Tom Rini wrote:

On Mon, Jan 22, 2018 at 11:20:56AM +0530, Jagan Teki wrote:


Hi Tom,

Please pull this PR.

thanks!
Jagan.

The following changes since commit
98691a60abffb44303d7dae6e9e699d0daded930:

Merge git://git.denx.de/u-boot-rockchip (2018-01-09 13:28:51
-0500)

are available in the git repository at:

git://git.denx.de/u-boot-spi.git master

for you to fetch changes up to
b23c685c6f295da3c01dd487f0e003b70299af91:

mips: bmips: enable the SPI flash on the Comtrend AR-5387un
(2018-01-22 10:39:13 +0530)


NAK:

commit 19e3a4856c1cba751a9ecb3931ff0d96a7f169be
Author: Álvaro Fernández Rojas 
Date:   Sat Jan 20 02:11:34 2018 +0100

  wait_bit: add 8/16/32 BE/LE versions of wait_for_bit

  Add 8/16/32 bits and BE/LE versions of wait_for_bit.
  This is needed for reading registers that are not aligned to
32 bits, and for
  Big Endian platforms.

  Signed-off-by: Álvaro Fernández Rojas 
  Reviewed-by: Daniel Schwierzeck 
  Reviewed-by: Jagan Teki 

Adds warnings on almost all platforms:
w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function
?wait_for_bit_be16?:
w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h:76:31:
warning: implicit declaration of function ?readw_be?
[-Wimplicit-function-declaration]
w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function
?wait_for_bit_be32?: w+(ls1088ardb_qspi_SECURE_BOOT)
../include/wait_bit.h:78:31: warning: implicit declaration of
function ?readl_be? [-Wimplicit-function-declaration]



Tom, would this change to the patch be acceptable?

--- a/include/wait_bit.h
+++ b/include/wait_bit.h
@@ -73,8 +73,12 @@ static inline int wait_for_bit_##sfx(const void
*reg,\

   BUILD_WAIT_FOR_BIT(8, u8, readb)
   BUILD_WAIT_FOR_BIT(le16, u16, readw)
+#ifdef readw_be
   BUILD_WAIT_FOR_BIT(be16, u16, readw_be)
+#endif
   BUILD_WAIT_FOR_BIT(le32, u32, readl)
+#ifdef readl_be
   BUILD_WAIT_FOR_BIT(be32, u32, readl_be)
+#endif

   #endif

This wouldn't define wait_bit_be*() on archs which doesn't implement
readw_be or readl_be.

A build with the updated patch is scheduled at
https://travis-ci.org/danielschwierzeck/u-boot/builds/331899381

That seems reasonable, thanks!


Álvaro, could you send a v10 where the patch "wait_bit: add 8/16/32
BE/LE versions of wait_for_bit" is fixed like above? Thanks.

Sure, but I think this alternative would be much cleaner:
https://gist.github.com/Noltari/3e6ed4648b87484c73ca22e2f533f9b0

What do you think?


I had a similar idea at first but a #ifdef within a #define is not possible and 
AFAIK not implemented in C standards.

Have you tried it? With nested #ifdef I'm getting:

$ ./tools/buildman/buildman -o /tmp/bm -b master..wait_for_bit aarch64
Building 1 commit for 111 boards (8 threads, 1 job per thread)
50   11   50 /111lion-rk3368

vs.

$ ./tools/buildman/buildman -o /tmp/bm -b master..wait_for_bit_2 aarch64
Building 1 commit for 111 boards (8 threads, 1 job per thread)
98   130 /1110:00:06  : ls1046ardb_emm

Also a Travis CI build already shows several broken builds:
https://travis-ci.org/danielschwierzeck/u-boot/builds/332205310

Maybe a yet better solution would be if each arch implements the same common 
set of I/O primitives like Linux is doing.

Recent patch from Alvaro, seems fine to built all [1]

[1] https://travis-ci.org/openedev/u-boot-spi/builds/332390626

I ended up adding the changes proposed by Daniel to avoid nested ifdefs.
So I guess it can be merged now :).

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Jagan Teki]

On Tue, Jan 23, 2018 at 3:58 PM, Daniel Schwierzeck
 wrote:
>
>
> On 22.01.2018 21:55, Álvaro Fernández Rojas wrote:
>> Hi Daniel,
>>
>>
>> El 22/01/2018 a las 21:26, Daniel Schwierzeck escribió:
>>>
>>> On 22.01.2018 18:14, Tom Rini wrote:
 On Mon, Jan 22, 2018 at 05:49:39PM +0100, Daniel Schwierzeck wrote:
>
> On 22.01.2018 13:58, Tom Rini wrote:
>> On Mon, Jan 22, 2018 at 11:20:56AM +0530, Jagan Teki wrote:
>>
>>> Hi Tom,
>>>
>>> Please pull this PR.
>>>
>>> thanks!
>>> Jagan.
>>>
>>> The following changes since commit
>>> 98691a60abffb44303d7dae6e9e699d0daded930:
>>>
>>>Merge git://git.denx.de/u-boot-rockchip (2018-01-09 13:28:51
>>> -0500)
>>>
>>> are available in the git repository at:
>>>
>>>git://git.denx.de/u-boot-spi.git master
>>>
>>> for you to fetch changes up to
>>> b23c685c6f295da3c01dd487f0e003b70299af91:
>>>
>>>mips: bmips: enable the SPI flash on the Comtrend AR-5387un
>>> (2018-01-22 10:39:13 +0530)
>>>
>> NAK:
>>
>> commit 19e3a4856c1cba751a9ecb3931ff0d96a7f169be
>> Author: Álvaro Fernández Rojas 
>> Date:   Sat Jan 20 02:11:34 2018 +0100
>>
>>  wait_bit: add 8/16/32 BE/LE versions of wait_for_bit
>>
>>  Add 8/16/32 bits and BE/LE versions of wait_for_bit.
>>  This is needed for reading registers that are not aligned to
>> 32 bits, and for
>>  Big Endian platforms.
>>
>>  Signed-off-by: Álvaro Fernández Rojas 
>>  Reviewed-by: Daniel Schwierzeck 
>>  Reviewed-by: Jagan Teki 
>>
>> Adds warnings on almost all platforms:
>> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function
>> ?wait_for_bit_be16?:
>> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h:76:31:
>> warning: implicit declaration of function ?readw_be?
>> [-Wimplicit-function-declaration]
>> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function
>> ?wait_for_bit_be32?: w+(ls1088ardb_qspi_SECURE_BOOT)
>> ../include/wait_bit.h:78:31: warning: implicit declaration of
>> function ?readl_be? [-Wimplicit-function-declaration]
>>
>>
> Tom, would this change to the patch be acceptable?
>
> --- a/include/wait_bit.h
> +++ b/include/wait_bit.h
> @@ -73,8 +73,12 @@ static inline int wait_for_bit_##sfx(const void
> *reg,\
>
>   BUILD_WAIT_FOR_BIT(8, u8, readb)
>   BUILD_WAIT_FOR_BIT(le16, u16, readw)
> +#ifdef readw_be
>   BUILD_WAIT_FOR_BIT(be16, u16, readw_be)
> +#endif
>   BUILD_WAIT_FOR_BIT(le32, u32, readl)
> +#ifdef readl_be
>   BUILD_WAIT_FOR_BIT(be32, u32, readl_be)
> +#endif
>
>   #endif
>
> This wouldn't define wait_bit_be*() on archs which doesn't implement
> readw_be or readl_be.
>
> A build with the updated patch is scheduled at
> https://travis-ci.org/danielschwierzeck/u-boot/builds/331899381
 That seems reasonable, thanks!

>>> Álvaro, could you send a v10 where the patch "wait_bit: add 8/16/32
>>> BE/LE versions of wait_for_bit" is fixed like above? Thanks.
>> Sure, but I think this alternative would be much cleaner:
>> https://gist.github.com/Noltari/3e6ed4648b87484c73ca22e2f533f9b0
>>
>> What do you think?
>>
>
> I had a similar idea at first but a #ifdef within a #define is not possible 
> and AFAIK not implemented in C standards.
>
> Have you tried it? With nested #ifdef I'm getting:
>
> $ ./tools/buildman/buildman -o /tmp/bm -b master..wait_for_bit aarch64
> Building 1 commit for 111 boards (8 threads, 1 job per thread)
>50   11   50 /111lion-rk3368
>
> vs.
>
> $ ./tools/buildman/buildman -o /tmp/bm -b master..wait_for_bit_2 aarch64
> Building 1 commit for 111 boards (8 threads, 1 job per thread)
>98   130 /1110:00:06  : ls1046ardb_emm
>
> Also a Travis CI build already shows several broken builds:
> https://travis-ci.org/danielschwierzeck/u-boot/builds/332205310
>
> Maybe a yet better solution would be if each arch implements the same common 
> set of I/O primitives like Linux is doing.

Recent patch from Alvaro, seems fine to built all [1]

[1] https://travis-ci.org/openedev/u-boot-spi/builds/332390626
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Daniel Schwierzeck]

On 22.01.2018 21:55, Álvaro Fernández Rojas wrote:
> Hi Daniel,
> 
> 
> El 22/01/2018 a las 21:26, Daniel Schwierzeck escribió:
>>
>> On 22.01.2018 18:14, Tom Rini wrote:
>>> On Mon, Jan 22, 2018 at 05:49:39PM +0100, Daniel Schwierzeck wrote:

 On 22.01.2018 13:58, Tom Rini wrote:
> On Mon, Jan 22, 2018 at 11:20:56AM +0530, Jagan Teki wrote:
>
>> Hi Tom,
>>
>> Please pull this PR.
>>
>> thanks!
>> Jagan.
>>
>> The following changes since commit
>> 98691a60abffb44303d7dae6e9e699d0daded930:
>>
>>    Merge git://git.denx.de/u-boot-rockchip (2018-01-09 13:28:51
>> -0500)
>>
>> are available in the git repository at:
>>
>>    git://git.denx.de/u-boot-spi.git master
>>
>> for you to fetch changes up to
>> b23c685c6f295da3c01dd487f0e003b70299af91:
>>
>>    mips: bmips: enable the SPI flash on the Comtrend AR-5387un
>> (2018-01-22 10:39:13 +0530)
>>
> NAK:
>
> commit 19e3a4856c1cba751a9ecb3931ff0d96a7f169be
> Author: Álvaro Fernández Rojas 
> Date:   Sat Jan 20 02:11:34 2018 +0100
>
>  wait_bit: add 8/16/32 BE/LE versions of wait_for_bit
>
>  Add 8/16/32 bits and BE/LE versions of wait_for_bit.
>  This is needed for reading registers that are not aligned to
> 32 bits, and for
>  Big Endian platforms.
>
>  Signed-off-by: Álvaro Fernández Rojas 
>  Reviewed-by: Daniel Schwierzeck 
>  Reviewed-by: Jagan Teki 
>
> Adds warnings on almost all platforms:
> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function
> ?wait_for_bit_be16?:
> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h:76:31:
> warning: implicit declaration of function ?readw_be?
> [-Wimplicit-function-declaration]
> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function
> ?wait_for_bit_be32?: w+(ls1088ardb_qspi_SECURE_BOOT)
> ../include/wait_bit.h:78:31: warning: implicit declaration of
> function ?readl_be? [-Wimplicit-function-declaration]
>
>
 Tom, would this change to the patch be acceptable?

 --- a/include/wait_bit.h
 +++ b/include/wait_bit.h
 @@ -73,8 +73,12 @@ static inline int wait_for_bit_##sfx(const void
 *reg,    \

   BUILD_WAIT_FOR_BIT(8, u8, readb)
   BUILD_WAIT_FOR_BIT(le16, u16, readw)
 +#ifdef readw_be
   BUILD_WAIT_FOR_BIT(be16, u16, readw_be)
 +#endif
   BUILD_WAIT_FOR_BIT(le32, u32, readl)
 +#ifdef readl_be
   BUILD_WAIT_FOR_BIT(be32, u32, readl_be)
 +#endif

   #endif

 This wouldn't define wait_bit_be*() on archs which doesn't implement
 readw_be or readl_be.

 A build with the updated patch is scheduled at
 https://travis-ci.org/danielschwierzeck/u-boot/builds/331899381
>>> That seems reasonable, thanks!
>>>
>> Álvaro, could you send a v10 where the patch "wait_bit: add 8/16/32
>> BE/LE versions of wait_for_bit" is fixed like above? Thanks.
> Sure, but I think this alternative would be much cleaner:
> https://gist.github.com/Noltari/3e6ed4648b87484c73ca22e2f533f9b0
> 
> What do you think?
> 

I had a similar idea at first but a #ifdef within a #define is not possible and 
AFAIK not implemented in C standards. 

Have you tried it? With nested #ifdef I'm getting:

$ ./tools/buildman/buildman -o /tmp/bm -b master..wait_for_bit aarch64 
Building 1 commit for 111 boards (8 threads, 1 job per thread)
   50   11   50 /111lion-rk3368
 
vs.

$ ./tools/buildman/buildman -o /tmp/bm -b master..wait_for_bit_2 aarch64 
Building 1 commit for 111 boards (8 threads, 1 job per thread)
   98   130 /1110:00:06  : ls1046ardb_emm

Also a Travis CI build already shows several broken builds:
https://travis-ci.org/danielschwierzeck/u-boot/builds/332205310

Maybe a yet better solution would be if each arch implements the same common 
set of I/O primitives like Linux is doing.

-- 
- Daniel



signature.asc
Description: OpenPGP digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Mon, Jan 22, 2018 at 09:55:43PM +0100, Álvaro Fernández Rojas wrote:
> Hi Daniel,
> 
> 
> El 22/01/2018 a las 21:26, Daniel Schwierzeck escribió:
> >
> >On 22.01.2018 18:14, Tom Rini wrote:
> >>On Mon, Jan 22, 2018 at 05:49:39PM +0100, Daniel Schwierzeck wrote:
> >>>
> >>>On 22.01.2018 13:58, Tom Rini wrote:
> On Mon, Jan 22, 2018 at 11:20:56AM +0530, Jagan Teki wrote:
> 
> >Hi Tom,
> >
> >Please pull this PR.
> >
> >thanks!
> >Jagan.
> >
> >The following changes since commit 
> >98691a60abffb44303d7dae6e9e699d0daded930:
> >
> >   Merge git://git.denx.de/u-boot-rockchip (2018-01-09 13:28:51 -0500)
> >
> >are available in the git repository at:
> >
> >   git://git.denx.de/u-boot-spi.git master
> >
> >for you to fetch changes up to b23c685c6f295da3c01dd487f0e003b70299af91:
> >
> >   mips: bmips: enable the SPI flash on the Comtrend AR-5387un 
> > (2018-01-22 10:39:13 +0530)
> >
> NAK:
> 
> commit 19e3a4856c1cba751a9ecb3931ff0d96a7f169be
> Author: Álvaro Fernández Rojas 
> Date:   Sat Jan 20 02:11:34 2018 +0100
> 
>  wait_bit: add 8/16/32 BE/LE versions of wait_for_bit
> 
>  Add 8/16/32 bits and BE/LE versions of wait_for_bit.
>  This is needed for reading registers that are not aligned to 32 
>  bits, and for
>  Big Endian platforms.
> 
>  Signed-off-by: Álvaro Fernández Rojas 
>  Reviewed-by: Daniel Schwierzeck 
>  Reviewed-by: Jagan Teki 
> 
> Adds warnings on almost all platforms:
> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function 
> ?wait_for_bit_be16?:
> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h:76:31: warning: 
> implicit declaration of function ?readw_be? 
> [-Wimplicit-function-declaration]
> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function 
> ?wait_for_bit_be32?: w+(ls1088ardb_qspi_SECURE_BOOT) 
> ../include/wait_bit.h:78:31: warning: implicit declaration of function 
> ?readl_be? [-Wimplicit-function-declaration]
> 
> 
> >>>Tom, would this change to the patch be acceptable?
> >>>
> >>>--- a/include/wait_bit.h
> >>>+++ b/include/wait_bit.h
> >>>@@ -73,8 +73,12 @@ static inline int wait_for_bit_##sfx(const void *reg,   
> >>>\
> >>>
> >>>  BUILD_WAIT_FOR_BIT(8, u8, readb)
> >>>  BUILD_WAIT_FOR_BIT(le16, u16, readw)
> >>>+#ifdef readw_be
> >>>  BUILD_WAIT_FOR_BIT(be16, u16, readw_be)
> >>>+#endif
> >>>  BUILD_WAIT_FOR_BIT(le32, u32, readl)
> >>>+#ifdef readl_be
> >>>  BUILD_WAIT_FOR_BIT(be32, u32, readl_be)
> >>>+#endif
> >>>
> >>>  #endif
> >>>
> >>>This wouldn't define wait_bit_be*() on archs which doesn't implement
> >>>readw_be or readl_be.
> >>>
> >>>A build with the updated patch is scheduled at
> >>>https://travis-ci.org/danielschwierzeck/u-boot/builds/331899381
> >>That seems reasonable, thanks!
> >>
> >Álvaro, could you send a v10 where the patch "wait_bit: add 8/16/32
> >BE/LE versions of wait_for_bit" is fixed like above? Thanks.
> Sure, but I think this alternative would be much cleaner:
> https://gist.github.com/Noltari/3e6ed4648b87484c73ca22e2f533f9b0
> 
> What do you think?

That is a bit cleaner, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Álvaro Fernández Rojas]

Hi Daniel,


El 22/01/2018 a las 21:26, Daniel Schwierzeck escribió:


On 22.01.2018 18:14, Tom Rini wrote:

On Mon, Jan 22, 2018 at 05:49:39PM +0100, Daniel Schwierzeck wrote:


On 22.01.2018 13:58, Tom Rini wrote:

On Mon, Jan 22, 2018 at 11:20:56AM +0530, Jagan Teki wrote:


Hi Tom,

Please pull this PR.

thanks!
Jagan.

The following changes since commit 98691a60abffb44303d7dae6e9e699d0daded930:

   Merge git://git.denx.de/u-boot-rockchip (2018-01-09 13:28:51 -0500)

are available in the git repository at:

   git://git.denx.de/u-boot-spi.git master

for you to fetch changes up to b23c685c6f295da3c01dd487f0e003b70299af91:

   mips: bmips: enable the SPI flash on the Comtrend AR-5387un (2018-01-22 
10:39:13 +0530)


NAK:

commit 19e3a4856c1cba751a9ecb3931ff0d96a7f169be
Author: Álvaro Fernández Rojas 
Date:   Sat Jan 20 02:11:34 2018 +0100

 wait_bit: add 8/16/32 BE/LE versions of wait_for_bit

 Add 8/16/32 bits and BE/LE versions of wait_for_bit.
 This is needed for reading registers that are not aligned to 32 bits, and 
for
 Big Endian platforms.

 Signed-off-by: Álvaro Fernández Rojas 
 Reviewed-by: Daniel Schwierzeck 
 Reviewed-by: Jagan Teki 

Adds warnings on almost all platforms:
w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function 
?wait_for_bit_be16?:
w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h:76:31: warning: implicit 
declaration of function ?readw_be? [-Wimplicit-function-declaration]
w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function 
?wait_for_bit_be32?: w+(ls1088ardb_qspi_SECURE_BOOT) 
../include/wait_bit.h:78:31: warning: implicit declaration of function 
?readl_be? [-Wimplicit-function-declaration]



Tom, would this change to the patch be acceptable?

--- a/include/wait_bit.h
+++ b/include/wait_bit.h
@@ -73,8 +73,12 @@ static inline int wait_for_bit_##sfx(const void *reg,
\

  BUILD_WAIT_FOR_BIT(8, u8, readb)
  BUILD_WAIT_FOR_BIT(le16, u16, readw)
+#ifdef readw_be
  BUILD_WAIT_FOR_BIT(be16, u16, readw_be)
+#endif
  BUILD_WAIT_FOR_BIT(le32, u32, readl)
+#ifdef readl_be
  BUILD_WAIT_FOR_BIT(be32, u32, readl_be)
+#endif

  #endif

This wouldn't define wait_bit_be*() on archs which doesn't implement
readw_be or readl_be.

A build with the updated patch is scheduled at
https://travis-ci.org/danielschwierzeck/u-boot/builds/331899381

That seems reasonable, thanks!


Álvaro, could you send a v10 where the patch "wait_bit: add 8/16/32
BE/LE versions of wait_for_bit" is fixed like above? Thanks.

Sure, but I think this alternative would be much cleaner:
https://gist.github.com/Noltari/3e6ed4648b87484c73ca22e2f533f9b0

What do you think?

___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Daniel Schwierzeck]

On 22.01.2018 18:14, Tom Rini wrote:
> On Mon, Jan 22, 2018 at 05:49:39PM +0100, Daniel Schwierzeck wrote:
>>
>>
>> On 22.01.2018 13:58, Tom Rini wrote:
>>> On Mon, Jan 22, 2018 at 11:20:56AM +0530, Jagan Teki wrote:
>>>
 Hi Tom,

 Please pull this PR.

 thanks!
 Jagan.

 The following changes since commit 
 98691a60abffb44303d7dae6e9e699d0daded930:

   Merge git://git.denx.de/u-boot-rockchip (2018-01-09 13:28:51 -0500)

 are available in the git repository at:

   git://git.denx.de/u-boot-spi.git master

 for you to fetch changes up to b23c685c6f295da3c01dd487f0e003b70299af91:

   mips: bmips: enable the SPI flash on the Comtrend AR-5387un (2018-01-22 
 10:39:13 +0530)

>>>
>>> NAK:
>>>
>>> commit 19e3a4856c1cba751a9ecb3931ff0d96a7f169be
>>> Author: Álvaro Fernández Rojas 
>>> Date:   Sat Jan 20 02:11:34 2018 +0100
>>>
>>> wait_bit: add 8/16/32 BE/LE versions of wait_for_bit
>>>
>>> Add 8/16/32 bits and BE/LE versions of wait_for_bit.
>>> This is needed for reading registers that are not aligned to 32 bits, 
>>> and for
>>> Big Endian platforms.
>>>
>>> Signed-off-by: Álvaro Fernández Rojas 
>>> Reviewed-by: Daniel Schwierzeck 
>>> Reviewed-by: Jagan Teki 
>>>
>>> Adds warnings on almost all platforms:
>>> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function 
>>> ?wait_for_bit_be16?:
>>> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h:76:31: warning: 
>>> implicit declaration of function ?readw_be? 
>>> [-Wimplicit-function-declaration]
>>> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function 
>>> ?wait_for_bit_be32?: w+(ls1088ardb_qspi_SECURE_BOOT) 
>>> ../include/wait_bit.h:78:31: warning: implicit declaration of function 
>>> ?readl_be? [-Wimplicit-function-declaration]
>>>
>>>
>>
>> Tom, would this change to the patch be acceptable?
>>
>> --- a/include/wait_bit.h
>> +++ b/include/wait_bit.h
>> @@ -73,8 +73,12 @@ static inline int wait_for_bit_##sfx(const void *reg, 
>> \
>>
>>  BUILD_WAIT_FOR_BIT(8, u8, readb)
>>  BUILD_WAIT_FOR_BIT(le16, u16, readw)
>> +#ifdef readw_be
>>  BUILD_WAIT_FOR_BIT(be16, u16, readw_be)
>> +#endif
>>  BUILD_WAIT_FOR_BIT(le32, u32, readl)
>> +#ifdef readl_be
>>  BUILD_WAIT_FOR_BIT(be32, u32, readl_be)
>> +#endif
>>
>>  #endif
>>
>> This wouldn't define wait_bit_be*() on archs which doesn't implement
>> readw_be or readl_be.
>>
>> A build with the updated patch is scheduled at
>> https://travis-ci.org/danielschwierzeck/u-boot/builds/331899381
> 
> That seems reasonable, thanks!
> 

Álvaro, could you send a v10 where the patch "wait_bit: add 8/16/32
BE/LE versions of wait_for_bit" is fixed like above? Thanks.

-- 
- Daniel



signature.asc
Description: OpenPGP digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Mon, Jan 22, 2018 at 05:49:39PM +0100, Daniel Schwierzeck wrote:
> 
> 
> On 22.01.2018 13:58, Tom Rini wrote:
> > On Mon, Jan 22, 2018 at 11:20:56AM +0530, Jagan Teki wrote:
> > 
> >> Hi Tom,
> >>
> >> Please pull this PR.
> >>
> >> thanks!
> >> Jagan.
> >>
> >> The following changes since commit 
> >> 98691a60abffb44303d7dae6e9e699d0daded930:
> >>
> >>   Merge git://git.denx.de/u-boot-rockchip (2018-01-09 13:28:51 -0500)
> >>
> >> are available in the git repository at:
> >>
> >>   git://git.denx.de/u-boot-spi.git master
> >>
> >> for you to fetch changes up to b23c685c6f295da3c01dd487f0e003b70299af91:
> >>
> >>   mips: bmips: enable the SPI flash on the Comtrend AR-5387un (2018-01-22 
> >> 10:39:13 +0530)
> >>
> > 
> > NAK:
> > 
> > commit 19e3a4856c1cba751a9ecb3931ff0d96a7f169be
> > Author: Álvaro Fernández Rojas 
> > Date:   Sat Jan 20 02:11:34 2018 +0100
> > 
> > wait_bit: add 8/16/32 BE/LE versions of wait_for_bit
> > 
> > Add 8/16/32 bits and BE/LE versions of wait_for_bit.
> > This is needed for reading registers that are not aligned to 32 bits, 
> > and for
> > Big Endian platforms.
> > 
> > Signed-off-by: Álvaro Fernández Rojas 
> > Reviewed-by: Daniel Schwierzeck 
> > Reviewed-by: Jagan Teki 
> > 
> > Adds warnings on almost all platforms:
> > w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function 
> > ?wait_for_bit_be16?:
> > w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h:76:31: warning: 
> > implicit declaration of function ?readw_be? 
> > [-Wimplicit-function-declaration]
> > w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function 
> > ?wait_for_bit_be32?: w+(ls1088ardb_qspi_SECURE_BOOT) 
> > ../include/wait_bit.h:78:31: warning: implicit declaration of function 
> > ?readl_be? [-Wimplicit-function-declaration]
> > 
> > 
> 
> Tom, would this change to the patch be acceptable?
> 
> --- a/include/wait_bit.h
> +++ b/include/wait_bit.h
> @@ -73,8 +73,12 @@ static inline int wait_for_bit_##sfx(const void *reg,  
> \
> 
>  BUILD_WAIT_FOR_BIT(8, u8, readb)
>  BUILD_WAIT_FOR_BIT(le16, u16, readw)
> +#ifdef readw_be
>  BUILD_WAIT_FOR_BIT(be16, u16, readw_be)
> +#endif
>  BUILD_WAIT_FOR_BIT(le32, u32, readl)
> +#ifdef readl_be
>  BUILD_WAIT_FOR_BIT(be32, u32, readl_be)
> +#endif
> 
>  #endif
> 
> This wouldn't define wait_bit_be*() on archs which doesn't implement
> readw_be or readl_be.
> 
> A build with the updated patch is scheduled at
> https://travis-ci.org/danielschwierzeck/u-boot/builds/331899381

That seems reasonable, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Daniel Schwierzeck]

On 22.01.2018 13:58, Tom Rini wrote:
> On Mon, Jan 22, 2018 at 11:20:56AM +0530, Jagan Teki wrote:
> 
>> Hi Tom,
>>
>> Please pull this PR.
>>
>> thanks!
>> Jagan.
>>
>> The following changes since commit 98691a60abffb44303d7dae6e9e699d0daded930:
>>
>>   Merge git://git.denx.de/u-boot-rockchip (2018-01-09 13:28:51 -0500)
>>
>> are available in the git repository at:
>>
>>   git://git.denx.de/u-boot-spi.git master
>>
>> for you to fetch changes up to b23c685c6f295da3c01dd487f0e003b70299af91:
>>
>>   mips: bmips: enable the SPI flash on the Comtrend AR-5387un (2018-01-22 
>> 10:39:13 +0530)
>>
> 
> NAK:
> 
> commit 19e3a4856c1cba751a9ecb3931ff0d96a7f169be
> Author: Álvaro Fernández Rojas 
> Date:   Sat Jan 20 02:11:34 2018 +0100
> 
> wait_bit: add 8/16/32 BE/LE versions of wait_for_bit
> 
> Add 8/16/32 bits and BE/LE versions of wait_for_bit.
> This is needed for reading registers that are not aligned to 32 bits, and 
> for
> Big Endian platforms.
> 
> Signed-off-by: Álvaro Fernández Rojas 
> Reviewed-by: Daniel Schwierzeck 
> Reviewed-by: Jagan Teki 
> 
> Adds warnings on almost all platforms:
> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function 
> ?wait_for_bit_be16?:
> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h:76:31: warning: 
> implicit declaration of function ?readw_be? [-Wimplicit-function-declaration]
> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function 
> ?wait_for_bit_be32?: w+(ls1088ardb_qspi_SECURE_BOOT) 
> ../include/wait_bit.h:78:31: warning: implicit declaration of function 
> ?readl_be? [-Wimplicit-function-declaration]
> 
> 

Tom, would this change to the patch be acceptable?

--- a/include/wait_bit.h
+++ b/include/wait_bit.h
@@ -73,8 +73,12 @@ static inline int wait_for_bit_##sfx(const void *reg,
\

 BUILD_WAIT_FOR_BIT(8, u8, readb)
 BUILD_WAIT_FOR_BIT(le16, u16, readw)
+#ifdef readw_be
 BUILD_WAIT_FOR_BIT(be16, u16, readw_be)
+#endif
 BUILD_WAIT_FOR_BIT(le32, u32, readl)
+#ifdef readl_be
 BUILD_WAIT_FOR_BIT(be32, u32, readl_be)
+#endif

 #endif

This wouldn't define wait_bit_be*() on archs which doesn't implement
readw_be or readl_be.

A build with the updated patch is scheduled at
https://travis-ci.org/danielschwierzeck/u-boot/builds/331899381

-- 
- Daniel



signature.asc
Description: OpenPGP digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Daniel Schwierzeck]

On 22.01.2018 16:32, Tom Rini wrote:
> On Mon, Jan 22, 2018 at 04:28:16PM +0100, Daniel Schwierzeck wrote:
>>
>>
>> On 22.01.2018 15:59, Tom Rini wrote:
>>> On Mon, Jan 22, 2018 at 03:56:09PM +0100, Daniel Schwierzeck wrote:
 Hi Tom,

 On 22.01.2018 13:58, Tom Rini wrote:
> On Mon, Jan 22, 2018 at 11:20:56AM +0530, Jagan Teki wrote:
>
>> Hi Tom,
>>
>> Please pull this PR.
>>
>> thanks!
>> Jagan.
>>
>> The following changes since commit 
>> 98691a60abffb44303d7dae6e9e699d0daded930:
>>
>>   Merge git://git.denx.de/u-boot-rockchip (2018-01-09 13:28:51 -0500)
>>
>> are available in the git repository at:
>>
>>   git://git.denx.de/u-boot-spi.git master
>>
>> for you to fetch changes up to b23c685c6f295da3c01dd487f0e003b70299af91:
>>
>>   mips: bmips: enable the SPI flash on the Comtrend AR-5387un 
>> (2018-01-22 10:39:13 +0530)
>>
>
> NAK:
>
> commit 19e3a4856c1cba751a9ecb3931ff0d96a7f169be
> Author: Álvaro Fernández Rojas 
> Date:   Sat Jan 20 02:11:34 2018 +0100
>
> wait_bit: add 8/16/32 BE/LE versions of wait_for_bit
>
> Add 8/16/32 bits and BE/LE versions of wait_for_bit.
> This is needed for reading registers that are not aligned to 32 bits, 
> and for
> Big Endian platforms.
>
> Signed-off-by: Álvaro Fernández Rojas 
> Reviewed-by: Daniel Schwierzeck 
> Reviewed-by: Jagan Teki 
>
> Adds warnings on almost all platforms:
> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function 
> ?wait_for_bit_be16?:
> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h:76:31: warning: 
> implicit declaration of function ?readw_be? 
> [-Wimplicit-function-declaration]
> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function 
> ?wait_for_bit_be32?: w+(ls1088ardb_qspi_SECURE_BOOT) 
> ../include/wait_bit.h:78:31: warning: implicit declaration of function 
> ?readl_be? [-Wimplicit-function-declaration]
>


 did this commit alone produce those warnings? The patch series itself
 builds successfully on Travis CI [1].

 [1] https://travis-ci.org/danielschwierzeck/u-boot/builds/331506036
>>>
>>> It builds, yes.  But it adds that warning too:
>>> https://travis-ci.org/danielschwierzeck/u-boot/jobs/331506059
>>>
>>> And I bisect'd down to the above commit being what adds that warning.
>>>
>>> And yes, sigh, I need to something-something to get us back to zero
>>> warnings and make -Werror at least a CONFIG option and perhaps default
>>> in travis as this isn't the first warning to come in that wasn't noticed
>>> as travis didn't fail.
>>
>> hm, since when are gcc warnings being ignored? I thought only DTC
>> warnings were suppressed. Thus I still expected to have Travis CI builds
>> marked as yellow in case of gcc warnings ;)
> 
> ... wait, you can have Travis CI do yellow for warnings?  That'd be
> handy to get back again.  Especially if we can have it for non-DTC
> warnings only.
> 

hm, I think I saw this in the past but can't find any reference in the
documentation. Sorry for creating false hopes ;)

-- 
- Daniel



signature.asc
Description: OpenPGP digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Mon, Jan 22, 2018 at 04:28:16PM +0100, Daniel Schwierzeck wrote:
> 
> 
> On 22.01.2018 15:59, Tom Rini wrote:
> > On Mon, Jan 22, 2018 at 03:56:09PM +0100, Daniel Schwierzeck wrote:
> >> Hi Tom,
> >>
> >> On 22.01.2018 13:58, Tom Rini wrote:
> >>> On Mon, Jan 22, 2018 at 11:20:56AM +0530, Jagan Teki wrote:
> >>>
>  Hi Tom,
> 
>  Please pull this PR.
> 
>  thanks!
>  Jagan.
> 
>  The following changes since commit 
>  98691a60abffb44303d7dae6e9e699d0daded930:
> 
>    Merge git://git.denx.de/u-boot-rockchip (2018-01-09 13:28:51 -0500)
> 
>  are available in the git repository at:
> 
>    git://git.denx.de/u-boot-spi.git master
> 
>  for you to fetch changes up to b23c685c6f295da3c01dd487f0e003b70299af91:
> 
>    mips: bmips: enable the SPI flash on the Comtrend AR-5387un 
>  (2018-01-22 10:39:13 +0530)
> 
> >>>
> >>> NAK:
> >>>
> >>> commit 19e3a4856c1cba751a9ecb3931ff0d96a7f169be
> >>> Author: Álvaro Fernández Rojas 
> >>> Date:   Sat Jan 20 02:11:34 2018 +0100
> >>>
> >>> wait_bit: add 8/16/32 BE/LE versions of wait_for_bit
> >>>
> >>> Add 8/16/32 bits and BE/LE versions of wait_for_bit.
> >>> This is needed for reading registers that are not aligned to 32 bits, 
> >>> and for
> >>> Big Endian platforms.
> >>>
> >>> Signed-off-by: Álvaro Fernández Rojas 
> >>> Reviewed-by: Daniel Schwierzeck 
> >>> Reviewed-by: Jagan Teki 
> >>>
> >>> Adds warnings on almost all platforms:
> >>> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function 
> >>> ?wait_for_bit_be16?:
> >>> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h:76:31: warning: 
> >>> implicit declaration of function ?readw_be? 
> >>> [-Wimplicit-function-declaration]
> >>> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function 
> >>> ?wait_for_bit_be32?: w+(ls1088ardb_qspi_SECURE_BOOT) 
> >>> ../include/wait_bit.h:78:31: warning: implicit declaration of function 
> >>> ?readl_be? [-Wimplicit-function-declaration]
> >>>
> >>
> >>
> >> did this commit alone produce those warnings? The patch series itself
> >> builds successfully on Travis CI [1].
> >>
> >> [1] https://travis-ci.org/danielschwierzeck/u-boot/builds/331506036
> > 
> > It builds, yes.  But it adds that warning too:
> > https://travis-ci.org/danielschwierzeck/u-boot/jobs/331506059
> > 
> > And I bisect'd down to the above commit being what adds that warning.
> > 
> > And yes, sigh, I need to something-something to get us back to zero
> > warnings and make -Werror at least a CONFIG option and perhaps default
> > in travis as this isn't the first warning to come in that wasn't noticed
> > as travis didn't fail.
> 
> hm, since when are gcc warnings being ignored? I thought only DTC
> warnings were suppressed. Thus I still expected to have Travis CI builds
> marked as yellow in case of gcc warnings ;)

... wait, you can have Travis CI do yellow for warnings?  That'd be
handy to get back again.  Especially if we can have it for non-DTC
warnings only.

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Daniel Schwierzeck]

On 22.01.2018 15:59, Tom Rini wrote:
> On Mon, Jan 22, 2018 at 03:56:09PM +0100, Daniel Schwierzeck wrote:
>> Hi Tom,
>>
>> On 22.01.2018 13:58, Tom Rini wrote:
>>> On Mon, Jan 22, 2018 at 11:20:56AM +0530, Jagan Teki wrote:
>>>
 Hi Tom,

 Please pull this PR.

 thanks!
 Jagan.

 The following changes since commit 
 98691a60abffb44303d7dae6e9e699d0daded930:

   Merge git://git.denx.de/u-boot-rockchip (2018-01-09 13:28:51 -0500)

 are available in the git repository at:

   git://git.denx.de/u-boot-spi.git master

 for you to fetch changes up to b23c685c6f295da3c01dd487f0e003b70299af91:

   mips: bmips: enable the SPI flash on the Comtrend AR-5387un (2018-01-22 
 10:39:13 +0530)

>>>
>>> NAK:
>>>
>>> commit 19e3a4856c1cba751a9ecb3931ff0d96a7f169be
>>> Author: Álvaro Fernández Rojas 
>>> Date:   Sat Jan 20 02:11:34 2018 +0100
>>>
>>> wait_bit: add 8/16/32 BE/LE versions of wait_for_bit
>>>
>>> Add 8/16/32 bits and BE/LE versions of wait_for_bit.
>>> This is needed for reading registers that are not aligned to 32 bits, 
>>> and for
>>> Big Endian platforms.
>>>
>>> Signed-off-by: Álvaro Fernández Rojas 
>>> Reviewed-by: Daniel Schwierzeck 
>>> Reviewed-by: Jagan Teki 
>>>
>>> Adds warnings on almost all platforms:
>>> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function 
>>> ?wait_for_bit_be16?:
>>> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h:76:31: warning: 
>>> implicit declaration of function ?readw_be? 
>>> [-Wimplicit-function-declaration]
>>> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function 
>>> ?wait_for_bit_be32?: w+(ls1088ardb_qspi_SECURE_BOOT) 
>>> ../include/wait_bit.h:78:31: warning: implicit declaration of function 
>>> ?readl_be? [-Wimplicit-function-declaration]
>>>
>>
>>
>> did this commit alone produce those warnings? The patch series itself
>> builds successfully on Travis CI [1].
>>
>> [1] https://travis-ci.org/danielschwierzeck/u-boot/builds/331506036
> 
> It builds, yes.  But it adds that warning too:
> https://travis-ci.org/danielschwierzeck/u-boot/jobs/331506059
> 
> And I bisect'd down to the above commit being what adds that warning.
> 
> And yes, sigh, I need to something-something to get us back to zero
> warnings and make -Werror at least a CONFIG option and perhaps default
> in travis as this isn't the first warning to come in that wasn't noticed
> as travis didn't fail.
> 

hm, since when are gcc warnings being ignored? I thought only DTC
warnings were suppressed. Thus I still expected to have Travis CI builds
marked as yellow in case of gcc warnings ;)

-- 
- Daniel



signature.asc
Description: OpenPGP digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Mon, Jan 22, 2018 at 03:56:09PM +0100, Daniel Schwierzeck wrote:
> Hi Tom,
> 
> On 22.01.2018 13:58, Tom Rini wrote:
> > On Mon, Jan 22, 2018 at 11:20:56AM +0530, Jagan Teki wrote:
> > 
> >> Hi Tom,
> >>
> >> Please pull this PR.
> >>
> >> thanks!
> >> Jagan.
> >>
> >> The following changes since commit 
> >> 98691a60abffb44303d7dae6e9e699d0daded930:
> >>
> >>   Merge git://git.denx.de/u-boot-rockchip (2018-01-09 13:28:51 -0500)
> >>
> >> are available in the git repository at:
> >>
> >>   git://git.denx.de/u-boot-spi.git master
> >>
> >> for you to fetch changes up to b23c685c6f295da3c01dd487f0e003b70299af91:
> >>
> >>   mips: bmips: enable the SPI flash on the Comtrend AR-5387un (2018-01-22 
> >> 10:39:13 +0530)
> >>
> > 
> > NAK:
> > 
> > commit 19e3a4856c1cba751a9ecb3931ff0d96a7f169be
> > Author: Álvaro Fernández Rojas 
> > Date:   Sat Jan 20 02:11:34 2018 +0100
> > 
> > wait_bit: add 8/16/32 BE/LE versions of wait_for_bit
> > 
> > Add 8/16/32 bits and BE/LE versions of wait_for_bit.
> > This is needed for reading registers that are not aligned to 32 bits, 
> > and for
> > Big Endian platforms.
> > 
> > Signed-off-by: Álvaro Fernández Rojas 
> > Reviewed-by: Daniel Schwierzeck 
> > Reviewed-by: Jagan Teki 
> > 
> > Adds warnings on almost all platforms:
> > w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function 
> > ?wait_for_bit_be16?:
> > w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h:76:31: warning: 
> > implicit declaration of function ?readw_be? 
> > [-Wimplicit-function-declaration]
> > w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function 
> > ?wait_for_bit_be32?: w+(ls1088ardb_qspi_SECURE_BOOT) 
> > ../include/wait_bit.h:78:31: warning: implicit declaration of function 
> > ?readl_be? [-Wimplicit-function-declaration]
> > 
> 
> 
> did this commit alone produce those warnings? The patch series itself
> builds successfully on Travis CI [1].
> 
> [1] https://travis-ci.org/danielschwierzeck/u-boot/builds/331506036

It builds, yes.  But it adds that warning too:
https://travis-ci.org/danielschwierzeck/u-boot/jobs/331506059

And I bisect'd down to the above commit being what adds that warning.

And yes, sigh, I need to something-something to get us back to zero
warnings and make -Werror at least a CONFIG option and perhaps default
in travis as this isn't the first warning to come in that wasn't noticed
as travis didn't fail.

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Daniel Schwierzeck]

Hi Tom,

On 22.01.2018 13:58, Tom Rini wrote:
> On Mon, Jan 22, 2018 at 11:20:56AM +0530, Jagan Teki wrote:
> 
>> Hi Tom,
>>
>> Please pull this PR.
>>
>> thanks!
>> Jagan.
>>
>> The following changes since commit 98691a60abffb44303d7dae6e9e699d0daded930:
>>
>>   Merge git://git.denx.de/u-boot-rockchip (2018-01-09 13:28:51 -0500)
>>
>> are available in the git repository at:
>>
>>   git://git.denx.de/u-boot-spi.git master
>>
>> for you to fetch changes up to b23c685c6f295da3c01dd487f0e003b70299af91:
>>
>>   mips: bmips: enable the SPI flash on the Comtrend AR-5387un (2018-01-22 
>> 10:39:13 +0530)
>>
> 
> NAK:
> 
> commit 19e3a4856c1cba751a9ecb3931ff0d96a7f169be
> Author: Álvaro Fernández Rojas 
> Date:   Sat Jan 20 02:11:34 2018 +0100
> 
> wait_bit: add 8/16/32 BE/LE versions of wait_for_bit
> 
> Add 8/16/32 bits and BE/LE versions of wait_for_bit.
> This is needed for reading registers that are not aligned to 32 bits, and 
> for
> Big Endian platforms.
> 
> Signed-off-by: Álvaro Fernández Rojas 
> Reviewed-by: Daniel Schwierzeck 
> Reviewed-by: Jagan Teki 
> 
> Adds warnings on almost all platforms:
> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function 
> ?wait_for_bit_be16?:
> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h:76:31: warning: 
> implicit declaration of function ?readw_be? [-Wimplicit-function-declaration]
> w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function 
> ?wait_for_bit_be32?: w+(ls1088ardb_qspi_SECURE_BOOT) 
> ../include/wait_bit.h:78:31: warning: implicit declaration of function 
> ?readl_be? [-Wimplicit-function-declaration]
> 


did this commit alone produce those warnings? The patch series itself
builds successfully on Travis CI [1].

[1] https://travis-ci.org/danielschwierzeck/u-boot/builds/331506036

-- 
- Daniel



signature.asc
Description: OpenPGP digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Mon, Jan 22, 2018 at 11:20:56AM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 98691a60abffb44303d7dae6e9e699d0daded930:
> 
>   Merge git://git.denx.de/u-boot-rockchip (2018-01-09 13:28:51 -0500)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to b23c685c6f295da3c01dd487f0e003b70299af91:
> 
>   mips: bmips: enable the SPI flash on the Comtrend AR-5387un (2018-01-22 
> 10:39:13 +0530)
> 

NAK:

commit 19e3a4856c1cba751a9ecb3931ff0d96a7f169be
Author: Álvaro Fernández Rojas 
Date:   Sat Jan 20 02:11:34 2018 +0100

wait_bit: add 8/16/32 BE/LE versions of wait_for_bit

Add 8/16/32 bits and BE/LE versions of wait_for_bit.
This is needed for reading registers that are not aligned to 32 bits, and 
for
Big Endian platforms.

Signed-off-by: Álvaro Fernández Rojas 
Reviewed-by: Daniel Schwierzeck 
Reviewed-by: Jagan Teki 

Adds warnings on almost all platforms:
w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function 
?wait_for_bit_be16?:
w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h:76:31: warning: implicit 
declaration of function ?readw_be? [-Wimplicit-function-declaration]
w+(ls1088ardb_qspi_SECURE_BOOT) ../include/wait_bit.h: In function 
?wait_for_bit_be32?: w+(ls1088ardb_qspi_SECURE_BOOT) 
../include/wait_bit.h:78:31: warning: implicit declaration of function 
?readl_be? [-Wimplicit-function-declaration]

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Tue, Dec 19, 2017 at 05:54:21PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 16fa2eb95172e63820ee5f3d4052f3362a6de84e:
> 
>   ARM: dra7: Kconfig: Add thermal configs for dra7xx and am57xx (2017-11-21 
> 08:03:39 -0500)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 065592b40b41b11ee66d8ff71a55156bf1b35088:
> 
>   mtd/spi: fix block count for is25lq040b (2017-12-19 17:33:48 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Tue, Oct 17, 2017 at 07:20:04PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 10509987285515b0a969c39ef7374fea3545851b:
> 
>   spi: fsl_qspi: Copy 16 byte aligned data in TX FIFO (2017-09-25 15:45:15 
> +0530)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to ca1ac16da097bf0ab176b1a201653553160dc042:
> 
>   sf: bar: Clean BA24 Bank Address Register bit after read/write/erase 
> operation (2017-09-27 13:31:59 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: PGP signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Mon, Sep 25, 2017 at 01:21:35PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 1f6049e2501b5c35c61435dbc05ba96743202674:
> 
>   tools/mkimage: Make the path to the dtc binary that mkimage calls 
> configurable (2017-09-24 07:33:03 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to db10809c17c7cd8960d0c45248bbef6e76251ad7:
> 
>   Fix s25fl256s position in spi_flash_ids list (2017-09-25 13:00:34 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Jagan Teki]

On Mon, Sep 25, 2017 at 2:11 PM, Łukasz Majewski  wrote:
> Hi Jagan,
>
>> Hi Tom,
>>
>> Please pull this PR.
>
>
> Would you find some time and look into following patch:
>
> http://patchwork.ozlabs.org/patch/813266/

Of-course, will comment on respective patch itself.

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Łukasz Majewski]

Hi Jagan,


Hi Tom,

Please pull this PR.


Would you find some time and look into following patch:

http://patchwork.ozlabs.org/patch/813266/

Thanks in advance,
Łukasz



thanks!
Jagan.

The following changes since commit 1f6049e2501b5c35c61435dbc05ba96743202674:

   tools/mkimage: Make the path to the dtc binary that mkimage calls 
configurable (2017-09-24 07:33:03 -0400)

are available in the git repository at:

   git://git.denx.de/u-boot-spi.git master

for you to fetch changes up to db10809c17c7cd8960d0c45248bbef6e76251ad7:

   Fix s25fl256s position in spi_flash_ids list (2017-09-25 13:00:34 +0530)


Marek Vasut (1):
   sf: Fix S25FL116K entry

Peng Fan (1):
   spi: mxc_spi: support driver model

Suresh Gupta (1):
   spi: fsl_qspi: Add controller busy check before new spi operation

Vsevolod Gribov (1):
   Fix s25fl256s position in spi_flash_ids list

Yogesh Gaur (1):
   mtd/spi: Add MT35XU512ABA1G12 NOR flash support

  drivers/mtd/spi/spi_flash_ids.c |   5 +-
  drivers/spi/fsl_qspi.c  |  28 ++-
  drivers/spi/fsl_qspi.h  |   4 +
  drivers/spi/mxc_spi.c   | 181 +---
  4 files changed, 183 insertions(+), 35 deletions(-)
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot




--
Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,  Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Wed, Aug 16, 2017 at 06:30:39PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit eaa90e5df2a4a1cb12fb73571978a9379242d0b5:
> 
>   common/env_embedded.c: rename PPCENV/PPCTEXT macros (2017-08-04 20:38:39 
> -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 294f2050c438d1e4ab39fd040d394927772048f2:
> 
>   sf: Preserve QE bit when clearing BP# bits for Macronix flash (2017-08-16 
> 18:21:50 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Wed, May 03, 2017 at 05:43:46PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please take this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit a63d800196ebee59b0f8ff924f67843cd597a8c1:
> 
>   Prepare v2017.05-rc3 (2017-05-01 19:54:41 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 2f54205829429d82c7591340a106bf68f3916120:
> 
>   drivers: spi: Remove duplicate .probe method (2017-05-03 11:52:16 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Sun, Jan 15, 2017 at 06:32:14PM +0100, Jagan Teki wrote:

> Hi Tom,
> 
> Please take this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 70c1e0474a9df2c4493b4e2330cc41d3132b4e90:
> 
>   Merge git://git.denx.de/u-boot-rockchip (2017-01-12 21:20:51 -0500)
> 
> are available in the git repository at:
> 
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 68e7999ba9de0a15dd3dc99e078b70f41eb98c82:
> 
>   spi: Zap cf_qspi driver and related code (2017-01-15 18:29:04 +0100)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Sat, Dec 24, 2016 at 12:39:22AM +0100, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 4cf5c5f1e60e6541630ae829b5fa2db704c268f0:
> 
>   Prepare v2017.01-rc2 (2016-12-19 16:08:57 -0500)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master 
> 
> for you to fetch changes up to b98fa02e8a1480eeab6c7e10eb1a2a9971a11497:
> 
>   spi: Zap armada100_spi.c and env (2016-12-23 11:13:04 +0100)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Wed, Dec 14, 2016 at 04:36:58PM +0100, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 136179bec19f4bc84227cba138214ea392a723ea:
> 
>   colibri_pxa270: transition to driver model for serial (2016-11-23 13:53:20 
> +0100)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 6c11b3a89fe9cd5ef8070b2a13103f6f466860f1:
> 
>   sf: Do not force the DT memory map size to exactly match the device 
> (2016-12-14 16:30:04 +0100)
> 

NAK:
https://travis-ci.org/trini/u-boot/jobs/184036802

Please fix, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Sun, Nov 20, 2016 at 05:29:41PM +0530, Jagan Teki wrote:
> Hi Tom,
> 
> On Sat, Nov 19, 2016 at 6:27 AM, Tom Rini  wrote:
> > On Fri, Nov 18, 2016 at 04:46:03PM +0530, Jagan Teki wrote:
> >
> >> Hi Tom,
> >>
> >> Please pull this PR.
> >>
> >> thanks!
> >> Jagan.
> >>
> >> The following changes since commit 
> >> c2cbd164ea5b5f564fcf03447c7bf9ec4a9f5699:
> >>
> >>   Merge branch 'master' of http://git.denx.de/u-boot-mmc (2016-11-17 
> >> 11:46:56 -0500)
> >>
> >> are available in the git repository at:
> >>
> >>
> >>   git://git.denx.de/u-boot-spi.git master
> >>
> >> for you to fetch changes up to 84cdc6e27aede7d87322842d262f0414824bb126:
> >>
> >>   sf: Fix s25fs512s id table (2016-11-18 13:04:55 +0530)
> >>
> >
> > NAK, this has a build failure that travis-ci catches:
> > https://travis-ci.org/trini/u-boot/jobs/177155166
> 
> Fixed the same, please consider the same PR again.

Applied, but in the future please send a new PR out, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Jagan Teki]

Hi Tom,

On Sat, Nov 19, 2016 at 6:27 AM, Tom Rini  wrote:
> On Fri, Nov 18, 2016 at 04:46:03PM +0530, Jagan Teki wrote:
>
>> Hi Tom,
>>
>> Please pull this PR.
>>
>> thanks!
>> Jagan.
>>
>> The following changes since commit c2cbd164ea5b5f564fcf03447c7bf9ec4a9f5699:
>>
>>   Merge branch 'master' of http://git.denx.de/u-boot-mmc (2016-11-17 
>> 11:46:56 -0500)
>>
>> are available in the git repository at:
>>
>>
>>   git://git.denx.de/u-boot-spi.git master
>>
>> for you to fetch changes up to 84cdc6e27aede7d87322842d262f0414824bb126:
>>
>>   sf: Fix s25fs512s id table (2016-11-18 13:04:55 +0530)
>>
>
> NAK, this has a build failure that travis-ci catches:
> https://travis-ci.org/trini/u-boot/jobs/177155166

Fixed the same, please consider the same PR again.

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Fri, Nov 18, 2016 at 04:46:03PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit c2cbd164ea5b5f564fcf03447c7bf9ec4a9f5699:
> 
>   Merge branch 'master' of http://git.denx.de/u-boot-mmc (2016-11-17 11:46:56 
> -0500)
> 
> are available in the git repository at:
> 
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 84cdc6e27aede7d87322842d262f0414824bb126:
> 
>   sf: Fix s25fs512s id table (2016-11-18 13:04:55 +0530)
> 

NAK, this has a build failure that travis-ci catches:
https://travis-ci.org/trini/u-boot/jobs/177155166

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Sat, Nov 12, 2016 at 05:43:08PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please take these fixes.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 38cacdab3b5a6d8efd16a4b2620f7ab72144a624:
> 
>   Merge branch 'master' of git://git.denx.de/u-boot-tegra (2016-11-08 
> 10:36:57 -0500)
> 
> are available in the git repository at:
> 
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 7480b35fd19d18871d09fc0447d978d8d10c05b8:
> 
>   spi: ti_qspi: Fix baudrate divider calculation (2016-11-11 17:22:47 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Thu, Sep 22, 2016 at 08:32:48PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please take this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 9b1b6d42256a4c2e59c803afdbf90d39371e61ba:
> 
>   Revert "Increase default of CONFIG_SYS_MALLOC_F_LEN for SPL_OF_CONTROL" 
> (2016-09-19 15:20:09 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to fe4753cbc6c51f712024121aad0d21293d6a85fc:
> 
>   configs: fsl: Move SPI/SPI-FLASH configs to defconfig (2016-09-22 14:17:02 
> +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Tue, Aug 09, 2016 at 05:33:59PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this request.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 08887ed4505ec14ee94ab32c482dc4dec5ddc1e4:
> 
>   ARM: am57xx_evm: Enable QSPI support (2016-07-30 00:15:07 +0530)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 53208741d6c3448b7a7f5260d52c28f912ff6453:
> 
>   dm: at91: Add driver model support for the spi driver (2016-07-31 17:03:33 
> +0530)
> 

NAK.  The atmel DM prep stuff needs to be taken in, all at once perhaps,
by Andreas all at once to avoid warnings like:
+   sama5d4_xplained_spiflash
+(sama5d4_xplained_spiflash)  static int clk_get_by_name(struct udevice *dev, 
const char *name,
+(sama5d4_xplained_spiflash) ^
w+(sama5d4_xplained_spiflash) In file included from drivers/spi/atmel_spi.c:7:0:
w+(sama5d4_xplained_spiflash) include/clk.h:107:12: warning: 'clk_get_by_name' 
defined but not used [-Wunused-function]
that Marek also hit with the USB patch.

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Sat, Jul 30, 2016 at 12:18:15AM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 4711e7f7af839b41a6d78490257a9e7975494dd3:
> 
>   Merge branch 'master' of git://www.denx.de/git/u-boot-imx (2016-07-28 
> 08:45:00 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 08887ed4505ec14ee94ab32c482dc4dec5ddc1e4:
> 
>   ARM: am57xx_evm: Enable QSPI support (2016-07-30 00:15:07 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Sat, Jul 09, 2016 at 09:00:16PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please take this series.
> 
> thanks!
> Jagan.
> 
> The following changes since commit e8009beff6d5c55c1bf1ae8184791f167e6378b0:
> 
>   Merge git://git.denx.de/u-boot-arc (2016-07-04 11:46:21 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 96907c0fe50a856f66f60ade68864a2d7949bf15:
> 
>   dm: spi: Read default speed and mode values from DT (2016-07-09 20:16:34 
> +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Sat, Jul 09, 2016 at 09:00:16PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please take this series.

We are about 2 days from release.  None of these changes are clearly 
critical for release bug fixes.  I will pick this up after the release,
thanks.

> 
> thanks!
> Jagan.
> 
> The following changes since commit e8009beff6d5c55c1bf1ae8184791f167e6378b0:
> 
>   Merge git://git.denx.de/u-boot-arc (2016-07-04 11:46:21 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 96907c0fe50a856f66f60ade68864a2d7949bf15:
> 
>   dm: spi: Read default speed and mode values from DT (2016-07-09 20:16:34 
> +0530)
> 
> 
> Anatolij Gustschin (1):
>   spi: spi-uclass: fix typo in debug output
> 
> Vignesh R (18):
>   dm: core: implement dev_map_physmem()
>   spi: davinci_spi: Convert to driver to adapt to DM
>   keystone2: spi: do not define DM_SPI and DM_SPI_FLASH for SPL build
>   ARM: dts: keystone2: add SPI aliases for davinci SPI nodes
>   ARM: dts: k2hk: Enable Davinci SPI controller
>   defconfig: k2hk_evm_defconfig: enable SPI driver model
>   ARM: dts: k2e: Enable Davinci SPI controller
>   defconfig: k2e_evm_defconfig: enable SPI driver model
>   ARM: dts: k2l: Enable Davinci SPI controller
>   defconfig: k2l_evm_defconfig: enable SPI driver model
>   ARM: dts: k2g: add support for Davinci SPI controller
>   defconfig: k2g_evm_defconfig: enable SPI driver model
>   spi: cadence_qspi_apb: Support 32 bit AHB address
>   spi: cadence_quadspi: Enable QUAD mode based on DT data
>   ARM: dts: K2G: Add support for QSPI controller
>   defconfig: k2g_evm_defconfig: Enable Cadence QSPI controller
>   ARM: dts: dra7x: Support QSPI MODE-0 operation at 64MHz
>   dm: spi: Read default speed and mode values from DT
> 
>  arch/arm/dts/dra7-evm.dts|   6 +-
>  arch/arm/dts/dra72-evm.dts   |   6 +-
>  arch/arm/dts/k2e-evm.dts |   3 +-
>  arch/arm/dts/k2g-evm.dts |  69 
>  arch/arm/dts/k2g.dtsi|  61 +++
>  arch/arm/dts/k2hk-evm.dts|   3 +-
>  arch/arm/dts/k2l-evm.dts |   3 +-
>  arch/arm/dts/keystone.dtsi   |   3 +
>  cmd/sf.c |   2 +
>  common/env_sf.c  |   8 +-
>  configs/k2e_evm_defconfig|   2 +
>  configs/k2g_evm_defconfig|   4 +
>  configs/k2hk_evm_defconfig   |   2 +
>  configs/k2l_evm_defconfig|   2 +
>  drivers/core/device.c|  11 ++
>  drivers/spi/cadence_qspi.c   |   3 +-
>  drivers/spi/cadence_qspi.h   |   2 +-
>  drivers/spi/cadence_qspi_apb.c   |  15 +-
>  drivers/spi/davinci_spi.c| 329 
> +--
>  drivers/spi/spi-uclass.c |  10 +-
>  include/configs/k2g_evm.h|   6 +
>  include/configs/ti_armv7_keystone2.h |   4 +
>  include/dm/device.h  |  13 ++
>  23 files changed, 450 insertions(+), 117 deletions(-)

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Jagan Teki]

On 15 March 2016 at 20:34, Tom Rini  wrote:
> On Tue, Mar 15, 2016 at 08:01:14AM -0400, Tom Rini wrote:
>> On Tue, Mar 15, 2016 at 12:41:20PM +0530, Jagan Teki wrote:
>>
>> > Hi Tom,
>> >
>> > Please pull this PR.
>> >
>> > thanks!
>> > Jagan.
>> >
>> > The following changes since commit 
>> > df61a74e6845ec9bdcdd48d2aff5e9c2c6debeaa:
>> >
>> >   Prepare v2016.03 (2016-03-14 10:20:21 -0400)
>> >
>> > are available in the git repository at:
>> >
>> >   git://git.denx.de/u-boot-spi.git master
>> >
>> > for you to fetch changes up to 77b8d04854f486741471ad02b93b473b5b3d72f8:
>> >
>> >   spi: omap3: Convert to driver model (2016-03-14 22:46:28 +0530)
>> >
>>
>> Applied to u-boot/master, thanks!
>
> But, bah!
>
> +(cm_t3517,cm_t35) drivers/spi/built-in.o:(.bss.priv+0x0): multiple 
> definition of `priv'
> +(cm_t3517,cm_t35) drivers/built-in.o:(.bss.priv+0x0): first defined here
> +(cm_t3517,cm_t35) arm-linux-gnueabi-ld.bfd: Warning: size of symbol `priv' 
> changed from 20 in drivers/built-in.o to 4 in drivers/spi/built-in.o
> +(cm_t3517,cm_t35) make[1]: *** [u-boot] Error 1
> +(cm_t3517,cm_t35) make: *** [sub-make] Error 2
>

Ohh, yes look like an issue with global priv on non-dm stuff, will send the fix.

thanks!
-- 
Jagan.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Tue, Mar 15, 2016 at 08:01:14AM -0400, Tom Rini wrote:
> On Tue, Mar 15, 2016 at 12:41:20PM +0530, Jagan Teki wrote:
> 
> > Hi Tom,
> > 
> > Please pull this PR.
> > 
> > thanks!
> > Jagan.
> > 
> > The following changes since commit df61a74e6845ec9bdcdd48d2aff5e9c2c6debeaa:
> > 
> >   Prepare v2016.03 (2016-03-14 10:20:21 -0400)
> > 
> > are available in the git repository at:
> > 
> >   git://git.denx.de/u-boot-spi.git master
> > 
> > for you to fetch changes up to 77b8d04854f486741471ad02b93b473b5b3d72f8:
> > 
> >   spi: omap3: Convert to driver model (2016-03-14 22:46:28 +0530)
> > 
> 
> Applied to u-boot/master, thanks!

But, bah!

+(cm_t3517,cm_t35) drivers/spi/built-in.o:(.bss.priv+0x0): multiple definition 
of `priv'
+(cm_t3517,cm_t35) drivers/built-in.o:(.bss.priv+0x0): first defined here
+(cm_t3517,cm_t35) arm-linux-gnueabi-ld.bfd: Warning: size of symbol `priv' 
changed from 20 in drivers/built-in.o to 4 in drivers/spi/built-in.o
+(cm_t3517,cm_t35) make[1]: *** [u-boot] Error 1
+(cm_t3517,cm_t35) make: *** [sub-make] Error 2

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Tue, Mar 15, 2016 at 12:41:20PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit df61a74e6845ec9bdcdd48d2aff5e9c2c6debeaa:
> 
>   Prepare v2016.03 (2016-03-14 10:20:21 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 77b8d04854f486741471ad02b93b473b5b3d72f8:
> 
>   spi: omap3: Convert to driver model (2016-03-14 22:46:28 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Sat, Mar 12, 2016 at 08:14:47PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please take these two fixes for this release.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 76aab9eb8b4618891914e41fa1ea84441f8c53fd:
> 
>   exynos5: common: Enable CONFIG_USB_ETHER_RTL8152 ethernet support 
> (2016-03-11 10:59:51 +0900)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to ea9619aed6908e83b0679bd9c9aa4ae97714ef97:
> 
>   sf: Correct data types in stm_is_locked_sr() (2016-03-12 19:55:42 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Mugunthan V N]

On Wednesday 24 February 2016 02:05 AM, Tom Rini wrote:
> On Tue, Feb 23, 2016 at 04:19:01PM +0530, Jagan Teki wrote:
> 
>> Hi Tom,
>>
>> Please pull this series.
>>
>> thanks!
>> Jagan.
>>
>> The following changes since commit 595af9db2422fa5ae734cfe615415b17a5098f34:
>>
>>   Merge branch 'master' of git://www.denx.de/git/u-boot-imx (2016-02-21 
>> 07:56:16 -0500)
>>
>> are available in the git repository at:
>>
>>
>>   git://git.denx.de/u-boot-spi.git master
>>
>> for you to fetch changes up to 674f3609aad39f099a5c3605643a6be124504b96:
>>
>>   spi: spi-uclass: Set slave wordlen with SPI_DEFAULT_WORDLEN (2016-02-23 
>> 16:14:46 +0530)
>>
> 
> Applied to u-boot/master, thanks!
> 
> Mugunthan, can you please test QSPI boot on J6 or J6Eco?  My board isn't
> behaving well and I couldn't walk Nishanth through doing it on his (or,
> there's a problem..).  Thanks!
> 

Tom, I am able to boot DRA74x EVM in QSPI boot Logs [1].

[1] - http://pastebin.ubuntu.com/15249899/

Regards
Mugunthan V N
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Mugunthan V N]

On Wednesday 24 February 2016 02:05 AM, Tom Rini wrote:
> On Tue, Feb 23, 2016 at 04:19:01PM +0530, Jagan Teki wrote:
> 
>> Hi Tom,
>>
>> Please pull this series.
>>
>> thanks!
>> Jagan.
>>
>> The following changes since commit 595af9db2422fa5ae734cfe615415b17a5098f34:
>>
>>   Merge branch 'master' of git://www.denx.de/git/u-boot-imx (2016-02-21 
>> 07:56:16 -0500)
>>
>> are available in the git repository at:
>>
>>
>>   git://git.denx.de/u-boot-spi.git master
>>
>> for you to fetch changes up to 674f3609aad39f099a5c3605643a6be124504b96:
>>
>>   spi: spi-uclass: Set slave wordlen with SPI_DEFAULT_WORDLEN (2016-02-23 
>> 16:14:46 +0530)
>>
> 
> Applied to u-boot/master, thanks!
> 
> Mugunthan, can you please test QSPI boot on J6 or J6Eco?  My board isn't
> behaving well and I couldn't walk Nishanth through doing it on his (or,
> there's a problem..).  Thanks!
> 

Tom, I will do a qspi boot test tomorrow and update here.

Regards
Mugunthan V N
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Tue, Feb 23, 2016 at 04:19:01PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this series.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 595af9db2422fa5ae734cfe615415b17a5098f34:
> 
>   Merge branch 'master' of git://www.denx.de/git/u-boot-imx (2016-02-21 
> 07:56:16 -0500)
> 
> are available in the git repository at:
> 
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 674f3609aad39f099a5c3605643a6be124504b96:
> 
>   spi: spi-uclass: Set slave wordlen with SPI_DEFAULT_WORDLEN (2016-02-23 
> 16:14:46 +0530)
> 

Applied to u-boot/master, thanks!

Mugunthan, can you please test QSPI boot on J6 or J6Eco?  My board isn't
behaving well and I couldn't walk Nishanth through doing it on his (or,
there's a problem..).  Thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Wed, Jan 13, 2016 at 08:16:41PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR - this sent intially before the release.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 077678eb0c226e52a1f90edabd3369ab26065b32:
> 
>   Merge git://git.denx.de/u-boot-dm (2016-01-12 18:12:42 -0500)
> 
> are available in the git repository at:
> 
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 69b41388ba45b853b3538f5b8cac8ab2154d36d8:
> 
>   dm: core: Add a new api to get indexed device address (2016-01-13 18:54:22 
> +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Thu, Jan 07, 2016 at 10:32:08PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 78680314c53a95c0bb25e942662979843b60d7b9:
> 
>   Merge branch 'master' of http://git.denx.de/u-boot-sunxi (2015-12-27 
> 09:15:57 -0500)
> 
> are available in the git repository at:
> 
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 8770413f380d07439bc9ad60c6b4d108d5a9adf0:
> 
>   spi: fsl_qspi: fix an error of using GENMASK (2016-01-07 20:29:33 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Fri, Dec 11, 2015 at 10:23:06PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 789fa275b3750e60c60cb3d18eabc9467892c257:
> 
>   x86: Remove HAVE_ACPI_RESUME (2015-12-09 17:44:56 +0800)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 76de51a6da0411e1f3e80e1c9a2ef5bfa8e35571:
> 
>   spi: xilinx: Add new compatible strings (2015-12-11 22:12:24 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Thu, Nov 19, 2015 at 11:16:40PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 3d4825446e4258192e1f2302d691a8c0c82a0975:
> 
>   Prepare v2016.01-rc1 (2015-11-16 20:29:51 -0500)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 3e56ecec435d30e25fcffb971f8c9627e85ac1df:
> 
>   sf: Correct flash->flags for SST flash (2015-11-18 12:52:05 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Jagan Teki]

On 28 October 2015 at 23:55, Otavio Salvador
 wrote:
> On Wed, Oct 28, 2015 at 4:22 PM, Jagan Teki  wrote:
>> Please pull this PR, and skip the previous one [1]
>>
>> [1] https://patchwork.ozlabs.org/patch/535548/
>
> What about Fabio's serie? it is required for the Congatec support to
> go in as well.

Next TODO!

thanks!
-- 
Jagan | openedev.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Otavio Salvador]

On Wed, Oct 28, 2015 at 4:22 PM, Jagan Teki  wrote:
> Please pull this PR, and skip the previous one [1]
>
> [1] https://patchwork.ozlabs.org/patch/535548/

What about Fabio's serie? it is required for the Congatec support to
go in as well.

-- 
Otavio Salvador O.S. Systems
http://www.ossystems.com.brhttp://code.ossystems.com.br
Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull request: u-boot-spi/master

[Tom Rini]

On Wed, Oct 28, 2015 at 11:52:15PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR, and skip the previous one [1]
> 
> [1] https://patchwork.ozlabs.org/patch/535548/
> 
> thanks!
> Jagan.
> 
> The following changes since commit 677f970bc62a661690b3431543d5a5d5e682ba70:
> 
>   common/board_f.c: modify the macro to use get_clocks() more common 
> (2015-10-24 13:50:38 -0400)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to bef87adf95e7ca923f866e27bbcccb2dad85df9f:
> 
>   spi: altera_spi: Minor cleanup (2015-10-28 13:54:09 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull-request: u-boot-spi/master

[Tom Rini]

On Sun, Oct 11, 2015 at 04:52:08PM +0530, Jagan Teki wrote:

> Hi Tom,
> 
> Please pull this PR.
> 
> thanks!
> Jagan.
> 
> The following changes since commit 9a4c6e9abf5261f565cfbf1e80c6e17d26ad0b1e:
> 
>   sunxi: Fix USB regulators in Linksprite_pcDuino_defconfig (2015-10-10 
> 11:54:16 +0200)
> 
> are available in the git repository at:
> 
>   git://git.denx.de/u-boot-spi.git master
> 
> for you to fetch changes up to 03d1d568a04b3d67e0f09b598554c2b74e31224f:
> 
>   configs: ls1021atwr: Enable DSPI for LS1021ATWR (2015-10-11 16:43:06 +0530)
> 

Applied to u-boot/master, thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull-request: u-boot-spi/master

[Jagan Teki]

On 9 October 2015 at 19:25, Michal Simek  wrote:
> Hi Tom,
>
> On 10/09/2015 03:54 PM, Tom Rini wrote:
>> On Fri, Oct 09, 2015 at 03:47:59PM +0200, Michal Simek wrote:
>>> Hi Jagan,
>>>
>>> On 09/30/2015 12:23 AM, Michal Simek wrote:
 On 09/29/2015 11:13 PM, Jagan Teki wrote:
> On 21 September 2015 at 23:56, Jagan Teki  wrote:
>> Hi Michal,
>>
>> On 19 September 2015 at 06:38, Michal Simek  
>> wrote:
>>> On 09/19/2015 02:55 AM, Michal Simek wrote:
 On 09/16/2015 09:20 AM, Jagan Teki wrote:
> Hi Michal,
>
> On 15 September 2015 at 18:58, Simon Glass  wrote:
>> Hi Jagan,
>>
>> On 15 September 2015 at 02:13, Jagan Teki  wrote:
>>> Hi Tom,
>>>
>>> Zynq patches has SPL build dependency with Simon changes [1].
>>>
>>> Simon, Any plan to send a PR for your changes.
>>>
>>> [1] 
>>> http://git.denx.de/?p=u-boot/u-boot-dm.git;a=shortlog;h=refs/heads/zynq-working
>>
>> These are for the zynq maintainer I think. They are not assigned to 
>> me
>> in patchwork.
>
> Seems like this patch[1] resolves the SPL build issue, any plan on
> pushing this? of-course I will test this and let you know.
>
>
> [1] 
> http://git.denx.de/?p=u-boot/u-boot-dm.git;a=commitdiff;h=7916a8cf902177afd20a09527a9cf307622bb6d2

 Simon: Are you going to push it? Or do you want me to collect all of
 these zynq/zynqmp patches?
>>>
>>> Sorry I have read Simon's reaction after. I will try to collect all
>>> these zynq patches and will send pull request.
>>
>> Please send your PR on top of these changes, and let me know for any 
>> inputs.
>
> Seems like Michal is busy with something, Shall I go with build fix
> (not sure whether it's working SPI-SPL or not)

 Next week I will look at it.
>>>
>>> All your patches will go on the top of zynq/zynqmp patches and the merge
>>> will happen after 2015.10.
>>> Is there any particular reason to push these changes before 2015.10?
>>
>> I had/have been holding this for after the merge window.  If there are
>> any release-critical fixes in the SPI tree they need to be put into a
>> separate pull request asap.  Thanks!
>
> Good. I was talking to Simon yesterday and retest zynq and zynqmp SPL DM
> changes which should go first to your tree and then these spi changes
> should go on the top.

No hurry with the zynq qspi patches for this release, will send the PR
again after release.
Meanwhile, I sent one more for this release [1], pls- pull the same.

[1] https://patchwork.ozlabs.org/patch/528729/

--  Jagan.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull-request: u-boot-spi/master

[Michal Simek]

Hi Tom,

On 10/09/2015 03:54 PM, Tom Rini wrote:
> On Fri, Oct 09, 2015 at 03:47:59PM +0200, Michal Simek wrote:
>> Hi Jagan,
>>
>> On 09/30/2015 12:23 AM, Michal Simek wrote:
>>> On 09/29/2015 11:13 PM, Jagan Teki wrote:
 On 21 September 2015 at 23:56, Jagan Teki  wrote:
> Hi Michal,
>
> On 19 September 2015 at 06:38, Michal Simek  
> wrote:
>> On 09/19/2015 02:55 AM, Michal Simek wrote:
>>> On 09/16/2015 09:20 AM, Jagan Teki wrote:
 Hi Michal,

 On 15 September 2015 at 18:58, Simon Glass  wrote:
> Hi Jagan,
>
> On 15 September 2015 at 02:13, Jagan Teki  wrote:
>> Hi Tom,
>>
>> Zynq patches has SPL build dependency with Simon changes [1].
>>
>> Simon, Any plan to send a PR for your changes.
>>
>> [1] 
>> http://git.denx.de/?p=u-boot/u-boot-dm.git;a=shortlog;h=refs/heads/zynq-working
>
> These are for the zynq maintainer I think. They are not assigned to me
> in patchwork.

 Seems like this patch[1] resolves the SPL build issue, any plan on
 pushing this? of-course I will test this and let you know.


 [1] 
 http://git.denx.de/?p=u-boot/u-boot-dm.git;a=commitdiff;h=7916a8cf902177afd20a09527a9cf307622bb6d2
>>>
>>> Simon: Are you going to push it? Or do you want me to collect all of
>>> these zynq/zynqmp patches?
>>
>> Sorry I have read Simon's reaction after. I will try to collect all
>> these zynq patches and will send pull request.
>
> Please send your PR on top of these changes, and let me know for any 
> inputs.

 Seems like Michal is busy with something, Shall I go with build fix
 (not sure whether it's working SPI-SPL or not)
>>>
>>> Next week I will look at it.
>>
>> All your patches will go on the top of zynq/zynqmp patches and the merge
>> will happen after 2015.10.
>> Is there any particular reason to push these changes before 2015.10?
> 
> I had/have been holding this for after the merge window.  If there are
> any release-critical fixes in the SPI tree they need to be put into a
> separate pull request asap.  Thanks!

Good. I was talking to Simon yesterday and retest zynq and zynqmp SPL DM
changes which should go first to your tree and then these spi changes
should go on the top.

Thanks,
Michal



___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull-request: u-boot-spi/master

[Tom Rini]

On Fri, Oct 09, 2015 at 03:47:59PM +0200, Michal Simek wrote:
> Hi Jagan,
> 
> On 09/30/2015 12:23 AM, Michal Simek wrote:
> > On 09/29/2015 11:13 PM, Jagan Teki wrote:
> >> On 21 September 2015 at 23:56, Jagan Teki  wrote:
> >>> Hi Michal,
> >>>
> >>> On 19 September 2015 at 06:38, Michal Simek  
> >>> wrote:
>  On 09/19/2015 02:55 AM, Michal Simek wrote:
> > On 09/16/2015 09:20 AM, Jagan Teki wrote:
> >> Hi Michal,
> >>
> >> On 15 September 2015 at 18:58, Simon Glass  wrote:
> >>> Hi Jagan,
> >>>
> >>> On 15 September 2015 at 02:13, Jagan Teki  wrote:
>  Hi Tom,
> 
>  Zynq patches has SPL build dependency with Simon changes [1].
> 
>  Simon, Any plan to send a PR for your changes.
> 
>  [1] 
>  http://git.denx.de/?p=u-boot/u-boot-dm.git;a=shortlog;h=refs/heads/zynq-working
> >>>
> >>> These are for the zynq maintainer I think. They are not assigned to me
> >>> in patchwork.
> >>
> >> Seems like this patch[1] resolves the SPL build issue, any plan on
> >> pushing this? of-course I will test this and let you know.
> >>
> >>
> >> [1] 
> >> http://git.denx.de/?p=u-boot/u-boot-dm.git;a=commitdiff;h=7916a8cf902177afd20a09527a9cf307622bb6d2
> >
> > Simon: Are you going to push it? Or do you want me to collect all of
> > these zynq/zynqmp patches?
> 
>  Sorry I have read Simon's reaction after. I will try to collect all
>  these zynq patches and will send pull request.
> >>>
> >>> Please send your PR on top of these changes, and let me know for any 
> >>> inputs.
> >>
> >> Seems like Michal is busy with something, Shall I go with build fix
> >> (not sure whether it's working SPI-SPL or not)
> > 
> > Next week I will look at it.
> 
> All your patches will go on the top of zynq/zynqmp patches and the merge
> will happen after 2015.10.
> Is there any particular reason to push these changes before 2015.10?

I had/have been holding this for after the merge window.  If there are
any release-critical fixes in the SPI tree they need to be put into a
separate pull request asap.  Thanks!

-- 
Tom


signature.asc
Description: Digital signature
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] Pull-request: u-boot-spi/master

[Michal Simek]

Hi Jagan,

On 09/30/2015 12:23 AM, Michal Simek wrote:
> On 09/29/2015 11:13 PM, Jagan Teki wrote:
>> On 21 September 2015 at 23:56, Jagan Teki  wrote:
>>> Hi Michal,
>>>
>>> On 19 September 2015 at 06:38, Michal Simek  wrote:
 On 09/19/2015 02:55 AM, Michal Simek wrote:
> On 09/16/2015 09:20 AM, Jagan Teki wrote:
>> Hi Michal,
>>
>> On 15 September 2015 at 18:58, Simon Glass  wrote:
>>> Hi Jagan,
>>>
>>> On 15 September 2015 at 02:13, Jagan Teki  wrote:
 Hi Tom,

 Zynq patches has SPL build dependency with Simon changes [1].

 Simon, Any plan to send a PR for your changes.

 [1] 
 http://git.denx.de/?p=u-boot/u-boot-dm.git;a=shortlog;h=refs/heads/zynq-working
>>>
>>> These are for the zynq maintainer I think. They are not assigned to me
>>> in patchwork.
>>
>> Seems like this patch[1] resolves the SPL build issue, any plan on
>> pushing this? of-course I will test this and let you know.
>>
>>
>> [1] 
>> http://git.denx.de/?p=u-boot/u-boot-dm.git;a=commitdiff;h=7916a8cf902177afd20a09527a9cf307622bb6d2
>
> Simon: Are you going to push it? Or do you want me to collect all of
> these zynq/zynqmp patches?

 Sorry I have read Simon's reaction after. I will try to collect all
 these zynq patches and will send pull request.
>>>
>>> Please send your PR on top of these changes, and let me know for any inputs.
>>
>> Seems like Michal is busy with something, Shall I go with build fix
>> (not sure whether it's working SPI-SPL or not)
> 
> Next week I will look at it.

All your patches will go on the top of zynq/zynqmp patches and the merge
will happen after 2015.10.
Is there any particular reason to push these changes before 2015.10?

Thanks,
Michal


___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot