Re: DM_MMC, BLK
On Thu, Feb 25, 2021 at 06:47:55PM +0100, Heinrich Schuchardt wrote: > On 2/24/21 10:32 PM, Tom Rini wrote: > > On Wed, Feb 24, 2021 at 10:28:31PM +0100, Heinrich Schuchardt wrote: > > > > > Hello Tom, > > > > > > migrating to CONFIG_DM_MMC was scheduled for release v2019.04. But some > > > board maintainers simply don't care. > > > > > > We have quite a lot of boards like cm_t335, draco, etamin, rastaban, > > > thuban, pxm2, vinco which compile when setting CONFIG_DM_MMC and > > > CONFIG_BLK. > > > > > > Shall we switch all boards that compile with these settings? > > > > Please see > > https://patchwork.ozlabs.org/project/uboot/list/?series=230325 > > There are other parts concerning block devices needing clean up. E.g the > usage of HAVE_BLOCK_DEVICE in disk/. > > Having all these changes collected in a next branch would be helpful. I've got various rebasing branches up with these removals (and some temporary merges) currently under WIP/make-DM_xxx-fatal. I will be opening next fairly soon. -- Tom signature.asc Description: PGP signature
Re: DM_MMC, BLK
On 2/24/21 10:32 PM, Tom Rini wrote: On Wed, Feb 24, 2021 at 10:28:31PM +0100, Heinrich Schuchardt wrote: Hello Tom, migrating to CONFIG_DM_MMC was scheduled for release v2019.04. But some board maintainers simply don't care. We have quite a lot of boards like cm_t335, draco, etamin, rastaban, thuban, pxm2, vinco which compile when setting CONFIG_DM_MMC and CONFIG_BLK. Shall we switch all boards that compile with these settings? Please see https://patchwork.ozlabs.org/project/uboot/list/?series=230325 There are other parts concerning block devices needing clean up. E.g the usage of HAVE_BLOCK_DEVICE in disk/. Having all these changes collected in a next branch would be helpful. Best regards Heinrich And there's a follow-up for MVSATA/IDE stuff. I've started but haven't finished yet one for DM_PCI, but did post more removals on top of that.
Re: DM_MMC, BLK
Hi Heinrich, On Wed, 24 Feb 2021 at 17:15, Heinrich Schuchardt wrote: > > On 24.02.21 22:32, Tom Rini wrote: > > On Wed, Feb 24, 2021 at 10:28:31PM +0100, Heinrich Schuchardt wrote: > > > >> Hello Tom, > >> > >> migrating to CONFIG_DM_MMC was scheduled for release v2019.04. But some > >> board maintainers simply don't care. > >> > >> We have quite a lot of boards like cm_t335, draco, etamin, rastaban, > >> thuban, pxm2, vinco which compile when setting CONFIG_DM_MMC and > >> CONFIG_BLK. > >> > >> Shall we switch all boards that compile with these settings? > > > > Please see > > https://patchwork.ozlabs.org/project/uboot/list/?series=230325 > > Thank you for the link. > > I tend to let EFI_LOADER depend on BLK. This will allow to remove legacy > code in the UEFI sub-system. As mentioned on the contributor call, I did push for that at the time. I strongly support doing it now. Regards, Simon
Re: DM_MMC, BLK
On 24.02.21 22:32, Tom Rini wrote: > On Wed, Feb 24, 2021 at 10:28:31PM +0100, Heinrich Schuchardt wrote: > >> Hello Tom, >> >> migrating to CONFIG_DM_MMC was scheduled for release v2019.04. But some >> board maintainers simply don't care. >> >> We have quite a lot of boards like cm_t335, draco, etamin, rastaban, >> thuban, pxm2, vinco which compile when setting CONFIG_DM_MMC and CONFIG_BLK. >> >> Shall we switch all boards that compile with these settings? > > Please see > https://patchwork.ozlabs.org/project/uboot/list/?series=230325 Thank you for the link. I tend to let EFI_LOADER depend on BLK. This will allow to remove legacy code in the UEFI sub-system. Best regards Heinrich > > And there's a follow-up for MVSATA/IDE stuff. I've started but haven't > finished yet one for DM_PCI, but did post more removals on top of that. >
Re: DM_MMC, BLK
On Wed, Feb 24, 2021 at 10:28:31PM +0100, Heinrich Schuchardt wrote: > Hello Tom, > > migrating to CONFIG_DM_MMC was scheduled for release v2019.04. But some > board maintainers simply don't care. > > We have quite a lot of boards like cm_t335, draco, etamin, rastaban, > thuban, pxm2, vinco which compile when setting CONFIG_DM_MMC and CONFIG_BLK. > > Shall we switch all boards that compile with these settings? Please see https://patchwork.ozlabs.org/project/uboot/list/?series=230325 And there's a follow-up for MVSATA/IDE stuff. I've started but haven't finished yet one for DM_PCI, but did post more removals on top of that. -- Tom signature.asc Description: PGP signature
