Re: rockpro64: Enable HDMI output

2020-05-21 Thread Kever Yang

Hi Marcin,

    Please add Signed-off-by in the commit message and prefix with 
'rockchip'


at the subject.


Thanks,

- Kever

On 2020/5/15 下午3:30, Marcin Juszkiewicz wrote:

Enable config options and console setting like on other rk3399 boards.

---
  configs/rockpro64-rk3399_defconfig | 4 
  include/configs/rockpro64_rk3399.h | 5 +
  2 files changed, 9 insertions(+)

diff --git configs/rockpro64-rk3399_defconfig
configs/rockpro64-rk3399_defconfig
index 8074e4665a..c815cc646d 100644
--- configs/rockpro64-rk3399_defconfig
+++ configs/rockpro64-rk3399_defconfig
@@ -58,5 +58,9 @@ CONFIG_USB_ETHER_ASIX88179=y
  CONFIG_USB_ETHER_MCS7830=y
  CONFIG_USB_ETHER_RTL8152=y
  CONFIG_USB_ETHER_SMSC95XX=y
+CONFIG_DM_VIDEO=y
+CONFIG_DISPLAY=y
+CONFIG_VIDEO_ROCKCHIP=y
+CONFIG_DISPLAY_ROCKCHIP_HDMI=y
  CONFIG_SPL_TINY_MEMSET=y
  CONFIG_ERRNO_STR=y
diff --git include/configs/rockpro64_rk3399.h
include/configs/rockpro64_rk3399.h
index 5f52c1e4f6..8e82131762 100644
--- include/configs/rockpro64_rk3399.h
+++ include/configs/rockpro64_rk3399.h
@@ -6,6 +6,11 @@
  #ifndef __ROCKPRO64_RK3399_H
  #define __ROCKPRO64_RK3399_H

+#define ROCKCHIP_DEVICE_SETTINGS \
+   "stdin=serial,usbkbd\0" \
+   "stdout=serial,vidconsole\0" \
+   "stderr=serial,vidconsole\0"
+
  #include 

  #define CONFIG_SYS_MMC_ENV_DEV 0





Re: rockpro64: Enable HDMI output

2020-05-19 Thread Anand Moon








On Friday, May 15, 2020, 5:28:36 PM GMT+5:30, Marcin Juszkiewicz 
 wrote: 





Enable config options and console setting like on other rk3399 boards.

---
configs/rockpro64-rk3399_defconfig | 4 
include/configs/rockpro64_rk3399.h | 5 +
2 files changed, 9 insertions(+)

diff --git configs/rockpro64-rk3399_defconfig
configs/rockpro64-rk3399_defconfig
index 8074e4665a..c815cc646d 100644
--- configs/rockpro64-rk3399_defconfig
+++ configs/rockpro64-rk3399_defconfig
@@ -58,5 +58,9 @@ CONFIG_USB_ETHER_ASIX88179=y
CONFIG_USB_ETHER_MCS7830=y
CONFIG_USB_ETHER_RTL8152=y
CONFIG_USB_ETHER_SMSC95XX=y
+CONFIG_DM_VIDEO=y
+CONFIG_DISPLAY=y
+CONFIG_VIDEO_ROCKCHIP=y
+CONFIG_DISPLAY_ROCKCHIP_HDMI=y
CONFIG_SPL_TINY_MEMSET=y
CONFIG_ERRNO_STR=y
diff --git include/configs/rockpro64_rk3399.h
include/configs/rockpro64_rk3399.h
index 5f52c1e4f6..8e82131762 100644
--- include/configs/rockpro64_rk3399.h
+++ include/configs/rockpro64_rk3399.h
@@ -6,6 +6,11 @@
#ifndef __ROCKPRO64_RK3399_H
#define __ROCKPRO64_RK3399_H

+#define ROCKCHIP_DEVICE_SETTINGS \
+        "stdin=serial,usbkbd\0" \
+        "stdout=serial,vidconsole\0" \
+        "stderr=serial,vidconsole\0"
+
#include 

#define CONFIG_SYS_MMC_ENV_DEV 0
-- 
2.26.2