Re: v2023.01: u-boot-tools build failure
Hi Vagrant,
On Fri, Jan 13, 2023 at 8:37 PM Vagrant Cascadian wrote:
> FWIW, we have not shipped bmp_logo in Debian's u-boot-tools package, so
> we have managed without it, though curious what the use-case might be.
>
> It is disabled in Debian for now:
>
>
> https://salsa.debian.org/debian/u-boot/-/blob/debian/2023.01+dfsg-1/debian/patches/tools-disable-video-logo
>
> ... at least until a better fix comes along. :)
Thanks for sharing your input.
Peter,
Commit 1cfba53ca46c ("config: tools only: add VIDEO to build
bmp_logo") is causing issues
on Debian and OpenEmbedded.
How do you suggest we proceed?
Thanks
Re: v2023.01: u-boot-tools build failure
On 2023-01-13, Tom Rini wrote: > On Fri, Jan 13, 2023 at 06:26:00PM -0300, Fabio Estevam wrote: >> I am trying to upgrade U-Boot to 2023.01 in OpenEmbedded, but I see >> the following error when trying to build u-boot-tools: >> >> | /bin/sh: line 1: tools/bmp_logo: No such file or directory >> >> Reverting the commit below makes u-boot-tools build again: >> >> commit 1cfba53ca46cade2dbf4e067afc8c19e72909a4b >> Author: Peter Robinson >> Date: Thu Nov 24 14:05:59 2022 + >> >> config: tools only: add VIDEO to build bmp_logo >> >> Pre 2023.01 the bmp_logo was built as part of the tools-only_defconfig >> build, something changed and the VIDEO dep needed to build it >> is no longer pulled in so fix that by explicitly defining it. >> >> Signed-off-by: Peter Robinson >> Reviewed-by: Simon Glass >> >> u-boot-tools-native builds fine though. >> >> What would be the correct way to fix this? > > Vagrant also hit this for Debian as Fedora cross-builds bmp_logo and > ships it in host tools, but the logo header files that we generate with > bmp_logo need the tool host built. And the same flag, VIDEO_LOGO > (default y if VIDEO, basically) controls both the tool and the headers. > I think the first thing to figure out is if bmp_logo should be shipped > as a host tool, or not. FWIW, we have not shipped bmp_logo in Debian's u-boot-tools package, so we have managed without it, though curious what the use-case might be. It is disabled in Debian for now: https://salsa.debian.org/debian/u-boot/-/blob/debian/2023.01+dfsg-1/debian/patches/tools-disable-video-logo ... at least until a better fix comes along. :) live well, vagrant signature.asc Description: PGP signature
Re: v2023.01: u-boot-tools build failure
On Fri, Jan 13, 2023 at 06:26:00PM -0300, Fabio Estevam wrote: > Hi, > > I am trying to upgrade U-Boot to 2023.01 in OpenEmbedded, but I see > the following error when trying to build u-boot-tools: > > | /bin/sh: line 1: tools/bmp_logo: No such file or directory > > Reverting the commit below makes u-boot-tools build again: > > commit 1cfba53ca46cade2dbf4e067afc8c19e72909a4b > Author: Peter Robinson > Date: Thu Nov 24 14:05:59 2022 + > > config: tools only: add VIDEO to build bmp_logo > > Pre 2023.01 the bmp_logo was built as part of the tools-only_defconfig > build, something changed and the VIDEO dep needed to build it > is no longer pulled in so fix that by explicitly defining it. > > Signed-off-by: Peter Robinson > Reviewed-by: Simon Glass > > u-boot-tools-native builds fine though. > > What would be the correct way to fix this? Vagrant also hit this for Debian as Fedora cross-builds bmp_logo and ships it in host tools, but the logo header files that we generate with bmp_logo need the tool host built. And the same flag, VIDEO_LOGO (default y if VIDEO, basically) controls both the tool and the headers. I think the first thing to figure out is if bmp_logo should be shipped as a host tool, or not. -- Tom signature.asc Description: PGP signature
v2023.01: u-boot-tools build failure
Hi, I am trying to upgrade U-Boot to 2023.01 in OpenEmbedded, but I see the following error when trying to build u-boot-tools: | /bin/sh: line 1: tools/bmp_logo: No such file or directory Reverting the commit below makes u-boot-tools build again: commit 1cfba53ca46cade2dbf4e067afc8c19e72909a4b Author: Peter Robinson Date: Thu Nov 24 14:05:59 2022 + config: tools only: add VIDEO to build bmp_logo Pre 2023.01 the bmp_logo was built as part of the tools-only_defconfig build, something changed and the VIDEO dep needed to build it is no longer pulled in so fix that by explicitly defining it. Signed-off-by: Peter Robinson Reviewed-by: Simon Glass u-boot-tools-native builds fine though. What would be the correct way to fix this? Thanks, Fabio Estevam
