Re: [U-Boot-Users] [PATCH] (Resubmit) ADD ARM AMBA PL031 RTCSupport

2008-07-21 Thread Gururaja Hebbar K R
Hi j,
 
Could you please reply so that i can submit a reformatted patch if
required.

  First your patch is line wrapped by your mailler.
That's why i had also attached the respective patch file. that i
generated using git-diff command.

  Secondly please be care ful of the 80 chars limits and the
  whitespace.
Regarding the white space, i am little confused abt this as i couldn't
find it in my patch. 
can u please let me know where it exists.


  Are you going to add a board which will use it?
Right now i am using it on arm Versatile board. Should i send a patch to
that also


Also,

I used below command to generate the diff. 
It says that 31 files have changed in this directory whereas only 1
files is changed and 1 file is added. 
Kindly help me to correct the same. Right now i have manually changed it
in the patch file.

$ git-diff -p   --summary --stat   u-boot-1.3.3/drivers/rtc/
uboot/drivers/rtc/

Regards
Gururaja



Signed off by: Gururaja Hebbar [EMAIL PROTECTED] 

- Add support to the ARM AMBA PL031 RTC Chip. 
- remove the call to rtc_init from lib_arm/board.c boot sequence as per
wd advice.
- check for pl031 rtc initialization. Initialize if it hasnt yet. 

 {u-boot-1.3.3 = uboot}/drivers/rtc/Makefile  |1 +
 /dev/null = uboot/drivers/rtc/rtc_pl031.c|  121
+
 2 files changed, 122 insertions(+), 0 deletions(-)
 create mode 100644 uboot/drivers/rtc/rtc_pl031.c

diff --git a/u-boot-1.3.3/drivers/rtc/Makefile
b/uboot/drivers/rtc/Makefile
index 2e0c118..f888a31 100644
--- a/u-boot-1.3.3/drivers/rtc/Makefile
+++ b/uboot/drivers/rtc/Makefile
@@ -56,6 +56,7 @@ COBJS-y += rs5c372.o
 COBJS-y += rx8025.o
 COBJS-y += s3c24x0_rtc.o
 COBJS-y += x1205.o
+COBJS-y += rtc_pl031.o
 
 COBJS  := $(COBJS-y)
 SRCS   := $(COBJS:.o=.c)
diff --git a/dev/null b/uboot/drivers/rtc/rtc_pl031.c
new file mode 100644
index 000..77b550b
--- /dev/null
+++ b/uboot/drivers/rtc/rtc_pl031.c
@@ -0,0 +1,121 @@
+/*
+ * (C) Copyright 2008
+ * Gururaja Hebbar [EMAIL PROTECTED]
+ *
+ * reference linux-2.6.20.6/drivers/rtc/rtc-pl031.c 
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include common.h
+#include command.h
+#include rtc.h
+
+#if defined(CONFIG_RTC_PL031)  defined(CONFIG_CMD_DATE)
+
+#ifndef CFG_RTC_PL031_BASE
+#error CFG_RTC_PL031_BASE is not defined!
+#endif
+
+/*
+ * Register definitions
+ */
+#defineRTC_DR  0x00/* Data read register */
+#defineRTC_MR  0x04/* Match register */
+#defineRTC_LR  0x08/* Data load register */
+#defineRTC_CR  0x0c/* Control register */
+#defineRTC_IMSC0x10/* Interrupt mask and set
register */
+#defineRTC_RIS 0x14/* Raw interrupt status register
*/
+#defineRTC_MIS 0x18/* Masked interrupt status
register */
+#defineRTC_ICR 0x1c/* Interrupt clear register */
+
+#define RTC_CR_MIE (1  0)
+
+#defineRTC_WRITE_REG(addr, val)(*(volatile unsigned int
*)(CFG_RTC_PL031_BASE + (addr)) = (val))
+#defineRTC_READ_REG(addr)  (*(volatile unsigned int
*)(CFG_RTC_PL031_BASE + (addr)))
+
+static int pl031_initted = 0;
+
+/* Enable RTC Start in Control register*/
+void rtc_init(void)
+{
+   RTC_WRITE_REG(RTC_CR,RTC_CR_MIE);
+   
+   pl031_initted = 1;
+}
+
+/*
+ * Reset the RTC. We set the date back to 1970-01-01.
+ */
+void rtc_reset(void)
+{
+   RTC_WRITE_REG(RTC_LR,0x00);
+   if(!pl031_initted)
+   rtc_init();
+}
+
+/*
+ * Set the RTC
+*/
+void rtc_set(struct rtc_time *tmp)
+{
+   unsigned long tim;
+   
+   if(!pl031_initted)
+   rtc_init();
+
+   if (tmp == NULL) {
+   puts(Error setting the date/time\n);
+   return;
+   }
+   
+   /* Calculate number of seconds this incoming time represents */
+   tim = mktime(tmp-tm_year, tmp-tm_mon, tmp-tm_mday,
+   tmp-tm_hour, tmp-tm_min, tmp-tm_sec);
+
+   RTC_WRITE_REG(RTC_LR,tim);
+}
+
+/*
+ * Get the current time from the RTC
+ */
+int rtc_get(struct rtc_time *tmp)
+{
+   ulong tim;
+   
+   if(!pl031_initted)
+   

Re: [U-Boot-Users] [PATCH] (Resubmit) ADD ARM AMBA PL031 RTCSupport

2008-07-21 Thread Gururaja Hebbar K R
Hi,

 Are you going to add a board which will use it?
  Right now i am using it on arm Versatile board. Should i send a
patch 
  to that also

 If you do I can test it 

 Regards
 Peter


Please find attached my changes to arm versatile config  board file to
enable rtc module
This is for test only. If you find it acceptable then i will send a
final patch.

Comments are welcome.

TIA

Regards
Gururaja


update_versatile_config_to_include_pl031_rtc_module.patch
Description: update_versatile_config_to_include_pl031_rtc_module.patch


add_pl031_rtc_init_func.patch
Description: add_pl031_rtc_init_func.patch
-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] (Resubmit) ADD ARM AMBA PL031 RTCSupport

2008-07-21 Thread Jean-Christophe PLAGNIOL-VILLARD
On 13:34 Mon 21 Jul , Gururaja Hebbar K R wrote:
 Hi,
 
Are you going to add a board which will use it?
   Right now i am using it on arm Versatile board. Should i send a
 patch 
   to that also
 
  If you do I can test it 
 
  Regards
  Peter
 
Could you please send your patch as inline, otherwise it's really
difficult to comment
use git-send-email as example

and also please read this http://www.denx.de/wiki/UBoot/Patches
and http://lwn.net/Articles/139918/

Best Regads,
J.

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] (Resubmit) ADD ARM AMBA PL031 RTCSupport

2008-07-17 Thread Gururaja Hebbar K R
From: Jean-Christophe PLAGNIOL-VILLARD
Subject: Re: [U-Boot-Users] [PATCH] (Resubmit) ADD ARM AMBA PL031
RTCSupport

Hi,
Hello

  First your patch is line wrapped by your mailler.
That's why i had also attached the respective patch file. that i
generated using git-diff command.

  Secondly please be care ful of the 80 chars limits and the
  whitespace.
Regarding the white space, i am little confused abt this as i couldn't
find it in my patch. 
can u please let me know where it exists.


  Are you going to add a board which will use it?
Right now i am using it on arm Versatile board. Should i send a patch to
that also

Regards
Gururaja



-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users