[U-Boot-Users] [PATCH] drivers/serial: Move conditional compilation to Makefile for CONFIG_* macros

2008-08-02 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]
---
Need to build nios2

I've prefer to move conditional compilation to Makefile instead of
you move an include in xuartlite. Which is not related to nios2.

I've choose to only move the CONFIG_ and merge the CFG_ in a second step during 
the next merge
 drivers/serial/Makefile   |   12 ++--
 drivers/serial/atmel_usart.c  |3 ---
 drivers/serial/mcfuart.c  |3 ---
 drivers/serial/s3c4510b_uart.c|4 
 drivers/serial/serial_max3100.c   |4 
 drivers/serial/serial_xuartlite.c |4 
 drivers/serial/usbtty.c   |5 -
 7 files changed, 6 insertions(+), 29 deletions(-)

diff --git a/drivers/serial/Makefile b/drivers/serial/Makefile
index c9e797e..de6fbab 100644
--- a/drivers/serial/Makefile
+++ b/drivers/serial/Makefile
@@ -25,18 +25,18 @@ include $(TOPDIR)/config.mk
 
 LIB:= $(obj)libserial.a
 
-COBJS-y += atmel_usart.o
-COBJS-y += mcfuart.o
+COBJS-$(CONFIG_ATMEL_USART) += atmel_usart.o
+COBJS-$(CONFIG_MCFUART) += mcfuart.o
 COBJS-y += ns9750_serial.o
 COBJS-y += ns16550.o
-COBJS-y += s3c4510b_uart.o
+COBJS-$(CONFIG_DRIVER_S3C4510_UART) += s3c4510b_uart.o
 COBJS-y += serial.o
-COBJS-y += serial_max3100.o
+COBJS-$(CONFIG_MAX3100_SERIAL) += serial_max3100.o
 COBJS-y += serial_pl010.o
 COBJS-y += serial_pl011.o
-COBJS-y += serial_xuartlite.o
+COBJS-$(CONFIG_XILINX_UARTLITE) += serial_xuartlite.o
 COBJS-y += serial_sh.o
-COBJS-y += usbtty.o
+COBJS-$(CONFIG_USB_TTY) += usbtty.o
 
 COBJS  := $(COBJS-y)
 SRCS   := $(COBJS:.o=.c)
diff --git a/drivers/serial/atmel_usart.c b/drivers/serial/atmel_usart.c
index f35b997..f3b146c 100644
--- a/drivers/serial/atmel_usart.c
+++ b/drivers/serial/atmel_usart.c
@@ -17,7 +17,6 @@
  */
 #include common.h
 
-#ifdef CONFIG_ATMEL_USART
 #include asm/io.h
 #include asm/arch/clk.h
 #include asm/arch/memory-map.h
@@ -96,5 +95,3 @@ int serial_tstc(void)
 {
return (usart3_readl(CSR)  USART3_BIT(RXRDY)) != 0;
 }
-
-#endif /* CONFIG_ATMEL_USART */
diff --git a/drivers/serial/mcfuart.c b/drivers/serial/mcfuart.c
index 5eb4f45..a1fcd05 100644
--- a/drivers/serial/mcfuart.c
+++ b/drivers/serial/mcfuart.c
@@ -29,8 +29,6 @@
 
 #include common.h
 
-#ifdef CONFIG_MCFUART
-
 #include asm/immap.h
 #include asm/uart.h
 
@@ -130,4 +128,3 @@ void serial_setbrg(void)
 
uart-ucr = UART_UCR_RX_ENABLED | UART_UCR_TX_ENABLED;
 }
-#endif /* CONFIG_MCFUART */
diff --git a/drivers/serial/s3c4510b_uart.c b/drivers/serial/s3c4510b_uart.c
index ddcd591..aa378e1 100644
--- a/drivers/serial/s3c4510b_uart.c
+++ b/drivers/serial/s3c4510b_uart.c
@@ -45,8 +45,6 @@
 
 #include common.h
 
-#ifdef CONFIG_DRIVER_S3C4510_UART
-
 #include asm/hardware.h
 #include s3c4510b_uart.h
 
@@ -212,5 +210,3 @@ void serial_puts (const char *s)
uart-m_ctrl.bf.sendBreak = 0;
 
 }
-
-#endif
diff --git a/drivers/serial/serial_max3100.c b/drivers/serial/serial_max3100.c
index 0611fc1..4abc271 100644
--- a/drivers/serial/serial_max3100.c
+++ b/drivers/serial/serial_max3100.c
@@ -26,8 +26,6 @@
 #include common.h
 #include watchdog.h
 
-#ifdef CONFIG_MAX3100_SERIAL
-
 DECLARE_GLOBAL_DATA_PTR;
 
 /**/
@@ -298,5 +296,3 @@ int serial_tstc(void)
 void serial_setbrg(void)
 {
 }
-
-#endif
diff --git a/drivers/serial/serial_xuartlite.c 
b/drivers/serial/serial_xuartlite.c
index 74546ce..00d0eaa 100644
--- a/drivers/serial/serial_xuartlite.c
+++ b/drivers/serial/serial_xuartlite.c
@@ -27,8 +27,6 @@
 #include config.h
 #include asm/io.h
 
-#ifdef CONFIG_XILINX_UARTLITE
-
 #define RX_FIFO_OFFSET 0 /* receive FIFO, read only */
 #define TX_FIFO_OFFSET 4 /* transmit FIFO, write only */
 #define STATUS_REG_OFFSET  8 /* status register, read only */
@@ -77,5 +75,3 @@ int serial_tstc(void)
 {
return (in_be32((u32 *) UARTLITE_STATUS)  SR_RX_FIFO_VALID_DATA);
 }
-
-#endif /* CONFIG_MICROBLZE */
diff --git a/drivers/serial/usbtty.c b/drivers/serial/usbtty.c
index 2bc5c3c..e738c56 100644
--- a/drivers/serial/usbtty.c
+++ b/drivers/serial/usbtty.c
@@ -23,8 +23,6 @@
 
 #include common.h
 
-#ifdef CONFIG_USB_TTY
-
 #include circbuf.h
 #include devices.h
 #include usbtty.h
@@ -1007,6 +1005,3 @@ void usbtty_poll (void)
udc_irq();
 
 }
-
-
-#endif
-- 
1.5.6.2


-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH] drivers/serial: Move conditional compilation to Makefile for CONFIG_* macros

2008-08-02 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote:
 Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD [EMAIL PROTECTED]
 ---
 Need to build nios2
 
 I've prefer to move conditional compilation to Makefile instead of
 you move an include in xuartlite. Which is not related to nios2.
 
 I've choose to only move the CONFIG_ and merge the CFG_ in a second step 
 during the next merge

OK.

  drivers/serial/Makefile   |   12 ++--
  drivers/serial/atmel_usart.c  |3 ---
  drivers/serial/mcfuart.c  |3 ---
  drivers/serial/s3c4510b_uart.c|4 
  drivers/serial/serial_max3100.c   |4 
  drivers/serial/serial_xuartlite.c |4 
  drivers/serial/usbtty.c   |5 -
  7 files changed, 6 insertions(+), 29 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
All this doesn't alter anything, you know. The world is still full of
stupid people. They don't use their brains. They don't seem  to  want
to think straight.- Terry Pratchett, _Soul Music_

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users