Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor
I have the same problem when replying to Jean-Christphe's replies. For some reason the reply-to field is set when JC posts a reply and I suppose that messes up Thunderbird/gmail etc. As an example, the email I'm replying to now has reply-to: set to [EMAIL PROTECTED] and [EMAIL PROTECTED] Follow ups from other people don't have the reply-to: field. So my guess is that JC's mutt adds that. I noticed the same thing when doing a reply-all to one of JC's e-mails. It put my address in 'To'. I using Thunderbird with IMAP connection to Gmail. I've seen with both Windows and Linux versions of Thunderbird. I do nothing special in mutt I just use it for several years and it's the first time some one report me this problem If someone known why please tell us I used mutt for the first time today just out of curiosity. Scanning the manual and the headers of your post it seems like you have instructed mutt to recognize the u-boot mailing lists as a mailing list and then you might do a List reply when replying to messages? This seems to cause mutt to insert a Mail-Followup-To: header which other clients use as a reply-to: when doing reply-all. Try doing a group reply instead in mutt or insert a 'set followup_to=false' in your muttrc. /Magnus - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor
Jean-Christophe PLAGNIOL-VILLARD schrieb: On 11:33 Tue 08 Jul , Jens Gehrlein wrote: Signed-off-by: Jens Gehrlein [EMAIL PROTECTED] --- Fixed two bugs: a) added NFS mount option rw to default environment b) added prefix $(obj) in front of .depend in Makefile. Thank you Magnus for catching that. MAINTAINERS |4 MAKEALL |1 Makefile |3 board/tqc/tqma31/Makefile | 48 board/tqc/tqma31/config.mk|2 board/tqc/tqma31/lowlevel_init.S | 375 + board/tqc/tqma31/tqma31.c | 95 board/tqc/tqma31/u-boot.lds | 72 ++ include/asm-arm/arch-mx31/mx31-regs.h | 42 include/configs/TQMA31.h | 271 10 files changed, 913 insertions(+), 0 deletions(-) create mode 100644 board/tqc/tqma31/Makefile create mode 100644 board/tqc/tqma31/config.mk create mode 100644 board/tqc/tqma31/lowlevel_init.S create mode 100644 board/tqc/tqma31/tqma31.c create mode 100644 board/tqc/tqma31/u-boot.lds create mode 100644 include/configs/TQMA31.h Do you have any plan to send a rebase patch? I suppose in Q1/2009. It depends on our customer and on my workload with other projects. But could you possibly consider [U-Boot-Users] [PATCH 01/10 v2] [ARM] MXC: insert bus busy check in i2c_probe from 2008-07-08 04:20 PM ? IMO it's independent of the other patches. Thank you for asking. It's curious: always, when replying to your e-mails, my e-mail address appears in the To field instead of your address. Do the others have this problem, too? (Thunderbird 2.0.0.14 on Linux) -- Kind regards, Jens - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor
On 16:29 Fri 31 Oct , Jens Gehrlein wrote: Jean-Christophe PLAGNIOL-VILLARD schrieb: On 11:33 Tue 08 Jul , Jens Gehrlein wrote: Signed-off-by: Jens Gehrlein [EMAIL PROTECTED] --- Fixed two bugs: a) added NFS mount option rw to default environment b) added prefix $(obj) in front of .depend in Makefile. Thank you Magnus for catching that. MAINTAINERS |4 MAKEALL |1 Makefile |3 board/tqc/tqma31/Makefile | 48 board/tqc/tqma31/config.mk|2 board/tqc/tqma31/lowlevel_init.S | 375 + board/tqc/tqma31/tqma31.c | 95 board/tqc/tqma31/u-boot.lds | 72 ++ include/asm-arm/arch-mx31/mx31-regs.h | 42 include/configs/TQMA31.h | 271 10 files changed, 913 insertions(+), 0 deletions(-) create mode 100644 board/tqc/tqma31/Makefile create mode 100644 board/tqc/tqma31/config.mk create mode 100644 board/tqc/tqma31/lowlevel_init.S create mode 100644 board/tqc/tqma31/tqma31.c create mode 100644 board/tqc/tqma31/u-boot.lds create mode 100644 include/configs/TQMA31.h Do you have any plan to send a rebase patch? I suppose in Q1/2009. It depends on our customer and on my workload with other projects. But could you possibly consider [U-Boot-Users] [PATCH 01/10 v2] [ARM] MXC: insert bus busy check in i2c_probe from 2008-07-08 04:20 PM ? IMO it's independent of the other patches. is it the only one? Thank you for asking. It's curious: always, when replying to your e-mails, my e-mail address appears in the To field instead of your address. Do the others have this problem, too? (Thunderbird 2.0.0.14 on Linux) I use mutt and I receve the e-mail with your e-mail address as sender Best Regards, J. - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor
It's curious: always, when replying to your e-mails, my e-mail address appears in the To field instead of your address. Do the others have this problem, too? (Thunderbird 2.0.0.14 on Linux) I use mutt and I receve the e-mail with your e-mail address as sender I have the same problem when replying to Jean-Christphe's replies. For some reason the reply-to field is set when JC posts a reply and I suppose that messes up Thunderbird/gmail etc. As an example, the email I'm replying to now has reply-to: set to [EMAIL PROTECTED] and [EMAIL PROTECTED] Follow ups from other people don't have the reply-to: field. So my guess is that JC's mutt adds that. Regards, Magnus - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor
Magnus Lilja wrote: It's curious: always, when replying to your e-mails, my e-mail address appears in the To field instead of your address. Do the others have this problem, too? (Thunderbird 2.0.0.14 on Linux) I use mutt and I receve the e-mail with your e-mail address as sender I have the same problem when replying to Jean-Christphe's replies. For some reason the reply-to field is set when JC posts a reply and I suppose that messes up Thunderbird/gmail etc. As an example, the email I'm replying to now has reply-to: set to [EMAIL PROTECTED] and [EMAIL PROTECTED] Follow ups from other people don't have the reply-to: field. So my guess is that JC's mutt adds that. Regards, Magnus I noticed the same thing when doing a reply-all to one of JC's e-mails. It put my address in 'To'. I using Thunderbird with IMAP connection to Gmail. I've seen with both Windows and Linux versions of Thunderbird. regards, Ben - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor
On 10:10 Fri 31 Oct , Ben Warren wrote: Magnus Lilja wrote: It's curious: always, when replying to your e-mails, my e-mail address appears in the To field instead of your address. Do the others have this problem, too? (Thunderbird 2.0.0.14 on Linux) I use mutt and I receve the e-mail with your e-mail address as sender I have the same problem when replying to Jean-Christphe's replies. For some reason the reply-to field is set when JC posts a reply and I suppose that messes up Thunderbird/gmail etc. As an example, the email I'm replying to now has reply-to: set to [EMAIL PROTECTED] and [EMAIL PROTECTED] Follow ups from other people don't have the reply-to: field. So my guess is that JC's mutt adds that. I noticed the same thing when doing a reply-all to one of JC's e-mails. It put my address in 'To'. I using Thunderbird with IMAP connection to Gmail. I've seen with both Windows and Linux versions of Thunderbird. I do nothing special in mutt I just use it for several years and it's the first time some one report me this problem If someone known why please tell us Best Regards, J. - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor
On 11:33 Tue 08 Jul , Jens Gehrlein wrote: Signed-off-by: Jens Gehrlein [EMAIL PROTECTED] --- Fixed two bugs: a) added NFS mount option rw to default environment b) added prefix $(obj) in front of .depend in Makefile. Thank you Magnus for catching that. MAINTAINERS |4 MAKEALL |1 Makefile |3 board/tqc/tqma31/Makefile | 48 board/tqc/tqma31/config.mk|2 board/tqc/tqma31/lowlevel_init.S | 375 + board/tqc/tqma31/tqma31.c | 95 board/tqc/tqma31/u-boot.lds | 72 ++ include/asm-arm/arch-mx31/mx31-regs.h | 42 include/configs/TQMA31.h | 271 10 files changed, 913 insertions(+), 0 deletions(-) create mode 100644 board/tqc/tqma31/Makefile create mode 100644 board/tqc/tqma31/config.mk create mode 100644 board/tqc/tqma31/lowlevel_init.S create mode 100644 board/tqc/tqma31/tqma31.c create mode 100644 board/tqc/tqma31/u-boot.lds create mode 100644 include/configs/TQMA31.h Do you have any plan to send a rebase patch? Best Regards, J. - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor
On Thu, Jul 10, 2008 at 12:46:42AM +0200, Wolfgang Denk wrote: In message [EMAIL PROTECTED] you wrote: The TQMA31, as well as the mx32ads use the General Purpose Timer 1, which is feeded by a 32768 clock (possibly imx31_litekit and imx31_phycore with 32000 Hz? I don't know.). The prescale divider can only be an integer. 32768/1000 = non-integer. I think other architectures hav / had similar issues. See for example the MIPS fixes that were added some time ago. Currently, I see only one way to solve this: 1. Patch the common file cpu/arm1136/mx31/interrupts.c, function interrupt_init(), so that the prescaler divides by 33. Alternatively, also make the divider a board specific define. 2. Patch all mx31 board config header files with CFG_HZ 1000. 3. All mx31 boards have to be tested. Sounds like a plan. And while we are at the timers: The udelay function is the next problem: udelay cannot go below 1/(32768 Hz) = 30.5 micros The current function inserts a theoretical nop if the requested usec value is below 1000. Therefore, IMHO, this timer is relatively imprecise, because the resulting delay is below 1 microsecond. IMHO, this all because of that slow input clock. How is this handled in Linux? I don't think they would let this go through? Linux uses the high frequency timer, or better said, the same timer with a high frequency input source. Regards, Sascha -- Pengutronix e.K. - Linux Solutions for Science and Industry --- Kontakt-Informationen finden Sie im Header dieser Mail oder auf der Webseite - http://www.pengutronix.de/impressum/ - - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor
In message [EMAIL PROTECTED] you wrote: CFG_HZ is a constant and has to be 1000. Why is it a board specific define then? Historical reasons only. When PPCBoot was created, I played with that parameter to get a feeling for the involved overhead, etc. This should really be removed, but as you know too many boards depend on this. You could add a software divider in get_timer(). But I think it's better to define CFG_HZ to whatever the timer frequency is. At least 49 boards do it. That's what I mean: many boards need fixing. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] A man either lives life as it happens to him, meets it head-on and licks it, or he turns his back on it and starts to wither away. -- Dr. Boyce, The Menagerie (The Cage), stardate unknown - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor
On Thu, Jul 10, 2008 at 10:49:09AM +0200, Wolfgang Denk wrote: In message [EMAIL PROTECTED] you wrote: CFG_HZ is a constant and has to be 1000. Why is it a board specific define then? Historical reasons only. When PPCBoot was created, I played with that parameter to get a feeling for the involved overhead, etc. This should really be removed, but as you know too many boards depend on this. You could add a software divider in get_timer(). But I think it's better to define CFG_HZ to whatever the timer frequency is. At least 49 boards do it. That's what I mean: many boards need fixing. How about using the Linux clocksource framework for U-Boot? I did this for V2 and it works like a charm. The timer implementation is straight forward. You only have to setup a free running timer and return its value, so there's not much to do wrong when implementing new timers. Currently U-Boot has many timing functions like get_timer, get_timer_masked, reset_timer, reset_timer_masked, udelay and I suppose most people do not understand the meaning of those functions, as the differing implementations show. Not that I volunteer to do this job though :( Regards, Sascha -- Pengutronix - Linux Solutions for Science and Industry Handelsregister: Amtsgericht Hildesheim, HRA 2686 Hannoversche Str. 2, 31134 Hildesheim, Germany Phone: +49-5121-206917-0 | Fax: +49-5121-206917-9 - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor
In message [EMAIL PROTECTED] you wrote: How about using the Linux clocksource framework for U-Boot? I did this I have to admit that I don't know how big that code is? Currently U-Boot has many timing functions like get_timer, get_timer_masked, reset_timer, reset_timer_masked, udelay and I suppose most people do not understand the meaning of those functions, as the differing implementations show. I have to admit that I don't have a clue why get_timer_masked or reset_timer_masked would be needed. Originally (see the PPC implementation), there was only get_timer, reset_timer, and udelay (and IIRC reset_timer was not even necessary). Not that I volunteer to do this job though :( What a pity :-) Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] Ever try. Ever fail. No matter. Try again. Fail again. Fail better. -- S. Beckett - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor
On Thu, Jul 10, 2008 at 11:46:45AM +0200, Wolfgang Denk wrote:
In message [EMAIL PROTECTED] you wrote:
How about using the Linux clocksource framework for U-Boot? I did this
I have to admit that I don't know how big that code is?
Somewhere next to nothing:
/*
* clock.c - generic clocksource implementation
*
* This file contains the clocksource implementation from the Linux
* kernel originally by John Stultz
*
* Copyright (C) 2004, 2005 IBM, John Stultz ([EMAIL PROTECTED])
* Copyright (c) 2007 Sascha Hauer [EMAIL PROTECTED], Pengutronix
*
* See file CREDITS for list of people who contributed to this
* project.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2
* as published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*/
#include common.h
#include asm-generic/div64.h
#include clock.h
static struct clocksource *current_clock;
static uint64_t time_ns;
/**
* get_time_ns - get current timestamp in nanoseconds
*/
uint64_t get_time_ns(void)
{
struct clocksource *cs = current_clock;
uint64_t cycle_now, cycle_delta;
uint64_t ns_offset;
/* read clocksource: */
cycle_now = cs-read();
/* calculate the delta since the last call: */
cycle_delta = (cycle_now - cs-cycle_last) cs-mask;
/* convert to nanoseconds: */
ns_offset = cyc2ns(cs, cycle_delta);
cs-cycle_last = cycle_now;
time_ns += ns_offset;
return time_ns;
}
EXPORT_SYMBOL(get_time_ns);
/**
* clocksource_hz2mult - calculates mult from hz and shift
* @hz: Clocksource frequency in Hz
* @shift_constant: Clocksource shift factor
*
* Helper functions that converts a hz counter
* frequency to a timsource multiplier, given the
* clocksource shift value
*/
uint32_t clocksource_hz2mult(uint32_t hz, uint32_t shift_constant)
{
/* hz = cyc/(Billion ns)
* mult/2^shift = ns/cyc
* mult = ns/cyc * 2^shift
* mult = 1Billion/hz * 2^shift
* mult = 10 * 2^shift / hz
* mult = (10shift) / hz
*/
uint64_t tmp = ((uint64_t)10) shift_constant;
tmp += hz/2; /* round for do_div */
do_div(tmp, hz);
return (uint32_t)tmp;
}
int is_timeout(uint64_t start_ns, uint64_t time_offset_ns)
{
if (start_ns + time_offset_ns get_time_ns())
return 1;
else
return 0;
}
EXPORT_SYMBOL(is_timeout);
void udelay(unsigned long usecs)
{
uint64_t start = get_time_ns();
while(!is_timeout(start, usecs * 1000));
}
EXPORT_SYMBOL(udelay);
void mdelay(unsigned long msecs)
{
uint64_t start = get_time_ns();
while(!is_timeout(start, msecs * 100));
}
EXPORT_SYMBOL(mdelay);
int init_clock(struct clocksource *cs)
{
current_clock = cs;
return 0;
}
The clocksource driver itself adds another 100 lines of code (for mx31).
The implementation of udelay shows how to implement timeouts, the main
usage of timing functions.
Regards,
Sascha
--
--
Pengutronix - Linux Solutions for Science and Industry
Handelsregister: Amtsgericht Hildesheim, HRA 2686
Hannoversche Str. 2, 31134 Hildesheim, Germany
Phone: +49-5121-206917-0 | Fax: +49-5121-206917-9
-
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor
Hi Guennadi, Guennadi Liakhovetski schrieb: On Tue, 8 Jul 2008, Jens Gehrlein wrote: diff --git a/board/tqc/tqma31/Makefile b/board/tqc/tqma31/Makefile new file mode 100644 index 000..f7e17c8 --- /dev/null +++ b/board/tqc/tqma31/Makefile @@ -0,0 +1,48 @@ +# +# Copyright (C) 2008, Guennadi Liakhovetski [EMAIL PROTECTED] +# Copyright (C) 2008, Jens Gehrlein [EMAIL PROTECTED] Thanks for the credit, but, although IANAL, I think, one does not _have_ to preserve the copyright of the original file when it gets copied to a new one. Otherwise most open-source files would have a vry long list of Copyrights:-) Am I right? I didn't quite understand. So what should I remove: - your name? - my name? - all? - in all files (much work)? Thanks. Neither I'm a lawyer. I just had a look to other source files, were it's done similar. Kind regards, Jens - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor
In message [EMAIL PROTECTED] you wrote: Yes, of course you do. If you copy code, you *must* honour existing copyrights and have not any right to remove these. hm, starting from how many lines of code? Copy-paste is one of the main programming technics, as we all know:-) If you copy one line, you don't have to transfer all copyrights over, do you? I don't know of any official rules, but anything above the 5...10 lines limit should be properly attributed. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] A morsel of genuine history is a thing so rare as to be always valuable. - Thomas Jefferson - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor
Guennadi Liakhovetski wrote: On Tue, 8 Jul 2008, Jens Gehrlein wrote: diff --git a/board/tqc/tqma31/Makefile b/board/tqc/tqma31/Makefile new file mode 100644 index 000..f7e17c8 --- /dev/null +++ b/board/tqc/tqma31/Makefile @@ -0,0 +1,48 @@ +# +# Copyright (C) 2008, Guennadi Liakhovetski [EMAIL PROTECTED] +# Copyright (C) 2008, Jens Gehrlein [EMAIL PROTECTED] Thanks for the credit, but, although IANAL, I think, one does not _have_ to preserve the copyright of the original file when it gets copied to a new one. Otherwise most open-source files would have a vry long list of Copyrights:-) Am I right? Thanks Guennadi IANAL, but I play one on Groklaw sometimes, much to PJ's chagrin. ;-) This is a squishy area. It is dependent on what of the original work survives the modification and whether the surviving pieces are copyrightable. It also depends on what country you are contemplating suing in. http://en.wikipedia.org/wiki/Limitations_and_exceptions_to_copyright Things that must be done in certain ways are not copyrightable, so Makefiles are pretty marginal to start with IMHO. http://en.wikipedia.org/wiki/Threshold_of_originality My opinion is to leave the original copyright notice in there and err on the side of preserving reasonable copyright notices. The lawyers will be happy to tell us that we did it wrong if it ever came to a lawsuit, and I would prefer that they tell us that we had a useless copyright notice in the file rather than tell us that we should have had a notice but didn't... Best regards, gvb - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor
Hello Jens, one comment to your patch: Jens Gehrlein wrote: Signed-off-by: Jens Gehrlein [EMAIL PROTECTED] --- Fixed two bugs: a) added NFS mount option rw to default environment b) added prefix $(obj) in front of .depend in Makefile. Thank you Magnus for catching that. [...] + +/*** + * Environment + **/ + +#define CONFIG_BOOTDELAY 4 + +/* Default values */ +#define CONFIG_NETMASK 255.255.255.0 +#define CONFIG_IPADDR172.20.5.100 +#define CONFIG_SERVERIP 172.20.5.121 Please delete this block. We do not accept such settings in default config files. bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor
On 11:33 Tue 08 Jul , Jens Gehrlein wrote: Signed-off-by: Jens Gehrlein [EMAIL PROTECTED] --- Fixed two bugs: a) added NFS mount option rw to default environment b) added prefix $(obj) in front of .depend in Makefile. Thank you Magnus for catching that. MAINTAINERS |4 MAKEALL |1 Makefile |3 board/tqc/tqma31/Makefile | 48 board/tqc/tqma31/config.mk|2 board/tqc/tqma31/lowlevel_init.S | 375 + board/tqc/tqma31/tqma31.c | 95 board/tqc/tqma31/u-boot.lds | 72 ++ include/asm-arm/arch-mx31/mx31-regs.h | 42 include/configs/TQMA31.h | 271 10 files changed, 913 insertions(+), 0 deletions(-) create mode 100644 board/tqc/tqma31/Makefile create mode 100644 board/tqc/tqma31/config.mk create mode 100644 board/tqc/tqma31/lowlevel_init.S create mode 100644 board/tqc/tqma31/tqma31.c create mode 100644 board/tqc/tqma31/u-boot.lds create mode 100644 include/configs/TQMA31.h + +COBJS:= tqma31.o why not use $(BOARD)? COBJS := $(BOARD).o +SOBJS:= lowlevel_init.o + +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) +SOBJS:= $(addprefix $(obj),$(SOBJS)) + +#elif defined CONFIG_MX31_CPU_532_MHZ + /* Platform clocks */ + REG CCM_PDR0, PDR0_CSI_PODF(0x1ff) /* camera sensor interface */ \ + | PDR0_PER_PODF(8-1)/* periph. if derived from USB clock */ \ + | PDR0_HSP_PODF(4-1)/* IPU 133 MHz */ \ Please use tab instead of whitespace + | PDR0_NFC_PODF(7-1)/* NAND FC 19 MHz */ \ Please use tab instead of whitespace + | PDR0_IPG_PODF(2-1)/* peripherals 66.5 MHz */ \ Please use tab instead of whitespace + | PDR0_MAX_PODF(4-1)/* AHB 133 MHz */ \ Please use tab instead of whitespace + | PDR0_MCU_PODF(1-1)/* core 532 MHz */ + /* MCU PLL */ + REG CCM_MPCTL, PLL_PD(1-1) | PLL_MFD(52-1) | PLL_MFI(10) | PLL_MFN(12) +#else +#error Please define CPU core frequency (CONFIG_CPU_399_MHZ or CONFIG_CPU_532_MHZ)! +#endif /* CONFIG_CPU_xxx_MHZ */ + + /* Serial PLL. Default: 1, 4, 12, 1 */ + REG CCM_SPCTL, PLL_PD(2-1) | PLL_MFD(5-1) | PLL_MFI(12) | PLL_MFN(1) +.endm /* init_sdram */ + + +/* setup SDRAM on CSD0 */ +.macro init_sdram + /* + * Enhanced SDRAM Miscellaneous Register + * Latency Hiding Enable + * LPDDR delay line measure unit is enabled + * LPDDR Delay Line is not reset + * Enable Mobile DDR SDRAM operation + * Soft Reset is disabled + */ + REG ESDMISC, 0x0004 + + /* + * Enhanced SDRAM Configuration Register 0 + * tXP 4 clock delay before new COMMAND issued to LPDDR + * tWTR tLPDDR WRITE to READ Command Delay = 2 clock + * tRP SDRAM Row Precharge Delay = 3 clock + * tMRD–SDRAM Load Mode Register to ACTIVE Command = 3 clock you have a nice char here '96' in vim + * tWR SDRAM WRITE to PRECHARGE Command = 3 clock + * tRAS SDRAM ACTIVE to PRECHARGE Command = 6 clock + * tRRD ACTIVE Bank A to ACTIVE Bank B Command = 2 clock + * tCAS CAS Latency = 3 clock + * tRCD SDRAM Row to Column Delay = 3 clock + * tRC SDRAM Row Cycle Delay = 13 clocks + */ + REG ESDCFG0, 0x006ac73c + + /* + * Enhanced SDRAM Control Register 0 + * Enhanced SDRAM Controller Enable = 1 + * SDRAM Controller Operating Mode = 001 Precharge Command + * Supervisor Protect = 0 User mode accesses are allowed to this + * chip select region + * ROW Row Address Width. = 011 14 Row Addresses + * COL Column Address Width = 01 9 Col Addresses + * DSIZ SDRAM Memory Data Width = 00 00 16-bit memory width + * aligned to D[31:16] + * SREFR SDRAM Refresh Rate = 000 Refresh Disabled + * (bit field reset value) + * PWDT Power Down = 00 Disabled (bit field reset value) Run Mode + * FP Full Page = 0 0 Burst Length of the external memory device + * is not set to Full Page + * BL Burst Length = 0 + * PRCT Precharge Timer 00 Disabled (Bit field reset value) + */ + REG ESDCTL0, 0x9220 + REG 0x8f00, 0x12344321 + + + /* Please use tab instead of whitespace + * Enhanced SDRAM Control Register 0 Please use tab instead of whitespace + * Enhanced SDRAM Controller
Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor
In message [EMAIL PROTECTED] you wrote: +/* Timer tick */ +#define CFG_HZ 32768 CFG_HZ is a constant and has to be 1000. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] Hokey religions and ancient weapons are no substitute for a good blaster at your side. - Han Solo - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor
Thank you very much for catching all these silly mistakes. A last question: When I want to reply all, your e-mail address doesn't appear in the to-field. I have to add the address manually. Is this intended? wierd, in the mail i'm not in the CC but in the FROM Best Regards, J. - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH 04/10 v2] [ARM] TQMA31: add new board with i.MX31 processor
On Wed, 9 Jul 2008, Wolfgang Denk wrote: In message [EMAIL PROTECTED] you wrote: +# Copyright (C) 2008, Guennadi Liakhovetski [EMAIL PROTECTED] +# Copyright (C) 2008, Jens Gehrlein [EMAIL PROTECTED] Thanks for the credit, but, although IANAL, I think, one does not _have_ to preserve the copyright of the original file when it gets copied to a Yes, of course you do. If you copy code, you *must* honour existing copyrights and have not any right to remove these. hm, starting from how many lines of code? Copy-paste is one of the main programming technics, as we all know:-) If you copy one line, you don't have to transfer all copyrights over, do you? Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [EMAIL PROTECTED] - Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW! Studies have shown that voting for your favorite open source project, along with a healthy diet, reduces your potential for chronic lameness and boredom. Vote Now at http://www.sourceforge.net/community/cca08 ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
