Re: [U-Boot-Users] [PATCH RFC 5/5] i.MX31: Add basic support for Freescale's i.MX31 PDK board.

2008-08-07 Thread Magnus Lilja
Hi,

On Wed, Aug 6, 2008 at 11:49 PM, Jean-Christophe PLAGNIOL-VILLARD
[EMAIL PROTECTED] wrote:
 On 14:19 Wed 06 Aug , Magnus Lilja wrote:
 Add support for NAND and ethernet on the Freescale i.MX31 PDK (a.k.a.
 3DS) board.

 Booting from NAND is not supported yet so U-boot relies on some other
 initial boot loader to set up SDRAM and clocks and copying U-boot to SDRAM.

 Signed-off-by: Magnus Lilja [EMAIL PROTECTED]
 --- a/Makefile
 +++ b/Makefile
 @@ -2683,6 +2683,9 @@ imx31_phycore_config: unconfig
  mx31ads_config   : unconfig
   @$(MKCONFIG) $(@:_config=) arm arm1136 mx31ads NULL mx31

 +mx31pdk_config   : unconfig
 + @$(MKCONFIG) $(@:_config=) arm arm1136 mx31pdk NULL mx31
 +
 I've just send a patch to move all freescale's mx31 board to vendor dir

 so please replace with
 +mx31pdk_config : unconfig
 +   @$(MKCONFIG) $(@:_config=) arm arm1136 mx31pdk freescale mx31
 +
  omap2420h4_config: unconfig
   @$(MKCONFIG) $(@:_config=) arm arm1136 omap2420h4 NULL omap24xx

 diff --git a/board/mx31pdk/Makefile b/board/mx31pdk/Makefile
 and move your board to
 board/freescale/mx31pdk/

Ok.

snip
 +#define CONFIG_DISPLAY_CPUINFO
 +#define CONFIG_DISPLAY_BOARDINFO
 +
 +/* Temporarily disabled */
 +#if 0
 +#define CONFIG_OF_LIBFDT 1
 +#define CONFIG_FIT   1
 +#define CONFIG_FIT_VERBOSE   1
 +#endif
 so please remove

Ok.

 +#define CONFIG_CMD_SPI
 +#define CONFIG_CMD_DATE
 +
 +#define CONFIG_CMD_NAND 1
 why not
 #define CONFIG_CMD_NAND

 the check is ifdef

Ok.

 +#define CFG_HZ   CONFIG_MX31_CLK32
 +
 +#define CONFIG_CMDLINE_EDITING   1
 +
 +#undef CONFIG_CMD_IMLS
 please regroup CONFIG_CMD_*

Ok.


Thanks, Magnus

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH RFC 5/5] i.MX31: Add basic support for Freescale's i.MX31 PDK board.

2008-08-07 Thread Magnus Lilja
Hi

On Thu, Aug 7, 2008 at 12:05 AM, Wolfgang Denk [EMAIL PROTECTED] wrote:
 In message [EMAIL PROTECTED] you wrote:
 Add support for NAND and ethernet on the Freescale i.MX31 PDK (a.k.a.
 3DS) board.

 Booting from NAND is not supported yet so U-boot relies on some other
 initial boot loader to set up SDRAM and clocks and copying U-boot to SDRAM.

 Signed-off-by: Magnus Lilja [EMAIL PROTECTED]
 ...
 --- /dev/null
 +++ b/include/configs/mx31pdk.h
 @@ -0,0 +1,186 @@
 ...
 +
 +#undef   CFG_CLKS_IN_HZ  /* everything, incl board info, in Hz 
 */

 Please remove that line. Makes no sense to undef what doesn't exist.

Ok (quite a number of board configs have this #undef and some have a
#define CFG_CLKS_IN_HZ).

 +#define CFG_LOAD_ADDR0x8100 /* default load address */
 +
 +#define CFG_HZ   CONFIG_MX31_CLK32
 +
 +#define CONFIG_CMDLINE_EDITING   1
 +
 +#undef CONFIG_CMD_IMLS

 Why do you want to disable the imls command?

Because I get compilation errors from cmd_bootm.c if it's enabled. I
haven't checked the details but perhaps it's because there is no NOR
flash defined in this config (no NOR present on the PDK board).

 ...
 +#undef CONFIG_JFFS2_CMDLINE

 Why do you disable this?

Probably a leftover from either a compilation problem or copypasted
from the config file I started with (some other i.MX31 board). I'll
remove the line if I don't run into problems, it seems to compile OK
if I remove the line.


Thanks, Magnus

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH RFC 5/5] i.MX31: Add basic support for Freescale's i.MX31 PDK board.

2008-08-07 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote:
 
  +#undef   CFG_CLKS_IN_HZ  /* everything, incl board info, in 
  Hz */
 
  Please remove that line. Makes no sense to undef what doesn't exist.
 
 Ok (quite a number of board configs have this #undef and some have a
 #define CFG_CLKS_IN_HZ).

I know, but it makes no sense to copy bad style.

  +#undef CONFIG_CMD_IMLS
 
  Why do you want to disable the imls command?
 
 Because I get compilation errors from cmd_bootm.c if it's enabled. I
 haven't checked the details but perhaps it's because there is no NOR
 flash defined in this config (no NOR present on the PDK board).

Ah! This is an indication of a problem with your board. You rather fix
this. imls is a standard command, and if you have to disablke it to
compile U-Boot, then something is broken.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
The POP3 server service depends on the SMTP  server  service,  which
failed to start because of the following error: The operation comple-
ted successfully. -- Windows NT Server v3.51

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH RFC 5/5] i.MX31: Add basic support for Freescale's i.MX31 PDK board.

2008-08-07 Thread Magnus Lilja
On Thu, Aug 7, 2008 at 2:18 PM, Wolfgang Denk [EMAIL PROTECTED] wrote:
 In message [EMAIL PROTECTED] you wrote:
  +#undef CONFIG_CMD_IMLS
 
  Why do you want to disable the imls command?

 Because I get compilation errors from cmd_bootm.c if it's enabled. I
 haven't checked the details but perhaps it's because there is no NOR
 flash defined in this config (no NOR present on the PDK board).

 Ah! This is an indication of a problem with your board. You rather fix
 this. imls is a standard command, and if you have to disablke it to
 compile U-Boot, then something is broken.


Well, I wonder if that's the case here. cmd_bootm.c needs the
flash_info_t datatype (amongst other things) when CONFIG_CMD_IMLS is
enabled. flash_info_t is found in include/flash.h but within a #ifndef
CFG_NO_FLASH. CFG_NO_FLASH is, as far as I can see, defined for boards
that don't have any NOR flash.

I haven't looked at all the config files for the boards that undef
CONFIG_CMD_IMLS but at least a couple of AT91SAM926x and Davinci
boards with only NAND flash present do this.


Regards, Magnus

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


[U-Boot-Users] [PATCH RFC 5/5] i.MX31: Add basic support for Freescale's i.MX31 PDK board.

2008-08-06 Thread Magnus Lilja
Add support for NAND and ethernet on the Freescale i.MX31 PDK (a.k.a.
3DS) board.

Booting from NAND is not supported yet so U-boot relies on some other
initial boot loader to set up SDRAM and clocks and copying U-boot to SDRAM.

Signed-off-by: Magnus Lilja [EMAIL PROTECTED]
---
 MAKEALL   |1 +
 Makefile  |3 +
 board/mx31pdk/Makefile|   53 
 board/mx31pdk/config.mk   |1 +
 board/mx31pdk/lowlevel_init.S |   30 +++
 board/mx31pdk/mx31pdk.c   |   76 +
 board/mx31pdk/u-boot.lds  |   59 +
 include/configs/mx31pdk.h |  186 +
 8 files changed, 409 insertions(+), 0 deletions(-)

diff --git a/MAKEALL b/MAKEALL
index ee83cca..ac2d3a8 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -515,6 +515,7 @@ LIST_ARM11=\
imx31_litekit   \
imx31_phycore   \
mx31ads \
+   mx31pdk \
 
 
 #
diff --git a/Makefile b/Makefile
index cb8c0f5..40bd9e1 100644
--- a/Makefile
+++ b/Makefile
@@ -2683,6 +2683,9 @@ imx31_phycore_config  : unconfig
 mx31ads_config : unconfig
@$(MKCONFIG) $(@:_config=) arm arm1136 mx31ads NULL mx31
 
+mx31pdk_config : unconfig
+   @$(MKCONFIG) $(@:_config=) arm arm1136 mx31pdk NULL mx31
+
 omap2420h4_config  : unconfig
@$(MKCONFIG) $(@:_config=) arm arm1136 omap2420h4 NULL omap24xx
 
diff --git a/board/mx31pdk/Makefile b/board/mx31pdk/Makefile
new file mode 100644
index 000..6ae34ea
--- /dev/null
+++ b/board/mx31pdk/Makefile
@@ -0,0 +1,53 @@
+#
+# (C) Copyright 2008 Magnus Lilja [EMAIL PROTECTED]
+#
+# (C) Copyright 2000-2006
+# Wolfgang Denk, DENX Software Engineering, [EMAIL PROTECTED]
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB= $(obj)lib$(BOARD).a
+
+COBJS  := mx31pdk.o
+SOBJS  := lowlevel_init.o
+
+SRCS   := $(SOBJS:.o=.S) $(COBJS:.o=.c)
+OBJS   := $(addprefix $(obj),$(COBJS))
+SOBJS  := $(addprefix $(obj),$(SOBJS))
+
+$(LIB):$(obj).depend $(OBJS) $(SOBJS)
+   $(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS)
+
+clean:
+   rm -f $(SOBJS) $(OBJS)
+
+distclean: clean
+   rm -f $(LIB) core *.bak .depend
+
+#
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#
diff --git a/board/mx31pdk/config.mk b/board/mx31pdk/config.mk
new file mode 100644
index 000..d34dc02
--- /dev/null
+++ b/board/mx31pdk/config.mk
@@ -0,0 +1 @@
+TEXT_BASE = 0x87f0
diff --git a/board/mx31pdk/lowlevel_init.S b/board/mx31pdk/lowlevel_init.S
new file mode 100644
index 000..a94ea7f
--- /dev/null
+++ b/board/mx31pdk/lowlevel_init.S
@@ -0,0 +1,30 @@
+/*
+ * (C) Copyright 2008 Magnus Lilja [EMAIL PROTECTED]
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+/*
+ * This is just to keep the linker happy.
+ */
+
+.globl lowlevel_init
+lowlevel_init:
+   mov pc, lr
+
diff --git a/board/mx31pdk/mx31pdk.c b/board/mx31pdk/mx31pdk.c
new file mode 100644
index 000..3f3488e
--- /dev/null
+++ b/board/mx31pdk/mx31pdk.c
@@ -0,0 +1,76 @@
+/*
+ *
+ * (C) Copyright 2008 Magnus Lilja [EMAIL PROTECTED]
+ *
+ * (c) 2007 Pengutronix, Sascha Hauer [EMAIL PROTECTED]
+ *
+ * See file 

Re: [U-Boot-Users] [PATCH RFC 5/5] i.MX31: Add basic support for Freescale's i.MX31 PDK board.

2008-08-06 Thread Ben Warren
Hi Magnus,

On Wed, Aug 6, 2008 at 5:19 AM, Magnus Lilja [EMAIL PROTECTED] wrote:
 Add support for NAND and ethernet on the Freescale i.MX31 PDK (a.k.a.
 3DS) board.

 Booting from NAND is not supported yet so U-boot relies on some other
 initial boot loader to set up SDRAM and clocks and copying U-boot to SDRAM.

 Signed-off-by: Magnus Lilja [EMAIL PROTECTED]
 ---
snip
 +#define CONFIG_NETMASK 255.255.255.0
 +#define CONFIG_IPADDR  192.168.23.168
 +#define CONFIG_SERVERIP192.168.23.2
Please remove default network parms
 +
 +#defineCONFIG_EXTRA_ENV_SETTINGS 
   \
 +   bootargs_base=setenv bootargs console=ttymxc0,115200\0\
 +   bootargs_nfs=setenv bootargs $(bootargs) root=/dev/nfs\
 +   ip=dhcp nfsroot=$(serverip):$(nfsrootfs),v3,tcp\0 \
 +   bootcmd=run bootcmd_net\0 \
 +   bootcmd_net=run bootargs_base bootargs_mtd bootargs_nfs;  \
 +   tftpboot 0x8000 uImage-mx31; bootm\0
 +
 +#define CONFIG_DRIVER_SMC911X  1
 +#define CONFIG_DRIVER_SMC911X_BASE CS5_BASE
 +#define CONFIG_DRIVER_SMC911X_32_BIT   1
 +
 +/*
 + * Miscellaneous configurable options
 + */
 +#define CFG_LONGHELP   /* undef to save memory */
 +#define CFG_PROMPT uboot 
 +#define CFG_CBSIZE 256  /* Console I/O Buffer Size */
 +/* Print Buffer Size */
 +#define CFG_PBSIZE (CFG_CBSIZE+sizeof(CFG_PROMPT)+16)
 +#define CFG_MAXARGS16  /* max number of command args */
 +#define CFG_BARGSIZE   CFG_CBSIZE  /* Boot Argument Buffer Size */
 +
 +#define CFG_MEMTEST_START  PHYS_SDRAM_1  /* memtest works on */
 +#define CFG_MEMTEST_END0x1
 +
 +#undef CFG_CLKS_IN_HZ  /* everything, incl board info, in Hz */
 +
 +#define CFG_LOAD_ADDR  0x8100 /* default load address */
 +
 +#define CFG_HZ CONFIG_MX31_CLK32
 +
 +#define CONFIG_CMDLINE_EDITING 1
 +
 +#undef CONFIG_CMD_IMLS
 +
 +/*---
 + * Stack sizes
 + *
 + * The stack sizes are set up in start.S using the settings below
 + */
 +#define CONFIG_STACKSIZE   (128 * 1024) /* regular stack */
 +
 +/*---
 + * Physical Memory Map
 + */
 +#define CONFIG_NR_DRAM_BANKS   1
 +#define PHYS_SDRAM_1   CSD0_BASE
 +#define PHYS_SDRAM_1_SIZE  (128 * 1024 * 1024)
 +
 +/*---
 + * FLASH and environment organization
 + */
 +/* No NOR flash present */
 +#define CFG_NO_FLASH   1
 +
 +/*
 + * NAND flash
 + */
 +
 +#define NAND_MAX_CHIPS 1
 +#define CFG_MAX_NAND_DEVICE1
 +#define CFG_NAND_BASE  0x4000
 +
 +/*
 + * Place U-boot environment right after the U-boot code.
 + */
 +#define CFG_ENV_IS_IN_NAND 1
 +#define CFG_ENV_OFFSET 0x4
 +/* CFG_ENV_SIZE has to be a multiple of the NAND block size */
 +#define CFG_ENV_SIZE   (128 * 1024)
 +
 +/*
 + * JFFS2 partitions
 + */
 +#undef CONFIG_JFFS2_CMDLINE
 +#define CONFIG_JFFS2_DEV   nand0
 +
 +#endif /* __CONFIG_H */
 +
 --
 1.5.2.4

regards,
Ben

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH RFC 5/5] i.MX31: Add basic support for Freescale's i.MX31 PDK board.

2008-08-06 Thread Magnus Lilja
Hi Ben,

On Wed, Aug 6, 2008 at 3:22 PM, Ben Warren [EMAIL PROTECTED] wrote:
 Hi Magnus,

 On Wed, Aug 6, 2008 at 5:19 AM, Magnus Lilja [EMAIL PROTECTED] wrote:
 Add support for NAND and ethernet on the Freescale i.MX31 PDK (a.k.a.
 3DS) board.

 Booting from NAND is not supported yet so U-boot relies on some other
 initial boot loader to set up SDRAM and clocks and copying U-boot to SDRAM.

 Signed-off-by: Magnus Lilja [EMAIL PROTECTED]
 ---
 snip
 +#define CONFIG_NETMASK 255.255.255.0
 +#define CONFIG_IPADDR  192.168.23.168
 +#define CONFIG_SERVERIP192.168.23.2
 Please remove default network parms

Will do!

Thanks, Magnus

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users


Re: [U-Boot-Users] [PATCH RFC 5/5] i.MX31: Add basic support for Freescale's i.MX31 PDK board.

2008-08-06 Thread Jean-Christophe PLAGNIOL-VILLARD
On 14:19 Wed 06 Aug , Magnus Lilja wrote:
 Add support for NAND and ethernet on the Freescale i.MX31 PDK (a.k.a.
 3DS) board.
 
 Booting from NAND is not supported yet so U-boot relies on some other
 initial boot loader to set up SDRAM and clocks and copying U-boot to SDRAM.
 
 Signed-off-by: Magnus Lilja [EMAIL PROTECTED]
 ---
  MAKEALL   |1 +
  Makefile  |3 +
  board/mx31pdk/Makefile|   53 
  board/mx31pdk/config.mk   |1 +
  board/mx31pdk/lowlevel_init.S |   30 +++
  board/mx31pdk/mx31pdk.c   |   76 +
  board/mx31pdk/u-boot.lds  |   59 +
  include/configs/mx31pdk.h |  186 
 +
  8 files changed, 409 insertions(+), 0 deletions(-)
 
 diff --git a/MAKEALL b/MAKEALL
 index ee83cca..ac2d3a8 100755
 --- a/MAKEALL
 +++ b/MAKEALL
 @@ -515,6 +515,7 @@ LIST_ARM11=  \
   imx31_litekit   \
   imx31_phycore   \
   mx31ads \
 + mx31pdk \
  
  
  #
 diff --git a/Makefile b/Makefile
 index cb8c0f5..40bd9e1 100644
 --- a/Makefile
 +++ b/Makefile
 @@ -2683,6 +2683,9 @@ imx31_phycore_config: unconfig
  mx31ads_config   : unconfig
   @$(MKCONFIG) $(@:_config=) arm arm1136 mx31ads NULL mx31
  
 +mx31pdk_config   : unconfig
 + @$(MKCONFIG) $(@:_config=) arm arm1136 mx31pdk NULL mx31
 +
I've just send a patch to move all freescale's mx31 board to vendor dir

so please replace with 
+mx31pdk_config : unconfig
+   @$(MKCONFIG) $(@:_config=) arm arm1136 mx31pdk freescale mx31
+
  omap2420h4_config: unconfig
   @$(MKCONFIG) $(@:_config=) arm arm1136 omap2420h4 NULL omap24xx
  
 diff --git a/board/mx31pdk/Makefile b/board/mx31pdk/Makefile
and move your board to 
board/freescale/mx31pdk/

 diff --git a/include/configs/mx31pdk.h b/include/configs/mx31pdk.h
 new file mode 100644
 index 000..d1f44ab
 --- /dev/null
 +++ b/include/configs/mx31pdk.h
 @@ -0,0 +1,186 @@
 +/*
 + * (C) Copyright 2008 Magnus Lilja [EMAIL PROTECTED]
 + *
 + * (C) Copyright 2004
 + * Texas Instruments.
 + * Richard Woodruff [EMAIL PROTECTED]
 + * Kshitij Gupta [EMAIL PROTECTED]
 + *
 + * Configuration settings for the Freescale i.MX31 PDK board.
 + *
 + * See file CREDITS for list of people who contributed to this
 + * project.
 + *
 + * This program is free software; you can redistribute it and/or
 + * modify it under the terms of the GNU General Public License as
 + * published by the Free Software Foundation; either version 2 of
 + * the License, or (at your option) any later version.
 + *
 + * This program is distributed in the hope that it will be useful,
 + * but WITHOUT ANY WARRANTY; without even the implied warranty of
 + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.   See the
 + * GNU General Public License for more details.
 + *
 + * You should have received a copy of the GNU General Public License
 + * along with this program; if not, write to the Free Software
 + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
 + * MA 02111-1307 USA
 + */
 +
 +#ifndef __CONFIG_H
 +#define __CONFIG_H
 +
 +#include asm/arch/mx31-regs.h
 +
 + /* High Level Configuration Options */
 +#define CONFIG_ARM1136   1/* This is an arm1136 CPU core */
 +#define CONFIG_MX31  1/* in a mx31 */
 +#define CONFIG_MX31_HCLK_FREQ2600
 +#define CONFIG_MX31_CLK3232768
 +
 +#define CONFIG_MX31_NAND 1
 +
 +#define CONFIG_DISPLAY_CPUINFO
 +#define CONFIG_DISPLAY_BOARDINFO
 +
 +/* Temporarily disabled */
 +#if 0
 +#define CONFIG_OF_LIBFDT 1
 +#define CONFIG_FIT   1
 +#define CONFIG_FIT_VERBOSE   1
 +#endif
so please remove
 +
 +#define CONFIG_CMDLINE_TAG   1/* enable passing of ATAGs */
 +#define CONFIG_SETUP_MEMORY_TAGS 1
 +#define CONFIG_INITRD_TAG1
 +
 +/*
 + * Size of malloc() pool
 + * An extra 128kbyte is needed for the NAND Bad Block table.
 + */
 +#define CFG_MALLOC_LEN   (CFG_ENV_SIZE + 128 * 1024 + 128 * 1024)
 +#define CFG_GBL_DATA_SIZE128  /* bytes reserved for initial data */
 +
 +/*
 + * Hardware drivers
 + */
 +
 +#define CONFIG_MX31_UART 1
 +#define CFG_MX31_UART1   1
 +
 +#define CONFIG_HARD_SPI  1
 +#define CONFIG_MXC_SPI   1
 +#define CONFIG_MXC_SPI_IFACE 1
 +
 +#define CONFIG_RTC_MC13783   1
 +
 +/* allow to overwrite serial and ethaddr */
 +#define CONFIG_ENV_OVERWRITE
 +#define CONFIG_CONS_INDEX1
 +#define CONFIG_BAUDRATE  115200
 +#define CFG_BAUDRATE_TABLE   {9600, 19200, 38400, 57600, 115200}
 +
 +/***
 + * Command definition
 + ***/
 +
 +#include config_cmd_default.h
 +
 +/* No support for NAND boot for i.MX31 PDK 

Re: [U-Boot-Users] [PATCH RFC 5/5] i.MX31: Add basic support for Freescale's i.MX31 PDK board.

2008-08-06 Thread Wolfgang Denk
In message [EMAIL PROTECTED] you wrote:
 Add support for NAND and ethernet on the Freescale i.MX31 PDK (a.k.a.
 3DS) board.
 
 Booting from NAND is not supported yet so U-boot relies on some other
 initial boot loader to set up SDRAM and clocks and copying U-boot to SDRAM.
 
 Signed-off-by: Magnus Lilja [EMAIL PROTECTED]
...
 --- /dev/null
 +++ b/include/configs/mx31pdk.h
 @@ -0,0 +1,186 @@
...
 +
 +#undef   CFG_CLKS_IN_HZ  /* everything, incl board info, in Hz */

Please remove that line. Makes no sense to undef what doesn't exist.

 +#define CFG_LOAD_ADDR0x8100 /* default load address */
 +
 +#define CFG_HZ   CONFIG_MX31_CLK32
 +
 +#define CONFIG_CMDLINE_EDITING   1
 +
 +#undef CONFIG_CMD_IMLS

Why do you want to disable the imls command?


...
 +#undef CONFIG_JFFS2_CMDLINE

Why do you disable this?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED]
The first thing we do is kill all the lawyers.
(Shakespeare. II Henry VI, Act IV, scene ii)

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
U-Boot-Users mailing list
U-Boot-Users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users