Re: [U-Boot-Users] [PATCH for STLS]: Add Makefile, config.mk and u-boot.lds.S in board/st/stls/ directory!
In message [EMAIL PROTECTED] you wrote: commit d66194654186b0e82d926ce4844b73e3508397f4 Parent: 699f05125509249072a0b865c8d35520d97cd501 Author: Ryan Chen [EMAIL PROTECTED] Date: Tue Jul 29 13:35:15 2008 -0400 Signed-off-by: Ryan Chen [EMAIL PROTECTED] new file: board/st/stls/Makefile new file: board/st/stls/config.mk new file: board/st/stls/u-boot.lds.S Please use git-format-patch to format the patch. Above text is NOT an acceptable commit message. +# diff --git a/board/st/stls/config.mk b/board/st/stls/config.mk new file mode 100755 index 000..683b009 --- /dev/null +++ b/board/st/stls/config.mk ... +#GUI_SUPPORT = minigui \ No newline at end of file ^^ Please fix this!! diff --git a/board/st/stls/u-boot.lds.S b/board/st/stls/u-boot.lds.S new file mode 100755 index 000..5e7bb76 --- /dev/null +++ b/board/st/stls/u-boot.lds.S Why not u-boot.lds like for all the other boards? The .S suffix suggests it is an assembler file, which it ain't. Hm... This patch is incomplete, as it does not add all filkes needed to support this board. On the other hand, it is not part of a patch series (at least it is not m,arked as such, and not threaded accordingly). Please fix. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [EMAIL PROTECTED] (null cookie; hope that's ok) - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
Re: [U-Boot-Users] [PATCH for STLS]: Add Makefile, config.mk and u-boot.lds.S in board/st/stls/ directory!
On 10:17 Wed 30 Jul , Ryan CHEN wrote: commit d66194654186b0e82d926ce4844b73e3508397f4 Parent: 699f05125509249072a0b865c8d35520d97cd501 Author: Ryan Chen [EMAIL PROTECTED] Date: Tue Jul 29 13:35:15 2008 -0400 Signed-off-by: Ryan Chen [EMAIL PROTECTED] new file: board/st/stls/Makefile new file: board/st/stls/config.mk new file: board/st/stls/u-boot.lds.S Could you do it in the same patch where you add the board support? with the update of the General Makefile, MAKALL and MAINTAINERS in it Best Regards, J. diff --git a/board/st/stls/Makefile b/board/st/stls/Makefile new file mode 100755 index 000..8213838 --- /dev/null +++ b/board/st/stls/Makefile @@ -0,0 +1,48 @@ +# +# (C) Copyright 2003-2006 +# Wolfgang Denk, DENX Software Engineering, [EMAIL PROTECTED] +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +include $(TOPDIR)/config.mk + +LIB = $(obj)lib$(BOARD).a + +COBJS= flash.o pci.o stls_board.o ide.o + +SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS)) +SOBJS:= $(addprefix $(obj),$(SOBJS)) + +$(LIB): $(obj).depend $(OBJS) $(SOBJS) u-boot.lds please use $(obj) for generated file in order to build it out-of-tree + $(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS) + +u-boot.lds: u-boot.lds.S + $(CPP) $(CPPFLAGS) -P $^ [EMAIL PROTECTED] + mv -f [EMAIL PROTECTED] $@ + Best Regards, J. - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
[U-Boot-Users] [PATCH for STLS]: Add Makefile, config.mk and u-boot.lds.S in board/st/stls/ directory!
commit d66194654186b0e82d926ce4844b73e3508397f4
Parent: 699f05125509249072a0b865c8d35520d97cd501
Author: Ryan Chen [EMAIL PROTECTED]
Date: Tue Jul 29 13:35:15 2008 -0400
Signed-off-by: Ryan Chen [EMAIL PROTECTED]
new file: board/st/stls/Makefile
new file: board/st/stls/config.mk
new file: board/st/stls/u-boot.lds.S
diff --git a/board/st/stls/Makefile b/board/st/stls/Makefile
new file mode 100755
index 000..8213838
--- /dev/null
+++ b/board/st/stls/Makefile
@@ -0,0 +1,48 @@
+#
+# (C) Copyright 2003-2006
+# Wolfgang Denk, DENX Software Engineering, [EMAIL PROTECTED]
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+include $(TOPDIR)/config.mk
+
+LIB= $(obj)lib$(BOARD).a
+
+COBJS = flash.o pci.o stls_board.o ide.o
+
+SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c)
+OBJS := $(addprefix $(obj),$(COBJS))
+SOBJS := $(addprefix $(obj),$(SOBJS))
+
+$(LIB):$(obj).depend $(OBJS) $(SOBJS) u-boot.lds
+ $(AR) $(ARFLAGS) $@ $(OBJS) $(SOBJS)
+
+u-boot.lds: u-boot.lds.S
+ $(CPP) $(CPPFLAGS) -P $^ [EMAIL PROTECTED]
+ mv -f [EMAIL PROTECTED] $@
+
+#
+
+# defines $(obj).depend target
+include $(SRCTREE)/rules.mk
+
+sinclude $(obj).depend
+
+#
diff --git a/board/st/stls/config.mk b/board/st/stls/config.mk
new file mode 100755
index 000..683b009
--- /dev/null
+++ b/board/st/stls/config.mk
@@ -0,0 +1,29 @@
+#
+# (C) Copyright 2003
+# Wolfgang Denk, DENX Software Engineering, [EMAIL PROTECTED]
+#
+# See file CREDITS for list of people who contributed to this
+# project.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+#
+# ST development board stls, Loongson core
+#
+TEXT_BASE = 0xc000
+
+#GUI_SUPPORT = minigui
\ No newline at end of file
diff --git a/board/st/stls/u-boot.lds.S b/board/st/stls/u-boot.lds.S
new file mode 100755
index 000..5e7bb76
--- /dev/null
+++ b/board/st/stls/u-boot.lds.S
@@ -0,0 +1,69 @@
+/*
+ * (C) Copyright 2003
+ * Wolfgang Denk Engineering, [EMAIL PROTECTED]
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+#include config.h
+
+OUTPUT_FORMAT(elf32-tradlittlemips, elf32-tradlittlemips,
elf32-tradlittlemips)
+OUTPUT_ARCH(mips)
+ENTRY(_start)
+SECTIONS
+{
+ . = TEXT_BASE;
+ uboot_start = .;
+ __uboot_start = .;
+
+ . = ALIGN(4);
+ .text :
+ {
+ cpu/stls/start.o (.text)
+ *(.text)
+ }
+
+ . = ALIGN(4);
+ .rodata : { *(.rodata) }
+
+ . = ALIGN(4);
+ uboot_start_data = .;
+ __uboot_start_data = .;
+ .data : { *(.data) }
+
+ . = ALIGN(4);
+ .sdata : { *(.sdata) }
+
+ . = ALIGN(16);
+
