I've just noticed via the Debian Package tracker that you merged with
the latest Debian package.
Since I'd like to get the differences between Debian and Ubuntu to a
minimum, two questions:
1. Why did you merge back the old Ubuntu test suite? There was a bug
open in Debian [1] to merge it into the Debian package. Since I wanted
to implement that correctly, I talked to Martin about it, and we came to
the conclusion that the whole python testlib.py stuff is not optimal, so
we thus decided to drop it. I implemented much simpler autopkgtests.
The only thing that new old Ubuntu test suite could do that the current
Debian autopkgtests can't do is that in in principle can test for iSCSI
functionality - but only if you manually edit the tests. (remote_server
= '', which is in test-open-iscsi.py, disables that by default, because
there's no target available by default) I still have an item on the TODO
list to automatically test iSCSI functionality by creating a target (see
related Debian bug [2], where I really should send a new patch). But if
you just look at what is actually tested automatically right now, the
"install" test already covers all of that.
But even if you want to merge back in the old test suite, please don't
do it in that way: there's a good reason why Depends: is empty for the
install tests: because the test wants to ensure that the installation
succeeds under different init systems, so it first needs to be able to
install a different init system before actually installing the package.
Now, Ubuntu only supports systemd nowadays (which is why the Debian
upstream test suite skips the sysvinit test on Ubuntu, see
debian/tests/sysvinit.inc), so it may not be a huge issue, but to be
consistent, please don't merge the Tests: lines and just have them
separate, even if you want to keep the old test suite:
Tests: install sysvinit-install
Restrictions: needs-root isolation-machine breaks-testbed
Depends:
Tests: daemon testsuite
Depends: open-iscsi, python
Restrictions: needs-root
2. Why is there actually a need for the network interface handling
stuff? So in Debian we don't have that (never had), but I've
successfully used root on iSCSI on Debian without having to do such
hacks. The reason is that if you look at partman-iscsi (used by debian-
installer), it automatically sets the interface to manual when iSCSI is
used. And README.Debian clearly documents that you need to use inet
manual, so people setting that up for themselves (without the installer,
which is possible, but more complicated) have it documented properly.
(Actually, I think 'manual' is technically a bit wrong, because if you
are indeed using DHCP and not a static IP configuration, you still need
something that renews the DHCP lease, otherwise the address might get
reused by the DHCP server. Of course, if the DHCP server gives you a new
address, you're screwed, so that shouldn't happen, but renewing the
existing address is something that actually should be done. OTOH, if
static configuration is used, DHCP shouldn't be done and it should
indeed be manual. I know for example that dracut's dhclient script sets
a finite valid lifetime for the IPv4 address when using DHCP in the
initramfs, so that network management tools on the system itself know it
was a DHCP address and that they need to renew it [3]. This is probably
something that needs to be fixed in ifupdown and/or dhclient, and then
we could get rid of this hack alltogether, because then "inet dhcp"
should do the right thing anyway.)
Thanks,
Christian
[1] https://bugs.debian.org/710148
[2] https://bugs.debian.org/800845
[3] https://bugzilla.redhat.com/show_bug.cgi?id=1058519
** Bug watch added: Debian Bug tracker #710148
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=710148
** Bug watch added: Debian Bug tracker #800845
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800845
** Bug watch added: Red Hat Bugzilla #1058519
https://bugzilla.redhat.com/show_bug.cgi?id=1058519
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1546877
Title:
sync with debian testing (2.0.873+git0.3b4b4500-13)
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/1546877/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
