[Bug 1899262] Re: Broken dbus GetAll message to wpa supplicant interface properties

2020-12-01 Thread Michael Nazzareno Trimarchi
@Sebastien I will test it today. Sorry for the delay

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1899262

Title:
  Broken dbus GetAll message to wpa supplicant interface properties

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899262/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1899262] Re: Broken dbus GetAll message to wpa supplicant interface properties

2020-11-04 Thread Michael Nazzareno Trimarchi
Dear Sebastian, the problem that the station patch was backported
already but wrongly. I have just fixed in this package

This is coming from change log

wpa (2:2.6-15ubuntu1) bionic; urgency=low

  * Merge from Debian unstable.  Remaining changes:
- debian/patches/wpa_service_ignore-on-isolate.patch: add
  IgnoreOnIsolate=yes so that when switching "runlevels" in oem-config
  will not kill off wpa and cause wireless to be unavailable on first
  boot.
- debian/patches/session-ticket.patch: disable the TLS Session Ticket
  extension to fix auth with 802.1x PEAP on some hardware.
- debian/patches/android_hal_fw_path_change.patch: add a DBus method
  for requesting a firmware change when working with the Android HAL;
  this is used to set a device in P2P or AP mode; conditional to
  CONFIG_ANDROID_HAL being enabled.
- debian/config/wpasupplicant/linux: enable CONFIG_ANDROID_HAL.
- debian/control: Build-Depends on android-headers to get the required
  wifi headers for the HAL support.
- debian/patches/dbus-available-sta.patch: Make the list of connected
  stations available on DBus for hotspot mode; along with some of the
  station properties, such as rx/tx packets, bytes, capabilities, etc.

Up you have the patch that break the package. I just made it working
properly patch the package



  * Updated debian/patches/dbus-available-sta.patch for new getter API

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1899262

Title:
  Broken dbus GetAll message to wpa supplicant interface properties

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899262/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1899262] Re: Broken dbus GetAll message to wpa supplicant interface properties

2020-11-03 Thread Michael Nazzareno Trimarchi
debdiff show the difference between the 18.04 ubuntu. In the 20.04 wpa
supplicant was bump to newer version so station attribute was added in
the right way

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1899262

Title:
  Broken dbus GetAll message to wpa supplicant interface properties

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899262/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1899262] Re: Broken dbus GetAll message to wpa supplicant interface properties

2020-11-03 Thread Michael Nazzareno Trimarchi
Are you using ubuntu 18.04? or are you using Focal Fossa?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1899262

Title:
  Broken dbus GetAll message to wpa supplicant interface properties

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899262/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1899262] Re: Broken dbus GetAll message to wpa supplicant interface properties

2020-11-03 Thread Michael Nazzareno Trimarchi
As I said Interfaces/1 or /2 or /3 depends on how they are enumerated.
That is just an example

Using d-feet to find your interface. Today is /4 on my laptop (and must
be a wifi)

** Attachment added: "Screenshot from 2020-11-03 17-25-40.png"
   
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899262/+attachment/5430694/+files/Screenshot%20from%202020-11-03%2017-25-40.png

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1899262

Title:
  Broken dbus GetAll message to wpa supplicant interface properties

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899262/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1899262] Re: Broken dbus GetAll message to wpa supplicant interface properties

2020-10-22 Thread Michael Nazzareno Trimarchi
dbus getAll let you to download information of any interface. Each
interface has a reference number inside the wpa_supplicant. In my laptop
my wifi is interface 1. In order to ready wifi interface information I
can use dbus as shown in this example:

sudo dbus-send --system --print-reply --dest=fi.w1.wpa_supplicant1
/fi/w1/wpa_supplicant1/Interfaces/1
org.freedesktop.DBus.Properties.GetAll
string:fi.w1.wpa_supplicant1.Interface

The result of the command give you the an answer like:

sudo dbus-send --system --print-reply --dest=fi.w1.wpa_supplicant1 
/fi/w1/wpa_supplicant1/Interfaces/1 org.freedesktop.DBus.Properties.GetAll 
string:fi.w1.wpa_supplicant1.Interface
[sudo] password for michael: 
method return time=1603398113.528196 sender=:1.4 -> destination=:1.267 
serial=476 reply_serial=2
   array [
  dict entry(
 string "Capabilities"
 variant array [
   dict entry(
  string "Pairwise"
  variant  array [
string "ccmp"
string "tkip"
 ]
   )
   dict entry(
  string "Group"
  variant  array [
string "ccmp"
string "tkip"
string "wep104"
string "wep40"
 ]
   )
   dict entry(
  string "GroupMgmt"
  variant  array [
string "aes-128-cmac"
 ]
   )
   dict entry(
  string "KeyMgmt"
  variant  array [
string "none"
string "ieee8021x"
string "wpa-eap"
string "wpa-ft-eap"
string "wpa-eap-sha256"
string "wpa-psk"
string "wpa-ft-psk"
string "wpa-psk-sha256"
string "wps"
 ]
...

If one of the value can not reported the entire request just plain fail.
This is not happen on the same version without any addition patch. In
the debian package was added a patch to report the Stations attribue
that is a part of this answer and the fact that this is only valid on ap
mode does not let reply at all of this message. Now in connman for
example this getAll is used to get out the interface information as you
can find in this snipped code:


int supplicant_dbus_property_get_all(const char *path, const char *interface,
supplicant_dbus_property_function function,
void *user_data, gpointer caller)
{
struct property_call_data *property_call = NULL;
DBusMessage *message;
DBusPendingCall *call;

if (!connection)
return -EINVAL;

if (!path || !interface)
return -EINVAL;

property_call = g_try_new0(struct property_call_data, 1);
if (!property_call)
return -ENOMEM;

message = dbus_message_new_method_call(SUPPLICANT_SERVICE, path,
DBUS_INTERFACE_PROPERTIES, "GetAll");
if (!message) {
g_free(property_call);
return -ENOMEM;
}
...


static void interface_added(DBusMessageIter *iter, void *user_data)
{
...
   if (!properties_appended) {
supplicant_dbus_property_get_all(path,
SUPPLICANT_INTERFACE 
".Interface", << this call fail
interface_property, interface,
interface);
return;
}

...


This break all the other call try to access the Interface object in dbus 
dictionary

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1899262

Title:
  Broken dbus GetAll message to wpa supplicant interface properties

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899262/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1899262] Re: Broken dbus GetAll message to wpa supplicant interface properties

2020-10-14 Thread Michael Nazzareno Trimarchi
wpa_supplicant exponse properties of the interface that you can read
using dbus command such as. Now if the property is empy you should just
expose as empty and not fail as it is in the code.

sudo dbus-send --system --print-reply --dest=fi.w1.wpa_supplicant1
/fi/w1/wpa_supplicant1/Interfaces/1
org.freedesktop.DBus.Properties.GetAll
string:fi.w1.wpa_supplicant1.Interface

This kind of interface is used by other network services aka connman. I
have tested on ubuntu-core and ubuntu 18.04

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1899262

Title:
  Broken dbus GetAll message to wpa supplicant interface properties

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899262/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1899262] Re: Broken dbus GetAll message to wpa supplicant interface properties

2020-10-11 Thread Michael Nazzareno Trimarchi
** Changed in: wpa (Ubuntu)
 Assignee: (unassigned) => Michael Nazzareno Trimarchi 
(michael-t16qijz8x59bnuup5)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1899262

Title:
  Broken dbus GetAll message to wpa supplicant interface properties

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899262/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1899262] Re: Broken dbus GetAll message to wpa supplicant interface properties

2020-10-11 Thread Michael Nazzareno Trimarchi
** Patch added: 
"0001-dbus-Fix-GetAll-message-if-ap_ifaces-are-not-availab.patch"
   
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899262/+attachment/5420793/+files/0001-dbus-Fix-GetAll-message-if-ap_ifaces-are-not-availab.patch

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1899262

Title:
  Broken dbus GetAll message to wpa supplicant interface properties

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899262/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1899262] Re: Broken dbus GetAll message to wpa supplicant interface properties

2020-10-10 Thread Michael Nazzareno Trimarchi
The attach is a debdiff. If it's not fine let me know

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1899262

Title:
  Broken dbus GetAll message to wpa supplicant interface properties

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899262/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1899263] [NEW] Broken dbus GetAll message to wpa supplicant interface properties

2020-10-10 Thread Michael Nazzareno Trimarchi
Public bug reported:

dbus-send is able to read the properties of interface using GetAll. Those 
information include interface name, status, encryption method, etc. 
The regression was introduced when someone try to have the Station attribute 
supported

** Affects: wpa (Ubuntu)
 Importance: Undecided
 Status: New

** Patch added: "Fix dbus GetAll Interface on interface attribute"
   
https://bugs.launchpad.net/bugs/1899263/+attachment/5420443/+files/fix-dbus-debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1899263

Title:
  Broken dbus GetAll message to wpa supplicant interface properties

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899263/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1899262] [NEW] Broken dbus GetAll message to wpa supplicant interface properties

2020-10-10 Thread Michael Nazzareno Trimarchi
Public bug reported:

dbus-send is able to read the properties of interface using GetAll. Those 
information include interface name, status, encryption method, etc. 
The regression was introduced when someone try to have the Station attribute 
supported

** Affects: wpa (Ubuntu)
 Importance: Undecided
 Status: New

** Patch added: "Fix dbus GetAll Interface on interface attribute"
   
https://bugs.launchpad.net/bugs/1899262/+attachment/5420442/+files/fix-dbus-debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1899262

Title:
  Broken dbus GetAll message to wpa supplicant interface properties

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wpa/+bug/1899262/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1136110] Re: [alsa-devel] Asynchronous audio USB chips: choppy playback since 3.8-rc7

2013-04-03 Thread Michael Nazzareno Trimarchi
Hi Daniel

On 03/04/13 12:23, Daniel Mack wrote:
 Hi David,
 
 On 03.04.2013 12:15, David Henningsson wrote:
 Just to get your attention here on what seems to be an USB audio 
 regression.

 The bug is described in detail here:

 https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1136110?comments=all

 Quoting the bug:

 
 This bug seems to affect only a certain kind of hardware, which is 
 called Asynchronous USB Digital Audio Codec (DAC). It's said that such 
 a DAC hosts the clock itself (USB Device Host). An ordinary DAC, so 
 called Synchronous USB DAC, uses the clock hosted by the mother board, 
 which is not affected by this bug.

 When this bug affects an asynchronous USB DAC, the audio played by the 
 DAC is constantly interrupted. The playback itself does not stop, but 
 the output becomes discontinous, filling with constant crackling noises, 
 destroying everything the DAC plays.
 

 According to the bug reporter, which seems to have done quite a bit of 
 research, this started between 3.8-rc6 and 3.8-rc7 as well as stable 
 kernels and the bug also lists a few commits which could be the cause, 
 none under sound/usb though.
 
 There were no relevant changes for snd-usb between the two versions
 mentioned. The only patches that come in mind in this time window are:
 
  3e619d041 USB: EHCI: fix bug in scheduling periodic split transfers
  b09a61cc0 USB: EHCI: fix for leaking isochronous data

This last one, doesn't give me any problem, just a memory leak and not a choppy
playback (tested on 48Khz, 96Khz, 192Khz 32bit on OMAP3 device) and I don't
think that it can be the reason of the problem.

http://www.m2tech.biz/hiface_dac.html

Michael


 
 And they have both been back-ported to stable. Copied Alan for reference.
 
 Any chance some of the bug reporters could try and revert exactly those
 for testing?
 
 
 Thanks,
 Daniel
 
 ___
 Alsa-devel mailing list
 alsa-de...@alsa-project.org
 http://mailman.alsa-project.org/mailman/listinfo/alsa-devel


-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1136110

Title:
  USB Audio Codec choppy playback

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1136110/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1136110] Re: [alsa-devel] Asynchronous audio USB chips: choppy playback since 3.8-rc7

2013-04-03 Thread Michael Nazzareno Trimarchi
Hi Daniel

On 03/04/13 15:55, Michael Trimarchi wrote:
 Hi Daniel
 
 On 03/04/13 12:23, Daniel Mack wrote:
 Hi David,

 On 03.04.2013 12:15, David Henningsson wrote:
 Just to get your attention here on what seems to be an USB audio 
 regression.

 The bug is described in detail here:

 https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1136110?comments=all

 Quoting the bug:

 
 This bug seems to affect only a certain kind of hardware, which is 
 called Asynchronous USB Digital Audio Codec (DAC). It's said that such 
 a DAC hosts the clock itself (USB Device Host). An ordinary DAC, so 
 called Synchronous USB DAC, uses the clock hosted by the mother board, 
 which is not affected by this bug.

 When this bug affects an asynchronous USB DAC, the audio played by the 
 DAC is constantly interrupted. The playback itself does not stop, but 
 the output becomes discontinous, filling with constant crackling noises, 
 destroying everything the DAC plays.
 

 According to the bug reporter, which seems to have done quite a bit of 
 research, this started between 3.8-rc6 and 3.8-rc7 as well as stable 
 kernels and the bug also lists a few commits which could be the cause, 
 none under sound/usb though.

 There were no relevant changes for snd-usb between the two versions
 mentioned. The only patches that come in mind in this time window are:

  3e619d041 USB: EHCI: fix bug in scheduling periodic split transfers
  b09a61cc0 USB: EHCI: fix for leaking isochronous data
 
 This last one, doesn't give me any problem, just a memory leak and not a 
 choppy
 playback (tested on 48Khz, 96Khz, 192Khz 32bit on OMAP3 device) and I don't
 think that it can be the reason of the problem.

Sorry the comment was for a bug that is not included in this list and recently 
fixed.
USB: EHCI: fix bug in iTD/siTD DMA pool allocation

Michael

 
 http://www.m2tech.biz/hiface_dac.html
 
 Michael
 
 

 And they have both been back-ported to stable. Copied Alan for reference.

 Any chance some of the bug reporters could try and revert exactly those
 for testing?


 Thanks,
 Daniel

 ___
 Alsa-devel mailing list
 alsa-de...@alsa-project.org
 http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1136110

Title:
  USB Audio Codec choppy playback

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1136110/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1136110] Re: [alsa-devel] Asynchronous audio USB chips: choppy playback since 3.8-rc7

2013-04-03 Thread Michael Nazzareno Trimarchi
Hi Daniel

On 03/04/13 17:00, Daniel Mack wrote:
 Hi Michael,
 
 On 03.04.2013 16:11, Michael Trimarchi wrote:
 On 03/04/13 15:55, Michael Trimarchi wrote:
 On 03/04/13 12:23, Daniel Mack wrote:
 Hi David,

 On 03.04.2013 12:15, David Henningsson wrote:
 Just to get your attention here on what seems to be an USB audio 
 regression.

 The bug is described in detail here:

 https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1136110?comments=all

 Quoting the bug:

 
 This bug seems to affect only a certain kind of hardware, which is 
 called Asynchronous USB Digital Audio Codec (DAC). It's said that such 
 a DAC hosts the clock itself (USB Device Host). An ordinary DAC, so 
 called Synchronous USB DAC, uses the clock hosted by the mother board, 
 which is not affected by this bug.

 When this bug affects an asynchronous USB DAC, the audio played by the 
 DAC is constantly interrupted. The playback itself does not stop, but 
 the output becomes discontinous, filling with constant crackling noises, 
 destroying everything the DAC plays.
 

 According to the bug reporter, which seems to have done quite a bit of 
 research, this started between 3.8-rc6 and 3.8-rc7 as well as stable 
 kernels and the bug also lists a few commits which could be the cause, 
 none under sound/usb though.

 There were no relevant changes for snd-usb between the two versions
 mentioned. The only patches that come in mind in this time window are:

  3e619d041 USB: EHCI: fix bug in scheduling periodic split transfers
  b09a61cc0 USB: EHCI: fix for leaking isochronous data

 This last one, doesn't give me any problem, just a memory leak and not a 
 choppy
 playback (tested on 48Khz, 96Khz, 192Khz 32bit on OMAP3 device) and I don't
 think that it can be the reason of the problem.
 
 Is OMAP3 at all a platform that is affected by the bug? It seems the
 effect is only seen on some special host controller hardware anyway.
 

Yes, omap3 ehci and m2tech products is not affected and I'm testing a
dac with internal clock.

 Sorry the comment was for a bug that is not included in this list and 
 recently fixed.
 USB: EHCI: fix bug in iTD/siTD DMA pool allocation
 
 Sorry, you lost me. So what's the status of this issue now? Does USB:
 EHCI: fix bug in iTD/siTD DMA pool allocation fix it?

With or without it, I don't have any choppy audio and this is not a fix
of this bug.

 
 If not - and assuming you can reproduce the bug - which patches of the
 two I mentioned did you revert, and what was the effect of that? Did you
 try and remove both as well?

In my version I have the other two commits applied. I doubt that these two
commits are the reason of the choppy audio. What I can do, it test it on my
laptop tomorrow and send feedback result

Michael


 
 
 Thanks,
 Daniel


-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1136110

Title:
  USB Audio Codec choppy playback

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1136110/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs