[Bug 558841] Re: bluetooth devices menu item not working in bluetooth indicator
Cody's above patch for gtk+ (#16) fixes the reported bug. He mentioned that he is going to rework it to make it more acceptable to upstream and then, if I understand correctly, include it in a gtk+ SRU. -- bluetooth devices menu item not working in bluetooth indicator https://bugs.launchpad.net/bugs/558841 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 570809] Re: Favorites displays application short names
** Description changed: Binary package hint: netbook-launcher Tested on Lucid UNE 20100427.1 Items displayed by default in Favorites, and new items that are added show the application's short name instead of the full name. ie: Empathy instead of Empathy IM Client and Evolution instead of Evolution Mail and Calendar. This is an issue as the long names are important to figure out what an application does instead of just what it's called. ProblemType: Bug DistroRelease: Ubuntu 10.04 Package: netbook-launcher 1:2.1.17-0ubuntu1 ProcVersionSignature: Ubuntu 2.6.32-21.32-generic 2.6.32.11+drm33.2 Uname: Linux 2.6.32-21-generic i686 NonfreeKernelModules: wl Architecture: i386 Date: Tue Apr 27 12:07:42 2010 DkmsStatus: bcmwl, 5.60.48.36+bdcom, 2.6.32-21-generic, i686: installed InstallationMedia: Ubuntu-Netbook 10.04 LTS Lucid Lynx - Release i386 (20100427) MachineType: Hewlett-Packard HP Mini ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.32-21-generic root=UUID=57dae9dc-b65e-4af1-bfe8-b20ebd61594d ro quiet splash ProcEnviron: - LANG=en_CA.utf8 - SHELL=/bin/bash + LANG=en_CA.utf8 + SHELL=/bin/bash SourcePackage: netbook-launcher dmi.bios.date: 05/11/2009 dmi.bios.vendor: Hewlett-Packard dmi.bios.version: 361A0 Ver. F.13 dmi.board.name: 361A dmi.board.vendor: Hewlett-Packard dmi.board.version: KBC Version 02.11 dmi.chassis.asset.tag: CNU9124FGM dmi.chassis.type: 10 dmi.chassis.vendor: Hewlett-Packard dmi.modalias: dmi:bvnHewlett-Packard:bvr361A0Ver.F.13:bd05/11/2009:svnHewlett-Packard:pnHPMini:pvrF.10:rvnHewlett-Packard:rn361A:rvrKBCVersion02.11:cvnHewlett-Packard:ct10:cvr: dmi.product.name: HP Mini dmi.product.version: F.10 dmi.sys.vendor: Hewlett-Packard glxinfo: Error: [Errno 2] No such file or directory system: - distro: Ubuntu - codename: lucid - architecture: i686 - kernel: 2.6.32-21-generic + distro: Ubuntu + codename: lucid + architecture: i686 + kernel: 2.6.32-21-generic -- Favorites displays application short names https://bugs.launchpad.net/bugs/570809 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 570809] Re: Favorites displays application short names
I attempted to reproduce in the following scenarios: - fresh, up to date UNE Lucid install, using default - fresh, up to date UNE Lucid install, using netbook 2d login - live CD from UNE iso from April 27th In each of the scenarios, each time I added a new item to the favorites, the long descriptive name was used. Didier mentioned to me that this sounds like a bug that was fixed earlier in the Lucid cycle (don't have the bug # handy). As indicated by the information shared in the bug report, it certainly looks like you are running the latest Lucid though. Is this from a live CD or from an install? Any other information to reproduce this? ** Changed in: netbook-launcher (Ubuntu) Status: New = Incomplete -- Favorites displays application short names https://bugs.launchpad.net/bugs/570809 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 558841] Re: bluetooth devices menu item not working in bluetooth indicator
I've got what I believe is a somewhat minimal example reproducing this without the extraneous bluetooth: https://code.launchpad.net/~nafai/+junk/minimal-menu-example I have debug prints showing the menu structure and the ui manager xml output before and after I add a new menu item to the placeholder menu. For some reason I can't get the submenu items to add, but I think the is possibly orthogonal to the original problem. Hopefully this will be a start to being figuring out what is going on with the app indicator. -- bluetooth devices menu item not working in bluetooth indicator https://bugs.launchpad.net/bugs/558841 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 558841] Re: bluetooth devices menu item not working in bluetooth indicator
Quick update with more details. First, steps to reproduce this: 1. Make sure you have at least one device paired (but not necessarily connected), with your computer. 2. Start with Bluetooth turned off. If you have to turn off bluetooth (via the indicator menu), kill bluetooth-applet (killall bluetooth-applet) and then relaunch (bluetooth-applet ). 3. Turn on Bluetooth via the indicator menu. The individual menus for the devices won't show up and you will only see the Devices heading in the menu. Investigation so far: First, at Ted Gould's suggestion, I ran dbusmenu-dumper to see what dbusmenu was getting: /usr/lib/libdbusmenu/dbusmenu-dumper --dbus- name=org.gnome.Bluetooth.applet --dbus- object=/org/ayatana/NotificationItem/bluetooth_manager/Menu The output of this confirmed that it indeed was not getting the menus for the devices. Next, I added debug prints to libappindicator/appindicator.c where menuitems with labels were being added, in menuitem_iterate() and container_iterate(). Again, I confirmed that at this level the device menus were never seen. I next added debug prints to applet/main.c in gnome-bluetooth to trace which related functions were being called and also when the top level devices menus were being added. I have confirmed that they *are* being added at this level. Another detail, if I kill the bluetooth-applet while bluetooth is enabled, and then re-launch it, the device menus do show up. I'm not sure if there is a signal that isn't being caught or what. At the end of the function where the menu items are being added, there is a call to: gtk_ui_manager_ensure_update (uimanager); I think I remember something about this causing issues in the past, but I'm unsure. -- bluetooth devices menu item not working in bluetooth indicator https://bugs.launchpad.net/bugs/558841 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 558841] Re: bluetooth devices menu item not working in bluetooth indicator
I've pastebin'd the bluetooth-applet code: http://gist.github.com/366360#file_main.c Here's the appropriate functions to look at: update_device_list (starts line 749) add_menu_item (starts line 684) -- bluetooth devices menu item not working in bluetooth indicator https://bugs.launchpad.net/bugs/558841 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 558841] Re: bluetooth devices menu item not working in bluetooth indicator
Since the bug report indicated this worked in alpha3, but stopped working as of April 8th, I started testing versions of libappindicator starting from the release right after alpha3. This was 0.0.15-0ubuntu1. I checked out the release from lp:~ubuntu-desktop/indicator-application/ubuntu at each specific revision and built the packages using dpkg-buildpackage. The bug was first exhibited for me at package version 0.0.17-0ubuntu1, which is this branch revision: http://bazaar.launchpad.net/~ubuntu-desktop/indicator- application/ubuntu/revision/98 I am slightly confused because there doesn't seem to be anything here that I imagine would cause the kind of breakage being reported. The one concern I have about this testing method is that I am building the libappindicator package on an up to date system. Thus, I have different versions of the libappindicator dependencies than were likely in the archive at the time of the original package build. This might affect where the problem first arose. I think I'll need additional help from either Ted or Cody to figure out what might be going on here. -- bluetooth devices menu item not working in bluetooth indicator https://bugs.launchpad.net/bugs/558841 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 558841] Re: bluetooth devices menu item not working in bluetooth indicator
Kevin: that's okay, it was working at alpha3 so that was a good starting point. :) I hope I'm not being too verbose in my comments, I'm just trying to track where I am and have everything documented so I can get additional help. -- bluetooth devices menu item not working in bluetooth indicator https://bugs.launchpad.net/bugs/558841 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 558841] Re: bluetooth devices menu item not working in bluetooth indicator
Sorry for lack of status updates, keep forgetting. :) I've narrowed it down to the see where the behavior is exhibiting in the code and am exploring whether this is caused by a problem in the gnome- bluetooth code itself or a change/regression in app indicator libraries. I should have the issue itself discovered and hopefully fixed or at least passed to the DX team today. ** Changed in: gnome-bluetooth (Ubuntu) Status: Confirmed = In Progress -- bluetooth devices menu item not working in bluetooth indicator https://bugs.launchpad.net/bugs/558841 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 558841] Re: bluetooth devices menu item not working in bluetooth indicator
I can reproduce, looking into the cause. ** Changed in: gnome-bluetooth (Ubuntu) Status: New = Confirmed -- bluetooth devices menu item not working in bluetooth indicator https://bugs.launchpad.net/bugs/558841 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 554005] Re: accessing keyring from python threads sometimes causes 100% CPU utilization
I'm working on this today since kenvandine is out. It has been discovered that accessing gnomekeyring from a thread is causing these CPU problems. What I am going to do is move the calls to gnomekeyring to before gwibber-service starts threads and store that data in mlock()'d memory. Then, replace the previous calls to gnomekeyring to calls to access that mlock()'d memory. I hope to have a branch pushed by end of day for kenvandine to review. -- accessing keyring from python threads sometimes causes 100% CPU utilization https://bugs.launchpad.net/bugs/554005 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 554005] Re: accessing keyring from python threads sometimes causes 100% CPU utilization
** Branch linked: lp:~nafai/gwibber/gnomekeyring-fix -- accessing keyring from python threads sometimes causes 100% CPU utilization https://bugs.launchpad.net/bugs/554005 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 497894] Re: Support Application Indicators
Unassigned myself as I didn't get to this in time for Lucid and my responsibilities have now changed. ** Changed in: bacula (Ubuntu) Assignee: Travis B. Hartwell (nafai) = (unassigned) -- Support Application Indicators https://bugs.launchpad.net/bugs/497894 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to bacula in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 497897] Re: Support Application Indicators
Unassigned myself as I didn't get to this in time for Lucid and my responsibilities are now different. ** Changed in: epiphany-browser (Ubuntu) Assignee: Travis B. Hartwell (nafai) = (unassigned) -- Support Application Indicators https://bugs.launchpad.net/bugs/497897 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 497894] Re: Support Application Indicators
Unassigned myself as I didn't get to this in time for Lucid and my responsibilities have now changed. ** Changed in: bacula (Ubuntu) Assignee: Travis B. Hartwell (nafai) = (unassigned) -- Support Application Indicators https://bugs.launchpad.net/bugs/497894 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 533775] Re: No icon for volume or typing break after upgrade to lucid
I can reproduce the situation the bug reporter describes (indicator applet removed from panel in Karmic, gnome typing monitor enabled, and then upgrade to Lucid, no icon shown. The failback is working in so much that a status icon is shown because there is no indicator applet, but an incorrect icon is shown. Will continue to investigate the cause and a potential fix. ** Changed in: gnome-control-center (Ubuntu) Status: New = Confirmed -- No icon for volume or typing break after upgrade to lucid https://bugs.launchpad.net/bugs/533775 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 548891] Re: keyboard input broken at gnome login prompt after package updates
I've looked into it a bit, but could not reproduce under this configuration: VMware Player version 3.0.1 build-227600 Host is 64-bit Lucid system up to date as of today Guest is 64-bit Lucid system up to date as of today Tried both with and without VMware Tools installed. VMware Tools version 8.1.4-227600 downloaded today. No keyboard issues at all in the gdm login screen. I note however that this is using a Ubuntu host, whereas from reading the original report and previous comments, it seems the problem is exhibited on OS X and Windows hosts. I don't have access to either OS X or Windows, so someone else will have to test. -- keyboard input broken at gnome login prompt after package updates https://bugs.launchpad.net/bugs/548891 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 528694] Re: application indicator does not refresh on/off state
I tried building jpetersen's latest branch: https://code.launchpad.net/~jpetersen/indicator-application/actions- notify-workaround and that seems to fix this bug. -- application indicator does not refresh on/off state https://bugs.launchpad.net/bugs/528694 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 532104] [NEW] Fix app indicator classification and other minor issues
Public bug reported: Binary package hint: gnome-bluetooth This updated patch is to address feedback from Sebastien that was missed from: https://bugs.launchpad.net/ubuntu/+source/gnome- bluetooth/+bug/497856/comments/2 Including: - Changing the category to APP_INDICATOR_CATEGORY_HARDWARE - Instead of not doing anything when bluetooth applet requests to blink, change to the APP_INDICATOR_STATUS_ATTENTION status. Currently, we don't have a separate icon for this and I'm not entirely sure how this is triggered. Doing this for code completeness. Also, a change to address this: https://bugs.launchpad.net/ubuntu/+source/gnome-bluetooth/+bug/497856/comments/3 - Adding to the configure summary to display if app indicators are used. ** Affects: gnome-bluetooth (Ubuntu) Importance: Undecided Assignee: Canonical Desktop Team (canonical-desktop-team) Status: In Progress ** Tags: patch ** Changed in: gnome-bluetooth (Ubuntu) Status: New = In Progress ** Changed in: gnome-bluetooth (Ubuntu) Assignee: (unassigned) = Travis B. Hartwell (nafai) -- Fix app indicator classification and other minor issues https://bugs.launchpad.net/bugs/532104 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 532104] Re: Fix app indicator classification and other minor issues
Updated gnome-bluetooth patch to replace file in debian/patches. ** Patch added: app-indicators-after-feedback.patch http://launchpadlibrarian.net/40188489/app-indicators-after-feedback.patch ** Tags added: patch ** Changed in: gnome-bluetooth (Ubuntu) Assignee: Travis B. Hartwell (nafai) = Canonical Desktop Team (canonical-desktop-team) -- Fix app indicator classification and other minor issues https://bugs.launchpad.net/bugs/532104 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 528527] Re: Extraneous icons throw off alignment in indicator menu
This removes the icons from the menus in the app-indicator. Per my conversation with Sebastien on #ayatana, I have made this as a replacement for the existing app indicators patch so it can replace the existing patch in the debian/patches directory. ** Patch added: Support for app-indicators with icons disabled from menus. http://launchpadlibrarian.net/40109760/app-indicators-no-icons.patch ** Tags added: patch ** Changed in: gnome-bluetooth (Ubuntu) Assignee: Travis B. Hartwell (nafai) = Canonical Desktop Team (canonical-desktop-team) -- Extraneous icons throw off alignment in indicator menu https://bugs.launchpad.net/bugs/528527 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 497853] Re: Support application indicators
To address Martin's concerns, I discussed with mpt what the appropriate user interaction here should be. I did the following: - I reverted the cancel menu item back to using GTK_STOCK_CANCEL so it will be translated and then did some additional work to remove the icon from being displayed. - Since the application indicator does not give any more information than the dialog does, I removed the change of the menu item from cancel - close. Instead, when the burn is finished, the application indicator is hidden and the dialog is shown if hidden. When the dialog is destroyed, the application indicator is also destroyed. Hopefully this has both made the interaction simpler and also removed the string translation issue. Thanks for the feedback Martin. ** Patch added: App Indicators patch addressing Martin's concerns. http://launchpadlibrarian.net/40110067/app-indicators-take-4.patch -- Support application indicators https://bugs.launchpad.net/bugs/497853 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 497853] Re: Support application indicators
** Changed in: brasero (Ubuntu Lucid) Status: Incomplete = In Progress ** Changed in: brasero (Ubuntu Lucid) Assignee: Travis B. Hartwell (nafai) = Martin Pitt (pitti) -- Support application indicators https://bugs.launchpad.net/bugs/497853 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 497853] Re: Support application indicators
Change to proper state, per seb128. ** Changed in: brasero (Ubuntu Lucid) Status: Fix Committed = In Progress ** Changed in: brasero (Ubuntu Lucid) Assignee: Ken VanDine (ken-vandine) = Travis B. Hartwell (nafai) -- Support application indicators https://bugs.launchpad.net/bugs/497853 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 497853] Re: Support application indicators
This patch fixes a bug found by Ken by changing the cancel menu item to close to emulate the behavior of the old GtkStatusIcon. It also removes the icons from the menu items to make the menu formatting look correct. ** Patch added: Updated patch to add support for app indicators http://launchpadlibrarian.net/39933276/app-indicators-take-3.patch -- Support application indicators https://bugs.launchpad.net/bugs/497853 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 497853] Re: Support application indicators
Ready for re-review. Note that this change is as invasive as the change to vino, bug #497883, and perhaps should first be vetted upstream as Martin suggested for vino. ** Changed in: brasero (Ubuntu Lucid) Assignee: Travis B. Hartwell (nafai) = Canonical Desktop Team (canonical-desktop-team) -- Support application indicators https://bugs.launchpad.net/bugs/497853 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 497883] Re: Support Application Indicators
** Patch added: String changes in glade .ui file. http://launchpadlibrarian.net/39938698/glade-changes.patch -- Support Application Indicators https://bugs.launchpad.net/bugs/497883 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 497883] Re: Support Application Indicators
All of the strings contained within this patch are copies of existing strings or are not in the UI, so no additional translations are necessary. ** Patch added: App indicator changes indpendent of string changes to glade http://launchpadlibrarian.net/39938759/app-indicators-only.patch -- Support Application Indicators https://bugs.launchpad.net/bugs/497883 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 528527] Re: Extraneous icons throw off alignment in indicator menu
** Changed in: gnome-bluetooth (Ubuntu) Status: Triaged = In Progress -- Extraneous icons throw off alignment in indicator menu https://bugs.launchpad.net/bugs/528527 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 497883] Re: Support Application Indicators
Forgot to mark In Progress while working on it, whoops. The porting of the VinoStatusTubeIcon have been untested, as it is not obvious how to test that. However the port of the VinoStatusIcon has been fully tested.?field.comment=Forgot to mark In Progress while working on it, whoops. The porting of the VinoStatusTubeIcon have been untested, as it is not obvious how to test that. However the port of the VinoStatusIcon has been fully tested. ** Changed in: vino (Ubuntu) Status: Triaged = In Progress ** Patch added: Patch to use Application Indicators http://launchpadlibrarian.net/39754560/app-indicators.patch ** Tags added: patch ** Changed in: vino (Ubuntu) Assignee: Travis B. Hartwell (nafai) = Canonical Desktop Team (canonical-desktop-team) -- Support Application Indicators https://bugs.launchpad.net/bugs/497883 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 497856] Re: Support application indicator
Still affected by bug #524308 -- the checkbox toggle is not shown. But is otherwise functionally and visually identical to the GtkStatusIcon version. ** Patch added: Patch to support application indicators in gnome-bluetooth http://launchpadlibrarian.net/39625652/app-indicators.patch ** Tags added: patch ** Changed in: gnome-bluetooth (Ubuntu) Status: In Progress = Fix Committed ** Changed in: gnome-bluetooth (Ubuntu) Assignee: Travis B. Hartwell (nafai) = Canonical Desktop Team (canonical-desktop-team) -- Support application indicator https://bugs.launchpad.net/bugs/497856 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 497894] Re: Support Application Indicators
** Changed in: bacula (Ubuntu) Assignee: (unassigned) = Travis B. Hartwell (nafai) -- Support Application Indicators https://bugs.launchpad.net/bugs/497894 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to bacula in ubuntu. -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 497897] Re: Support Application Indicators
** Changed in: epiphany-browser (Ubuntu) Assignee: (unassigned) = Travis B. Hartwell (nafai) -- Support Application Indicators https://bugs.launchpad.net/bugs/497897 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 497894] Re: Support Application Indicators
** Changed in: bacula (Ubuntu) Assignee: (unassigned) = Travis B. Hartwell (nafai) -- Support Application Indicators https://bugs.launchpad.net/bugs/497894 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 497881] Re: Support Application Indicators
policykit-gnome is deprecated, and policykit-1-gnome is the one that uses GtkStatusIcon currently anyway. ** Package changed: policykit-gnome (Ubuntu) = policykit-1-gnome (Ubuntu) -- Support Application Indicators https://bugs.launchpad.net/bugs/497881 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 497881] Re: Support Application Indicators
** Changed in: policykit-gnome (Ubuntu) Assignee: Canonical Desktop Experience Team (canonical-dx-team) = Travis B. Hartwell (nafai) -- Support Application Indicators https://bugs.launchpad.net/bugs/497881 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 497857] Re: Support application indicators
Thank you for your work there, some comment:
GtkStatusIcon *icon;
-
Why the blank line change?
These were probably all unintentional, I have since found a parameter
with git diff that allows me to ignore whitespace changes when
creating diffs that I will use. They partly came from calling M-x
delete-trailing-whitespace in Emacs, which possibly removed whitespace
that was there in the original code. I'll make sure there are no
extraneous lines in future patches.
+#ifdef HAVE_APP_INDICATOR
+const char TYPING_MONITOR_ACTIVE_ICON[] = bar-green;
+const char TYPING_MONITOR_ATTENTION_ICON[] = bar-red;
you can use #define TYPING_MONITOR_ACTIVE_ICON bar-green rather, that's
what GNOME does usually
Good hint, thanks.
+static gint get_time_left (DrWright *drwright);
this change seems to be code cleaning
I did this so I didn't copy and paste code between the two methods
that needed this functionality between the old update_tooltip () and
the new update_menu_text () functionality.
+update_app_indicator (DrWright *dr)
+current_status = app_indicator_get_status (dr-indicator);
+if (new_status != current_status) {
no need to get the current status and compare to the new one in this function,
could can just call set_status on the new one, if there is no status change
that will just do nothing
Good to know, I noticed you asking this question earlier, I'll remove
the extraneous check.
+#ifndef HAVE_APP_INDICATOR
gtk_status_icon_set_from_pixbuf (dr-icon,
dr-composite_bar);
+#endif
} else {
+#ifndef HAVE_APP_INDICATOR
gtk_status_icon_set_from_pixbuf (dr-icon,
dr-neutral_bar);
+#endif
no need to have 2 ifndef there, you can as well use one since there no action
to do in either case
Oh duh. :)
stop_blinking (dr);
+
the new line adding there doesn't seem required
+const gchar normal_msg_template[] = Take a break now (next in %dm);
+const gchar less_than_one_msg_template[] = Take a break now (next in
less than one minute);
why do you use strings different than the upstream ones? the upstream labels
indicate that the indication is the time before next break where you state
take a break now, did you change how the software works? aren't just menu
indications about the next break? in that's the case where should the user
take a break now when looking when is the next one?
This was from a suggestion from mpt. Previously, the information on
how much time left was indicated via a tooltip, which application
indicators don't support.
To quote from an e-mail from mpt:
-- quote --
For the typing break in particular, I suggest including the time in the
Take a Break item, like this:
..
| Take a Break Now (next in 7m) |
||
| Settings… |
| About Typing Break |
''
--- end quote ---
The reason we shortened the text there is the previous strings were
really long and would have made the menu strangely long. I tried not
to change the way the software works, just the way in which the
current information is conveyed. Would be it be clearer if the time
left was an insensitive menu item alone at the very top of the menu?
is ngettext() required there is the singular and plurial forms have no change?
Probably not, I bet I could just use the _N() macro.
+get_time_left (DrWright *dr)
+{
+gint elapsed_time, min;
the min variable seems not required there, you can as well use return directly
the value
Good catch, I'll fix that.
init_tray_icon (dr);
-
g_timeout_add_seconds (12,
the blank line change is not required
As noted above, whoops.
--
Support application indicators
https://bugs.launchpad.net/bugs/497857
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 497857] Re: Support application indicators
Attached is an updated patch: 1) following recommendations from Sebastien above 2) updating the configure.ac with the latest suggestions from Ken ** Patch added: Patch for app indicators, take 2 http://launchpadlibrarian.net/39031554/app-indicators-take2.patch -- Support application indicators https://bugs.launchpad.net/bugs/497857 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 497857] Re: Support application indicators
Hopefully final changes, based on what Sebastien pointed out on IRC, and another thing I noticed: 1) preprocessed out the code to blink completely in the case of using app indicators 2) the #ifdef/#endif's sometimes were separated by a bit, so I added a comment on each #endif to be #endif /* HAVE_APP_INDICATOR */ ?field.comment=Hopefully final changes, based on what Sebastien pointed out on IRC, and another thing I noticed: 1) preprocessed out the code to blink completely in the case of using app indicators 2) the #ifdef/#endif's sometimes were separated by a bit, so I added a comment on each #endif to be #endif /* HAVE_APP_INDICATOR */ Should be ready for upstream. ** Patch added: Take 3 http://launchpadlibrarian.net/39033229/app-indicators-take3.patch -- Support application indicators https://bugs.launchpad.net/bugs/497857 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 497853] Re: Support application indicators
Not sure how to best remove the code duplication, so pending any other suggestions from Ken, likely ready for upstream review. ** Patch added: Updated patch with configure.in changes suggested by Ken http://launchpadlibrarian.net/38928367/app-indicators-take-2.patch -- Support application indicators https://bugs.launchpad.net/bugs/497853 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 497857] Re: Support application indicators
Note: As agreed on with jcastro, this only supports showing green when plenty of time before locked - showing red right before - locking. The original behavior shows gradients of green as time progresses and then flashing red right before locking, then red when locked. ** Patch added: Support for application indicators http://launchpadlibrarian.net/38931559/app-indicators.patch ** Changed in: gnome-control-center (Ubuntu) Status: In Progress = Fix Committed ** Changed in: gnome-control-center (Ubuntu) Assignee: Travis B. Hartwell (nafai) = Ken VanDine (ken-vandine) -- Support application indicators https://bugs.launchpad.net/bugs/497857 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 497853] Re: Support application indicators
Patch was made against upstream git tag BRASERO_2_29_6, matching the version in Lucid, and I have verified patch both cleanly applies against the original tarball acquired via apt-get source -d brasero (using patch -p0) and against git HEAD (via git rebase). Feature complete with the following caveats. particularly to make it upstream acceptable: - Probably need to add a flag to configure like --enable/disable-app-indicators. My autoconf foo is weak, so I left that undone. - When compiling with app-indicator support, libbrasero-burn/brasero-tray is still compiled and linked, which is unnecessary. I tried added #ifdefs in Makefile.am around the lines which included brasero-tray.c and brasero-tray.h, but that didn't work. - I have code duplication between the existing libbrasero-burn/brasero-tray.c and the new libbrasero-burn/brasero-app-indicator.c, due to a cut and paste job to get started. The areas I'm concerned about: - in libbrasero-burn/brasero-app-indicator.c, the function brasero_app_indicator_set_progress_menu_text (starting line 227) is largely a copy of libbrasero-burn/brasero-tray.c, the function brasero_tray_icon_set_tooltip (starting line 244), except for the portion where the menu item label is set vs. the original tooltip being set. - similarly, libbrasero-burn/brasero-app-indicator.c, function brasero_app_indicator_set_progress (starting line 281) is largely a copy of libbrasero-burn/brasero-tray.c, function brasero_tray_icon_set_progress (starting line 293), except for the calls to set the tooltip and set the icon. I wasn't sure how to address these the best. It didn't make sense to inherit BraseroAppIndicator from BraseroTrayIcon because BraseroTrayIcon itself is a sub-class of GtkStatusIcon. Should I just move the common calculation / string creation methods out to a separate .h/.c pair and call those from each? That leaves the question of where to free the string. Any other suggestions would be great so I can improve my patches in the future. ** Patch added: Patch to use Application Indicators http://launchpadlibrarian.net/38906062/app-indicators.patch -- Support application indicators https://bugs.launchpad.net/bugs/497853 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 497853] Re: Support application indicators
Will attach patch to upstream bug after Ken has had a chance to review it. ** Changed in: brasero (Ubuntu Lucid) Status: In Progress = Fix Committed ** Changed in: brasero (Ubuntu Lucid) Assignee: Travis B. Hartwell (nafai) = Ken VanDine (ken-vandine) -- Support application indicators https://bugs.launchpad.net/bugs/497853 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 497856] Re: Support application indicator
** Changed in: gnome-bluetooth (Ubuntu) Status: New = In Progress -- Support application indicator https://bugs.launchpad.net/bugs/497856 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 497853] Re: Support application indicators
** Changed in: brasero (Ubuntu Lucid) Status: Triaged = In Progress -- Support application indicators https://bugs.launchpad.net/bugs/497853 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 497857] Re: Support application indicators
** Changed in: gnome-control-center (Ubuntu) Status: Triaged = In Progress -- Support application indicators https://bugs.launchpad.net/bugs/497857 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 296880] [NEW] Vuze won't launch if default Java is not Java 6
Public bug reported: Binary package hint: azureus The azureus package depends on default-jre, which is java 6 on Interpid. The code is compiled with a Java 6 compiler. But, I have my system /usr/bin/java set to Java 5 via the alternatives mechanism. Launching Vuze from the menu silently fails. Launching it from a terminal shows that there is a wrong class file version. I fixed this by copying /usr/bin/vuze, editing the line that sets the java environment variable to point specifically to the java 6 version and then setting the JAVA_HOME appropriately in the terminal where I launched vuze. If Vuze depends on Java 6, you should probably hard code the path of the Java 6 JRE/JDK in the shell script to launch it. Attached is a patch of what I did to the shell script to get it to launch. ** Affects: azureus (Ubuntu) Importance: Undecided Status: New -- Vuze won't launch if default Java is not Java 6 https://bugs.launchpad.net/bugs/296880 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 296880] Re: Vuze won't launch if default Jjava is not Java 6
** Attachment added: vuze.patch http://launchpadlibrarian.net/19571752/vuze.patch ** Summary changed: - Vuze won't launch if default Jjava is not Java 6 + Vuze won't launch if default Java is not Java 6 -- Vuze won't launch if default Java is not Java 6 https://bugs.launchpad.net/bugs/296880 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 30447] Re: Lockup problems with both the free xorg ATI driver and the proprietary fglrx driver, using various ATI cards
I use an ATI 9700 Pro in my desktop machine. I get no lock-ups with the recent kernels, except when I try to switch users. Since my wife and I share the computer, I need to be able to switch users. I would also like to have hardware acceleration so I can play around with Google Earth, Xgl and other things, but the free drivers do not support accelerated video on the R300 chipset-based cards. I really would like this to work...not sure if it is an ATI issue or an Ubuntu issue, but probably it is something with the closed drivers. -- Lockup problems with both the free xorg ATI driver and the proprietary fglrx driver, using various ATI cards https://launchpad.net/bugs/30447 -- kubuntu-bugs mailing list kubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
