[Bug 1046461] Re: [UIFe] UOA integration needs to support multiple accounts
Patch is ready for review (I hope I submitted it on the correct project): https://code.launchpad.net/~mardy/shotwell/uoa-update/+merge/124126 ** Branch linked: lp:~mardy/shotwell/uoa-update -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1046461 Title: [UIFe] UOA integration needs to support multiple accounts To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/shotwell/+bug/1046461/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1046461] Re: [UIFe] UOA integration needs to support multiple accounts
Hi Aaron, thanks for your advice! So, the embedding can be done, in theory, but I wouldn't recommend it for a series of reasons of which the main one is the dialog sizing. But your suggestion of checking whether the OAuth token is still valid before showing the login button is a good one. Indeed it makes the code a bit more complicated, but that's life. :-) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1046461 Title: [UIFe] UOA integration needs to support multiple accounts To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/shotwell/+bug/1046461/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1046461] Re: [UIFe] UOA integration needs to support multiple accounts
Alberto, I find that it is uncommon that the Oauth token has expired. I have never been prompted to login on the website before publishing, so clicking the "login" button seems pointless. If the OAuth web site is truly a pop-up, I can see the problem with automatically launching it, since it would get in the way and steal focus. I think this could be fixed by either - embedding the web site in the form, so that it doesn't steal focus or block the UI. That way, you can start loading the web site as soon as the the user selects "publish". - detect whether the OAuth token has not expired, and skip the login step. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1046461 Title: [UIFe] UOA integration needs to support multiple accounts To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/shotwell/+bug/1046461/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1046461] Re: [UIFe] UOA integration needs to support multiple accounts
Hi Adam, and sorry for the late reply. I didn't explain the issue properly, so I'll try again. :-) The current situation is: 1) The user chooses a picture and chooses the "Publish" option from the menu 2) A dialog appears, showing a combobox with the available services, and a login button 3) (optional) The user chooses the desired service, if different from the already selected one 4) The user clicks on the login button 5) (if the OAuth token has expired) A modal dialog (created in the signon-ui process) pops up, embedding the website login page for OAuth 6) Account informations are retrieved 7) The publishing dialog is ready: the user can change some options, if desired, and start the upload. Now, point 6 takes some time to execute, and point 5 is even heavier, because besides taking some time, it requires user interaction. If we remove the login step, and attempt to login automatically, points 5 and 6 will be executed automatically as the user starts publishing, and whenever he changes the publishing service. Now, suppose that the pre-selected service is not what the user wants. There's the risk that the OAuth dialog from step 5 would appear, prompting the user to login to a service which he doesn't want to use. Sure, the user can cancel it and continue selecting another service, but it seems better to me to avoid starting logging in to a service which the user might not want to use. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1046461 Title: [UIFe] UOA integration needs to support multiple accounts To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/shotwell/+bug/1046461/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1046461] Re: [UIFe] UOA integration needs to support multiple accounts
Alberto, I don't understand. Today, I can select a service and log in, but that doesn't block me from selecting another service. Couldn't we remove the buttons and simply log in automatically whenever the user selects any service? Why would the service selector need to be a dialog in this case? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1046461 Title: [UIFe] UOA integration needs to support multiple accounts To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/shotwell/+bug/1046461/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1046461] Re: [UIFe] UOA integration needs to support multiple accounts
About the login/logout buttons, I wouldn't remove them: without them, the session will start as soon as the value of the service selector changes, blocking the user from selecting another service. Indeed it would make sense to remove them, but only if the overall publishing flow is changed (for instance, making the service selector a dialog of its own) -- but unfortunately I think we don't have time to change all that now. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1046461 Title: [UIFe] UOA integration needs to support multiple accounts To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/shotwell/+bug/1046461/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1046461] Re: [UIFe] UOA integration needs to support multiple accounts
Sorry, I actually had this written here : https://docs.google.com/a/canonical.com/document/d/1UwAQTXgEyZSD3di6fAUS0W18rKxh8TXb1TwsmkgbGG0/edit#bookmark=kix.lzetjp1y4jv1 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1046461 Title: [UIFe] UOA integration needs to support multiple accounts To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/shotwell/+bug/1046461/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1046461] Re: [UIFe] UOA integration needs to support multiple accounts
Alternatively, Shotwell could maintain it's list of compatible accounts as is, but for accounts that are not activated display this https://docs.google.com/a/canonical.com/document/d/1UwAQTXgEyZSD3di6fAUS0W18rKxh8TXb1TwsmkgbGG0/edit#heading=h.9dy9njhiq1qo -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1046461 Title: [UIFe] UOA integration needs to support multiple accounts To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/shotwell/+bug/1046461/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1046461] Re: [UIFe] UOA integration needs to support multiple accounts
For improving discoverability, I plan to have an "Add more accounts..." element as the last one in the services selector, which will open the Online Accounts panel. Calum, unless you propose something else, I'll go for this implementation. ** Changed in: shotwell (Ubuntu) Status: New => In Progress ** Tags added: needs-design -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1046461 Title: [UIFe] UOA integration needs to support multiple accounts To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/shotwell/+bug/1046461/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
