[Bug 1128952]
FWIW, we do have regression tests for most of the libraries. They use raw output format (which just prints the API calls and their arguments) and flat ODF for comparison. And we run them before every release. There is none for libmspub yet, because noone has invested the time to create a representative set of documents. (Well, we need a better set of documents for libcdr and libvisio too. With a clear license, so we can actually make them public.) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1128952 Title: libmspub should have tests To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1128952/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1128952] Re: libmspub should have tests
** Changed in: df-libreoffice Status: Confirmed = Won't Fix -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1128952 Title: libmspub should have tests To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1128952/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1128952]
Just a few comments: convwatch looks like a bad idea and maybe a bit unreliable for libmspub, libvisio and libcdr But since all three of them implement interfaces they could all easily use mocking similar to libcmis and orcus. The advantage with mocking compared to a visual comparison that I see is that as long as the libs are under heavy development you have a high rate of false positives while mocking allows you to concentrate on the features that you wish to test. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1128952 Title: libmspub should have tests To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1128952/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1128952] [NEW] libmspub should have tests
Public bug reported: Neither upstream nor the packaging introduces tests for libmspub. We should really have them! ** Affects: df-libreoffice Importance: Unknown Status: Unknown ** Affects: libmspub (Ubuntu) Importance: Undecided Status: New ** Bug watch added: freedesktop.org Bugzilla #61050 https://bugs.freedesktop.org/show_bug.cgi?id=61050 ** Also affects: df-libreoffice via https://bugs.freedesktop.org/show_bug.cgi?id=61050 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1128952 Title: libmspub should have tests To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1128952/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1128952] Re: libmspub should have tests
Launchpad has imported 2 comments from the remote bug at https://bugs.freedesktop.org/show_bug.cgi?id=61050. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. On 2013-02-18T09:51:45+00:00 Björn Michaelsen wrote: The Microsoft Publisher import in libmspub could profit of tests against regressions of the conversion by comparing known good files to the expected result. Caolán McNamaras convwatch: http://www.openoffice.org/qa/qadevOOo_doc/convwatch/convwatch.html shows a possible starting point for the concept as applied to a different part of the product. Reply at: https://bugs.launchpad.net/ubuntu/+source/libmspub/+bug/1128952/comments/0 On 2013-02-18T10:03:47+00:00 Dtardon wrote: The latest rewrite of convwatch is http://cgit.freedesktop.org/libreoffice/core/tree/bin/convwatch.py Reply at: https://bugs.launchpad.net/ubuntu/+source/libmspub/+bug/1128952/comments/1 ** Changed in: df-libreoffice Status: Unknown = Confirmed ** Changed in: df-libreoffice Importance: Unknown = Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1128952 Title: libmspub should have tests To manage notifications about this bug go to: https://bugs.launchpad.net/df-libreoffice/+bug/1128952/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs