[Bug 1263229] Re: [maguro] Query CLIR SS returns unexpected values
More testing reveals that depends more on the operator than on the phone: Pepephone operator, krillin, arale and mako: test-ss "*31#" -> Number shown in called phone. Shown status is "disabled". test-ss "#31#" -> Number not shown in called phone. Shown status is "disabled". Vodafone operator, krillin and mako: test-ss "*31#" -> Number shown in called phone. Shown status is "disabled". test-ss "#31#" -> Number not shown in called phone. Shown status is "enabled". -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1263229 Title: [maguro] Query CLIR SS returns unexpected values To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ofono/+bug/1263229/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1263229] Re: [maguro] Query CLIR SS returns unexpected values
More combinations are possible... krillin: test-ss "*31#" -> Number shown in called phone. Shown status is "disabled". test-ss "#31#" -> Number not shown in called phone. Shown status is "enabled". arale: test-ss "*31#" -> Number shown in called phone. Shown status is "disabled". test-ss "#31#" -> Number not shown in called phone. Shown status is "disabled". -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1263229 Title: [maguro] Query CLIR SS returns unexpected values To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ofono/+bug/1263229/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1263229] Re: [maguro] Query CLIR SS returns unexpected values
@Alfonso Did we ever resolve this in our rilmodem code? I guess since maguro is no longer supported, we would've changed the logic based on mako's behavior. How would this bug manifest itself to an end-user? I don't think we expose the line number presentation as a system settings ( I wonder if this is a GCF-required feature ), so the end-user would most likely on encounter this when entering the USSD commands via the dialpad. I guess the end-result would be that the query and/or toggle of clir would be broken on maguro... ** Changed in: ofono (Ubuntu) Status: Confirmed => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1263229 Title: [maguro] Query CLIR SS returns unexpected values To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ofono/+bug/1263229/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1263229] Re: [maguro] Query CLIR SS returns unexpected values
As this is a maguro bug, I'd like to close it out as WontFix, but I'd like to ensure that we handled this in the rilmodem layer. At minimum, we've hopefully added comments to the code involved so that this can be handled for future modems? ** Changed in: ofono (Ubuntu) Importance: High => Low -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1263229 Title: [maguro] Query CLIR SS returns unexpected values To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ofono/+bug/1263229/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1263229] Re: [maguro] Query CLIR SS returns unexpected values
It looks like the logic for this SS is really messed up in some modems.
Network-wise, what I see is:
mako:
test-ss "*31#" -> No line number shown in called phone. Shown status is
"disabled".
test-ss "#31#" -> Line number shown in called phone. Shown status is "enabled".
maguro:
test-ss "*31#" -> Line number shown in called phone. Shown status is "enabled".
test-ss "#31#" -> No line number shown in called phone. Shown status is
"enabled".
In both cases, RIL_REQUEST_SET_CLIR is the same for the same string
(*31# or #31#). SIM card is the same.
RIL_REQUEST_GET_CLIR returns:
mako:
After (test-ss "*31#"): {2,4}
After (test-ss "#31#"): {1,4}
maguro:
After (test-ss "*31#"): {2,3}
After (test-ss "#31#"): {1,4}
The reason for the different status displayed is because of the
interpretation that is done by the second integer in core ofono
call_settings.c:
case CLIR_STATUS_TEMPORARY_RESTRICTED: // 3
if (override == OFONO_CLIR_OPTION_SUPPRESSION) // 2
value = "enabled";
else
value = "disabled";
break;
case CLIR_STATUS_TEMPORARY_ALLOWED: // 4
if (override == OFONO_CLIR_OPTION_INVOCATION) // 1
value = "enabled";
else
value = "disabled";
break;
The values returned by maguro do not really match this.
To complicate things more, ofono core uses inverse logic when
activating/deactivating this SS. For control type
SS_CONTROL_TYPE_ACTIVATION, it calls
clir_set(OFONO_CLIR_OPTION_SUPPRESSION), and for
SS_CONTROL_TYPE_DEACTIVATION it calls
clir_set(OFONO_CLIR_OPTION_INVOCATION). I do not think this is right,
but it certainly matches maguro's behaviour, but not mako's (that is the
reason for having the # command activating the SS instead of the *
command, which seems to be the right thing looking at the standards).
So, my conclusion is that not all modems behave the right way regarding
this SS and somewhat the messy ofono core code proves this. To get this
right in both mako and maguro, we need different implementations, or
detect the modem type and behave accordingly.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1263229
Title:
[maguro] Query CLIR SS returns unexpected values
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ofono/+bug/1263229/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
