[Bug 1272363] Re: test failures with python 3.4: WARNING: help() not available - check site.py
** Changed in: ipython (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1272363 Title: test failures with python 3.4: WARNING: help() not available - check site.py To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ipython/+bug/1272363/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1272363] Re: test failures with python 3.4: WARNING: help() not available - check site.py
Excellent, thank you! ** Changed in: ipython (Ubuntu) Status: Triaged => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1272363 Title: test failures with python 3.4: WARNING: help() not available - check site.py To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ipython/+bug/1272363/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1272363] Re: test failures with python 3.4: WARNING: help() not available - check site.py
Thanks, that makes sense now - I didn't see it becaus I was testing with master and 1.x, both of which already had that code removed. Expect release candidates for 1.2 soon. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1272363 Title: test failures with python 3.4: WARNING: help() not available - check site.py To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ipython/+bug/1272363/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1272363] Re: test failures with python 3.4: WARNING: help() not available - check site.py
this was fixed upstream in https://github.com/ipython/ipython/issues/4738 as trusty will most likely have the next bugfix release this will solve itself soon, thanks for the triaging -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1272363 Title: test failures with python 3.4: WARNING: help() not available - check site.py To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ipython/+bug/1272363/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1272363] Re: test failures with python 3.4: WARNING: help() not available - check site.py
Ah, the warning is from ipython itself: IPython/core/interactiveshell.py:warn('help() not available - check site.py') I added a "raise" before that, to see what's going on: File "/home/ubuntu/ipython/build/lib/IPython/core/interactiveshell.py", line 1137, in init_user_ns from site import _Helper ImportError: cannot import name '_Helper' $ python3.3 -c 'from site import _Helper' $ python3.4 -c 'from site import _Helper' Traceback (most recent call last): File "", line 1, in ImportError: cannot import name '_Helper' Python3.4's site.py indeed does not have a _Helper class any more. It seems it's now this: def sethelper(): builtins.help = _sitebuiltins._Helper() So I take it interactiveshell.py needs to be adjusted in that regard for 3.4. ** Changed in: ipython (Ubuntu) Status: New => Triaged ** Description changed: - Current ipython has a test failure when running with Python 3.4 as - default: + Current ipython has a test failure when running with Python 3.4 + (3.4.0b2) as default: http://people.canonical.com/~pitti/tmp/autopkgtest- py34/fail/py34-ipython/results/ FAIL: Test the IPython runner. -- Traceback (most recent call last): File "/tmp/adt-run.bmsO89/dsc0t-python3-testtmp/adttmp/IPython/lib/tests/test_irunner.py", line 136, in testIPython self._test_runner(runner,source,output) File "/tmp/adt-run.bmsO89/dsc0t-python3-testtmp/adttmp/IPython/lib/tests/test_irunner.py", line 46, in _test_runner self.fail(message) nose.proxy.AssertionError: Mismatch in number of lines [...] Expected: ~ In [1]: print('hello, this is python') hello, this is python [...] that's all folks! In [12]: exit Got: ~ In [1]: print('hello, this is python') hello, this is python [...] In [12]: exit WARNING: help() not available - check site.py I. e. it fails on the extra WARNING about help() (last line) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1272363 Title: test failures with python 3.4: WARNING: help() not available - check site.py To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ipython/+bug/1272363/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1272363] Re: test failures with python 3.4
> actually ipython adt ignores the python3.4 test results as they fail anyway, Ah, indeed. The test output doesn't say for which Python version it ran, so I just assumed it was for 3.4 as with 3.3 as the default it succeeds. In fact I can reproduce this on current trusty without the tests: sudo apt-get install python3.4 ipython3 With python3.3 (still the default Python), the warning does not appear: $ ipython3 [...] In [1]: quit() $ But if I run it with python3.4, the warning does appear: $ python3.4 /usr/bin/ipython3 [...] In [1]: quit() WARNING: help() not available - check site.py $ Curiously, help() *does* work with both 3.3 and 3.4, in python3.{3,4} (interactive shell) and ipython3 with python3.3 and 3.4. So that at least rules out an issue with the Debian autopkgtest (which is quite involved) and indeed shows that the issue is with ipython3 itself, so the test did find something real. At this point I don't know whether that's something due to the Debian packaging, or an upstream issue. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1272363 Title: test failures with python 3.4 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ipython/+bug/1272363/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1272363] Re: test failures with python 3.4
** Description changed: Current ipython has a test failure when running with Python 3.4 as default: - http://people.canonical.com/~pitti/tmp/autopkgtest- + http://people.canonical.com/~pitti/tmp/autopkgtest- py34/fail/py34-ipython/results/ FAIL: Test the IPython runner. -- Traceback (most recent call last): - File "/tmp/adt-run.bmsO89/dsc0t-python3-testtmp/adttmp/IPython/lib/tests/test_irunner.py", line 136, in testIPython - self._test_runner(runner,source,output) - File "/tmp/adt-run.bmsO89/dsc0t-python3-testtmp/adttmp/IPython/lib/tests/test_irunner.py", line 46, in _test_runner - self.fail(message) + File "/tmp/adt-run.bmsO89/dsc0t-python3-testtmp/adttmp/IPython/lib/tests/test_irunner.py", line 136, in testIPython + self._test_runner(runner,source,output) + File "/tmp/adt-run.bmsO89/dsc0t-python3-testtmp/adttmp/IPython/lib/tests/test_irunner.py", line 46, in _test_runner + self.fail(message) nose.proxy.AssertionError: Mismatch in number of lines [...] + Expected: + ~ + In [1]: print('hello, this is python') + hello, this is python + [...] + that's all folks! + In [12]: exit + + Got: + ~ + In [1]: print('hello, this is python') + hello, this is python + In [12]: exit + WARNING: help() not available - check site.py + + I. e. it fails on the extra WARNING about help() (last line) ** Description changed: Current ipython has a test failure when running with Python 3.4 as default: http://people.canonical.com/~pitti/tmp/autopkgtest- py34/fail/py34-ipython/results/ FAIL: Test the IPython runner. -- Traceback (most recent call last): File "/tmp/adt-run.bmsO89/dsc0t-python3-testtmp/adttmp/IPython/lib/tests/test_irunner.py", line 136, in testIPython self._test_runner(runner,source,output) File "/tmp/adt-run.bmsO89/dsc0t-python3-testtmp/adttmp/IPython/lib/tests/test_irunner.py", line 46, in _test_runner self.fail(message) nose.proxy.AssertionError: Mismatch in number of lines [...] Expected: ~ In [1]: print('hello, this is python') hello, this is python [...] that's all folks! In [12]: exit Got: ~ In [1]: print('hello, this is python') hello, this is python + [...] In [12]: exit WARNING: help() not available - check site.py I. e. it fails on the extra WARNING about help() (last line) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1272363 Title: test failures with python 3.4 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ipython/+bug/1272363/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1272363] Re: test failures with python 3.4
Martin, I'd like to get this fixed for IPython 1.2, but since we don't see the failure on our own machines, I'm relying on getting more info about what might be different in the autopkgtest environment. Unless the latest beta of Python has fixed it. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1272363 Title: test failures with python 3.4 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ipython/+bug/1272363/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1272363] Re: test failures with python 3.4
oh seems I rebased it at some point and the tests are now skipped in 3.4, so the results are not very meaningful anymore -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1272363 Title: test failures with python 3.4 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ipython/+bug/1272363/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1272363] Re: test failures with python 3.4
Julian, can you let us know what failures you see when Python 3.4 isn't skipped? We're aiming for a 1.2 release soon, and we're trying to ensure that the tests do pass on 3.4 (albeit by skipping some of them). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1272363 Title: test failures with python 3.4 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ipython/+bug/1272363/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1272363] Re: test failures with python 3.4
its probably my weird adt hack that causes it, I'll have a look -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1272363 Title: test failures with python 3.4 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ipython/+bug/1272363/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1272363] Re: test failures with python 3.4
actually ipython adt ignores the python3.4 test results as they fail anyway, there are no issues here: https://jenkins.qa.ubuntu.com/view/Trusty/view/AutoPkgTest/job/trusty-adt-ipython/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1272363 Title: test failures with python 3.4 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ipython/+bug/1272363/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1272363] Re: test failures with python 3.4
for py in $pys; do # fails but functional, mostly issues in the tests themselves [ "$py" = "python3.4" ] && continue ... did the py3.4 default test run something special that does not trigger this? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1272363 Title: test failures with python 3.4 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ipython/+bug/1272363/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1272363] Re: test failures with python 3.4
The relevant code is being removed for IPython 2.0, but I've filed an upstream bug to fix the test for 1.2: https://github.com/ipython/ipython/issues/4864 The failure appears to be due to an extra line printed: "WARNING: help() not available - check site.py". We haven't seen this when we run the tests. Is there something odd about the autopkgtest environment that might cause that? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1272363 Title: test failures with python 3.4 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ipython/+bug/1272363/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs