[Bug 1272788] Re: php5-fpm upstart job is not compatible with precise upstart
James, Ruben, Your concerns are completely valid, but it isn't effective to track them here as this bug was about the upgrade path which is fixed, so this bug is marked Fix Released and thus isn't on anyone's radar. I understand that the fix regressed fpm reload behaviour so we should track this regression in a separate bug and I don't see a relevant one. If you can't find one then please could you file one and note that bug number here? -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to php5 in Ubuntu. https://bugs.launchpad.net/bugs/1272788 Title: php5-fpm upstart job is not compatible with precise upstart To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1272788/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1272788] Re: php5-fpm upstart job is not compatible with precise upstart
James, Ruben, Your concerns are completely valid, but it isn't effective to track them here as this bug was about the upgrade path which is fixed, so this bug is marked Fix Released and thus isn't on anyone's radar. I understand that the fix regressed fpm reload behaviour so we should track this regression in a separate bug and I don't see a relevant one. If you can't find one then please could you file one and note that bug number here? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1272788 Title: php5-fpm upstart job is not compatible with precise upstart To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1272788/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1272788] Re: php5-fpm upstart job is not compatible with precise upstart
Thanks. Bug 1242376 looks like the bug we want to track for the regression James and Ruben described. Please mark yourself as affected in that bug (Does this bug affect you? link near the top). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1272788 Title: php5-fpm upstart job is not compatible with precise upstart To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1272788/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1272788] Re: php5-fpm upstart job is not compatible with precise upstart
Thanks. Bug 1242376 looks like the bug we want to track for the regression James and Ruben described. Please mark yourself as affected in that bug (Does this bug affect you? link near the top). -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to php5 in Ubuntu. https://bugs.launchpad.net/bugs/1272788 Title: php5-fpm upstart job is not compatible with precise upstart To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1272788/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1272788] Re: php5-fpm upstart job is not compatible with precise upstart
Hi, Robie FYI, here is the content in Trusty /etc/init/php5-fpm.conf file, # Precise upstart does not support reload signal, and thus rejects the # job. We'd rather start the daemon, instead of forcing users to # reboot https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1272788 # # reload signal USR2 There is another bug report that you participated back in July https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1242376 I have tested the above solution: adding 'reload signal USR2' in php5-fpm.override solve the problem. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to php5 in Ubuntu. https://bugs.launchpad.net/bugs/1272788 Title: php5-fpm upstart job is not compatible with precise upstart To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1272788/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1272788] Re: php5-fpm upstart job is not compatible with precise upstart
Hi, Robie FYI, here is the content in Trusty /etc/init/php5-fpm.conf file, # Precise upstart does not support reload signal, and thus rejects the # job. We'd rather start the daemon, instead of forcing users to # reboot https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1272788 # # reload signal USR2 There is another bug report that you participated back in July https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1242376 I have tested the above solution: adding 'reload signal USR2' in php5-fpm.override solve the problem. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1272788 Title: php5-fpm upstart job is not compatible with precise upstart To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1272788/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1272788] Re: php5-fpm upstart job is not compatible with precise upstart
I concurred with Ruben Laban. It is annoying and I didn't expect to find this behavior from the bug list. After all, Trusty is LTS.. Dimitri's third proposal seems to be perfect to me - no bug for upgrading from precise. and neither for the trusty user. * (possibly) ship reload signal stanza in the .override file (precise upstart will ignore override, trusty upstart will use it) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1272788 Title: php5-fpm upstart job is not compatible with precise upstart To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1272788/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1272788] Re: php5-fpm upstart job is not compatible with precise upstart
I concurred with Ruben Laban. It is annoying and I didn't expect to find this behavior from the bug list. After all, Trusty is LTS.. Dimitri's third proposal seems to be perfect to me - no bug for upgrading from precise. and neither for the trusty user. * (possibly) ship reload signal stanza in the .override file (precise upstart will ignore override, trusty upstart will use it) -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to php5 in Ubuntu. https://bugs.launchpad.net/bugs/1272788 Title: php5-fpm upstart job is not compatible with precise upstart To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1272788/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1272788] Re: php5-fpm upstart job is not compatible with precise upstart
This decision has some REALLY annoying side effects on Trusty, which took us quite some time to figure out. With the commented reload stanza, the reload function is broken in a horrible way: It sends SIGHUP to the php5-fpm master process causing it to terminate! Without any warning or indication that this is in fact happening. Based on the output the user thinks the reload worked just fine. However, after having done such a reload, any further reloads, restarts or stops will fail, because the master process has been terminated. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to php5 in Ubuntu. https://bugs.launchpad.net/bugs/1272788 Title: php5-fpm upstart job is not compatible with precise upstart To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1272788/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1272788] Re: php5-fpm upstart job is not compatible with precise upstart
This decision has some REALLY annoying side effects on Trusty, which took us quite some time to figure out. With the commented reload stanza, the reload function is broken in a horrible way: It sends SIGHUP to the php5-fpm master process causing it to terminate! Without any warning or indication that this is in fact happening. Based on the output the user thinks the reload worked just fine. However, after having done such a reload, any further reloads, restarts or stops will fail, because the master process has been terminated. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1272788 Title: php5-fpm upstart job is not compatible with precise upstart To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1272788/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1272788] Re: php5-fpm upstart job is not compatible with precise upstart
@Renan I believe Dimitri made this change to avoid breaking php5-fpm on upgrade from Precise to Trusty, because the previous version of upstart needs to have support for the new feature before we can use it. AFAICT, this means that we can fix this in Trusty+1, but it will remain like this in Trusty. The workaround is trivial, right? Just remove the comment? -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to php5 in Ubuntu. https://bugs.launchpad.net/bugs/1272788 Title: php5-fpm upstart job is not compatible with precise upstart To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1272788/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
Re: [Bug 1272788] Re: php5-fpm upstart job is not compatible with precise upstart
On 18 April 2014 11:58, Renan Gonçalves renan.sad...@gmail.com wrote: The package 5.5.9+dfsg-1ubuntu3 have the correct upstart script with reload signal USR2, which works great on Ubuntu Trusty since it uses upstart = 1.10.0 The fix for this bug introduces a new package, called 5.5.9+dfsg-1ubuntu4, which comments out reload signal USR2. Making it work on Precise but breaking on Trusty. Installing a new Ubuntu machine with the latest version and latest PHP should be the priority to work out of the box. No adjustments should be needed. If anyone wants to use Precise with the latest PHP version, adjustments to the upstart script are okay. Hence, IMO this fix should be reversed. We fully understand the drawbacks of all combinations, and there is no win-win situation at the moment. At release time, it was decided that smooth upgrades are more important than supporting reload mechanism in this single job. Independently, i'm working on patches to service and invoke-rc.d commands to properly support this case. Once those get accepted into Debian, and subsequently SRUed into trusty, this change can be reverted and the service will be correctly started using sysvinit upon upgrades from precise and will be managed by upstart after reboot into trusty's upstart. If you require reload functionality, you can uncoment that line in the upstart job or add reload signal USR2 into .override file next to the job file. -- Regards, Dimitri. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to php5 in Ubuntu. https://bugs.launchpad.net/bugs/1272788 Title: php5-fpm upstart job is not compatible with precise upstart To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1272788/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
Re: [Bug 1272788] Re: php5-fpm upstart job is not compatible with precise upstart
@Renan I believe Dimitri made this change to avoid breaking php5-fpm on upgrade from Precise to Trusty, because the previous version of upstart needs to have support for the new feature before we can use it. AFAICT, this means that we can fix this in Trusty+1, but it will remain like this in Trusty. The workaround is trivial, right? Just remove the comment? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1272788 Title: php5-fpm upstart job is not compatible with precise upstart To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1272788/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1272788] Re: php5-fpm upstart job is not compatible with precise upstart
On 18 April 2014 11:58, Renan Gonçalves renan.sad...@gmail.com wrote: The package 5.5.9+dfsg-1ubuntu3 have the correct upstart script with reload signal USR2, which works great on Ubuntu Trusty since it uses upstart = 1.10.0 The fix for this bug introduces a new package, called 5.5.9+dfsg-1ubuntu4, which comments out reload signal USR2. Making it work on Precise but breaking on Trusty. Installing a new Ubuntu machine with the latest version and latest PHP should be the priority to work out of the box. No adjustments should be needed. If anyone wants to use Precise with the latest PHP version, adjustments to the upstart script are okay. Hence, IMO this fix should be reversed. We fully understand the drawbacks of all combinations, and there is no win-win situation at the moment. At release time, it was decided that smooth upgrades are more important than supporting reload mechanism in this single job. Independently, i'm working on patches to service and invoke-rc.d commands to properly support this case. Once those get accepted into Debian, and subsequently SRUed into trusty, this change can be reverted and the service will be correctly started using sysvinit upon upgrades from precise and will be managed by upstart after reboot into trusty's upstart. If you require reload functionality, you can uncoment that line in the upstart job or add reload signal USR2 into .override file next to the job file. -- Regards, Dimitri. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1272788 Title: php5-fpm upstart job is not compatible with precise upstart To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1272788/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1272788] Re: php5-fpm upstart job is not compatible with precise upstart
The package 5.5.9+dfsg-1ubuntu3 have the correct upstart script with reload signal USR2, which works great on Ubuntu Trusty since it uses upstart = 1.10.0 The fix for this bug introduces a new package, called 5.5.9+dfsg-1ubuntu4, which comments out reload signal USR2. Making it work on Precise but breaking on Trusty. Installing a new Ubuntu machine with the latest version and latest PHP should be the priority to work out of the box. No adjustments should be needed. If anyone wants to use Precise with the latest PHP version, adjustments to the upstart script are okay. Hence, IMO this fix should be reversed. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to php5 in Ubuntu. https://bugs.launchpad.net/bugs/1272788 Title: php5-fpm upstart job is not compatible with precise upstart To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1272788/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1272788] Re: php5-fpm upstart job is not compatible with precise upstart
The package 5.5.9+dfsg-1ubuntu3 have the correct upstart script with reload signal USR2, which works great on Ubuntu Trusty since it uses upstart = 1.10.0 The fix for this bug introduces a new package, called 5.5.9+dfsg-1ubuntu4, which comments out reload signal USR2. Making it work on Precise but breaking on Trusty. Installing a new Ubuntu machine with the latest version and latest PHP should be the priority to work out of the box. No adjustments should be needed. If anyone wants to use Precise with the latest PHP version, adjustments to the upstart script are okay. Hence, IMO this fix should be reversed. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1272788 Title: php5-fpm upstart job is not compatible with precise upstart To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1272788/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1272788] Re: php5-fpm upstart job is not compatible with precise upstart
** Also affects: php5 (Ubuntu Trusty) Importance: High Assignee: Dimitri John Ledkov (xnox) Status: Triaged ** Changed in: php5 (Ubuntu Trusty) Status: Triaged = Fix Committed -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to php5 in Ubuntu. https://bugs.launchpad.net/bugs/1272788 Title: php5-fpm upstart job is not compatible with precise upstart To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1272788/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1272788] Re: php5-fpm upstart job is not compatible with precise upstart
This bug was fixed in the package php5 - 5.5.9+dfsg-1ubuntu4 --- php5 (5.5.9+dfsg-1ubuntu4) trusty; urgency=medium * Comment out reload signal USR2 stanza from php5-fpm to make the job compatible with Precise upstart, when it's still running as pid1 during upgrade to trusty and before the restart. We'd rather support shorter down-time then reload interface. (LP: #1272788) -- Dimitri John Ledkov x...@ubuntu.com Wed, 09 Apr 2014 16:23:30 +0100 ** Changed in: php5 (Ubuntu Trusty) Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to php5 in Ubuntu. https://bugs.launchpad.net/bugs/1272788 Title: php5-fpm upstart job is not compatible with precise upstart To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1272788/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1272788] Re: php5-fpm upstart job is not compatible with precise upstart
** Also affects: php5 (Ubuntu Trusty) Importance: High Assignee: Dimitri John Ledkov (xnox) Status: Triaged ** Changed in: php5 (Ubuntu Trusty) Status: Triaged = Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1272788 Title: php5-fpm upstart job is not compatible with precise upstart To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1272788/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1272788] Re: php5-fpm upstart job is not compatible with precise upstart
This bug was fixed in the package php5 - 5.5.9+dfsg-1ubuntu4 --- php5 (5.5.9+dfsg-1ubuntu4) trusty; urgency=medium * Comment out reload signal USR2 stanza from php5-fpm to make the job compatible with Precise upstart, when it's still running as pid1 during upgrade to trusty and before the restart. We'd rather support shorter down-time then reload interface. (LP: #1272788) -- Dimitri John Ledkov x...@ubuntu.com Wed, 09 Apr 2014 16:23:30 +0100 ** Changed in: php5 (Ubuntu Trusty) Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1272788 Title: php5-fpm upstart job is not compatible with precise upstart To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1272788/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
