[Bug 1312966] Re: ssvnc creates a 1x1 window with -scale auto

[Bug Watch Updater]

** Changed in: ssvnc (Debian)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1312966

Title:
  ssvnc creates a 1x1 window with -scale auto

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ssvnc/+bug/1312966/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1312966] Re: ssvnc creates a 1x1 window with -scale auto

[Launchpad Bug Tracker]

This bug was fixed in the package ssvnc - 1.0.29-3

---
ssvnc (1.0.29-3) unstable; urgency=low

  * debian/rules: Add call to dh_strip_nondeterminism.
  * openssl1.1.patch (new): Support OpenSSL 1.1 API changes (Closes:
#828559).
  * auto-scale.patch (new): Make autoscaling work (Closes: #801804, LP:
#1312966). In addition to the command-line option "-scale auto"
creating a 1×1 window, rescaling when resizing the window didn't
happen, at least not when Caps Lock or other modifiers were active.
  * samemachine_ipv6_overflow.patch (new): Fix stack overflow when
connecting over IPv6, caused by non-IPv6-aware code (Closes: #774622).
  * nostrip.patch: Don't strip vncstorepw or ultravnc_dsm_helper either.
  * buildflags.patch: Also pass flags to vncstorepw/Makefile and patch
that to use them.
  * Bump Standards-Version to 3.9.8.

 -- Magnus Holmgren   Sat, 30 Jul 2016 23:09:44
+0200

** Changed in: ssvnc (Ubuntu)
   Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1312966

Title:
  ssvnc creates a 1x1 window with -scale auto

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ssvnc/+bug/1312966/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1312966] Re: ssvnc creates a 1x1 window with -scale auto

[Jérôme Poulin]

Thanks for the proper patch, I'm not much aware of the steps involved in
deploying submitted patches via Ubuntu launchpad.  You're right, our use
case implies most of the time connecting to 1080p display, causing ssvnc
to be unusable using our loader sets autoscale enabled.  Otherwise,
since we use SSH tunneling, ssvnc is the best tool for the job.

Again, thanks for improving (rewriting) the patch and comitting it, I'll
give it a try this week.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1312966

Title:
  ssvnc creates a 1x1 window with -scale auto

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ssvnc/+bug/1312966/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1312966] Re: ssvnc creates a 1x1 window with -scale auto

[Bug Watch Updater]

** Changed in: ssvnc (Debian)
   Status: Unknown => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1312966

Title:
  ssvnc creates a 1x1 window with -scale auto

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ssvnc/+bug/1312966/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1312966] Re: ssvnc creates a 1x1 window with -scale auto

[Magnus Holmgren]

** Bug watch added: Debian Bug tracker #801804
   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=801804

** Also affects: ssvnc (Debian) via
   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=801804
   Importance: Unknown
   Status: Unknown

** Changed in: ssvnc (Ubuntu)
   Status: Confirmed => In Progress

** Changed in: ssvnc (Ubuntu)
 Assignee: (unassigned) => Magnus Holmgren (holmgren)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1312966

Title:
  ssvnc creates a 1x1 window with -scale auto

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ssvnc/+bug/1312966/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1312966] Re: ssvnc creates a 1x1 window with -scale auto

[Magnus Holmgren]

I did some debugging and found that firstly, XtVaGetValues(toplevel,
XtNwidth, , XtNheight, , NULL) in check_things() didn't get the size
of the window, but the size of the remote desktop, and secondly, the
mask that XQueryPointer() fetched wouldn't be zero because it includes
not only mouse buttons as intended, but keyboard modifiers such as Caps
Lock (typically the lock modifier) and Num Lock (mod2 in my case). The
problem with the 1×1 window, I found, was more in get_scale_values(). In
the end I wound up adding a new, more proper event handler to detect
window size changes.

As to why nothing has happened to this bug for this long, well, I do
this on a voluntary basis, it didn't seem that critical, and haven't
gotten around to taking a closer look until now, also hoping that Karl
(upstream) might do something. When you're saying that the unpatched
version is completely unusable, do you mean that you always connect to
desktops that are larger than your screen and therefore have to enable
autoscaling right away?

** Patch added: "My solution"
   
https://bugs.launchpad.net/ubuntu/+source/ssvnc/+bug/1312966/+attachment/4710533/+files/auto-scale.patch

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1312966

Title:
  ssvnc creates a 1x1 window with -scale auto

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ssvnc/+bug/1312966/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1312966] Re: ssvnc creates a 1x1 window with -scale auto

[Jérôme Poulin]

Would you mind adding more details about the problem you encounter?

This patch is currently in use on our corporate repo since Trusty and
has been working correctly in Utopic, Vivid, Wily and still works in
Xenial. It has been tested on Unity, Gnome-Shell and Lxde.

Anyway, right now the unmatched version is completely unusable and I'm
still wondering why this patch has been lingering here so long. Maybe
your advice will help me getting it accepted.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1312966

Title:
  ssvnc creates a 1x1 window with -scale auto

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ssvnc/+bug/1312966/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1312966] Re: ssvnc creates a 1x1 window with -scale auto

[Magnus Holmgren]

This patch, while it does mean that you don't get a 1×1 window, doesn't
enable automatic rescaling to the current window size; it just checks if
the remote desktop is larger than 90% of the width and/or height of the
local screen, and multiples the scale factor by 0.9 until it's not.
However, that automatic rescaling doesn't seem to work for me anyway.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1312966

Title:
  ssvnc creates a 1x1 window with -scale auto

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ssvnc/+bug/1312966/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1312966] Re: ssvnc creates a 1x1 window with -scale auto

[Launchpad Bug Tracker]

Status changed to 'Confirmed' because the bug affects multiple users.

** Changed in: ssvnc (Ubuntu)
   Status: New = Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1312966

Title:
  ssvnc creates a 1x1 window with -scale auto

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ssvnc/+bug/1312966/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1312966] Re: ssvnc creates a 1x1 window with -scale auto

[Rohit Rawat]

Version information:
SSVNC Viewer (based on TightVNC viewer version 1.3.9)

Shell output with the -scale auto switch
$ ssvncviewer -scale auto hostname
Proto: RFB 003.008

Connected to RFB server, using protocol version 3.8

SelectSecurityType:
  sec-type[0]2  (rfbSecTypeVncAuth)
  sec-type[1]   16  (rfbSecTypeTight)
Enabling TightVNC protocol extensions
Security-Type:  16  (rfbSecTypeTight)  Latency: 9.03 ms

Performing standard VNC authentication
VNC Password: 
VNC authentication succeeded

Desktop name hostname

VNC server default format:
  32 bits per pixel.  Least significant byte first in each pixel.
  True colour: max red 255 green 255 blue 255, shift red 16 green 8 blue 0
Using default colormap which is TrueColor.  Pixel format:
  32 bits per pixel.  Least significant byte first in each pixel.
  True colour: max red 255 green 255 blue 255, shift red 16 green 8 blue 0
auto: 0x0
Invalid scale string: 'auto'
geometry: 1x1+680+371 ycrop: 0
create_image()
try_create_image: shm image create fail: image == NULL
try_create_image: created *non-shm* image: 1440x900
try_create_image: image-bytes_per_line: 5760

guessed: -compresslevel 2
guessed: -qualitylevel  8

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1312966

Title:
  ssvnc creates a 1x1 window with -scale auto

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ssvnc/+bug/1312966/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1312966] Re: ssvnc creates a 1x1 window with -scale auto

[Ubuntu Foundations Team Bug Bot]

The attachment auto-scale.patch seems to be a patch.  If it isn't,
please remove the patch flag from the attachment, remove the patch
tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the
team.

[This is an automated message performed by a Launchpad user owned by
~brian-murray, for any issues please contact him.]

** Tags added: patch

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1312966

Title:
  ssvnc creates a 1x1 window with -scale auto

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ssvnc/+bug/1312966/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs