[Bug 1348244] Re: debug log messages need to be unicode
OK. Removing trusty's nova task then. And unsubscribing ubuntu- sponsors until a new patch is updated. Thanks, Liang! ** No longer affects: nova (Ubuntu Trusty) -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1348244] Re: debug log messages need to be unicode
OK. Removing trusty's nova task then. And unsubscribing ubuntu- sponsors until a new patch is updated. Thanks, Liang! ** No longer affects: nova (Ubuntu Trusty) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1348244] Re: debug log messages need to be unicode
@Liang, do you mean that the change there shouldn't be reviewed for sponsoring anymore? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1348244] Re: debug log messages need to be unicode
@Liang, do you mean that the change there shouldn't be reviewed for sponsoring anymore? -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1348244] Re: debug log messages need to be unicode
@Sebastien, The fix for Nova is merged at LP#1459046. cinder patch is still needed. But the current cinder patch is unnecessarily big, it can be done more easily as LP#1459046 does. I will remove the cinder patch for now, and propose a simpler one later. Thanks. ** Patch removed: trusty cinder debdiff https://bugs.launchpad.net/nova/+bug/1348244/+attachment/4416906/+files/cinder-2014.1.4-0ubuntu3-lp1348244.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1348244] Re: debug log messages need to be unicode
@Sebastien, The fix for Nova is merged at LP#1459046. cinder patch is still needed. But the current cinder patch is unnecessarily big, it can be done more easily as LP#1459046 does. I will remove the cinder patch for now, and propose a simpler one later. Thanks. ** Patch removed: trusty cinder debdiff https://bugs.launchpad.net/nova/+bug/1348244/+attachment/4416906/+files/cinder-2014.1.4-0ubuntu3-lp1348244.patch -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1348244] Re: debug log messages need to be unicode
Nova SRU is removed as it will be fixed at https://bugs.launchpad.net/ubuntu/+source/nova/+bug/1459046 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1348244] Re: debug log messages need to be unicode
Nova SRU is removed as it will be fixed at https://bugs.launchpad.net/ubuntu/+source/nova/+bug/1459046 -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1348244] Re: debug log messages need to be unicode
** Patch removed: trusty nova debdiff https://bugs.launchpad.net/nova/+bug/1348244/+attachment/4408927/+files/nova-2014.1.4-0ubuntu3-lp1348244.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1348244] Re: debug log messages need to be unicode
** Patch removed: trusty nova debdiff https://bugs.launchpad.net/nova/+bug/1348244/+attachment/4408927/+files/nova-2014.1.4-0ubuntu3-lp1348244.patch -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1348244] Re: debug log messages need to be unicode
Hi Guys, Any news in regards to Liang's patch? Do you think we can have the fix in the Trusty release? ty Leo -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1348244] Re: debug log messages need to be unicode
Hi Guys, Any news in regards to Liang's patch? Do you think we can have the fix in the Trusty release? ty Leo -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1348244] Re: debug log messages need to be unicode
** Patch added: trusty cinder debdiff https://bugs.launchpad.net/ubuntu/+source/nova/+bug/1348244/+attachment/4416906/+files/cinder-2014.1.4-0ubuntu3-lp1348244.patch -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1348244] Re: debug log messages need to be unicode
** Patch removed: trusty cinder debdiff https://bugs.launchpad.net/ubuntu/+source/nova/+bug/1348244/+attachment/4411790/+files/cinder-2014.1.4-0ubuntu3-lp1348244.patch -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1348244] Re: debug log messages need to be unicode
** Patch removed: trusty cinder debdiff https://bugs.launchpad.net/ubuntu/+source/nova/+bug/1348244/+attachment/4411790/+files/cinder-2014.1.4-0ubuntu3-lp1348244.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1348244] Re: debug log messages need to be unicode
** Patch added: trusty cinder debdiff https://bugs.launchpad.net/ubuntu/+source/nova/+bug/1348244/+attachment/4416906/+files/cinder-2014.1.4-0ubuntu3-lp1348244.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1348244] Re: debug log messages need to be unicode
** Also affects: nova (Ubuntu Trusty) Importance: Undecided Status: New ** Also affects: cinder (Ubuntu Trusty) Importance: Undecided Status: New ** Changed in: cinder (Ubuntu) Status: In Progress = Fix Released ** Changed in: nova (Ubuntu) Status: In Progress = Fix Released ** Changed in: cinder (Ubuntu Trusty) Assignee: (unassigned) = Liang Chen (cbjchen) ** Changed in: nova (Ubuntu Trusty) Assignee: (unassigned) = Liang Chen (cbjchen) -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to cinder in Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1348244] Re: debug log messages need to be unicode
** Also affects: nova (Ubuntu Trusty) Importance: Undecided Status: New ** Also affects: cinder (Ubuntu Trusty) Importance: Undecided Status: New ** Changed in: cinder (Ubuntu) Status: In Progress = Fix Released ** Changed in: nova (Ubuntu) Status: In Progress = Fix Released ** Changed in: cinder (Ubuntu Trusty) Assignee: (unassigned) = Liang Chen (cbjchen) ** Changed in: nova (Ubuntu Trusty) Assignee: (unassigned) = Liang Chen (cbjchen) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1348244] Re: debug log messages need to be unicode
A few comments before sponsoring: Nova/Cinder - wait-syslog-on-startup.patch you mentioned was from comments in bug 1459046, can you have somebody else review this like James Page to ensure it makes sense. (Since this isn't upstream) - The changelog refers to bugs that aren't SRU/targeted to Ubuntu/nova/trusty, can you either make those bugs proper SRUs or change the changelog. If you use this bug as the master bug, then it should explain why those patches are needed. (Fixing regression) -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1348244] Re: debug log messages need to be unicode
A few comments before sponsoring: Nova/Cinder - wait-syslog-on-startup.patch you mentioned was from comments in bug 1459046, can you have somebody else review this like James Page to ensure it makes sense. (Since this isn't upstream) - The changelog refers to bugs that aren't SRU/targeted to Ubuntu/nova/trusty, can you either make those bugs proper SRUs or change the changelog. If you use this bug as the master bug, then it should explain why those patches are needed. (Fixing regression) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1348244] Re: debug log messages need to be unicode
Hi Chris, Thanks for looking at the patch. I will contact James Page to review wait-syslog-on-startup.patch, and update the corresponding bugs that are referenced in the changelog. Thanks, Liang ** Description changed: [Impact] * Nova services fail to start because they cannot connect to rsyslog [Test Case] * Set user_syslog to True in nova.conf, stop rsyslog service and restart nova services. [Regression Potential] - * None + * The following patches from 1385295 and 1399088 that address the +regression introduced in this bug's fix are also included. +fix-syslog-logging.patch (LP: #1385295) +move-syslog-instantiation.patch (LP: #1399088) - When nova services log to syslog, they should wait for syslog to start - prior to the nova-* services start. + When nova services log to syslog, they should wait for syslog to start prior to the nova-* services start. Debug logs should be: LOG.debug(message) should be LOG.debug(umessage) Before the translation of debug log messages was removed, the translation was returning unicode. Now that they are no longer translated they need to be explicitly marked as unicode. This was confirmed by discussion with dhellman. See 2014-07-23T13:48:23 in this log http://eavesdrop.openstack.org/irclogs /%23openstack-oslo/%23openstack-oslo.2014-07-23.log The problem was discovered when an exception was used as replacement text in a debug log message: LOG.debug(Failed to mount image %(ex)s), {'ex': e}) In particular it was discovered as part of enabling lazy translation, where the exception message is replaced with an object that does not support str(). Note that this would also fail without lazy enabled, if a translation for the exception message was provided that was unicode. Example trace: Traceback (most recent call last): File nova/tests/virt/disk/test_api.py, line 78, in test_can_resize_need_fs_type_specified self.assertFalse(api.is_image_partitionless(imgfile, use_cow=True)) File nova/virt/disk/api.py, line 208, in is_image_partitionless fs.setup() File nova/virt/disk/vfs/localfs.py, line 80, in setup LOG.debug(Failed to mount image %(ex)s), {'ex': e}) File /usr/lib/python2.7/logging/__init__.py, line 1412, in debug self.logger.debug(msg, *args, **kwargs) File /usr/lib/python2.7/logging/__init__.py, line 1128, in debug self._log(DEBUG, msg, args, **kwargs) File /usr/lib/python2.7/logging/__init__.py, line 1258, in _log self.handle(record) File /usr/lib/python2.7/logging/__init__.py, line 1268, in handle self.callHandlers(record) File /usr/lib/python2.7/logging/__init__.py, line 1308, in callHandlers hdlr.handle(record) File nova/test.py, line 212, in handle self.format(record) File /usr/lib/python2.7/logging/__init__.py, line 723, in format return fmt.format(record) File /usr/lib/python2.7/logging/__init__.py, line 464, in format record.message = record.getMessage() File /usr/lib/python2.7/logging/__init__.py, line 328, in getMessage msg = msg % self.args File /opt/stack/nova/.tox/py27/local/lib/python2.7/site-packages/oslo/i18n/_message.py, line 167, in __str__ raise UnicodeError(msg) UnicodeError: Message objects do not support str() because they may contain non-ascii characters. Please use unicode() or translate() instead. == FAIL: nova.tests.virt.disk.test_api.APITestCase.test_resize2fs_e2fsck_fails tags: worker-3 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1348244] Re: debug log messages need to be unicode
Hi Chris, Thanks for looking at the patch. I will contact James Page to review wait-syslog-on-startup.patch, and update the corresponding bugs that are referenced in the changelog. Thanks, Liang ** Description changed: [Impact] * Nova services fail to start because they cannot connect to rsyslog [Test Case] * Set user_syslog to True in nova.conf, stop rsyslog service and restart nova services. [Regression Potential] - * None + * The following patches from 1385295 and 1399088 that address the +regression introduced in this bug's fix are also included. +fix-syslog-logging.patch (LP: #1385295) +move-syslog-instantiation.patch (LP: #1399088) - When nova services log to syslog, they should wait for syslog to start - prior to the nova-* services start. + When nova services log to syslog, they should wait for syslog to start prior to the nova-* services start. Debug logs should be: LOG.debug(message) should be LOG.debug(umessage) Before the translation of debug log messages was removed, the translation was returning unicode. Now that they are no longer translated they need to be explicitly marked as unicode. This was confirmed by discussion with dhellman. See 2014-07-23T13:48:23 in this log http://eavesdrop.openstack.org/irclogs /%23openstack-oslo/%23openstack-oslo.2014-07-23.log The problem was discovered when an exception was used as replacement text in a debug log message: LOG.debug(Failed to mount image %(ex)s), {'ex': e}) In particular it was discovered as part of enabling lazy translation, where the exception message is replaced with an object that does not support str(). Note that this would also fail without lazy enabled, if a translation for the exception message was provided that was unicode. Example trace: Traceback (most recent call last): File nova/tests/virt/disk/test_api.py, line 78, in test_can_resize_need_fs_type_specified self.assertFalse(api.is_image_partitionless(imgfile, use_cow=True)) File nova/virt/disk/api.py, line 208, in is_image_partitionless fs.setup() File nova/virt/disk/vfs/localfs.py, line 80, in setup LOG.debug(Failed to mount image %(ex)s), {'ex': e}) File /usr/lib/python2.7/logging/__init__.py, line 1412, in debug self.logger.debug(msg, *args, **kwargs) File /usr/lib/python2.7/logging/__init__.py, line 1128, in debug self._log(DEBUG, msg, args, **kwargs) File /usr/lib/python2.7/logging/__init__.py, line 1258, in _log self.handle(record) File /usr/lib/python2.7/logging/__init__.py, line 1268, in handle self.callHandlers(record) File /usr/lib/python2.7/logging/__init__.py, line 1308, in callHandlers hdlr.handle(record) File nova/test.py, line 212, in handle self.format(record) File /usr/lib/python2.7/logging/__init__.py, line 723, in format return fmt.format(record) File /usr/lib/python2.7/logging/__init__.py, line 464, in format record.message = record.getMessage() File /usr/lib/python2.7/logging/__init__.py, line 328, in getMessage msg = msg % self.args File /opt/stack/nova/.tox/py27/local/lib/python2.7/site-packages/oslo/i18n/_message.py, line 167, in __str__ raise UnicodeError(msg) UnicodeError: Message objects do not support str() because they may contain non-ascii characters. Please use unicode() or translate() instead. == FAIL: nova.tests.virt.disk.test_api.APITestCase.test_resize2fs_e2fsck_fails tags: worker-3 -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1348244] Re: debug log messages need to be unicode
** Description changed: + Nova SRU: [Impact] * Nova services fail to start because they cannot connect to rsyslog [Test Case] * Set user_syslog to True in nova.conf, stop rsyslog service and restart nova services. [Regression Potential] - * The following patches from 1385295 and 1399088 that address the -regression introduced in this bug's fix are also included. -fix-syslog-logging.patch (LP: #1385295) -move-syslog-instantiation.patch (LP: #1399088) + * The following patches from 1385295 and 1399088 that address the + regression introduced in this bug's fix are also included. + fix-syslog-logging.patch (LP: #1385295) + move-syslog-instantiation.patch (LP: #1399088) + When nova services log to syslog, they should wait for syslog to start + prior to the nova-* services start. - When nova services log to syslog, they should wait for syslog to start prior to the nova-* services start. + Cinder SRU: + [Impact] + + * Cinder services fail to start because they cannot connect to rsyslog + + [Test Case] + + * Set user_syslog to True in cinder.conf, stop rsyslog service and + restart cinder services. + + [Regression Potential] + + * The following patches from 1385295 and 1399088 that address the + regression introduced in this bug's fix are also included. + fix-syslog-logging.patch (LP: #1385295) + move-syslog-instantiation.patch (LP: #1399088) + + When cinder services log to syslog, they should wait for syslog to start + prior to the cinder-* services start. + Debug logs should be: LOG.debug(message) should be LOG.debug(umessage) Before the translation of debug log messages was removed, the translation was returning unicode. Now that they are no longer translated they need to be explicitly marked as unicode. This was confirmed by discussion with dhellman. See 2014-07-23T13:48:23 in this log http://eavesdrop.openstack.org/irclogs /%23openstack-oslo/%23openstack-oslo.2014-07-23.log The problem was discovered when an exception was used as replacement text in a debug log message: LOG.debug(Failed to mount image %(ex)s), {'ex': e}) In particular it was discovered as part of enabling lazy translation, where the exception message is replaced with an object that does not support str(). Note that this would also fail without lazy enabled, if a translation for the exception message was provided that was unicode. Example trace: Traceback (most recent call last): File nova/tests/virt/disk/test_api.py, line 78, in test_can_resize_need_fs_type_specified self.assertFalse(api.is_image_partitionless(imgfile, use_cow=True)) File nova/virt/disk/api.py, line 208, in is_image_partitionless fs.setup() File nova/virt/disk/vfs/localfs.py, line 80, in setup LOG.debug(Failed to mount image %(ex)s), {'ex': e}) File /usr/lib/python2.7/logging/__init__.py, line 1412, in debug self.logger.debug(msg, *args, **kwargs) File /usr/lib/python2.7/logging/__init__.py, line 1128, in debug self._log(DEBUG, msg, args, **kwargs) File /usr/lib/python2.7/logging/__init__.py, line 1258, in _log self.handle(record) File /usr/lib/python2.7/logging/__init__.py, line 1268, in handle self.callHandlers(record) File /usr/lib/python2.7/logging/__init__.py, line 1308, in callHandlers hdlr.handle(record) File nova/test.py, line 212, in handle self.format(record) File /usr/lib/python2.7/logging/__init__.py, line 723, in format return fmt.format(record) File /usr/lib/python2.7/logging/__init__.py, line 464, in format record.message = record.getMessage() File /usr/lib/python2.7/logging/__init__.py, line 328, in getMessage msg = msg % self.args File /opt/stack/nova/.tox/py27/local/lib/python2.7/site-packages/oslo/i18n/_message.py, line 167, in __str__ raise UnicodeError(msg) UnicodeError: Message objects do not support str() because they may contain non-ascii characters. Please use unicode() or translate() instead. == FAIL: nova.tests.virt.disk.test_api.APITestCase.test_resize2fs_e2fsck_fails tags: worker-3 -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1348244] Re: debug log messages need to be unicode
** Description changed: + Nova SRU: [Impact] * Nova services fail to start because they cannot connect to rsyslog [Test Case] * Set user_syslog to True in nova.conf, stop rsyslog service and restart nova services. [Regression Potential] - * The following patches from 1385295 and 1399088 that address the -regression introduced in this bug's fix are also included. -fix-syslog-logging.patch (LP: #1385295) -move-syslog-instantiation.patch (LP: #1399088) + * The following patches from 1385295 and 1399088 that address the + regression introduced in this bug's fix are also included. + fix-syslog-logging.patch (LP: #1385295) + move-syslog-instantiation.patch (LP: #1399088) + When nova services log to syslog, they should wait for syslog to start + prior to the nova-* services start. - When nova services log to syslog, they should wait for syslog to start prior to the nova-* services start. + Cinder SRU: + [Impact] + + * Cinder services fail to start because they cannot connect to rsyslog + + [Test Case] + + * Set user_syslog to True in cinder.conf, stop rsyslog service and + restart cinder services. + + [Regression Potential] + + * The following patches from 1385295 and 1399088 that address the + regression introduced in this bug's fix are also included. + fix-syslog-logging.patch (LP: #1385295) + move-syslog-instantiation.patch (LP: #1399088) + + When cinder services log to syslog, they should wait for syslog to start + prior to the cinder-* services start. + Debug logs should be: LOG.debug(message) should be LOG.debug(umessage) Before the translation of debug log messages was removed, the translation was returning unicode. Now that they are no longer translated they need to be explicitly marked as unicode. This was confirmed by discussion with dhellman. See 2014-07-23T13:48:23 in this log http://eavesdrop.openstack.org/irclogs /%23openstack-oslo/%23openstack-oslo.2014-07-23.log The problem was discovered when an exception was used as replacement text in a debug log message: LOG.debug(Failed to mount image %(ex)s), {'ex': e}) In particular it was discovered as part of enabling lazy translation, where the exception message is replaced with an object that does not support str(). Note that this would also fail without lazy enabled, if a translation for the exception message was provided that was unicode. Example trace: Traceback (most recent call last): File nova/tests/virt/disk/test_api.py, line 78, in test_can_resize_need_fs_type_specified self.assertFalse(api.is_image_partitionless(imgfile, use_cow=True)) File nova/virt/disk/api.py, line 208, in is_image_partitionless fs.setup() File nova/virt/disk/vfs/localfs.py, line 80, in setup LOG.debug(Failed to mount image %(ex)s), {'ex': e}) File /usr/lib/python2.7/logging/__init__.py, line 1412, in debug self.logger.debug(msg, *args, **kwargs) File /usr/lib/python2.7/logging/__init__.py, line 1128, in debug self._log(DEBUG, msg, args, **kwargs) File /usr/lib/python2.7/logging/__init__.py, line 1258, in _log self.handle(record) File /usr/lib/python2.7/logging/__init__.py, line 1268, in handle self.callHandlers(record) File /usr/lib/python2.7/logging/__init__.py, line 1308, in callHandlers hdlr.handle(record) File nova/test.py, line 212, in handle self.format(record) File /usr/lib/python2.7/logging/__init__.py, line 723, in format return fmt.format(record) File /usr/lib/python2.7/logging/__init__.py, line 464, in format record.message = record.getMessage() File /usr/lib/python2.7/logging/__init__.py, line 328, in getMessage msg = msg % self.args File /opt/stack/nova/.tox/py27/local/lib/python2.7/site-packages/oslo/i18n/_message.py, line 167, in __str__ raise UnicodeError(msg) UnicodeError: Message objects do not support str() because they may contain non-ascii characters. Please use unicode() or translate() instead. == FAIL: nova.tests.virt.disk.test_api.APITestCase.test_resize2fs_e2fsck_fails tags: worker-3 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1348244] Re: debug log messages need to be unicode
** Also affects: cinder (Ubuntu) Importance: Undecided Status: New ** Changed in: cinder (Ubuntu) Assignee: (unassigned) = Liang Chen (cbjchen) ** Changed in: cinder (Ubuntu) Status: New = In Progress ** Patch added: trusty cinder debdiff https://bugs.launchpad.net/ubuntu/+source/cinder/+bug/1348244/+attachment/4411763/+files/cinder-2014.1.4-0ubuntu4-lp1348244.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1348244] Re: debug log messages need to be unicode
** Also affects: cinder (Ubuntu) Importance: Undecided Status: New ** Changed in: cinder (Ubuntu) Assignee: (unassigned) = Liang Chen (cbjchen) ** Changed in: cinder (Ubuntu) Status: New = In Progress ** Patch added: trusty cinder debdiff https://bugs.launchpad.net/ubuntu/+source/cinder/+bug/1348244/+attachment/4411763/+files/cinder-2014.1.4-0ubuntu4-lp1348244.patch -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to cinder in Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1348244] Re: debug log messages need to be unicode
** Patch removed: trusty cinder debdiff https://bugs.launchpad.net/ubuntu/+source/cinder/+bug/1348244/+attachment/4411763/+files/cinder-2014.1.4-0ubuntu4-lp1348244.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1348244] Re: debug log messages need to be unicode
** Patch removed: trusty cinder debdiff https://bugs.launchpad.net/ubuntu/+source/cinder/+bug/1348244/+attachment/4411763/+files/cinder-2014.1.4-0ubuntu4-lp1348244.patch -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1348244] Re: debug log messages need to be unicode
** Patch added: trusty cinder debdiff https://bugs.launchpad.net/ubuntu/+source/cinder/+bug/1348244/+attachment/4411790/+files/cinder-2014.1.4-0ubuntu3-lp1348244.patch -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1348244] Re: debug log messages need to be unicode
** Patch added: trusty cinder debdiff https://bugs.launchpad.net/ubuntu/+source/cinder/+bug/1348244/+attachment/4411790/+files/cinder-2014.1.4-0ubuntu3-lp1348244.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1348244] Re: debug log messages need to be unicode
The attachment trusty debdiff seems to be a debdiff. The ubuntu- sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the patch flag from the attachment, remove the patch tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1348244] Re: debug log messages need to be unicode
The attachment trusty debdiff seems to be a debdiff. The ubuntu- sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the patch flag from the attachment, remove the patch tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/1348244 Title: debug log messages need to be unicode To manage notifications about this bug go to: https://bugs.launchpad.net/cinder/+bug/1348244/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1348244] Re: debug log messages need to be unicode
** Description changed: + [Impact] + + * Nova services fail to start because they cannot connect to rsyslog + + [Test Case] + + * Set user_syslog to True in nova.conf, stop rsyslog service and + restart nova services. + + [Regression Potential] + + * None + + When nova services log to syslog, we should make sure the dependency on + the upstart jobs is set prior to the nova-* services start. + + Debug logs should be: - - LOG.debug(message) should be LOG.debug(umessage) + + LOG.debug(message) should be LOG.debug(umessage) Before the translation of debug log messages was removed, the translation was returning unicode. Now that they are no longer translated they need to be explicitly marked as unicode. This was confirmed by discussion with dhellman. See 2014-07-23T13:48:23 in this log http://eavesdrop.openstack.org/irclogs /%23openstack-oslo/%23openstack-oslo.2014-07-23.log The problem was discovered when an exception was used as replacement text in a debug log message: -LOG.debug(Failed to mount image %(ex)s), {'ex': e}) + LOG.debug(Failed to mount image %(ex)s), {'ex': e}) In particular it was discovered as part of enabling lazy translation, where the exception message is replaced with an object that does not support str(). Note that this would also fail without lazy enabled, if a translation for the exception message was provided that was unicode. + Example trace: - Example trace: - - Traceback (most recent call last): - File nova/tests/virt/disk/test_api.py, line 78, in test_can_resize_need_fs_type_specified - self.assertFalse(api.is_image_partitionless(imgfile, use_cow=True)) - File nova/virt/disk/api.py, line 208, in is_image_partitionless - fs.setup() - File nova/virt/disk/vfs/localfs.py, line 80, in setup - LOG.debug(Failed to mount image %(ex)s), {'ex': e}) - File /usr/lib/python2.7/logging/__init__.py, line 1412, in debug - self.logger.debug(msg, *args, **kwargs) - File /usr/lib/python2.7/logging/__init__.py, line 1128, in debug - self._log(DEBUG, msg, args, **kwargs) - File /usr/lib/python2.7/logging/__init__.py, line 1258, in _log - self.handle(record) - File /usr/lib/python2.7/logging/__init__.py, line 1268, in handle - self.callHandlers(record) - File /usr/lib/python2.7/logging/__init__.py, line 1308, in callHandlers - hdlr.handle(record) - File nova/test.py, line 212, in handle - self.format(record) - File /usr/lib/python2.7/logging/__init__.py, line 723, in format - return fmt.format(record) - File /usr/lib/python2.7/logging/__init__.py, line 464, in format - record.message = record.getMessage() - File /usr/lib/python2.7/logging/__init__.py, line 328, in getMessage - msg = msg % self.args - File /opt/stack/nova/.tox/py27/local/lib/python2.7/site-packages/oslo/i18n/_message.py, line 167, in __str__ - raise UnicodeError(msg) + Traceback (most recent call last): + File nova/tests/virt/disk/test_api.py, line 78, in test_can_resize_need_fs_type_specified + self.assertFalse(api.is_image_partitionless(imgfile, use_cow=True)) + File nova/virt/disk/api.py, line 208, in is_image_partitionless + fs.setup() + File nova/virt/disk/vfs/localfs.py, line 80, in setup + LOG.debug(Failed to mount image %(ex)s), {'ex': e}) + File /usr/lib/python2.7/logging/__init__.py, line 1412, in debug + self.logger.debug(msg, *args, **kwargs) + File /usr/lib/python2.7/logging/__init__.py, line 1128, in debug + self._log(DEBUG, msg, args, **kwargs) + File /usr/lib/python2.7/logging/__init__.py, line 1258, in _log + self.handle(record) + File /usr/lib/python2.7/logging/__init__.py, line 1268, in handle + self.callHandlers(record) + File /usr/lib/python2.7/logging/__init__.py, line 1308, in callHandlers + hdlr.handle(record) + File nova/test.py, line 212, in handle + self.format(record) + File /usr/lib/python2.7/logging/__init__.py, line 723, in format + return fmt.format(record) + File /usr/lib/python2.7/logging/__init__.py, line 464, in format + record.message = record.getMessage() + File /usr/lib/python2.7/logging/__init__.py, line 328, in getMessage + msg = msg % self.args + File /opt/stack/nova/.tox/py27/local/lib/python2.7/site-packages/oslo/i18n/_message.py, line 167, in __str__ + raise UnicodeError(msg) UnicodeError: Message objects do not support str() because they may contain non-ascii characters. Please use unicode() or translate() instead. == FAIL: nova.tests.virt.disk.test_api.APITestCase.test_resize2fs_e2fsck_fails tags: worker-3 ** Description changed: [Impact] - * Nova services fail to start because they cannot connect to rsyslog + * Nova services fail to start because they cannot connect to rsyslog [Test Case] - * Set user_syslog to True in nova.conf, stop rsyslog
[Bug 1348244] Re: debug log messages need to be unicode
** Description changed: + [Impact] + + * Nova services fail to start because they cannot connect to rsyslog + + [Test Case] + + * Set user_syslog to True in nova.conf, stop rsyslog service and + restart nova services. + + [Regression Potential] + + * None + + When nova services log to syslog, we should make sure the dependency on + the upstart jobs is set prior to the nova-* services start. + + Debug logs should be: - - LOG.debug(message) should be LOG.debug(umessage) + + LOG.debug(message) should be LOG.debug(umessage) Before the translation of debug log messages was removed, the translation was returning unicode. Now that they are no longer translated they need to be explicitly marked as unicode. This was confirmed by discussion with dhellman. See 2014-07-23T13:48:23 in this log http://eavesdrop.openstack.org/irclogs /%23openstack-oslo/%23openstack-oslo.2014-07-23.log The problem was discovered when an exception was used as replacement text in a debug log message: -LOG.debug(Failed to mount image %(ex)s), {'ex': e}) + LOG.debug(Failed to mount image %(ex)s), {'ex': e}) In particular it was discovered as part of enabling lazy translation, where the exception message is replaced with an object that does not support str(). Note that this would also fail without lazy enabled, if a translation for the exception message was provided that was unicode. + Example trace: - Example trace: - - Traceback (most recent call last): - File nova/tests/virt/disk/test_api.py, line 78, in test_can_resize_need_fs_type_specified - self.assertFalse(api.is_image_partitionless(imgfile, use_cow=True)) - File nova/virt/disk/api.py, line 208, in is_image_partitionless - fs.setup() - File nova/virt/disk/vfs/localfs.py, line 80, in setup - LOG.debug(Failed to mount image %(ex)s), {'ex': e}) - File /usr/lib/python2.7/logging/__init__.py, line 1412, in debug - self.logger.debug(msg, *args, **kwargs) - File /usr/lib/python2.7/logging/__init__.py, line 1128, in debug - self._log(DEBUG, msg, args, **kwargs) - File /usr/lib/python2.7/logging/__init__.py, line 1258, in _log - self.handle(record) - File /usr/lib/python2.7/logging/__init__.py, line 1268, in handle - self.callHandlers(record) - File /usr/lib/python2.7/logging/__init__.py, line 1308, in callHandlers - hdlr.handle(record) - File nova/test.py, line 212, in handle - self.format(record) - File /usr/lib/python2.7/logging/__init__.py, line 723, in format - return fmt.format(record) - File /usr/lib/python2.7/logging/__init__.py, line 464, in format - record.message = record.getMessage() - File /usr/lib/python2.7/logging/__init__.py, line 328, in getMessage - msg = msg % self.args - File /opt/stack/nova/.tox/py27/local/lib/python2.7/site-packages/oslo/i18n/_message.py, line 167, in __str__ - raise UnicodeError(msg) + Traceback (most recent call last): + File nova/tests/virt/disk/test_api.py, line 78, in test_can_resize_need_fs_type_specified + self.assertFalse(api.is_image_partitionless(imgfile, use_cow=True)) + File nova/virt/disk/api.py, line 208, in is_image_partitionless + fs.setup() + File nova/virt/disk/vfs/localfs.py, line 80, in setup + LOG.debug(Failed to mount image %(ex)s), {'ex': e}) + File /usr/lib/python2.7/logging/__init__.py, line 1412, in debug + self.logger.debug(msg, *args, **kwargs) + File /usr/lib/python2.7/logging/__init__.py, line 1128, in debug + self._log(DEBUG, msg, args, **kwargs) + File /usr/lib/python2.7/logging/__init__.py, line 1258, in _log + self.handle(record) + File /usr/lib/python2.7/logging/__init__.py, line 1268, in handle + self.callHandlers(record) + File /usr/lib/python2.7/logging/__init__.py, line 1308, in callHandlers + hdlr.handle(record) + File nova/test.py, line 212, in handle + self.format(record) + File /usr/lib/python2.7/logging/__init__.py, line 723, in format + return fmt.format(record) + File /usr/lib/python2.7/logging/__init__.py, line 464, in format + record.message = record.getMessage() + File /usr/lib/python2.7/logging/__init__.py, line 328, in getMessage + msg = msg % self.args + File /opt/stack/nova/.tox/py27/local/lib/python2.7/site-packages/oslo/i18n/_message.py, line 167, in __str__ + raise UnicodeError(msg) UnicodeError: Message objects do not support str() because they may contain non-ascii characters. Please use unicode() or translate() instead. == FAIL: nova.tests.virt.disk.test_api.APITestCase.test_resize2fs_e2fsck_fails tags: worker-3 ** Description changed: [Impact] - * Nova services fail to start because they cannot connect to rsyslog + * Nova services fail to start because they cannot connect to rsyslog [Test Case] - * Set user_syslog to True in nova.conf, stop rsyslog