Re: [Bug 1397898] [NEW] incorrect PID in initscript
On 12/01/2014 10:42 PM, Stig Sandbeck Mathisen wrote:
That's a delightfully evil hack. Will using an upstart job work instead,
or do you need to keep track of the PID there, as well (something for
post-start, then)?
Matthaus Owens of Puppet Labs responded that Puppet *does* write its own
PID. This is true for both the newest Puppet version from Puppet Labs
and the version currently in Ubuntu Trusty. So my patch is not needed
after all. It is enough to put the following in /etc/default/puppet
(which is source by the init script):
PIDFILE=/var/lib/puppet/run/agent.pid
That is assuming that puppet.conf is the default. Alternatively,
according to
https://docs.puppetlabs.com/references/latest/configuration.html#pidfile
it is possible to set the location of the PIDfile to
/var/run/puppet/${NAME}.pid in /etc/puppet/puppet.conf.
--
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to puppet in Ubuntu.
https://bugs.launchpad.net/bugs/1397898
Title:
incorrect PID in initscript
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/1397898/+subscriptions
--
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
Re: [Bug 1397898] [NEW] incorrect PID in initscript
On 12/01/2014 10:42 PM, Stig Sandbeck Mathisen wrote:
That's a delightfully evil hack. Will using an upstart job work instead,
or do you need to keep track of the PID there, as well (something for
post-start, then)?
Matthaus Owens of Puppet Labs responded that Puppet *does* write its own
PID. This is true for both the newest Puppet version from Puppet Labs
and the version currently in Ubuntu Trusty. So my patch is not needed
after all. It is enough to put the following in /etc/default/puppet
(which is source by the init script):
PIDFILE=/var/lib/puppet/run/agent.pid
That is assuming that puppet.conf is the default. Alternatively,
according to
https://docs.puppetlabs.com/references/latest/configuration.html#pidfile
it is possible to set the location of the PIDfile to
/var/run/puppet/${NAME}.pid in /etc/puppet/puppet.conf.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1397898
Title:
incorrect PID in initscript
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/1397898/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1397898] [NEW] incorrect PID in initscript
Public bug reported:
Abstract:
Puppet initscript doesn't record the correct PID. WIth this patch, it does.
Longer version:
When the Puppet agent daemon gets started, /etc/init.d/puppet records a PID in
/var/run/puppet/${NAME}.pid, but it is the wrong one. Puppet may fork half a
dozen times before settling on a PID. Start-stop-daemon has no way to keep
track of such behaviour, and I know of no way to make Puppet write its own PID
to a file. So I patched the script.
The patch isn't completely fool proof, but we ran it in production for months,
and it's certainly better than no PID at all.
Is Ubuntu the place to offer such fixes? Or is it better to take them to
Debian, or to PuppetLabs?
** Affects: puppet (Ubuntu)
Importance: Undecided
Status: New
** Patch added: Patch to make Puppet initscript find the PID of the daemon
https://bugs.launchpad.net/bugs/1397898/+attachment/4271933/+files/puppet-init.patch
--
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to puppet in Ubuntu.
https://bugs.launchpad.net/bugs/1397898
Title:
incorrect PID in initscript
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/1397898/+subscriptions
--
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
Re: [Bug 1397898] [NEW] incorrect PID in initscript
Jurjen Bokma j.bo...@rug.nl writes: ** Patch added: Patch to make Puppet initscript find the PID of the daemon https://bugs.launchpad.net/bugs/1397898/+attachment/4271933/+files/puppet-init.patch That's a delightfully evil hack. Will using an upstart job work instead, or do you need to keep track of the PID there, as well (something for post-start, then)? -- Stig Sandbeck Mathisen -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to puppet in Ubuntu. https://bugs.launchpad.net/bugs/1397898 Title: incorrect PID in initscript To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/1397898/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1397898] [NEW] incorrect PID in initscript
Public bug reported:
Abstract:
Puppet initscript doesn't record the correct PID. WIth this patch, it does.
Longer version:
When the Puppet agent daemon gets started, /etc/init.d/puppet records a PID in
/var/run/puppet/${NAME}.pid, but it is the wrong one. Puppet may fork half a
dozen times before settling on a PID. Start-stop-daemon has no way to keep
track of such behaviour, and I know of no way to make Puppet write its own PID
to a file. So I patched the script.
The patch isn't completely fool proof, but we ran it in production for months,
and it's certainly better than no PID at all.
Is Ubuntu the place to offer such fixes? Or is it better to take them to
Debian, or to PuppetLabs?
** Affects: puppet (Ubuntu)
Importance: Undecided
Status: New
** Patch added: Patch to make Puppet initscript find the PID of the daemon
https://bugs.launchpad.net/bugs/1397898/+attachment/4271933/+files/puppet-init.patch
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1397898
Title:
incorrect PID in initscript
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/1397898/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1397898] [NEW] incorrect PID in initscript
Jurjen Bokma j.bo...@rug.nl writes: ** Patch added: Patch to make Puppet initscript find the PID of the daemon https://bugs.launchpad.net/bugs/1397898/+attachment/4271933/+files/puppet-init.patch That's a delightfully evil hack. Will using an upstart job work instead, or do you need to keep track of the PID there, as well (something for post-start, then)? -- Stig Sandbeck Mathisen -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1397898 Title: incorrect PID in initscript To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/puppet/+bug/1397898/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
