[Bug 1432265] Re: does not ask for LUKS passphrases without plymouth

2018-01-31 Thread dino99
patched into 215-16

** Changed in: systemd (Debian)
   Importance: Unknown => Undecided

** Changed in: systemd (Debian)
 Remote watch: Debian Bug tracker #779612 => None

** Changed in: systemd (Debian)
   Status: New => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1432265

Title:
  does not ask for LUKS passphrases without plymouth

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/plymouth/+bug/1432265/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1432265] Re: does not ask for LUKS passphrases without plymouth

2016-02-29 Thread Didier Roche
The argument passed from "splash" to "nosplash" in debian by default. I
did try to reintroduce backward compatibility and this case handling. I
may have missed some parts (reminder: 150+ files difference), and that
was not the intend.
Remember as well that the description is made from most of the diff I
could understand. Indeed, even recent patches from people uploading
plymouth in ubuntu included new patches without any description (and not
following DEP3), which was making this merge even harder…

We did try with Martin on a vm when a passphrase was asked from the
start, and didn't see any issue, but that was maybe another case and we
didn't get into that one.

Feel free to amend and change for the expected user experience where the
fundation team feel the needs.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1432265

Title:
  does not ask for LUKS passphrases without plymouth

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/plymouth/+bug/1432265/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1432265] Re: does not ask for LUKS passphrases without plymouth

2016-02-29 Thread Didier Roche
Le 29/02/2016 08:55, Steve Langasek a écrit :
> On Mon, Feb 22, 2016 at 12:17:09PM -, Martin Pitt wrote:
>> See also debian/patches/ubuntu-add-splash-option.patch which explicitly
>> documents that plymouth should only be started with "splash".
> 
> ... which appears to be a regression in xenial.  The 'splash' commandline
> option was previously used to control whether or not a graphical splash was
> shown; it was *not* used to control whether plymouth itself was running,
> only whether it was graphical.
> 
> Didier, why have you disabled the plymouth services when 'splash' is not
> given on the commandline?  What is the expected boot experience now for e.g.
> filesystem checks on a server (that may require interaction)?
> 

The argument passed from "splash" to "nosplash" in debian by default. I
did try to reintroduce backward compatibility and this case handling. I
may have missed some parts (reminder: 150+ files difference), and that
was not the intend.
Remember as well that the description is made from most of the diff I
could understand. Indeed, even recent patches from people uploading
plymouth in ubuntu included new patches without any description (and not
following DEP3), which was making this merge even harder…

We did try with Martin on a vm when a passphrase was asked from the
start, and didn't see any issue, but that was maybe another case and we
didn't get into that one.

Feel free to amend and change for the expected user experience where the
fundation team feel the needs.

Cheers,
Didier

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1432265

Title:
  does not ask for LUKS passphrases without plymouth

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/plymouth/+bug/1432265/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1432265] Re: does not ask for LUKS passphrases without plymouth

2016-02-29 Thread Steve Langasek
On Mon, Feb 22, 2016 at 12:17:09PM -, Martin Pitt wrote:
> See also debian/patches/ubuntu-add-splash-option.patch which explicitly
> documents that plymouth should only be started with "splash".

... which appears to be a regression in xenial.  The 'splash' commandline
option was previously used to control whether or not a graphical splash was
shown; it was *not* used to control whether plymouth itself was running,
only whether it was graphical.

Didier, why have you disabled the plymouth services when 'splash' is not
given on the commandline?  What is the expected boot experience now for e.g.
filesystem checks on a server (that may require interaction)?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1432265

Title:
  does not ask for LUKS passphrases without plymouth

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/plymouth/+bug/1432265/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1432265] Re: does not ask for LUKS passphrases without plymouth

2016-02-22 Thread Launchpad Bug Tracker
This bug was fixed in the package plymouth - 0.9.2-3ubuntu10

---
plymouth (0.9.2-3ubuntu10) xenial; urgency=medium

  * debian/local/plymouth.init-premount: Don't start plymouth if "splash" is
not present on the kernel command line. This makes initrd behaviour
consistent with what happens at boot (see ubuntu-add-splash-option.patch).
Fixes password prompts when not booting with "splash". (LP: #1432265)

 -- Martin Pitt   Mon, 22 Feb 2016 13:15:42
+0100

** Changed in: plymouth (Ubuntu)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1432265

Title:
  does not ask for LUKS passphrases without plymouth

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/plymouth/+bug/1432265/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1432265] Re: does not ask for LUKS passphrases without plymouth

2016-02-22 Thread Martin Pitt
** Changed in: plymouth (Ubuntu)
   Status: Triaged => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1432265

Title:
  does not ask for LUKS passphrases without plymouth

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/plymouth/+bug/1432265/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1432265] Re: does not ask for LUKS passphrases without plymouth

2016-02-22 Thread Martin Pitt
See also debian/patches/ubuntu-add-splash-option.patch which explicitly
documents that plymouth should only be started with "splash".

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1432265

Title:
  does not ask for LUKS passphrases without plymouth

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/plymouth/+bug/1432265/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1432265] Re: does not ask for LUKS passphrases without plymouth

2016-02-22 Thread Martin Pitt
I tested this on current Xenial amd64 with a LUKS partition for /opt.
Indeed when dropping "splash" from the command line I only get "Starting
cryptography for..." but no actual prompt. Theh same happens when I use
"console=ttyS0" and thus see the boot messages on the QEMU serial
console.

In this case, systemd-ask-password-console is supposed to kick in. Both
systemd-ask-password-console.{path,service} have

   ConditionPathExists=!/run/plymouth/pid

with the idea that if plymouth is running, the password will be asked by
plymouth, and the "console" askpass would actually get in the way.
Asking passwords with plymouth does work for me (both on tty1 and the
serial console ttyS0), and that's consistent with Julian's report in
comment 8 and the original report by Michael whose kernel command line
also does not have "splash".

Now, I observed that even when booting without "splash", plymouthd is
*still* running, and /run/plymouth/pid exists. It isn't started by
plymouth-start.service as its condition fail (no "splash" in command
line). But I suppose it's already started in the initramfs and survives
from there.

When I  remove the above ConditionPathExists=!/run/plymouth/pid, then
prompting for the password when booting without "splash" works fine for
both tty1 and ttyS0, but this is of course not a solution.

I think the bug is that /usr/share/initramfs-tools/scripts/init-
premount/plymouth defaults to starting plymouth if there is no "splash"
argument, but plymouth's systemd units default to *not* starting
plymouth without a "splash" argument.

Explicitly specifying "nosplash" works, but we need to make up our mind
what the default should be for no "*splash*" argument at all. I'd argue
that it should not start plymouth in this case, as that's the intent of
cloud-config and friends, and the intent of plymouth's services.

** Package changed: systemd (Ubuntu) => plymouth (Ubuntu)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1432265

Title:
  does not ask for LUKS passphrases without plymouth

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/plymouth/+bug/1432265/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1432265] Re: does not ask for LUKS passphrases without plymouth

2016-01-13 Thread Martin Pitt
** Summary changed:

- does not ask for multiple LUKS passphrases without plymouth
+ does not ask for LUKS passphrases without plymouth

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1432265

Title:
  does not ask for LUKS passphrases without plymouth

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1432265/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs